mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Properly trigger testRemote after getting a 404 from remote fed share 

Whenever a remote fed share's shareinfo call returns a 404, don't
directly assume the storage is not available by throwing
StorageNotAvailableException. We need to properly throw
NotFoundException to trigger the later logic that calls testRemote()
that verifies that the 404 is not from a broken server but really from
an obsolete share.
This commit is contained in:
Vincent Petry 2016-02-18 11:57:03 +01:00
parent 73d46afc3c
commit e1dbae1467
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/files_sharing/lib/external/storage.php vendored
View File

@ -252,6 +252,9 @@ class Storage extends DAV implements ISharedStorage {
if ($e->getCode() === 401 || $e->getCode() === 403) {
throw new ForbiddenException();
}
if ($e->getCode() === 404) {
throw new NotFoundException();
}
// throw this to be on the safe side: the share will still be visible
// in the UI in case the failure is intermittent, and the user will
// be able to decide whether to remove it if it's really gone