Merge pull request #26410 from nextcloud/fix/noid/phpdoc

Add proper PHPDoc tags to files ApiController
This commit is contained in:
Morris Jobke 2021-05-27 21:00:05 +02:00 committed by GitHub
commit e3129056c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 10 deletions

View File

@ -67,9 +67,9 @@ class ApiController extends Controller {
private $shareManager; private $shareManager;
/** @var IPreview */ /** @var IPreview */
private $previewManager; private $previewManager;
/** IUserSession */ /** @var IUserSession */
private $userSession; private $userSession;
/** IConfig */ /** @var IConfig */
private $config; private $config;
/** @var Folder */ /** @var Folder */
private $userFolder; private $userFolder;
@ -291,8 +291,8 @@ class ApiController extends Controller {
* @return Response * @return Response
* @throws \OCP\PreConditionNotMetException * @throws \OCP\PreConditionNotMetException
*/ */
public function showHiddenFiles($show) { public function showHiddenFiles(bool $show): Response {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', (int)$show); $this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_hidden', $show ? '1' : '0');
return new Response(); return new Response();
} }
@ -305,8 +305,8 @@ class ApiController extends Controller {
* @return Response * @return Response
* @throws \OCP\PreConditionNotMetException * @throws \OCP\PreConditionNotMetException
*/ */
public function cropImagePreviews($crop) { public function cropImagePreviews(bool $crop): Response {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'crop_image_previews', (int)$crop); $this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'crop_image_previews', $crop ? '1' : '0');
return new Response(); return new Response();
} }
@ -319,8 +319,8 @@ class ApiController extends Controller {
* @return Response * @return Response
* @throws \OCP\PreConditionNotMetException * @throws \OCP\PreConditionNotMetException
*/ */
public function showGridView($show) { public function showGridView(bool $show): Response {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_grid', (int)$show); $this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', 'show_grid', $show ? '1' : '0');
return new Response(); return new Response();
} }
@ -345,13 +345,13 @@ class ApiController extends Controller {
* @return Response * @return Response
* @throws \OCP\PreConditionNotMetException * @throws \OCP\PreConditionNotMetException
*/ */
public function toggleShowFolder(int $show, string $key) { public function toggleShowFolder(int $show, string $key): Response {
// ensure the edited key exists // ensure the edited key exists
$navItems = \OCA\Files\App::getNavigationManager()->getAll(); $navItems = \OCA\Files\App::getNavigationManager()->getAll();
foreach ($navItems as $item) { foreach ($navItems as $item) {
// check if data is valid // check if data is valid
if (($show === 0 || $show === 1) && isset($item['expandedState']) && $key === $item['expandedState']) { if (($show === 0 || $show === 1) && isset($item['expandedState']) && $key === $item['expandedState']) {
$this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', $key, $show); $this->config->setUserValue($this->userSession->getUser()->getUID(), 'files', $key, (string)$show);
return new Response(); return new Response();
} }
} }