From e6a0ad470115e902b2c82d5694b9c4bd00167f35 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Fri, 12 May 2017 10:02:15 +0200 Subject: [PATCH] Fix unit tests Signed-off-by: Joas Schilling --- tests/lib/App/AppStore/Fetcher/AppFetcherTest.php | 7 ++++++- tests/lib/App/AppStore/Fetcher/CategoryFetcherTest.php | 3 ++- tests/lib/App/AppStore/Fetcher/FetcherBase.php | 4 ++++ 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/tests/lib/App/AppStore/Fetcher/AppFetcherTest.php b/tests/lib/App/AppStore/Fetcher/AppFetcherTest.php index f3769fc09c..2efecef4dc 100644 --- a/tests/lib/App/AppStore/Fetcher/AppFetcherTest.php +++ b/tests/lib/App/AppStore/Fetcher/AppFetcherTest.php @@ -32,6 +32,7 @@ use OCP\Http\Client\IClient; use OCP\Http\Client\IClientService; use OCP\Http\Client\IResponse; use OCP\IConfig; +use OCP\ILogger; use Test\TestCase; class AppFetcherTest extends TestCase { @@ -43,6 +44,8 @@ class AppFetcherTest extends TestCase { protected $timeFactory; /** @var IConfig|\PHPUnit_Framework_MockObject_MockObject */ protected $config; + /** @var ILogger|\PHPUnit_Framework_MockObject_MockObject */ + protected $logger; /** @var AppFetcher */ protected $fetcher; /** @var string */ @@ -64,6 +67,7 @@ EOD; $this->clientService = $this->createMock(IClientService::class); $this->timeFactory = $this->createMock(ITimeFactory::class); $this->config = $this->createMock(IConfig::class); + $this->logger = $this->createMock(ILogger::class); $this->config ->expects($this->at(0)) @@ -74,7 +78,8 @@ EOD; $factory, $this->clientService, $this->timeFactory, - $this->config + $this->config, + $this->logger ); } diff --git a/tests/lib/App/AppStore/Fetcher/CategoryFetcherTest.php b/tests/lib/App/AppStore/Fetcher/CategoryFetcherTest.php index 6143da662d..a1ce718520 100644 --- a/tests/lib/App/AppStore/Fetcher/CategoryFetcherTest.php +++ b/tests/lib/App/AppStore/Fetcher/CategoryFetcherTest.php @@ -33,7 +33,8 @@ class CategoryFetcherTest extends FetcherBase { $this->appDataFactory, $this->clientService, $this->timeFactory, - $this->config + $this->config, + $this->logger ); } diff --git a/tests/lib/App/AppStore/Fetcher/FetcherBase.php b/tests/lib/App/AppStore/Fetcher/FetcherBase.php index 3d89ae942a..bd19141ea9 100644 --- a/tests/lib/App/AppStore/Fetcher/FetcherBase.php +++ b/tests/lib/App/AppStore/Fetcher/FetcherBase.php @@ -32,6 +32,7 @@ use OCP\Http\Client\IClient; use OCP\Http\Client\IClientService; use OCP\Http\Client\IResponse; use OCP\IConfig; +use OCP\ILogger; use Test\TestCase; abstract class FetcherBase extends TestCase { @@ -45,6 +46,8 @@ abstract class FetcherBase extends TestCase { protected $timeFactory; /** @var IConfig|\PHPUnit_Framework_MockObject_MockObject */ protected $config; + /** @var ILogger|\PHPUnit_Framework_MockObject_MockObject */ + protected $logger; /** @var Fetcher */ protected $fetcher; /** @var string */ @@ -63,6 +66,7 @@ abstract class FetcherBase extends TestCase { $this->clientService = $this->createMock(IClientService::class); $this->timeFactory = $this->createMock(ITimeFactory::class); $this->config = $this->createMock(IConfig::class); + $this->logger = $this->createMock(ILogger::class); } public function testGetWithAlreadyExistingFileAndUpToDateTimestampAndVersion() {