mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update SecurityMiddleware.php 

OC::$WEBROOT can be empty in case if your nextcloud installation has no url prefix. This will result in an empty Location Header.

in other areas OC::$WEBROOT is always used together with an /
This commit is contained in:
Holger Hees 2020-01-13 17:53:08 +01:00 committed by Morris Jobke
parent b2959d7c86
commit e70249e089
No known key found for this signature in database
GPG Key ID: FE03C3A163FEDE68
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php
View File

@ -211,7 +211,7 @@ class SecurityMiddleware extends Middleware {
public function afterException($controller, $methodName, \Exception $exception): Response { public function afterException($controller, $methodName, \Exception $exception): Response {
if ($exception instanceof SecurityException) { if ($exception instanceof SecurityException) {
if ($exception instanceof StrictCookieMissingException) { if ($exception instanceof StrictCookieMissingException) {
return new RedirectResponse(\OC::$WEBROOT); return new RedirectResponse(\OC::$WEBROOT . '/');
} }
if (stripos($this->request->getHeader('Accept'),'html') === false) { if (stripos($this->request->getHeader('Accept'),'html') === false) {
$response = new JSONResponse( $response = new JSONResponse(

2
tests/lib/AppFramework/Middleware/Security/SecurityMiddlewareTest.php
View File

@ -535,7 +535,7 @@ class SecurityMiddlewareTest extends \Test\TestCase {
new StrictCookieMissingException() new StrictCookieMissingException()
); );
$expected = new RedirectResponse(\OC::$WEBROOT); $expected = new RedirectResponse(\OC::$WEBROOT . '/');
$this->assertEquals($expected , $response); $this->assertEquals($expected , $response);
} }