mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Change var_dumps to exceptions

This commit is contained in:
Bart Visscher 2013-03-17 14:15:36 +01:00
parent 4a02dacf16
commit e9213a6711
2 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/db/mdb2schemareader.php
View File

@ -29,7 +29,7 @@ class OC_DB_MDB2SchemaReader {
self::loadTable($schema, $child);
break;
default:
var_dump($child->getName());
throw new DomainException('Unknown element: '.$child->getName());
}
}
@ -52,7 +52,7 @@ class OC_DB_MDB2SchemaReader {
self::loadDeclaration($table, $child);
break;
default:
var_dump($child->getName());
throw new DomainException('Unknown element: '.$child->getName());
}
}
@ -68,7 +68,7 @@ class OC_DB_MDB2SchemaReader {
self::loadIndex($table, $child);
break;
default:
var_dump($child->getName());
throw new DomainException('Unknown element: '.$child->getName());
}
}
@ -118,16 +118,11 @@ class OC_DB_MDB2SchemaReader {
$options['default'] = $default;
break;
default:
var_dump($child->getName());
throw new DomainException('Unknown element: '.$child->getName());
}
}
if (isset($name) && isset($type)) {
if ($name == 'x') {
var_dump($name, $type, $options);
echo '<pre>';
debug_print_backtrace();
}
if (empty($options['default'])) {
if ($type == 'integer') {
if (empty($options['default'])) {
@ -187,13 +182,13 @@ class OC_DB_MDB2SchemaReader {
case 'sorting':
break;
default:
var_dump($field->getName());
throw new DomainException('Unknown element: '.$field->getName());
}
}
break;
default:
var_dump($child->getName());
throw new DomainException('Unknown element: '.$child->getName());
}
}
@ -207,7 +202,7 @@ class OC_DB_MDB2SchemaReader {
$table->addIndex($fields, $name);
}
} else {
var_dump($name, $fields);
throw new DomainException('Empty index definition: '.$name.' options:'. print_r($fields, true));
}
}

2
lib/db/schema.php
View File

@ -76,8 +76,6 @@ class OC_DB_Schema {
$toSchema = clone $fromSchema;
$toSchema->dropTable('user');
$sql = $fromSchema->getMigrateToSql($toSchema, $conn->getDatabasePlatform());
var_dump($sql);
die;
$conn->execute($sql);
}