mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #8112 from nextcloud/fix-integer-overflow 

Fix integer overflow in ChunkingPlugin
This commit is contained in:
Morris Jobke 2018-03-09 10:27:17 +01:00 committed by GitHub
parent 528ffaf250 fc4e0501f0
commit ed5008597f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
apps/dav/lib/Upload/ChunkingPlugin.php
View File

@ -97,7 +97,10 @@ class ChunkingPlugin extends ServerPlugin {
return; return;
} }
$actualSize = $this->sourceNode->getSize(); $actualSize = $this->sourceNode->getSize();
if ((int)$expectedSize !== $actualSize) {
// casted to string because cast to float cause equality for non equal numbers
// and integer has the problem of limited size on 32 bit systems
if ((string)$expectedSize !== (string)$actualSize) {
throw new BadRequest("Chunks on server do not sum up to $expectedSize but to $actualSize bytes"); throw new BadRequest("Chunks on server do not sum up to $expectedSize but to $actualSize bytes");
} }
} }