mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Adjust by/self filter aswell and fix tests

This commit is contained in:
Joas Schilling 2015-03-31 17:35:04 +02:00
parent 116b257b4d
commit efcc2e87ab
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/files/lib/activity.php
View File

@ -318,7 +318,7 @@ class Activity implements IExtension {
} }
// Display actions from favorites only // Display actions from favorites only
if ($filter === self::FILTER_FAVORITES || $filter === 'all' && $this->userSettingFavoritesOnly($user)) { if ($filter === self::FILTER_FAVORITES || in_array($filter, ['all', 'by', 'self']) && $this->userSettingFavoritesOnly($user)) {
try { try {
$favorites = $this->helper->getFavoriteFilePaths($user); $favorites = $this->helper->getFavoriteFilePaths($user);
} catch (\RuntimeException $e) { } catch (\RuntimeException $e) {

4
apps/files/tests/activitytest.php
View File

@ -234,7 +234,7 @@ class ActivityTest extends TestCase {
'items' => [], 'items' => [],
'folders' => [], 'folders' => [],
], ],
' CASE WHEN `app` = ? THEN (`type` <> ? OR `type` <> ?) ELSE `app` <> ? END ', ' CASE WHEN `app` = ? THEN ((`type` <> ? AND `type` <> ?)) ELSE `app` <> ? END ',
['files', Activity::TYPE_SHARE_CREATED, Activity::TYPE_SHARE_CHANGED, 'files'] ['files', Activity::TYPE_SHARE_CREATED, Activity::TYPE_SHARE_CHANGED, 'files']
], ],
[ [
@ -242,7 +242,7 @@ class ActivityTest extends TestCase {
'items' => ['file.txt', 'folder'], 'items' => ['file.txt', 'folder'],
'folders' => ['folder'], 'folders' => ['folder'],
], ],
' CASE WHEN `app` = ? THEN (`type` <> ? OR `type` <> ? OR `file` = ? OR `file` = ? OR `file` LIKE ?) ELSE `app` <> ? END ', ' CASE WHEN `app` = ? THEN ((`type` <> ? AND `type` <> ?) OR `file` = ? OR `file` = ? OR `file` LIKE ?) ELSE `app` <> ? END ',
['files', Activity::TYPE_SHARE_CREATED, Activity::TYPE_SHARE_CHANGED, 'file.txt', 'folder', 'folder/%', 'files'] ['files', Activity::TYPE_SHARE_CREATED, Activity::TYPE_SHARE_CHANGED, 'file.txt', 'folder', 'folder/%', 'files']
], ],
]; ];