Limit Sinon version to 5.0.7 at most
When using fake servers with Sinon.JS, the JavaScript test framework, the XHR objects are also fake. In Sinon 5.0.8 the "setRequestHeader" of XMLHttpRequest was modified to normalize the header values (as requested by the spec), but since then only string values are accepted; null or integer values can no longer be passed to "setRequestHeader", as it expects the "replace" function to be available in the object. However, in the tests null and integer values are passed to "setRequestHeader", which causes them to fail. Both Firefox and Chromium accept passing non-string values to their "setRequestHeader" implementation, and it is done, for example, in davclient.js; it is not clear yet whether Sinon got too restrictive or the code calling "setRequestHeader" was too loose. Given that davclient.js is an external dependency, as a temporary measure Sinon version is forced to be 5.0.7 at most until either Sinon or davclient.js are updated. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This commit is contained in:
parent
7a121f81b5
commit
f2385ae038
|
@ -24,7 +24,7 @@
|
|||
"karma-phantomjs-launcher": "*",
|
||||
"phantomjs-prebuilt": "*",
|
||||
"node-sass": "~4.1.1",
|
||||
"sinon": "*"
|
||||
"sinon": "<= 5.0.7"
|
||||
},
|
||||
"engine": "node >= 6.9"
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue