From f54b201f234e1cb9bfe99a5086caaa6229f43253 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20Molakvo=C3=A6=20=28skjnldsv=29?=
 <skjnldsv@protonmail.com>
Date: Tue, 6 Nov 2018 18:02:47 +0100
Subject: [PATCH] Better primary visual on public pages
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
---
 apps/files_sharing/css/public.scss | 14 ++++++++++++++
 core/templates/layout.public.php   |  6 +++---
 2 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/apps/files_sharing/css/public.scss b/apps/files_sharing/css/public.scss
index b8a5dbf4f3..c31b4f82be 100644
--- a/apps/files_sharing/css/public.scss
+++ b/apps/files_sharing/css/public.scss
@@ -192,6 +192,20 @@ thead {
 	font-weight: bold;
 }
 
+// hide the download entry on the menu
+// on public share when NOT on mobile
+@media only screen and (min-width: 769px) {
+	#body-public {
+		.header-right {
+			#header-actions-menu {
+				> ul > li#download {
+					display: none;
+				}
+			}
+		}
+	}
+}
+
 // hide the primary on public share on mobile
 @media only screen and (max-width: 768px) {
 	#body-public {
diff --git a/core/templates/layout.public.php b/core/templates/layout.public.php
index 0558da52d0..8a87e88a16 100644
--- a/core/templates/layout.public.php
+++ b/core/templates/layout.public.php
@@ -51,18 +51,18 @@
 			?>
 		<div class="header-right">
 			<span id="header-primary-action" class="<?php if($template->getActionCount() === 1) {  p($primary->getIcon()); } ?>">
-				<a href="<?php p($primary->getLink()); ?>">
+				<a href="<?php p($primary->getLink()); ?>" class="primary button">
 					<span><?php p($primary->getLabel()) ?></span>
 				</a>
 			</span>
-			<?php if($template->getActionCount()>1) { ?>
+			<?php if($template->getActionCount() > 1) { ?>
 			<div id="header-secondary-action">
 				<span id="header-actions-toggle" class="menutoggle icon-more-white"></span>
 				<div id="header-actions-menu" class="popovermenu menu">
 					<ul>
 						<?php
 							/** @var \OCP\AppFramework\Http\Template\IMenuAction $action */
-							foreach($template->getOtherActions() as $action) {
+							foreach($others as $action) {
 								print_unescaped($action->render());
 							}
 						?>