Assert also element visibility instead of just finding it
Although if the element could not be found an exception would be thrown and the test aborted if an element is in the DOM but hidden it would be found and the test would pass. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This commit is contained in:
parent
30c91a7303
commit
f92a216dcf
|
@ -170,7 +170,9 @@ class AppsManagementContext implements Context, ActorAwareInterface {
|
|||
*/
|
||||
public function iSeeThatTheAppHasBeenEnabled($app) {
|
||||
// TODO: Find a way to check if the enable button is removed
|
||||
$this->actor->find(self::disableButtonForApp($app), 10);
|
||||
PHPUnit_Framework_Assert::assertTrue(
|
||||
$this->actor->find(self::disableButtonForApp($app), 10)->isVisible()
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -178,7 +180,9 @@ class AppsManagementContext implements Context, ActorAwareInterface {
|
|||
*/
|
||||
public function iSeeThatTheAppHasBeenDisabled($app) {
|
||||
// TODO: Find a way to check if the disable button is removed
|
||||
$this->actor->find(self::enableButtonForApp($app), 10);
|
||||
PHPUnit_Framework_Assert::assertTrue(
|
||||
$this->actor->find(self::enableButtonForApp($app), 10)->isVisible()
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -237,8 +241,12 @@ class AppsManagementContext implements Context, ActorAwareInterface {
|
|||
* @Given /^I see the app bundles$/
|
||||
*/
|
||||
public function iSeeTheAppBundles() {
|
||||
$this->actor->find(self::rowForApp('Auditing / Logging'), 2);
|
||||
$this->actor->find(self::rowForApp('LDAP user and group backend'), 2);
|
||||
PHPUnit_Framework_Assert::assertTrue(
|
||||
$this->actor->find(self::rowForApp('Auditing / Logging'), 2)->isVisible()
|
||||
);
|
||||
PHPUnit_Framework_Assert::assertTrue(
|
||||
$this->actor->find(self::rowForApp('LDAP user and group backend'), 2)->isVisible()
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
Loading…
Reference in New Issue