From faab6c095c895f146ac0f749d287040fd46c1cf2 Mon Sep 17 00:00:00 2001 From: Arthur Schiwon Date: Tue, 25 Feb 2014 14:05:48 +0100 Subject: [PATCH] move group-click initialization to groups.js and only react on elements with a data-gid attribute given --- settings/js/users/groups.js | 12 +++++++++++- settings/js/users/users.js | 9 --------- settings/templates/users/part.grouplist.php | 2 +- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/settings/js/users/groups.js b/settings/js/users/groups.js index 3ac8d3f36e..d939f0d3ad 100644 --- a/settings/js/users/groups.js +++ b/settings/js/users/groups.js @@ -75,7 +75,7 @@ $(document).ready( function () { if (e.target.id !== 'newgroup-form') { $("#newgroup-form").hide(); $("#newgroup-init").show(); - } + } }); }); @@ -120,6 +120,16 @@ $(document).ready( function () { } ) }); + + // click on group name + // FIXME: also triggered when clicking on "remove" + $('ul').on('click', 'li[data-gid]', function (event) { + var li = $(this); + var gid = $(li).attr('data-gid'); + // Call function for handling delete/undo on Groups + GroupList.showGroup(gid); + }); + // Implements Groupname editing. $('#app-navigation').on('click', 'img.rename', function (event) { event.stopPropagation(); diff --git a/settings/js/users/users.js b/settings/js/users/users.js index e82a6ceac1..e939d1d3bf 100644 --- a/settings/js/users/users.js +++ b/settings/js/users/users.js @@ -503,15 +503,6 @@ $(document).ready(function () { }); }); - // click on group name - // FIXME: also triggered when clicking on "remove" - $('ul').on('click', 'li', function (event) { - var li = $(this); - var gid = $(li).attr('data-gid'); - // Call function for handling delete/undo on Groups - GroupList.showGroup(gid); - }); - $('#newuser').submit(function (event) { event.preventDefault(); var username = $('#newusername').val(); diff --git a/settings/templates/users/part.grouplist.php b/settings/templates/users/part.grouplist.php index 620049eb29..6acf12a952 100644 --- a/settings/templates/users/part.grouplist.php +++ b/settings/templates/users/part.grouplist.php @@ -12,7 +12,7 @@ -
  • +
  • t('Everyone')); ?>