mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #19731 from owncloud/update-list-of-deprecated-methods 

Update list of deprecated methods
This commit is contained in:
Thomas Müller 2015-10-14 16:34:55 +02:00
parent ba461b0c92 d904a09a04
commit fbccdedb5c
4 changed files with 29 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
lib/private/app/codechecker/deprecationcheck.php
View File

@ -34,6 +34,8 @@ class DeprecationCheck extends AbstractCheck implements ICheck {
*/
protected function getLocalClasses() {
return [
'OC_JSON' => '8.2.0',
'OCP\Config' => '8.0.0',
'OCP\Contacts' => '8.1.0',
'OCP\DB' => '8.1.0',
@ -49,6 +51,15 @@ class DeprecationCheck extends AbstractCheck implements ICheck {
*/
protected function getLocalConstants() {
return [
'OC_API::GUEST_AUTH' => '8.2.0',
'OC_API::USER_AUTH' => '8.2.0',
'OC_API::SUBADMIN_AUTH' => '8.2.0',
'OC_API::ADMIN_AUTH' => '8.2.0',
'OC_API::RESPOND_UNAUTHORISED' => '8.2.0',
'OC_API::RESPOND_SERVER_ERROR' => '8.2.0',
'OC_API::RESPOND_NOT_FOUND' => '8.2.0',
'OC_API::RESPOND_UNKNOWN_ERROR' => '8.2.0',
'OCP::PERMISSION_CREATE' => '8.0.0',
'OCP::PERMISSION_READ' => '8.0.0',
'OCP::PERMISSION_UPDATE' => '8.0.0',
@ -80,8 +91,13 @@ class DeprecationCheck extends AbstractCheck implements ICheck {
*/
protected function getLocalMethods() {
return [
'OC_L10N::get' => '8.2.0',
'OCP\Activity\IManager::publishActivity' => '8.2.0',
'OCP\App::register' => '8.1.0',
'OCP\App::addNavigationEntry' => '8.1.0',
'OCP\App::getActiveNavigationEntry' => '8.2.0',
'OCP\App::setActiveNavigationEntry' => '8.1.0',
'OCP\AppFramework\Controller::params' => '7.0.0',
@ -115,8 +131,12 @@ class DeprecationCheck extends AbstractCheck implements ICheck {
'OCP\IAppConfig::setValue' => '8.0.0',
'OCP\IAppConfig::deleteApp' => '8.0.0',
'OCP\IDBConnection::createQueryBuilder' => '8.2.0',
'OCP\IDBConnection::getExpressionBuilder' => '8.2.0',
'OCP\ISearch::search' => '8.0.0',
'OCP\IServerContainer::getCache' => '8.2.0',
'OCP\IServerContainer::getDb' => '8.1.0',
'OCP\IServerContainer::getHTTPHelper' => '8.1.0',
@ -128,20 +148,21 @@ class DeprecationCheck extends AbstractCheck implements ICheck {
'OCP\User::logout' => '8.1.0',
'OCP\User::checkPassword' => '8.1.0',
'OCP\Util::sendMail' => '8.1.0',
'OCP\Util::formatDate' => '8.0.0',
'OCP\Util::encryptedFiles' => '8.1.0',
'OCP\Util::linkToRoute' => '8.1.0',
'OCP\Util::linkTo' => '8.1.0',
'OCP\Util::formatDate' => '8.0.0',
'OCP\Util::generateRandomBytes' => '8.1.0',
'OCP\Util::getServerHost' => '8.1.0',
'OCP\Util::getServerProtocol' => '8.1.0',
'OCP\Util::getRequestUri' => '8.1.0',
'OCP\Util::getScriptName' => '8.1.0',
'OCP\Util::imagePath' => '8.1.0',
'OCP\Util::isValidFileName' => '8.1.0',
'OCP\Util::generateRandomBytes' => '8.1.0',
'OCP\Util::linkToRoute' => '8.1.0',
'OCP\Util::linkTo' => '8.1.0',
'OCP\Util::logException' => '8.2.0',
'OCP\Util::mb_str_replace' => '8.2.0',
'OCP\Util::mb_substr_replace' => '8.2.0',
'OCP\Util::sendMail' => '8.1.0',
];
}
}

3
lib/private/util.php
View File

@ -1300,12 +1300,11 @@ class OC_Util {
/**
* Get URL content
* @param string $url Url to get content
* @deprecated Use \OC::$server->getHTTPHelper()->getUrlContent($url);
* @throws Exception If the URL does not start with http:// or https://
* @return string of the response or false on error
* This function get the content of a page via curl, if curl is enabled.
* If not, file_get_contents is used.
* @deprecated Use \OCP\Http\Client\IClientService
* @deprecated Use \OC::$server->getHTTPClientService()->newClient()->get($url);
*/
public static function getUrlContent($url) {
try {

2
tests/data/app/code-checker/test-const.php
View File

@ -5,6 +5,6 @@
*/
class BadClass {
public function foo() {
$bar = OC_API::ADMIN_AUTH;
$bar = \OC_API::ADMIN_AUTH;
}
}

2
tests/lib/app/codechecker/deprecationchecktest.php
View File

@ -38,6 +38,7 @@ class DeprecationCheckTest extends TestCase {
['OCP\AppFramework\IApi', 1006, 'test-deprecated-use-alias.php'],
['AppFramework\IApi', 1001, 'test-deprecated-use-sub.php'],
['OAF\IApi', 1001, 'test-deprecated-use-sub-alias.php'],
['OC_API::ADMIN_AUTH', 1003, 'test-const.php'],
];
}
@ -61,7 +62,6 @@ class DeprecationCheckTest extends TestCase {
['test-extends.php'],
['test-implements.php'],
['test-static-call.php'],
['test-const.php'],
['test-new.php'],
['test-use.php'],
['test-identical-operator.php'],