From fca4628a5c7b9e56d8c3c195fb1fd1c7eeb1c262 Mon Sep 17 00:00:00 2001 From: Lukas Reschke Date: Wed, 25 Feb 2015 17:26:54 +0100 Subject: [PATCH] Show 404 page when accessing empty share URL MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Testplan: - [ ] Without: Accessing `public.php?service=files&t=` throws an exception - [ ] With: No exception thrown and 404 page displayed. Fixes https://github.com/owncloud/core/issues/14231 --- apps/files_sharing/public.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/apps/files_sharing/public.php b/apps/files_sharing/public.php index 028c6da12f..ebc5b7bda4 100644 --- a/apps/files_sharing/public.php +++ b/apps/files_sharing/public.php @@ -25,4 +25,10 @@ $urlGenerator = new \OC\URLGenerator(\OC::$server->getConfig()); $token = isset($_GET['t']) ? $_GET['t'] : ''; $route = isset($_GET['download']) ? 'files_sharing.sharecontroller.downloadShare' : 'files_sharing.sharecontroller.showShare'; -OC_Response::redirect($urlGenerator->linkToRoute($route, array('token' => $token))); +if($token !== '') { + OC_Response::redirect($urlGenerator->linkToRoute($route, array('token' => $token))); +} else { + header('HTTP/1.0 404 Not Found'); + $tmpl = new OCP\Template('', '404', 'guest'); + print_unescaped($tmpl->fetchPage()); +}