mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove the deprecated update.php 

* It was documented as deprecated.
* The app code checker warned about it
* It's been three years

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
This commit is contained in:
Christoph Wurst 2020-11-27 13:02:59 +01:00
parent ada55a941e
commit fd649afb1f
No known key found for this signature in database
GPG Key ID: CC42AC2A7F0E56D8
3 changed files with 1 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/files_external/lib/Lib/Storage/AmazonS3.php
View File

@ -185,7 +185,7 @@ class AmazonS3 extends \OC\Files\Storage\Common {
/**
* Updates old storage ids (v0.2.1 and older) that are based on key and secret to new ones based on the bucket name.
* TODO Do this in an update.php. requires iterating over all users and loading the mount.json from their home
* TODO Do this in a repair step. requires iterating over all users and loading the mount.json from their home
*
* @param array $params
*/

18
core/Command/App/CheckCode.php
View File

@ -157,8 +157,6 @@ class CheckCode extends Command implements CompletionAwareInterface {
$errors = array_merge($errors, $schemaErrors['errors']);
}
$this->analyseUpdateFile($appId, $output);
if (empty($errors)) {
$output->writeln('<info>App is compliant - awesome job!</info>');
return 0;
@ -168,22 +166,6 @@ class CheckCode extends Command implements CompletionAwareInterface {
}
}
/**
* @param string $appId
* @param $output
*/
private function analyseUpdateFile($appId, OutputInterface $output) {
$appPath = \OC_App::getAppPath($appId);
if ($appPath === false) {
throw new \RuntimeException("No app with given id <$appId> known.");
}
$updatePhp = $appPath . '/appinfo/update.php';
if (file_exists($updatePhp)) {
$output->writeln("<info>Deprecated file found: $updatePhp - please use repair steps</info>");
}
}
/**
* @param string $optionName
* @param CompletionContext $context

5
lib/private/legacy/OC_App.php
View File

@ -990,11 +990,6 @@ class OC_App {
\OC::$server->getAppManager()->clearAppsCache();
\OC::$server->getAppManager()->getAppVersion($appId, false);
// run upgrade code
if (file_exists($appPath . '/appinfo/update.php')) {
self::loadApp($appId);
include $appPath . '/appinfo/update.php';
}
self::setupBackgroundJobs($appData['background-jobs']);
//set remote/public handlers