From fe8d98f84b36325ccf02dc0cdc85872ddbb4e5d0 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Tue, 20 Apr 2021 17:18:15 +0200 Subject: [PATCH] Fix twofactor backup code tests 16) OCA\TwoFactorBackupCodes\Tests\Unit\Listener\ActivityPublisherTest::testHandleCodesGeneratedEvent Method publish may not return value of type Mock_IEvent_11bf8381, its return declaration is ": void" 17) OCA\TwoFactorBackupCodes\Tests\Unit\Controller\SettingsControllerTest::testCreateCodes Method getBackupCodesState may not return value of type string, its return declaration is ": array" Signed-off-by: Joas Schilling --- .../tests/Unit/Controller/SettingsControllerTest.php | 4 ++-- .../tests/Unit/Listener/ActivityPublisherTest.php | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/apps/twofactor_backupcodes/tests/Unit/Controller/SettingsControllerTest.php b/apps/twofactor_backupcodes/tests/Unit/Controller/SettingsControllerTest.php index db048a4274..e74f08043f 100644 --- a/apps/twofactor_backupcodes/tests/Unit/Controller/SettingsControllerTest.php +++ b/apps/twofactor_backupcodes/tests/Unit/Controller/SettingsControllerTest.php @@ -75,11 +75,11 @@ class SettingsControllerTest extends TestCase { $this->storage->expects($this->once()) ->method('getBackupCodesState') ->with($user) - ->willReturn('state'); + ->willReturn(['state']); $expected = [ 'codes' => $codes, - 'state' => 'state', + 'state' => ['state'], ]; $response = $this->controller->createCodes(); $this->assertInstanceOf(JSONResponse::class, $response); diff --git a/apps/twofactor_backupcodes/tests/Unit/Listener/ActivityPublisherTest.php b/apps/twofactor_backupcodes/tests/Unit/Listener/ActivityPublisherTest.php index 4a32faf0f6..4d93110514 100644 --- a/apps/twofactor_backupcodes/tests/Unit/Listener/ActivityPublisherTest.php +++ b/apps/twofactor_backupcodes/tests/Unit/Listener/ActivityPublisherTest.php @@ -89,8 +89,7 @@ class ActivityPublisherTest extends TestCase { ->with('fritz') ->willReturnSelf(); $this->activityManager->expects($this->once()) - ->method('publish') - ->willReturn($activityEvent); + ->method('publish'); $this->listener->handle($event); }