6a6bcdc558
Propagate throttling on OCS response
...
The BaseResponse converter did not take over any throttling state from the DataResponse.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-01 19:42:31 +00:00
a1877062ac
Use noreply@ as email address for share emails
...
Fixes #26683
Before it used the instance name, which a) doesn't make sense to randomly guess email addresses and b) could contain characters that are not allowed in email addresses like spaces.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-05-28 11:42:16 +00:00
5bb0370994
improve type handling of Avatar::generateAvatarFromSv
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-26 17:11:42 +00:00
ede67149ea
Avoid reading ~/.aws/config when using S3 provider
...
When using S3 storage, we sometimes have open_basedir errors due to aws-sdk-php trying to read ~/.aws/config which is out of open_basedir restrictions.
Christoph Wurst already added csm=false config in #21406 but it wasn't enough, we also need to set use_arn_region=false, added in this commit.
Signed-off-by: Florent <florent@coppint.com>
2021-05-25 08:59:03 +00:00
80cda3b174
Fix log error when creating files from an empty template
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-05-19 07:03:27 +00:00
3d9abee6f0
Don't break OCC if an app is breaking in it's Application class
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-06 14:46:11 +02:00
f4135573d0
Do not try to contact lookup server if not needed
...
In some cases (for example you never send data to the lookup server)
there is no need for this job to even try.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-29 09:07:38 +02:00
e2fffcda44
Fail when creating new files with an empty path
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-28 10:06:03 +00:00
ab595274c0
Do not allow to overwrite some variables
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:40:14 +00:00
6a8d6beb57
Fix ratelimit template
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:40:12 +00:00
4082318616
Merge pull request #26760 from nextcloud/backport/26259/stable21
...
[stable21] Validate the website field input to be a valid URL
2021-04-26 20:42:06 +02:00
e075f80f41
Merge pull request #26759 from nextcloud/backport/26747/stable21
...
[stable21] Fix installer deprecation warnings for PHP 8
2021-04-26 20:41:49 +02:00
d1756dde20
Log deprecation only as debug
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 15:12:50 +00:00
6ed9bb36ac
Respect the error level when logging
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 15:12:50 +00:00
2c1218826d
Validate the website field input to be a valid URL
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 11:58:56 +00:00
63fa7d9354
PHP 8+ deprecates openssl_free_key
2021-04-26 10:46:44 +00:00
c12be83a0b
Only use libxml_disable_entity_loader on PHP<8
2021-04-26 10:46:44 +00:00
35204381bb
private cannot be final
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2021-04-26 07:06:08 +00:00
97e5fe43df
Explicitly check hex2bin input
...
For #23197
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-22 11:31:39 +00:00
f915efc859
Merge pull request #26639 from nextcloud/backport/26551/stable21
...
[stable21] ensure redis returns bool for hasKey
2021-04-20 10:33:18 +02:00
92e1606c18
ensure redis returns bool for hasKey
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-19 23:40:47 +02:00
fe0f1c792c
Fix empty password check for mail shares
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-19 15:44:26 +02:00
ad91f39c46
Limit size of properties to 2048 characters
...
It is unreasonable to expect that one of these fields would be longer
than 2048 characters. Whilst some have definitely lower limits (such as
for phone numbers or domain names), a upper bound as sanity check makes
sense.
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-12 16:37:04 +00:00
b5838c5248
Increase subnet matcher
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-12 10:36:25 +00:00
d66e86c56c
Merge pull request #26400 from nextcloud/backport/26061/stable21
...
[stable21] Log and continue when failing to update encryption keys during for individual files
2021-04-06 13:43:34 +02:00
b59cf16325
Merge pull request #26406 from nextcloud/backport/26396/stable21
2021-04-02 16:59:51 +02:00
dc8e819915
Properly handle creating the template directory in a subfolder ( fixes #25787 )
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:31:55 +00:00
89a19a338e
Get the parent directory before creating a file from a template
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:31:55 +00:00
40507ca543
make ILDAPProviderFactory usable when there is no ldap setup
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-01 13:08:23 +02:00
6ac708c99a
Fix phpcs issues in encryption update
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-01 07:56:41 +00:00
d6bad03a5c
Log and continue when failing to update encryption keys during for individual files
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 07:56:41 +00:00
0c348863e7
Allow apps to write/update account data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-01 06:07:47 +00:00
618a48487f
Merge pull request #26377 from nextcloud/backport/25500/stable21
...
[stable21] fix(translation): replace static error message
2021-03-31 10:07:58 +02:00
00daf58da8
Merge pull request #26376 from nextcloud/backport/25804/stable21
...
[stable21] Do not attempt to read 0 bytes when manually iterating over a non-seekable file
2021-03-31 09:44:47 +02:00
0432b32535
Merge pull request #26379 from nextcloud/backport/25924/stable21
...
[stable21] Only mark migrations as installed after execution
2021-03-31 07:43:32 +02:00
caec3a8cee
gracefully handle deleteFromSelf when share is already gone
...
- handling race conditions
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 20:26:29 +00:00
e3927afe19
Only mark migrations as installed after execution
...
The problem is that if a developer creates a structural error in their migration file,
they will already be marked as executed and an not be rerun.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-30 19:51:12 +00:00
3073732002
revert(comment)
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-03-30 19:26:04 +00:00
c49cff453c
revert(exception): keep throwing an exception for now
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-03-30 19:26:04 +00:00
22ddcfa740
fix(translation): replace static error message
...
as suggested by @kesselb in nextcloud/server#25490
Signed-off-by: Samuel <faust64@gmail.com>
2021-03-30 19:26:04 +00:00
fc2e09b667
Properly end iterating over the file once the target has been reached
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-30 19:22:47 +00:00
ec492eadfa
Add known user check in avatar when v2-private scope
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-29 07:03:37 +00:00
ab22999eb9
Added PlaceholderAvatar with own cached images
...
When avatar scope is private, the PlaceholderAvatar is used to deliver a
placeholder avatar based on the user's initials.
This was implemented as a separate class for now to avoid messing with
the existing UserAvatar implementation and its generated vs
non-generated logic.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-29 07:03:36 +00:00
73ec32d19b
Add property scope tests for AccountManager
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-29 07:03:35 +00:00
b9d59e2994
OCS allow reading and writing account property scopes
...
Extends the provisioning API to allow a user to get and set their own
account property scopes.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-29 07:03:32 +00:00
5d76574a81
Map old account scope properties to new names
...
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-29 07:03:31 +00:00
f45f826b52
Add new v2-private account scope
...
Added new v2-private account manager scope that restricts the scope
further by excluding public link access.
Avatars with v2-private account scope are now showing the guest avatar
instead of the real avatar.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-29 07:03:31 +00:00
d65ce19f6e
Merge pull request #26291 from nextcloud/backport/21484/stable21
...
[stable21] show better error messages when a file with a forbidden path is encountered
2021-03-26 10:44:43 +01:00
cf8be87e47
Log when a storage is marked as unavailable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 16:10:28 +00:00
fdf7eb10a2
show better error messages when a file with a forbidden path is encountered
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-25 10:56:59 +00:00
Lukas Reschke
Morris Jobke
Robin Appelman
Florent
Julius Härtl
Joas Schilling
Roeland Jago Douma
Roeland Jago Douma
acsfer
Maxence Lange
Arthur Schiwon
Vincent Petry
John Molakvoæ
kesselb
Christoph Wurst
Samuel