Daniel Calviño Sánchez
01ccbe68ff
Restore previous state when failing to change video verification state
...
When video verification can not be enabled or disabled the previous
state is set again in the JavaScript share object. This ensures that the
UI will not reflect a misleading state.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-06-03 14:08:17 +00:00
Christoph Wurst
c423a50938
Fix the Talk verification
...
When enabling or disabling Talk verification in mail shares the server
expects also a new password to be set. As we always just update one
property at a time this means the Talk verification was impossible to
activate or deactivate. With this patch, we send the talk option AND the
new password. If there is no new password, the Talk option is disabled
(in mail shares; in link shares it is possible to enable or disable the
video verification without changing the password).
When we finally have descriptive text on ActionCheckbox'es we should
definitely add some explanatory text for the user. Right now this is as
good as it gets.
We'll have to backport to 18.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-03 13:51:42 +00:00
Daniel Calviño Sánchez
9a5b51d43c
Fix creating a mail share with a password
...
When a mail share was created with a password the given password was not
hashed, so it was not possible to open the share with that password.
Moreover, if passwords were enforced the given password was ignored and
a new one was set (although in this case it was hashed so it worked as
expected). Now the given password is properly hashed and not overriden.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:43 +00:00
Daniel Calviño Sánchez
5de6eb07c0
Extend mail shares unit tests to check the password and mail template
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 11:37:42 +00:00
Daniel Calviño Sánchez
e9ccb802e8
Fix reference to wrong class name
...
\OCP\IShare does not exist; the right name is \OCP\Share\IShare,
although it is already imported as IShare.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 06:48:00 +00:00
Roeland Jago Douma
d12e379c96
Merge pull request #21128 from nextcloud/backport/21123/stable19
...
[stable19] simplify getGroups, fixing wrong chunking logic
2020-05-28 14:59:50 +02:00
Arthur Schiwon
1e5295138a
simplify getGroups, fixing wrong chunking logic
...
pagination is taken care of properly in the search logic in Access class
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-27 17:38:45 +00:00
Christoph Wurst
14b618bcaf
Fix devices & sessions sanitization
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-27 15:57:18 +02:00
Arthur Schiwon
557a3754c1
use the loginname to verify the old password in user password changes
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 19:20:42 +00:00
Arthur Schiwon
d0559a4871
fixes infinitely repeating LDPA search results with PHP <= 7.2
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 09:56:10 +00:00
Morris Jobke
138eddc0f1
Merge pull request #21028 from nextcloud/backport/20629/stable19
...
[stable19] Don't load text file preview when text app is available (Fixes : #20615 )
2020-05-20 13:54:17 +02:00
Julius Härtl
dd15780edd
Fix share update test
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-05-18 13:47:39 +00:00
Roeland Jago Douma
aac0dd1f20
Have share permissions on link shares if it is enabled
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-18 13:47:38 +00:00
Jonas Meurer
be37ca1776
Don't load text file preview when text app is available ( Fixes : #20615 )
...
When opening a shared text document, the files_sharing app uses
internal preview support in case no other app to open the text file is
available.
So far, it only checks for the old files_texteditor app, not for the new
new text app. This commit fixes this by checking for both.
Signed-off-by: Jonas Meurer <jonas@freesources.org>
2020-05-18 08:59:53 +00:00
Robin Appelman
ffc3b48a40
update icewind/smb to 3.2.4
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-15 12:35:22 +00:00
John Molakvoæ
4bde23d239
Merge pull request #20878 from nextcloud/backport/20719/stable19
2020-05-11 14:55:16 +02:00
Georg Ehrke
e048bf8550
Rename app-generated to z-app-generated, because macOS Contacts supports only one and will pick the first one alphabetically
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:56 +00:00
Georg Ehrke
d1909526fc
Implement ctag and etag in ContactsInteraction
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:55 +00:00
GretaD
adbdecb1d6
Fix languages empty array
...
Signed-off-by: GretaD <gretadoci@gmail.com>
2020-05-08 09:25:59 +00:00
John Molakvoæ (skjnldsv)
90a65f83e0
Do not process the same FileInfo twice
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-08 05:39:53 +00:00
Robin Appelman
614acc9419
add locking to resolve concurent move to trashbin conflicts
...
uses a lock to prevent two requests from moving a file to the trashbin concurrently
(causing sql duplicate key errors)
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-06 20:36:55 +02:00
Morris Jobke
06732cf2af
Merge pull request #20832 from nextcloud/fix/sharing-filter-user-shares-only-fix-group-display
...
Do not filter id matching userId on non-user-share shares
2020-05-06 17:46:21 +02:00
Nextcloud bot
3bf4e7d673
[tx-robot] updated from transifex
2020-05-06 02:16:28 +00:00
John Molakvoæ (skjnldsv)
a26ca1e638
Do not filter id matching userId on non-user-share shares
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 21:36:46 +02:00
John Molakvoæ (skjnldsv)
edecd0931e
Fix filtering our owner & current user from shares
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 10:28:33 +00:00
Nextcloud bot
09d7854d0e
[tx-robot] updated from transifex
2020-05-05 02:16:14 +00:00
John Molakvoæ (skjnldsv)
ff20da637e
Fix federated link sharing permissions
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-04 11:48:11 +00:00
Morris Jobke
6aceb39714
Merge pull request #19124 from nextcloud/bug/13647/ignore-delete-groups
...
Exclude groups from sharing: Skip delete groups
2020-05-04 10:02:32 +02:00
Nextcloud bot
43fefee847
[tx-robot] updated from transifex
2020-05-04 02:16:18 +00:00
Nextcloud bot
d2f165e448
[tx-robot] updated from transifex
2020-05-03 02:16:16 +00:00
Gary Kim
8dd23f9854
Fix expiry datepicker allowing all dates
...
vue2-datepicker expects a `disabled-date` function
rather than `not-before` and `not-after` dates.
This commit updates it so that we now provide
vue2-datepicker with a `disabled-date` function.
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-05-02 18:58:41 +08:00
Nextcloud bot
e77e0b0e2f
[tx-robot] updated from transifex
2020-05-02 02:16:32 +00:00
John Molakvoæ (skjnldsv)
31172a0cd9
Process shares only once, better debug and expiration date code
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-01 13:39:57 +00:00
Roeland Jago Douma
b7b7b2872c
Fix owner on publicownerwrapper
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-01 10:50:26 +02:00
Roeland Jago Douma
c724eb24d5
Merge pull request #20380 from nextcloud/design/notification-mails
...
Fix design and layout of notification mails
2020-05-01 08:53:39 +02:00
Roeland Jago Douma
da9ad9ec78
Merge pull request #20291 from nextcloud/fix/user_menu_not_focused
...
Fix focus for user actionmenu
2020-05-01 08:42:06 +02:00
Nextcloud bot
9f448d864b
[tx-robot] updated from transifex
2020-05-01 02:16:47 +00:00
Jan-Christoph Borchardt
e981669e89
Fix notification mail tests
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-05-01 03:00:42 +02:00
GretaD
9b1f98f6fd
Fix the keyboard tab for actionmenu
...
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-30 19:03:56 +00:00
Roeland Jago Douma
b2b8be83f8
Merge pull request #20538 from nextcloud/fix/20520/share-expire
...
Fix share expiration date not shown
2020-04-30 20:55:05 +02:00
Jan-Christoph Borchardt
ae665e2175
Merge pull request #20744 from nextcloud/fix/public-design
...
Fix public layout header title & description
2020-04-30 19:02:32 +02:00
Gary Kim
02b5ded840
Fix share expiration date not shown
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-30 22:35:52 +08:00
Morris Jobke
0f9b88c5a9
Merge pull request #20718 from nextcloud/fix/public_share_owner_activity_mess
...
Add a wrapper to fall back to the share owner on public shares
2020-04-30 13:46:13 +02:00
John Molakvoæ (skjnldsv)
6e79fb60d8
Fix public layout header title & description
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-30 13:32:28 +02:00
Joas Schilling
5b5550dbba
Merge pull request #20677 from nextcloud/followup/17718/scaling-user-provisioning
...
Scaling user provisioning for subadmins with many groups
2020-04-30 12:49:57 +02:00
Roeland Jago Douma
b8b53a2d9a
Merge pull request #19436 from nextcloud/bugfix/noid/dav-quota-calculation
...
Do not include mountpoints when calculating quota usage on WebDAV
2020-04-30 09:13:19 +02:00
Roeland Jago Douma
a1f3293c06
Merge pull request #19039 from nextcloud/dav-activity-provide-links-to-calendar
...
Provide links to calendar in event creation/update activities
2020-04-30 09:10:56 +02:00
Roeland Jago Douma
bc66bdc072
Add a wrapper to fall back to the share owner on public shares
...
Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-30 08:57:01 +02:00
Roeland Jago Douma
2df57b270c
Merge pull request #20720 from nextcloud/bugfix/noid/temporary-fix-contacts-search
...
Temporary fix contacts search
2020-04-30 08:52:50 +02:00
Nextcloud bot
523a8ba5c3
[tx-robot] updated from transifex
2020-04-30 02:17:11 +00:00