cb0c2243ac
Merge pull request #25384 from nextcloud/backport/25218/stable20
...
[stable20] do not remove valid group shares
2021-02-18 20:13:58 +01:00
a6414a7d05
take into account that UNIQUE index might not work as expected
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 15:59:50 +01:00
bf61a439d8
do not remove valid group shares
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-17 08:51:37 +01:00
d5407764d7
Do not send imip email to invalid recipients
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-11 19:03:14 +00:00
fcfa39183c
Properly handle SMB ACL blocking scanning a directory
...
This makes sure that a possible ForbiddenException is properly passed
through the storage as a ForbiddenException and can be catched when
trying to fetch the quota info of a parent folder
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-01 11:13:44 +00:00
9d0319446e
[CalDAV] Validate notified emails
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-01-25 19:49:20 +00:00
ead953addd
Catch NotFoundException when querying quota
...
Fixes parent folder that becomes inaccessible when it contains a
non-existing / broken entry because the quota check made the PROPFIND
on parent fail altogether.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-25 12:32:18 +00:00
e0598117e1
also use storage copy when dav copying directories
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-21 21:08:58 +00:00
8295cc90d8
Merge pull request #24590 from nextcloud/backport/24358/stable20
...
[stable20] use storage copy implementation when doing dav copy
2021-01-07 14:08:17 +01:00
9e6cc31f60
Merge pull request #24972 from nextcloud/backport/24964/stable20
...
[stable20] Don't throw a 500 when importing a broken ics reminder file
2021-01-07 09:08:11 +01:00
f34202190c
fixes sharing to group ids /w chars that are being url encoded, carddav
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-05 18:54:15 +01:00
b4434833af
fix finding of groups with decodable chars in their id via DAV
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-05 18:54:15 +01:00
3ce013fa14
fixes sharing to group ids with characters that are being url encoded
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-05 18:54:15 +01:00
088418fd91
Don't throw a 500 when importing a broken ics reminder file
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-05 11:59:40 +00:00
4fa34362a3
Allow to force rename a conflicting calendar
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-12-22 07:35:23 +00:00
d44c6aa524
Add tel, note, org and title search
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-12-14 16:41:55 +00:00
958f7968e3
Adjust further columns
...
- calendarsubscriptions.lastmodified -> not null
- external_config.value -> allow null
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-14 11:12:50 +01:00
1fef301334
Adjust calendars.components to 64 chars
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-14 11:12:50 +01:00
6790369cfe
use storage copy implementation when doing dav copy
...
instead of using the sabredav fallback (which does a read+write stream copy)
this greatly speeds up dav copies
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-07 16:07:06 +00:00
6916240d98
Merge pull request #24446 from nextcloud/backport/23652/stable20
...
[stable20] Fix public calendars shared to circles
2020-11-30 11:24:38 +01:00
6635dbb3bd
A valid user session is required for circles.
...
The circles app depends on a valid userId. A public shared calender might be viewed by guests without a user session. For such requests the principal is null.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-30 09:01:53 +00:00
761ee14fd7
Update phpdoc for circleToPrincipal
...
as the QueryException is already catched inside circleToPrincipal.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-30 09:01:51 +00:00
8e262d9e59
Make sure we add new line between vcf groups exports
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-11-30 08:13:46 +00:00
5aac8a1b34
Use correct year for generated birthdays events
...
'X-APPLE-OMIT-YEAR' is not always present, at least iOS 12.4 uses the hard coded date of 1604 (the start of the gregorian calendar) when the year is unknown.
cf. https://forums.bitfire.at/topic/2050/bday-without-year-for-vcard-3-0-if-server-drops-property-x-apple-omit-year and https://gitlab.com/CardBook/CardBook/-/issues/586
Signed-off-by: Sven Strickroth <email@cs-ware.de>
2020-11-20 20:47:56 +00:00
cd76043691
Fix CS
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:52 +01:00
b6ce689e25
Fix public calendars as they are stored with null on oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:51 +01:00
8ff0523c3d
Make sure columns with an empty default are nullable for Oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 12:57:51 +01:00
a0f95cd1d3
Merge pull request #24058 from nextcloud/backport/24054/stable20
...
[stable20] Manually iterate over calendardata when oracle is used
2020-11-11 21:54:55 +01:00
bf0dbffe81
Manually iterate over calendardata when oracle is used
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-11 16:12:25 +00:00
b82b3b0140
Use png icons in caldav reminder emails
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-11-11 12:38:21 +00:00
19816fe85f
Don't leave cursors open when tests fail
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 14:18:02 +00:00
f14c0dec40
Don't overwrite the event if we use it later
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-28 13:41:38 +00:00
aa12dd403e
Also run the SabreAuthInitEvent for the main server
...
else for example trusted servers breaks
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-28 08:10:21 +00:00
b1d3877625
CalDavBackend: check if timerange is array before accessing
...
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-10-19 10:56:51 +00:00
732cf6b8d3
Fix array to string conversion on event search
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-05 21:07:05 +00:00
6365e7e162
Sync all users to the system addresssbook
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-29 07:15:49 +00:00
aefbf4c01d
Fix numeric folders throwing on markDirty
...
TypeError: strpos() expects parameter 1 to be string, int given
The problem is that in cacheNode() we strip of any slashes, so
a folder "0/" will be trimmed to "0" and be used as an array key.
Since PHP automatically casts numeric array keys to integers,
you afterwards get $nodePath as int(0). Since it's now a number,
the strpos() function does not accept it anymore. Simply casting
$nodePath to a string again in the foreach solves the issue
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-25 13:14:49 +00:00
1639289b95
Update urls to stackoverflow.com to "HTTPS"
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-09-17 17:38:27 +02:00
99c9423766
Remove @suppress SqlInjectionChecker
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 15:53:56 +02:00
04a3580d19
Remove phan config - was replaced by Psalm
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 14:46:29 +02:00
c1ff011990
Merge pull request #22799 from nextcloud/bugfix/noid/dont-log-microsoft-webdav-client-trying-to-tag
...
Don't log Microsoft WebDAV client trying to tag things
2020-09-14 14:43:54 +02:00
2dbd6424f7
Don't log Microsoft WebDAV client trying to tag things
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-11 11:52:05 +02:00
b5204a78cc
Mitigate encoding issue with user principal uri
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-10 16:00:03 +02:00
1dddf6adc7
Properly catch exception from writing to stream when copying a file
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-10 09:03:53 +02:00
1f7f93a695
Update license headers for Nextcloud 20 (again)
...
There are still lots of outdated headers, so time for another round of
updates.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +02:00
e8a4feb1c6
Change Content-Disposition Header
...
- Make ALLOWED_CONTENT_TYPES public in order to use
- Add $fileName variable which uses "$node->getName()" to get the proper file name and "$file->getMimeType()" along with the ALLOWED_CONTENT_TYPES array in PhotoCache.php to get the proper file extension
- Make "$fileName" the name of the file in the Content-Disposition header when downloading a Contact's photo
- Add filename to the CardDAV integration image export test header
- Change headers in ImageExportPluginTest to reflect changes
Signed-off-by: Jacob Neplokh <me@jacobneplokh.com>
2020-09-05 11:46:25 -07:00
593d64d935
Merge pull request #17456 from brad2014/feature/brad2014/12391-improve-imip-mail-message-take-2
2020-09-04 19:53:02 +02:00
4cf29e598d
Do not keep the part file if the forbidden exception has retry set to false
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-03 11:00:24 +02:00
442af8c5d5
Minor cleanup: php-cs-fixer, tests, interface consistency
...
IMipPlugin.php Removed blank lines to make php-cs-fixer happy.
Minor cleanup: bugs found by Psalm static checker
IEMailTemplate: The public interface to addBodyListItem also needs to include the new plainIndent parameter.
IMipPlugin: Fixes an undefined variable for events that do not have DTEND. Also use explicit string conversion for parameters and properties in several places.
The new email template adds an additional blank line before "button" links in plain text, so the tests were fixed to include that additional blank line.
Signed-off-by: Brad Rubenstein <brad@wbr.tech>
2020-09-02 17:54:36 +02:00
460db942a0
Update apps/dav/lib/CalDAV/Activity/Setting/CalDAVSetting.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2020-08-26 12:20:46 +00:00
Roeland Jago Douma
Arthur Schiwon
Christoph Wurst
Julius Härtl
Thomas Citharel
Vincent Petry
Robin Appelman
Morris Jobke
Joas Schilling
John Molakvoæ (skjnldsv)
Daniel Kesselberg
Sven Strickroth
Richard Steinmetz
Roeland Jago Douma
Simon Spannagel
J0WI
Georg Ehrke
Jacob Neplokh
John Molakvoæ
Brad Rubenstein