Christoph Wurst
fbf25e164d
Merge pull request #24515 from nextcloud/fix/noid/dav-share-groups-special-chars
...
fixes sharing to group ids with characters that are being url encoded
2020-12-18 12:01:49 +01:00
Arthur Schiwon
622d02842c
fixes sharing to group ids /w chars that are being url encoded, carddav
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-16 22:42:57 +01:00
Arthur Schiwon
9abff14e8d
fix finding of groups with decodable chars in their id via DAV
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-16 22:28:20 +01:00
Arthur Schiwon
1186977589
fixes sharing to group ids with characters that are being url encoded
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-16 22:15:02 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
Christoph Wurst
820f9f4f63
Merge pull request #24629 from nextcloud/enh/noid/optional-before-required
...
Make $vars and $secureRandom required.
2020-12-16 12:43:06 +01:00
Arthur Schiwon
d8ad4ef6b5
use a consistent default value for sharing.maxAutocompleteResults
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 11:53:39 +01:00
Arthur Schiwon
2b017b704a
dav search to honour sharing.maxAutocompleteResults setting
...
- it is being used on frontend by users
- user and big instances benefit from quicker results and less load
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-15 11:53:39 +01:00
John Molakvoæ (skjnldsv)
45b3ddd882
Add tel, note, org and title search
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-12-14 16:45:17 +01:00
Nextcloud bot
ea4fc6b507
[tx-robot] updated from transifex
2020-12-13 02:18:32 +00:00
Daniel Kesselberg
9558734d07
Add $secureRandom to test case
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-12-10 17:06:37 +01:00
Roeland Jago Douma
ccd5ca5476
Merge pull request #23044 from nextcloud/migration-10.5
...
Handle owncloud migration to latest release
2020-12-10 14:32:13 +01:00
Roeland Jago Douma
3c693db0ca
Merge pull request #24605 from nextcloud/enh/share-deck
...
Add deck share provider support
2020-12-10 14:30:08 +01:00
John Molakvoæ (skjnldsv)
fd01d24402
Allow to force rename a conflicting calendar
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-12-10 09:12:28 +01:00
Nextcloud bot
5fc20e8862
[tx-robot] updated from transifex
2020-12-10 02:20:14 +00:00
Julius Härtl
bac1651380
Handle deck share type in audit and dav app
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:23 +01:00
Vincent Petry
0d42d996d1
Adjust further columns
...
- calendarsubscriptions.lastmodified -> not null
- external_config.value -> allow null
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-09 12:13:33 +01:00
Vincent Petry
b9836398cc
Adjust calendars.components to 64 chars
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-12-09 12:13:33 +01:00
Joas Schilling
86a3b7e7bf
Merge pull request #24486 from nextcloud/feature/noid/phone-number-validation
...
Phone number validation and search
2020-12-08 17:05:38 +01:00
Roeland Jago Douma
6a7e849090
php cs fix
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
Roeland Jago Douma
b98fbcb774
We can no longe mock multiple interfaces
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
Roeland Jago Douma
673beefb41
Fix MoveCalendarTest
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:04 +01:00
Roeland Jago Douma
7f0b2738bf
Fix notifier test
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-07 15:44:03 +01:00
Joas Schilling
da9462b482
Make code strict
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
Morris Jobke
fc57f60ece
Merge pull request #24358 from nextcloud/dav-storage-copy
...
use storage copy implementation when doing dav copy
2020-12-03 15:03:13 +01:00
Morris Jobke
32f6bdf067
Merge pull request #24396 from nextcloud/dont-use-system-composer
...
dont use system composer for autoload checker
2020-12-02 16:15:55 +01:00
Morris Jobke
9be5caa937
Merge pull request #24340 from nextcloud/td/psalm/job_execute
...
Use proper OCP\BackgroundJobs\Job
2020-11-30 10:00:14 +01:00
Morris Jobke
528516b69f
Merge pull request #23652 from nextcloud/bug/circles-508/circles-public-shares
...
Fix public calendars shared to circles
2020-11-30 09:53:53 +01:00
Robin Appelman
7956cef622
rebuild autoloader scripts with 2.0.7
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-26 15:49:03 +01:00
Daniel Kesselberg
35098a9973
A valid user session is required for circles.
...
The circles app depends on a valid userId. A public shared calender might be viewed by guests without a user session. For such requests the principal is null.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-26 09:00:09 +01:00
Daniel Kesselberg
efef6e9b78
Update phpdoc for circleToPrincipal
...
as the QueryException is already catched inside circleToPrincipal.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-26 09:00:04 +01:00
Roeland Jago Douma
6166e1a157
Use proper OCP\BackgroundJobs\Job
...
And typehunt the IJobList
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-25 15:03:06 +01:00
Christoph Wurst
e165dcbe35
Merge pull request #24357 from nextcloud/fix/vcf-export-group-multiline
...
Make sure we add new line between vcf groups exports
2020-11-25 12:24:27 +01:00
Nextcloud bot
81bf307845
[tx-robot] updated from transifex
2020-11-25 02:18:53 +00:00
Robin Appelman
5ca0de2dee
use storage copy implementation when doing dav copy
...
instead of using the sabredav fallback (which does a read+write stream copy)
this greatly speeds up dav copies
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-24 18:42:05 +01:00
John Molakvoæ (skjnldsv)
e18899a06d
Make sure we add new line between vcf groups exports
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-11-24 18:33:39 +01:00
John Molakvoæ
ce5e60d4b5
Merge pull request #24108 from csware/apple-unknown-year
...
Use correct year for generated birthdays events
2020-11-17 09:20:59 +01:00
Nextcloud bot
0bed1c2bd0
[tx-robot] updated from transifex
2020-11-16 02:19:21 +00:00
Sven Strickroth
e526e76314
Use correct year for generated birthdays events
...
'X-APPLE-OMIT-YEAR' is not always present, at least iOS 12.4 uses the hard coded date of 1604 (the start of the gregorian calendar) when the year is unknown.
cf. https://forums.bitfire.at/topic/2050/bday-without-year-for-vcard-3-0-if-server-drops-property-x-apple-omit-year and https://gitlab.com/CardBook/CardBook/-/issues/586
Signed-off-by: Sven Strickroth <email@cs-ware.de>
2020-11-13 15:57:12 +01:00
Morris Jobke
9db321cf11
Merge pull request #24054 from nextcloud/bugfix/noid/calendar-repair-oracle
...
Manually iterate over calendardata when oracle is used
2020-11-11 17:09:28 +01:00
Julius Härtl
e69655e9a6
Manually iterate over calendardata when oracle is used
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-11 15:08:43 +01:00
Morris Jobke
0c7bed26e8
Merge pull request #23915 from st3iny/fix/noid/png-icons-in-caldav-reminder-emails
...
Use png icons in caldav reminder emails
2020-11-11 12:45:23 +01:00
Joas Schilling
264d54b388
Fix CS
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:43:34 +01:00
Joas Schilling
31e243be74
Fix public calendars as they are stored with null on oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:35:16 +01:00
Joas Schilling
ecbb066dec
Make sure columns with an empty default are nullable for Oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:35:16 +01:00
Joas Schilling
609c8a9cf8
Fix "Invalid fetch style: 12" on Oracle
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:35:14 +01:00
Morris Jobke
f23c2162ad
Merge pull request #23993 from nextcloud/bugfix/noid/close-cursors
...
Don't leave cursors open
2020-11-10 15:15:03 +01:00
eleith
10aa22dd45
Merge pull request #23070 from eleith/complex-recurrance-imports
...
handle vcalander documents with multiple VEVENTS not in order
2020-11-10 05:20:56 -08:00
Joas Schilling
8027dcbc6f
Don't leave cursors open when tests fail
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 12:28:17 +01:00
Richard Steinmetz
f1c242c71d
Use png icons in caldav reminder emails
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-11-07 14:09:22 +01:00
Roeland Jago Douma
8bd39fccf4
Have the CommentsPropertiesPlugin use the new fancy method
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-04 16:37:42 +01:00
Morris Jobke
8d02ee9ac7
Merge pull request #21693 from nextcloud/fix/noid/import-certificates-only-by-system
...
Improve CertificateManager to not be user context dependent
2020-11-03 21:48:37 +01:00
Nextcloud bot
a6719390e2
[tx-robot] updated from transifex
2020-11-03 02:19:16 +00:00
Morris Jobke
dc479aae2d
Improve CertificateManager to not be user context dependent
...
* removes the ability for users to import their own certificates (for external storage)
* reliably returns the same certificate bundles system wide (and not depending on the user context and available sessions)
The user specific certificates were broken in some cases anyways, as they are only loaded if the specific user is logged in and thus causing unexpected behavior for background jobs and other non-user triggered code paths.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 00:13:01 +01:00
Nextcloud bot
3f94c014f0
[tx-robot] updated from transifex
2020-11-02 02:19:04 +00:00
Nextcloud bot
b1620344f3
[tx-robot] updated from transifex
2020-11-01 02:18:23 +00:00
Nextcloud bot
ffda62b421
[tx-robot] updated from transifex
2020-10-31 02:18:47 +00:00
leith abdulla
8c1f17383b
resolve review comments
...
update styling for conditionals and simplifying conditional by only
relying on dtstart instead of also counting vevents (since they imply
the same condition, assuming valid events)
Signed-off-by: leith abdulla <online-nextcloud@eleith.com>
2020-10-29 07:31:56 -07:00
leith abdulla
a40a307b65
handle vcalander documents with recurrence with exemptions or edits
...
when importing ics files from third party services (ex: google), long
running recurrence vcalander objects can contain numerous vevents
relating to past exemptions or edits.
these objects are handled incorrectly, leading to incorrect first and/or
last occurence dates from being inferred. as a result, a number of
imported events are not rendered in the calendar.
this PR makes use of EventIterator's constructor that takes in an array
of VEVENTS to properly handle these complex cases.
Also of note is that other parameter signatures of EventIterator's constructor,
will be deprecated, according to comments in sabre dav EventIterator.php
Signed-off-by: leith abdulla <online-nextcloud@eleith.com>
2020-10-28 21:07:00 -07:00
Roeland Jago Douma
c5e0ef1972
Don't overwrite the event if we use it later
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-28 13:24:17 +01:00
Morris Jobke
510b653330
Merge pull request #23723 from nextcloud/fix/dav_server_auth_init
...
Also run the SabreAuthInitEvent for the main server
2020-10-28 09:08:03 +01:00
Nextcloud bot
e4288529fa
[tx-robot] updated from transifex
2020-10-28 02:18:52 +00:00
Roeland Jago Douma
46ce7277c7
Also run the SabreAuthInitEvent for the main server
...
else for example trusted servers breaks
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-27 15:23:27 +01:00
Nextcloud bot
ae54ae6c9b
[tx-robot] updated from transifex
2020-10-27 02:18:34 +00:00
Nextcloud bot
9aedda5542
[tx-robot] updated from transifex
2020-10-23 02:18:51 +00:00
Joas Schilling
8ad1bf69f8
Merge pull request #23497 from nextcloud/bugfix/noid/caldav-timerange-array
...
CalDavBackend: check if timerange is array before accessing
2020-10-19 12:54:14 +02:00
Simon Spannagel
9956d13b90
CalDavBackend: check if timerange is array before accessing
...
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-10-16 07:50:36 +02:00
Nextcloud bot
b13d9bcca6
[tx-robot] updated from transifex
2020-10-16 02:18:11 +00:00
Nextcloud bot
55b923e1fd
[tx-robot] updated from transifex
2020-10-13 19:33:40 +00:00
Morris Jobke
78da9532ba
Merge pull request #23317 from nextcloud/fix/contact-update
...
handle nested properties for contact updates
2020-10-12 21:49:04 +02:00
call-me-matt
1b2386d108
handle nested properties, fixes #20544
...
Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
2020-10-12 21:27:38 +02:00
Nextcloud bot
8ae4ff6648
[tx-robot] updated from transifex
2020-10-12 02:18:06 +00:00
Nextcloud bot
d9c3b99907
[tx-robot] updated from transifex
2020-10-11 02:18:42 +00:00
Nextcloud bot
9c21bd22b5
[tx-robot] updated from transifex
2020-10-09 02:18:45 +00:00
Joas Schilling
51fbcb0801
Use PSR Logger in event dispatcher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-08 16:52:56 +02:00
Morris Jobke
ca5e8d2093
Merge pull request #23025 from Iscle/master
...
DirectController: Let users choose the link expiration time
2020-10-06 22:12:22 +02:00
Morris Jobke
5169976d2b
Merge pull request #23028 from nextcloud/bugfix/noid/array-to-string-conversion-on-event-search
...
Fix array to string conversion on event search
2020-10-05 23:04:48 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
Roeland Jago Douma
a1faee8a1e
Fix unit tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-10-05 15:49:00 +02:00
Roeland Jago Douma
0bca480efd
Merge pull request #22969 from eleith/catch-no-instance-exception
...
broaden exception handling on webcal refresh
2020-10-04 11:14:00 +02:00
Iscle
0e5d692866
DirectController: Verify that expirationTime is between 0s and 24h
...
Signed-off-by: Iscle <albertiscle9@gmail.com>
2020-10-01 23:48:41 +02:00
eleith
aa956ab46e
broaden exception handling on webcal refresh
...
when iterating through a calendar, recurrance events can throw an
exception if no instances of the recurrance are found.
this exception is of class `Exception` but the try/catch clause in the
webcal refresh loop only catches `BadRequest` exception.
this leads to the exception bubbling up and thus other calendar events
do not get processed by the event iterator.
this PR broadens the exception to handle both BadRequest and
NoInstanceFoundException so that the full webcal can be processed, even
if minor hiccups are processing on vobject
Signed-off-by: leith abdulla <online-nextcloud@eleith.com>
2020-09-29 20:47:38 -07:00
Roeland Jago Douma
4175c3f499
Merge pull request #22983 from nextcloud/bugfix/noid/sync-all-users-to-systemaddressbook
...
Sync all users to the system addresssbook
2020-09-29 09:12:40 +02:00
Nextcloud bot
8383b63b34
[tx-robot] updated from transifex
2020-09-29 02:17:55 +00:00
Joas Schilling
deddcbd817
Merge pull request #23034 from nextcloud/bugfix/noid/numeric-folders-thorw-on-mark-dirty
...
Fix numeric folders throwing on markDirty
2020-09-25 14:52:46 +02:00
Joas Schilling
6db5f53bc6
Fix numeric folders throwing on markDirty
...
TypeError: strpos() expects parameter 1 to be string, int given
The problem is that in cacheNode() we strip of any slashes, so
a folder "0/" will be trimmed to "0" and be used as an array key.
Since PHP automatically casts numeric array keys to integers,
you afterwards get $nodePath as int(0). Since it's now a number,
the strpos() function does not accept it anymore. Simply casting
$nodePath to a string again in the foreach solves the issue
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-24 15:02:30 +02:00
Roeland Jago Douma
fe30bfd232
Update autloader
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-24 14:59:41 +02:00
Joas Schilling
cea7252874
Fix array to string conversion on event search
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-24 13:52:24 +02:00
Nextcloud bot
260d0dff3b
[tx-robot] updated from transifex
2020-09-24 02:17:48 +00:00
Iscle
ebd734dc86
DirectController: Let users choose the expiration time
...
Signed-off-by: Iscle <albertiscle9@gmail.com>
2020-09-24 01:27:33 +02:00
Joas Schilling
8b77aa6b4f
Sync all users to the system addresssbook
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-21 09:01:39 +02:00
Nextcloud bot
bdc60ef9b2
[tx-robot] updated from transifex
2020-09-20 02:17:05 +00:00
Joas Schilling
48761481eb
Bump versions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-18 09:16:45 +02:00
Nextcloud bot
f3ec3bfa4a
[tx-robot] updated from transifex
2020-09-18 02:16:56 +00:00
J0WI
1639289b95
Update urls to stackoverflow.com to "HTTPS"
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-09-17 17:38:27 +02:00
Morris Jobke
99c9423766
Remove @suppress SqlInjectionChecker
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 15:53:56 +02:00
Morris Jobke
04a3580d19
Remove phan config - was replaced by Psalm
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 14:46:29 +02:00
Nextcloud bot
869f3f5895
[tx-robot] updated from transifex
2020-09-15 10:48:26 +00:00
Morris Jobke
c1ff011990
Merge pull request #22799 from nextcloud/bugfix/noid/dont-log-microsoft-webdav-client-trying-to-tag
...
Don't log Microsoft WebDAV client trying to tag things
2020-09-14 14:43:54 +02:00
Joas Schilling
2dbd6424f7
Don't log Microsoft WebDAV client trying to tag things
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-11 11:52:05 +02:00