Commit Graph

17853 Commits

Author SHA1 Message Date
Julius Härtl 2e60f91ab1
Move external share saving to template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 13:11:55 +02:00
Arthur Schiwon f1565336bd
DI for NC's user manager
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:46:24 +02:00
Arthur Schiwon 373a1d5391
more consistent naming
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:46:15 +02:00
Arthur Schiwon 2ebf26e444
admin_audit and dav listen to announce and revoke signals
also place them in doc

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:38:43 +02:00
Arthur Schiwon 8fe914f07e
LDAP backend to emit announce and revoke signals on mapping changes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-04-05 12:38:39 +02:00
Julius Härtl bbeb3402b6
Move styling and menu handling to publicpage.js
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 12:21:39 +02:00
Julius Härtl cc3b1179fc
Do not hide primary action text
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 11:32:11 +02:00
Daniel Calviño Sánchez bcfe8431b4 Fix progress bar hidden before the upload ends
The jQuery File Upload plugin triggers the "stop" event once there are
no more files being uploaded (even if some of them were added when
another upload was already in progress). Therefore, the progress bar
should be hidden in the "fileuploadstop" callback.

In some cases the "stop" event is not triggered and thus the progress
bar is not hidden once no more files are being uploaded. This is caused
by a race condition and it will be fixed in another commit; except in
buggy cases like that one (that need to be fixed anyway) it is safe to
hide the progress bar in the "fileuploadstop" callback.

In any case, note that the callbacks in "fileuploaddone" may be called
after the "stop" event was triggered and handled when using chunked
uploads. In that case once all the chunks are uploaded the assembled
file is moved to its final destination, so its promise could be resolved
after the "stop" event was triggered. Therefore a different approach
would be needed to keep the progress bar visible until the chunked
upload is truly finished, but for the time being the current one is good
enough.

Before this commit the progress bar was being hidden when the first
upload finished, either successfully or with an error, no matter if
there were other files being uploaded too.

The progress bar was being explicitly hidden also when the upload was
cancelled. When an upload is cancelled all the single uploads are
aborted, which triggers a "fail" event for each of them. However, the
"stop" event is always triggered when no more files are being uploaded,
so it is triggered too once all the single uploads were aborted. As all
the single uploads are immediately aborted in a loop when the general
upload is cancelled it makes no difference to hide the progress bar when
the first single upload is aborted or when all the single uploads were
aborted, so the progress bar is no longer explicitly hidden in the
former case.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-04-05 11:12:33 +02:00
Julius Härtl eb19899f8e
Move common menu templates to public API
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-04-05 11:09:19 +02:00
Nextcloud bot 0c12c06325
[tx-robot] updated from transifex 2018-04-05 00:11:47 +00:00
blizzz 3678d3b14a
Merge pull request #8926 from nextcloud/ocs-api-quota-fallback
Return quota even if user is not initialised
2018-04-04 17:19:54 +02:00
Roeland Jago Douma d6cda3f2a6
When formatting a share node an Empty target is invalid
Fixes #9028

For federated shares the share table holds no target information (since
it is on the other server). So when a node is actually invalid and not
found we should not display it anymore in the shared with sections etc
and thus throw the proper exceptions.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-04-04 11:33:05 +02:00
Nextcloud bot b90b73df6f
[tx-robot] updated from transifex 2018-04-04 00:13:26 +00:00
Morris Jobke bd8352d4c4
Merge pull request #8996 from brandonkirsch/fix-onenote-dav
Fix webdav support for OneNote clients
2018-04-03 13:27:29 +02:00
Morris Jobke f0fcf88a4f
Merge pull request #9006 from nextcloud/bugfix/8977/ignore_encrypted_custom_properties
Do not treat is-encrypted as custom property
2018-04-03 11:44:58 +02:00
Morris Jobke 56fa44b71d
Merge pull request #8945 from nextcloud/fix-files-copy-in-recent-favorites
Fixed files copy/move when in favorites or recent section
2018-04-03 10:30:08 +02:00
Morris Jobke 6dca0bbd79
Merge pull request #9014 from nextcloud/smb-2.0.5
update icewind/smb to 2.0.5
2018-04-03 10:21:26 +02:00
Nextcloud bot 5105f1d466
[tx-robot] updated from transifex 2018-04-03 00:11:47 +00:00
Nextcloud bot 25c479c0c5
[tx-robot] updated from transifex 2018-04-02 00:11:49 +00:00
Nextcloud bot 21b7611457
[tx-robot] updated from transifex 2018-04-01 00:11:48 +00:00
Nextcloud bot 0f398e7611
[tx-robot] updated from transifex 2018-03-31 00:13:51 +00:00
Nextcloud bot 660ae73e5f
[tx-robot] updated from transifex 2018-03-30 00:11:34 +00:00
Nextcloud bot 65908bacd2
[tx-robot] updated from transifex 2018-03-29 00:13:35 +00:00
Robin Appelman d91d84b485
update icewind/smb to 2.0.5
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-28 16:09:27 +02:00
Roeland Jago Douma e8b7e9e75d
Do not treat is-encrypted as customer property
fixes #8977

Else for all files in a folder we would launch off more queries.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-28 08:34:50 +02:00
Roeland Jago Douma b2e34167eb
Merge pull request #8976 from nextcloud/dep_user_code
Remove deprecated functions from OCP\User
2018-03-28 08:23:57 +02:00
Nextcloud bot 9dad5ac59b
[tx-robot] updated from transifex 2018-03-28 00:21:16 +00:00
Roeland Jago Douma 06f52ead31
Merge pull request #8993 from nextcloud/theming-allow-ui-with-theme
Show UI when using a custom theme
2018-03-27 19:27:49 +02:00
Nextcloud bot 7b4e51dbc7
[tx-robot] updated from transifex 2018-03-27 00:11:40 +00:00
Roeland Jago Douma 5bfad25e83
Merge pull request #8968 from nextcloud/filter_method_not_allowed
MethodNotAllowed is not a Fatal error
2018-03-26 22:41:49 +02:00
Abijeet 16bf9326cb Fixing failing test cases due to change in functionality.
Also fixes scrutinizer warnings.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 01:34:00 +05:30
Roeland Jago Douma fa09e0e670
Merge pull request #8983 from nextcloud/fix-8888
Clear any theming prefixed cache on cache buster increase
2018-03-26 21:46:46 +02:00
Roeland Jago Douma 36dbd7ec8f
Merge pull request #8985 from nextcloud/cleanup_ocp_db
Cleanup ocp db
2018-03-26 21:45:25 +02:00
Brandon Kirsch c5005bbab5 Fix webdav support for OneNote clients 2018-03-26 15:32:12 -04:00
Abijeet 18096f55d0 Disabled comment changes opacity only for message text.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet 01c5a31a4a Adds a tooltip for the submit / save button in comments.
Towards #7281

Also hiding the menu before triggering click action.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet 6d2716dceb Added ellipsis for longer usernames.
Towards #7281

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet 872853af58 Moves the edit and delete options into a dropdown menu.
Fixes #7281

- Added a new View to render the dropdown.
- Modified the existing code.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet 001cd986ed Converts the css file to scss file, and adds border-top to comments.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet 61b38a16fa Fixes the following UI issues,
1. Increased the size of the delete, edit, close and submit buttons to take up 44x44px.
2. Now showing the delete button at all times when editing to avoid usability issues with touch screens.
3. Edit icon is also shown at all times, rather than only on hover.
4. Reduced the gap between comments a wee bit.
5. Fixed issues with focus event now working properly for edit and delete.
6. Removed absolute positioning of elements for alignment.
7. Fixed issue with tooltips becoming too high due to padding around actions. Occurred due to my changes.
8. Changed the position of the submit and close icons.
9. Fixed issue with jumping of the delete icon in Firefox. Occurred due to my changes.
10. Fixed issue with wrapping of content due to long author names. Occurred due to my changes.
11. Fixed issue with longer comments not appearing properly. This might have occurred due to my changes.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet b3e1026cab Fixes div being added placed directly under ul during editing of comments.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Abijeet facd1cae2f Fixes issue where saving a non-modified comment kept the edit window open.
Now irrespective of the whether the comment has been modified we are going to go back to the view mode.

Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 00:49:34 +05:30
Julius Härtl b6501ae966
Show UI when using a custom theme
Do not hide the theming app UI when using a custom theme besides it, but warn the users about some settings being overwritten by that.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-26 18:23:51 +02:00
Roeland Jago Douma f4fd0224db
Do not use \OCP\DB anymore
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 14:40:23 +02:00
Julius Härtl af4acdc6d6
Fix tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-26 14:29:28 +02:00
Julius Härtl e7c3b8da77
Clear any theming prefixed cache on cache buster increase
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-03-26 12:34:26 +02:00
Roeland Jago Douma e6a2c13ac1
MethodNotAllowed is not a Fatal error
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 12:15:31 +02:00
Roeland Jago Douma b52c935c09
Make 2FA backupcodes strict
* and follow the interface again

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 11:31:02 +02:00
Roeland Jago Douma 74f0e37233
Remove deprecated \OCP\User::userExists
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-26 11:16:23 +02:00
Nextcloud bot e2b44d199b
[tx-robot] updated from transifex 2018-03-26 00:13:15 +00:00
Roeland Jago Douma 7ebd96416c
Remove deprecated OCP\User::getDisplayname
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-25 20:42:03 +02:00
Roeland Jago Douma 6c8caa1641
Remove deprecated \OCP\User::getUsers
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-25 20:33:24 +02:00
Nextcloud bot 89ebb8a663
[tx-robot] updated from transifex 2018-03-25 01:09:58 +00:00
Nextcloud bot 3b6a45b926
[tx-robot] updated from transifex 2018-03-24 01:12:19 +00:00
Roeland Jago Douma e2866091bc
Merge pull request #8943 from nextcloud/dep_oc_json
Remove \OCP\JSON
2018-03-23 15:20:38 +01:00
Joas Schilling 3d8fcad88b
Merge pull request #8865 from nextcloud/ocs-groups-displayname
Return groups displayname in provisioning api
2018-03-23 14:44:13 +01:00
John Molakvoæ (skjnldsv) 5f38cfbc80
Return groups displayname in provisioning api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-23 12:06:50 +01:00
Roeland Jago Douma 26073eac0c
Finally remove \OCP\JSON
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-23 08:50:17 +01:00
Morris Jobke 6a31203793
Merge pull request #8856 from nextcloud/ocs-api-new-user-password-email
Allow admin to create users without password by sending mail automatic…
2018-03-23 08:17:41 +01:00
Nextcloud bot 64948bf30c
[tx-robot] updated from transifex 2018-03-23 01:11:28 +00:00
John Molakvoæ (skjnldsv) 24ecf3f4c9
Fixed files copy/move when in favorites or recent section
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-22 18:09:30 +01:00
Roeland Jago Douma c306bc29d1
Make displayname selectable
It is dav. so if it is not properly set we just return a 404 anyway.
2018-03-22 16:46:21 +01:00
John Molakvoæ (skjnldsv) 41b690ed53
Allow admin to create users withoutpassword by sending mail automatically
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-22 15:06:04 +01:00
Roeland Jago Douma 3dac15a891
Move calls to \OCP\JSON to private \OC_JSON
They should be properly fixed at some point.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-22 13:19:29 +01:00
Morris Jobke 91b9c0d2c4
Merge pull request #8909 from nextcloud/feature/noid/make-the-autocomplete-endpoint-ocs
Make the new autocomplete endpoint OCS
2018-03-22 11:53:23 +01:00
John Molakvoæ (skjnldsv) 63fa245461
Fix quota return if unlimited
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-22 10:14:15 +01:00
John Molakvoæ (skjnldsv) 6e7b7749bd
Return quota even if user is not initialized
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-22 10:14:15 +01:00
Nextcloud bot c1b36e165e
[tx-robot] updated from transifex 2018-03-22 01:11:40 +00:00
Morris Jobke de3297848e
Merge pull request #8918 from nextcloud/remove-deprecated-ocp-response
Remove deprecated and unused OCP\Response
2018-03-21 16:54:19 +01:00
Morris Jobke d435061f8e
Remove deprecated and unused OCP\Response
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-03-21 16:53:56 +01:00
Morris Jobke 6f455d5c41
Merge pull request #7196 from nextcloud/sharing-confirm-button
Add confirmation button to share input
2018-03-21 15:08:39 +01:00
Joas Schilling dabd7291c3
Make the new autocomplete endpoint OCS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-21 09:46:52 +01:00
Nextcloud bot af3ab1de10
[tx-robot] updated from transifex 2018-03-21 01:11:55 +00:00
Morris Jobke 18994cd700
Merge pull request #8821 from nextcloud/feature/noid/show-eol-warning
Show EOL warning in the update section
2018-03-20 22:39:00 +01:00
Jan-Christoph Borchardt ce7775acd0 Replace information icon with confirmation button in share input
The confirmation button right now is just an icon; its behaviour will be
added in the following commits.

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-03-20 19:09:03 +01:00
Morris Jobke 29c551c88f
Merge pull request #8847 from nextcloud/ocs-api-userdetails
Add userdetails to ocs api
2018-03-20 18:12:25 +01:00
Joas Schilling ec1e039790
Show EOL warning in the update section
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-03-20 15:52:30 +01:00
Joas Schilling 64feb3f391
Merge pull request #8861 from nextcloud/rakekniven-patch-1
Update ThemingController.php
2018-03-20 13:45:20 +01:00
Roeland Jago Douma 99abe3bc8e
Merge pull request #8864 from nextcloud/ocs-allow-empty-email-displayname
Allow empty emails provisioning api
2018-03-20 09:44:38 +01:00
Nextcloud bot 615258ba26
[tx-robot] updated from transifex 2018-03-20 01:11:33 +00:00
John Molakvoæ (skjnldsv) 24659342f5
fixup! Check if groups is array, return empty do not throw
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-19 15:12:32 +01:00
rakekniven 789221a0fc
Update ThemingControllerTest.php
Adjusted test
2018-03-19 15:07:49 +01:00
rakekniven d88db9b496
Update ThemingController.php
Changed file according to discussion on PR.
2018-03-19 15:00:27 +01:00
Roeland Jago Douma 734cddfa97
Merge pull request #8880 from nextcloud/delete_unused_download
Remove unused download.php
2018-03-19 14:18:51 +01:00
Roeland Jago Douma 9834f33d56
Merge pull request #8878 from nextcloud/remove_tmpfile
Remove deprecated tmpFile/tmpFolder
2018-03-19 12:29:08 +01:00
Roeland Jago Douma 1d6a2a7019
Remove unused download.php
There were two routes apps/files/ajax/download.php but apparently also
apps/files/download.php I could not find any use of it.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 11:45:48 +01:00
Roeland Jago Douma 17bfa1c74e
Merge pull request #8815 from nextcloud/channel-description
Provide a description of the update channels inline
2018-03-19 11:25:15 +01:00
Roeland Jago Douma 47a3008141
Remove \OCP\Files::tmpFile
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-03-19 10:52:35 +01:00
Morris Jobke 63bc633d89
Merge pull request #8857 from nextcloud/swift-verify-cached-token
verify cached swift token
2018-03-19 10:10:04 +01:00
John Molakvoæ (skjnldsv) ccd57ce1b1
Allow empty emails provisionning api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-17 12:18:22 +01:00
Nextcloud bot 3cac7911d5
[tx-robot] updated from transifex 2018-03-17 01:11:30 +00:00
rakekniven b2ceb29484
Update ThemingController.php
Changed wording according to discussion at Transifex. See https://www.transifex.com/nextcloud/nextcloud/translate/#de/$/121491259?issue=yes
Aligned ending of error messages
2018-03-16 18:45:20 +01:00
blizzz e56759917b
Merge pull request #8843 from nextcloud/set-share-with-field-to-the-id-of-the-circle
Set "share with" field to the ID of the circle
2018-03-16 16:42:31 +01:00
John Molakvoæ (skjnldsv) 2493e9426d
Check if groups is array, return empty do not throw
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-16 15:32:36 +01:00
Robin Appelman 41954d2903
verify cached swift token
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-03-16 15:20:16 +01:00
John Molakvoæ (skjnldsv) f5137fef6c
Fixed tests and improved code
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-16 11:44:20 +01:00
John Molakvoæ (skjnldsv) aa1e8713fb
Fixed throw error on unreachable users
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-16 09:38:09 +01:00
Morris Jobke f83aa58d1f
Merge pull request #8835 from nextcloud/fix/noid/ldap_existence_check
group existence check works without attribute (like with users)
2018-03-16 09:31:49 +01:00
John Molakvoæ (skjnldsv) ce625bbad5
Add userdetails to ocs api
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-03-16 09:19:47 +01:00
Daniel Calviño Sánchez 2c073dc53d Set "share_with" field to the ID of the circle
When a share is shared with a circle the "share_with" field returned by
the API endpoint was always set to the name of the circle. However, the
name is not enough to identify a circle. The Circles app now provides
the ID of the circle in the "shared with" field of a Share, so this
commit modifies the API endpoint to set the "share_with" field to the ID
of the circle when provided by the Circles app.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-03-16 04:58:00 +01:00