Commit Graph

5040 Commits

Author SHA1 Message Date
Roeland Jago Douma 096498c033 Fix the thorrtler whitelist bitmask
Before we actually didn't check each bit of the bitmask. Now we do.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-12 07:56:07 +00:00
Roeland Jago Douma 355b0defe4
Clean pending 2FA authentication on password reset
When a password is reste we should make sure that all users are properly
logged in. Pending states should be cleared. For example a session where
the 2FA code is not entered yet should be cleared.

The token is now removed so the session will be killed the next time
this is checked (within 5 minutes).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-30 10:41:09 +01:00
Robin Appelman ff5f28a65e always use multipart uploader for s3 uploads
the multipart uploader handles non seekable streams while `upload` does not

Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-29 10:17:07 +00:00
Daniel Calviño Sánchez d4e1e9709f Add acceptance tests for moving and copying selections to another folder
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-23 21:05:54 +01:00
Daniel Calviño Sánchez f8473f4427 Add acceptance tests for moving and copying files to another folder
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-23 21:05:54 +01:00
Morris Jobke e086a5e7f9
Merge pull request #13758 from nextcloud/backport/13747/stable15
[stable15] Honor remember_login_cookie_lifetime
2019-01-23 15:31:05 +01:00
Morris Jobke 09db2bc701
Merge pull request #13740 from nextcloud/backport/13140/stable15
[stable15] Cache tokens when using swift's v2 authentication
2019-01-23 15:29:56 +01:00
Roeland Jago Douma 4d3bb0a521 Honor remember_login_cookie_lifetime
If the remember_login_cookie_lifetime is set to 0 this means we do not
want to use remember me at all. In that case we should also not creatae
a remember me cookie and should create a proper temp token.

Further this specifies that is not 0 the remember me time should always
be larger than the session timeout. Because else the behavior is not
really defined.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-23 09:23:41 +00:00
Robin Appelman f7a4f1f128 cleanup shared lock if changing to exclusive lock failed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-22 15:12:46 +00:00
Robin Appelman 6855c1594c Cache tokens when using swift's v2 authentication
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-22 14:37:09 +00:00
Roeland Jago Douma 16966ee5aa Fix template paramter
Else we get shown an error page instead of the correct 403.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-18 18:43:45 +00:00
Roeland Jago Douma 412d6a4a24
Merge pull request #13036 from nextcloud/objectstore-write-exists-15
[15] upload new files in objectstore to a .part path first
2019-01-14 11:29:18 +01:00
Roeland Jago Douma de30c11cf3 CSP: Allow fonts to be provided in data
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-07 14:40:23 +00:00
Bjoern Schiessle d715a28cf2 fix can change password check in case of encryption is enabled
Admin should _not_ be able to change password when:
- if an encryption module is loaded and it uses per-user keys
- if encryption is enabled but no encryption modules are loaded

Admin should be able to change the password when:
- no encryption module is loaded and encryption is disabled
- encryption module is loaded but it doesn't require per user keys

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2019-01-04 08:54:41 +00:00
Daniel Calviño Sánchez 43ddf715d0
Add acceptance tests for opening search results for comments
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-03 11:39:16 +01:00
Daniel Calviño Sánchez d845f2b1e3
Add acceptance tests for searching comments
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-03 11:39:13 +01:00
Roeland Jago Douma 7b09d11924 Use a case insensitive search for email
Fixes #7084
Now entering wrongly cased email (roeland@ instead of Roeland@) for
password reset etc. Will also work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-20 15:19:15 +00:00
Roeland Jago Douma 9f6ee5b939 Only trust the X-FORWARDED-HOST header for trusted proxies
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-12-19 08:48:18 +00:00
Robin Appelman 2d2de36baf
upload new files in objectstore to a .part path first
This prevent the object store and cache from getting out of sync
when an objectstore silently fails or the php process get's killed
during the upload without giving us the chance to cleanup

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-12-12 15:31:47 +01:00
Robin Appelman fe23285e44
Add objectExists to objectstore interface
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-12-12 15:31:44 +01:00
Daniel Calviño Sánchez 9f0272ffd9 Add acceptance tests for comments on shared files and folders
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-12-07 14:08:09 +00:00
John Molakvoæ (skjnldsv) 7028362604 Log and continue on Dav reader failure
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-12-05 21:54:50 +00:00
Morris Jobke 9838c91a5c Add setup check for pending bigint conversion
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-05 17:53:42 +00:00
Morris Jobke f4b582ec44 Update casing of PHP inside method name
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-04 23:34:39 +00:00
Morris Jobke ec9d58b21d Add setup check for recommended PHP modules (i.e. Imagick, intl)
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-12-04 23:34:39 +00:00
Morris Jobke 96450a9e9b
Merge pull request #12692 from nextcloud/storage-no-encryption-interface-15
[15] Add interface to allow storages from opting out of encryption
2018-11-29 22:01:14 +01:00
Roeland Jago Douma c602d1b751
Merge pull request #12736 from nextcloud/backport/12424/stable15
[stable15] Add pipe mode for sendmail
2018-11-29 19:36:30 +01:00
Daniel Kesselberg cbff5fabe7 Add testcases for pipe mode
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-11-29 16:44:36 +00:00
Robin Appelman 7cdc04a793
update encryption wrapper tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-11-29 16:36:35 +01:00
John Molakvoæ (skjnldsv) 6c14b57337 Fix tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-29 10:17:01 +00:00
Robin Appelman 9ee94afe7e Fix folder path containing leading slash when getting mount root by id
This fixes collabora on public link shared groupfolders

Fixes https://github.com/nextcloud/groupfolders/issues/225

Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-11-28 19:07:11 +00:00
Daniel Calviño Sánchez c6ca6b03eb Rename "FilesSharingAppContext" to "PublicShareContext"
Having both "FilesAppSharingContext" and "FilesSharingAppContext" was
confusing, so "FilesSharingAppContext" was renamed to a more descriptive
name.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 21:08:59 +00:00
Daniel Calviño Sánchez 9354de01bb Extract locators and steps for sharing in Files app to their own context
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 21:08:58 +00:00
Daniel Calviño Sánchez 65192469c8 Extract sharing related acceptance tests to their own feature files
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 21:08:58 +00:00
Daniel Calviño Sánchez 39e5493072 Add acceptance tests for folders that can not be reshared
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 21:08:58 +00:00
Daniel Calviño Sánchez 41fff0932c Add acceptance tests for resharing a folder with another user
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 21:08:58 +00:00
Daniel Calviño Sánchez e435574613 Add acceptance test for checking that the owner can see reshares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 21:08:58 +00:00
Daniel Calviño Sánchez 976fa8487f Add acceptance test for resharing a file with another user
To reshare a file there must be at least three enabled users in the
system; although it would be possible to run the steps to create a third
user in the scenarios that need it for convenience a third enabled user
besides "admin" and "user0" was added to the default setup.

In a similar way, a new step was added too to login as a given user
name, similar to the steps to log in as "user0" and as "admin".

Finally, another actor, "Jim", was introduced for those scenarios which
should be played by three standard actors (that is, without a special
configuration like "Rubeus").

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 21:08:58 +00:00
Daniel Calviño Sánchez aa19e89645 Add acceptance tests for sharing a folder with another user
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 21:08:58 +00:00
Daniel Calviño Sánchez 6ca82176a4 Add acceptance tests for sharing a file with another user
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 21:08:58 +00:00
Daniel Calviño Sánchez ad0adaea95 Wait for the comment to be added before changing to another file
If the server is too slow, changing to a different file immediately
after sending a new comment but without waiting for the comment to be
shown for the original file could cause the new comment to be shown for
the current file instead.

This is, indeed, a bug in the comments. However, it is not possible to
test it reliably in the acceptance tests, as it depends on how fast the
server adds the message and how fast the client changes to a different
file; sometimes the test would fail and sometimes it would not.

Therefore, now it is waited for the comment to be added before changing
to another file, as in this case it can be reliably tested that changing
to a different file does not cause the comments from the previous file
to be shown in the current file (this was a different bug already fixed
and due to which this test was added in the first place).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 16:55:32 +00:00
Daniel Calviño Sánchez 4c88b12a28 Wait for the empty content element to be shown
When the "Comments" tab is open the empty content element is always in
the DOM, although it is only shown once the message collection was
fetched and there were no messages. Due to this it is necessary to
explicitly wait for it to be shown instead of relying on the implicit
wait made to find the element; otherwise it would be found immediately
and if the collection was not fetched yet it would not be visible,
causing the test to fail.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-27 16:55:32 +00:00
Morris Jobke db6fad3eee
Merge pull request #12571 from TheLastProject/feature/make_connectivity_check_domains_changeable
Make connectivity check domains configurable
2018-11-22 13:42:54 +01:00
Sylvia van Os 935bb25639 Make connectivity check domains configurable
Signed-off-by: Sylvia van Os <sylvia@hackerchick.me>
2018-11-22 10:57:16 +01:00
Morris Jobke ede53e06c1
Merge pull request #12553 from nextcloud/bugfix/noid/allow-empty-string-in-getAbsoluteURL
Allow empty string in get absolute url
2018-11-22 10:26:23 +01:00
Daniel Calviño Sánchez 1d1708688f Add acceptance tests for showing again the input field for tags
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 05:26:45 +01:00
Daniel Calviño Sánchez 57ffa9ea73 Add acceptance tests for opening and closing again the details view
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 05:26:01 +01:00
Daniel Calviño Sánchez 94645ed754 Add acceptance tests for marking a file as favorite in the details view
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 05:25:12 +01:00
Daniel Calviño Sánchez 139e2218d1 Add acceptance tests for switching to the comments of another file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 05:20:26 +01:00
Joas Schilling b8fcf6e9b3
Allow empty strings in getAbsoluteURL
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-20 13:36:16 +01:00