Commit Graph

22743 Commits

Author SHA1 Message Date
Bernhard Posselt ff5715779c Merge pull request #13539 from owncloud/unit-tests-must-have
Unit tests are a must have for any changed code
2015-01-21 11:31:11 +01:00
Vincent Petry f3d696599a Add unit test for external share JS dialog
Moved external share JS code into a small plugin to make it testable.

Added unit test for the external share dialog logic + ajax calls.
2015-01-21 11:26:54 +01:00
Vincent Petry 23ea45760f External share dialog must properly read entered password 2015-01-21 11:26:36 +01:00
Thomas Müller b533aad216 Unit tests are a must have for any changed code 2015-01-21 11:15:32 +01:00
Jenkins for ownCloud b8ab21d3ad [tx-robot] updated from transifex 2015-01-21 01:55:15 -05:00
Sugaroverdose 2244e0eba7 do not clear fields until request return success 2015-01-20 23:14:41 +03:00
Lukas Reschke 2ed2a7c7a8 Merge pull request #13520 from owncloud/fix-comparison-op
this must be larger then (>), since buggy behaviour occurs when the para...
2015-01-20 20:15:04 +01:00
Morris Jobke 9a17006b93 Merge pull request #13506 from owncloud/fix-scanner-s2s-trashbin
avoid $this->cache being null
2015-01-20 20:14:49 +01:00
Arthur Schiwon 9cb1ef5675 this must be larger then (>), since buggy behaviour occurs when the parameter is a small number 2015-01-20 17:50:53 +01:00
Robin Appelman 750cff0e3e Bypass the view when storing encryption keys 2015-01-20 16:20:49 +01:00
Thomas Müller 84bb4cc2e9 Merge pull request #13499 from owncloud/issue/13451-redis-json-encode
Issue/13451 redis json encode
2015-01-20 14:53:33 +01:00
Lukas Reschke 02848a5021 Merge pull request #13512 from owncloud/kill-ancient-code
kill ancient code
2015-01-20 14:16:33 +01:00
Morris Jobke ce47065d8f kill ancient code 2015-01-20 14:14:01 +01:00
Morris Jobke a87a2e8e2c Merge pull request #13494 from owncloud/windows_warning
add a Windows warning
2015-01-20 14:12:30 +01:00
Lukas Reschke fedc7c6f34 Merge pull request #13497 from owncloud/fix-basic-auth-for-session
Fix WebDAV auth for session authentication only
2015-01-20 13:38:36 +01:00
Frank Karlitschek 828d7d6cf5 add a Windows warning 2015-01-20 13:37:50 +01:00
Thomas Müller 87a754c72e avoid $this->cache being null - fixes #13491 2015-01-20 12:38:54 +01:00
Lukas Reschke e25a0303f4 Streamline CSRF and login check
Let's make this consistent with other pieces of the code to make it easier to auditable.
2015-01-20 12:24:13 +01:00
Joas Schilling e25998df0f Json_(en|de)code values on redis to be able to cache arrays 2015-01-20 10:51:27 +01:00
Joas Schilling 7eb8404040 Add a test case for memcaches to store an array 2015-01-20 10:51:04 +01:00
Joas Schilling 2fe6513557 Merge pull request #13454 from owncloud/improve-empty-displayname
also show message for empty display name if change of it isn't allowed
2015-01-20 10:27:50 +01:00
Lukas Reschke 476579b9c6 Fix WebDAV auth for session authentication only
\Sabre\DAV\Auth\Backend\AbstractBasic::authenticate was only calling \OC_Connector_Sabre_Auth::validateUserPass when the response of \Sabre\HTTP\BasicAuth::getUserPass was not null.

However, there is a case where the value can be null and the user could be authenticated anyways: The authentication via ownCloud web-interface and then accessing WebDAV resources. This was not possible anymore with this patch because it never reached the code path in this scenario.

This patchs allows authenticating with a session without isDavAuthenticated value stored (this is for ugly WebDAV clients that send the cookie in any case) and thus the functionality should work again.

To test this go to the admin settings and test if the WebDAV check works fine. Furthermore all the usual stuff (WebDAV / Shibboleth / etc...) needs testing as well.
2015-01-20 10:03:14 +01:00
Jenkins for ownCloud 2ac015256f [tx-robot] updated from transifex 2015-01-20 01:54:37 -05:00
Morris Jobke 870bc429b2 Merge pull request #13416 from owncloud/reauthenticate-if-session-differs-from-basic-auth
Prioritise Basic Auth header over Cookie
2015-01-19 22:23:02 +01:00
Lukas Reschke cbffaff7a0 Merge pull request #13480 from owncloud/mysql-autocommit
set MySQL autocommit on connection setup
2015-01-19 19:39:26 +01:00
Lukas Reschke 6c1e13a6ed Merge pull request #13478 from owncloud/tags-chunkedquery
Fix chunked query for tags + unit test
2015-01-19 18:15:13 +01:00
Ross Nicoll 1c2cbf6fc6 Align checkbox configuration in external files
Modified CSS for files_external application to render labels around checkboxes at the same
width as other input elements, aligning them with other elements on the same page.
2015-01-19 17:01:25 +00:00
Lukas Reschke fcf4e2a44c Merge pull request #13471 from owncloud/fix-blog-typo
fix typo of blog -> changed to block
2015-01-19 17:54:32 +01:00
Thomas Müller baefefbbc8 set MySQL autocommit on connection setup 2015-01-19 17:20:49 +01:00
Vincent Petry ef8d38ca27 Fix chunked query for tags + unit test 2015-01-19 17:05:44 +01:00
Thomas Müller 4894a2c458 Merge pull request #13466 from owncloud/Undefined-index-mimetype-cache
check if mimetype is set - fixes #13452
2015-01-19 16:35:07 +01:00
Lukas Reschke 730460c9fa Close session properly 2015-01-19 16:25:44 +01:00
Georg Ehrke 374ddbff55 show animated gifs on public sharing page 2015-01-19 16:20:06 +01:00
Morris Jobke 2229290cca fix typo of blog -> changed to block
* fixes #13460
2015-01-19 15:57:53 +01:00
Morris Jobke 956e17d008 also show message for empty display name if change of it isn't allowed 2015-01-19 15:45:03 +01:00
Thomas Müller c9db9523b1 Merge pull request #13419 from owncloud/drop-animation-user-list
Drop the hide and show of new users in user list
2015-01-19 15:08:57 +01:00
Thomas Müller 65041440de check is mimetype is set - fixed #13452 2015-01-19 15:04:53 +01:00
Thomas Müller 1810ea2d33 Merge pull request #13461 from owncloud/remove-strip-slashes
Remove stripslashes() from newfolder.php
2015-01-19 14:47:34 +01:00
Lukas Reschke 003fc183a2 Remove stripslashes() from newfolder.php 2015-01-19 14:12:36 +01:00
Morris Jobke cd4c7fd11f Merge pull request #13377 from owncloud/trashbin_storage_wrapper
[trashbin] replace hook with storage wrapper
2015-01-19 13:17:52 +01:00
Thomas Müller d2d6472e39 Merge pull request #13423 from owncloud/share-fixfindshareforuserwithmultiplegroups
Fix getItemSharedWithUser for groups
2015-01-19 12:34:28 +01:00
Thomas Müller d75af7ddd2 Merge pull request #13362 from owncloud/fix-11442
LDAP Wizared: update user or group count only, when the multiselect is closed
2015-01-19 12:22:24 +01:00
Thomas Müller fa9834372d Merge pull request #13443 from owncloud/fix-filtering-for-users
Fix filtering for users when $gid is empty
2015-01-19 11:39:27 +01:00
Bjoern Schiessle 15ae6b47ed replace hook with storage wrapper 2015-01-19 09:16:15 +01:00
Thomas Müller 4fcfedb03c Merge pull request #13438 from owncloud/cache-the-array
Reuse the array key of mimetypes
2015-01-19 08:40:25 +01:00
Joas Schilling 5b3ff7867f Merge pull request #13447 from owncloud/fix_typo
fix typo - caused by 3d997e8c62
2015-01-19 08:30:43 +01:00
Jenkins for ownCloud 3404bd8cdd [tx-robot] updated from transifex 2015-01-19 01:54:31 -05:00
Georg Ehrke 9cef90da98 Merge pull request #13448 from owncloud/fix-exif-orientation
Fix exif orientation for flipped images
2015-01-19 00:12:55 +01:00
Morris Jobke a28d3b594b Fix exif orientation for flipped images
fixes #13363

Links:
 * http://www.daveperrett.com/articles/2012/07/28/exif-orientation-handling-is-a-ghetto/
 * Example data: https://github.com/recurser/exif-orientation-examples
2015-01-18 23:15:52 +01:00
Morris Jobke 7b9343f385 fix typo - caused by 3d997e8c62 2015-01-18 22:08:11 +01:00