a4d2c7810e
Merge pull request #14975 from owncloud/add-smtp-debug-mode
...
Add debug mode back to mailer
2015-03-17 23:49:19 +01:00
f13216d275
Use `FILTER_UNSAFE_RAW` instead of `FILTER_SANITIZE_STRING`
...
`FILTER_SANITIZE_STRING` will still encode everything else.
2015-03-17 21:56:16 +01:00
087117d87d
Merge pull request #14961 from owncloud/onlyrequireinfo
...
Only hard depend on the info.xml and not the app.php
2015-03-17 21:27:51 +01:00
760f5fc5e5
Merge pull request #14954 from owncloud/cache-image-path
...
Cache \OC\URLGenerator::imagePath
2015-03-17 19:36:23 +00:00
aea4b3166b
Add debug mode back to mailer
...
This re-adds the debug mode for the mailer which will log the whole SMTP traffic within the log file if enabled.
2015-03-17 19:41:13 +01:00
012016d331
Deprecated \OCP\IAppConfig - add missing methods to IConfig
2015-03-17 17:19:33 +01:00
57ceed590a
only hard depend on the info.xml and not the app.php
...
fix comment
2015-03-17 15:43:48 +01:00
6d5f52484e
Merge pull request #14948 from owncloud/prefix-memcache
...
Add version and path to cache prefix
2015-03-17 13:39:22 +01:00
1f4aa5350a
Reuse cache result
2015-03-17 13:15:52 +01:00
4f9b76d821
Read theme only if required
2015-03-17 12:47:46 +01:00
c233f2c90b
Add version and path to cache prefix
...
Prevents to have the cache reused by other instances on the server which have possible the same instance ID and also invalidates older cache entries after an upgrade which can cause unwanted side-effects.
Impact for deployment: The same cache will only get used if ownCloud is installed with the same version and under the same path. But this should be a basic requirement anyways.
2015-03-17 12:39:49 +01:00
9e2ebf2dce
Cache \OC\URLGenerator::imagePath
...
\OC\URLGenerator::imagePath is a really expensive operation due to all the I/O handling and can really benefit from caching.
2015-03-17 12:35:47 +01:00
5ea8ab3bb0
Fix Principal connector override
2015-03-17 12:22:29 +01:00
9c45ab49a1
Use a closure for the files app entry and deprecate old methods
2015-03-17 12:17:09 +01:00
98a42dbccc
Merge pull request #14927 from oparoz/raw-mimetypes
...
Introducing the Raw media types
2015-03-17 11:32:09 +01:00
e4c6b0abf5
Merge pull request #14931 from owncloud/issue/14881-closures-for-navigation-entries
...
Issue/14881 closures for navigation entries
2015-03-17 11:28:27 +01:00
b1c19f74a1
Merge pull request #12085 from owncloud/add-swift-mailer
...
Migrate OC_Mail to SwiftMailer
2015-03-17 11:15:39 +01:00
fa1be7d296
fall back to absolute path for pipelined assets ( #14940 )
...
If the asset is, for example, in an apps directory that is
outside the $SERVERROOT, we won't be able to get a relative
path. We shouldn't just fail hard in this case. Fall back to
using the absolute path instead (as we used to).
2015-03-16 19:08:11 -07:00
7bc09f8f06
Fix setup config
2015-03-16 17:57:34 +01:00
6f687fa6ae
Merge pull request #14923 from owncloud/fix-preference-key-definition
...
Fix user preference key definition for insertIfNotExists()
2015-03-16 17:14:09 +01:00
54e1edbf03
Merge pull request #13733 from mmattel/Try_to_write_logtimezone_during_installation
...
Write the parameter 'logtimezone' into config.php during setup
2015-03-16 17:04:06 +01:00
bef12488c3
Introducing the Raw mimetypes
2015-03-16 16:25:04 +01:00
970846624f
Allow registering closures for navigation entries
...
This speeds up all pages that don't use the navigation by 0.04sec per app,
because we don't need to create the routing anymore, unless we really need to.
2015-03-16 16:17:43 +01:00
c2a5bd6a01
Also add a note that clob does not work in the compare array
2015-03-16 15:41:00 +01:00
06b2446269
The key is over configkey, user and app, not the value
...
stupid me :(
2015-03-16 15:37:12 +01:00
d7c7808a5e
Add debug log message back
2015-03-16 13:01:17 +01:00
e32f1582c7
Show more detailed error message
2015-03-16 12:47:06 +01:00
f92f3a1a6e
Incorporate review changes
2015-03-16 12:47:05 +01:00
13486a5ada
Migrate to SwiftMail
...
Replaces the OC_Mail and phpmailer with SwiftMail allowing us to mock it properly.
Fixes the unit test execution on master on local machines and https://github.com/owncloud/core/issues/12014
Conflicts:
3rdparty
lib/private/server.php
lib/public/iservercontainer.php
tests/lib/mail.php
tests/settings/controller/mailsettingscontrollertest.php
Conflicts:
3rdparty
lib/private/mail.php
lib/private/server.php
lib/public/iservercontainer.php
settings/ajax/lostpassword.php
settings/application.php
2015-03-16 12:47:05 +01:00
2731b80f74
Only register the core providers when necessary
2015-03-16 12:45:18 +01:00
8ed27d2ce0
Create an interface for OC_Image and OCP\Image for the public API
2015-03-16 12:45:15 +01:00
3b7aec1b7d
Only sort the list when required
2015-03-16 12:44:12 +01:00
37b827f0b2
Order the providers alphabetically
2015-03-16 12:44:12 +01:00
9c86574acf
Only do all the "find path" magic when we need to register them
2015-03-16 12:44:11 +01:00
e38dea3542
Cache result for isMimeTypeSupported()
2015-03-16 12:44:11 +01:00
e518eacba6
Add more type hinting
2015-03-16 12:44:11 +01:00
1a1dc9b335
Use DI for the config
2015-03-16 12:44:11 +01:00
c1f266db88
Add an interface for the preview providers
2015-03-16 12:44:11 +01:00
227ff0a9e3
Clean up some docs
2015-03-16 12:44:11 +01:00
0b37d5aea3
Move default provider registration to preview manager
2015-03-16 12:44:11 +01:00
cae8529359
Register preview providers on the preview manager instead of OC\Preview
2015-03-16 12:44:11 +01:00
1075914f8a
Merge pull request #14883 from owncloud/imagepng_expects_resource_issue
...
validate resource's integrity before using it
2015-03-16 12:22:27 +01:00
09b05373ed
validate resource's integrity before using it
2015-03-16 10:57:01 +01:00
17b10ef9b4
Add spaces
2015-03-16 10:52:29 +01:00
997a7a2668
Merge pull request #14766 from owncloud/fix-insertifnotexists-poc
...
Allow specifying the compare-array for insertIfNotExists()
2015-03-16 10:31:36 +01:00
bbaf97ca43
Merge pull request #14644 from owncloud/trash-expire-command
...
Expire files from the trash in the background
2015-03-16 10:04:05 +01:00
6927773648
Merge pull request #14776 from owncloud/fix-14629-master
...
verify the file name length not to exceed 255 characters + verify path d...
2015-03-16 09:58:41 +01:00
b159c7f274
Merge pull request #14848 from owncloud/kill-curl-fallback-master
...
drop any fallback code related to curl
2015-03-16 09:56:31 +01:00
918b86a5bc
Merge pull request #14871 from owncloud/use-proper-error-type
...
Use proper error type and clean-up code
2015-03-13 23:30:49 +01:00
e77d2ff2b4
Remove outdated comment
2015-03-13 16:19:52 +01:00
bf9030e874
Drop example user backend
...
We already provide an interface for application developers, this file is outdated and thus should get removed.
Addresses No. 3 from https://github.com/owncloud/core/issues/14847
2015-03-13 16:12:32 +01:00
0d9f149dd9
Merge pull request #14867 from owncloud/drop-OC_User_HTTP
...
Remove OC_User_HTTP
2015-03-13 15:53:22 +01:00
38fec9b095
Can also be null
...
If the user does not exist this returns null and can lead to nasty bugs since the IDE is not indicating this...
2015-03-13 14:01:24 +01:00
4eb118dd33
Use proper error type and clean-up code
2015-03-13 13:21:09 +01:00
93a303970f
Remove OC_User_HTTP
...
Addresses No. 1 from https://github.com/owncloud/core/issues/14847
2015-03-13 12:26:33 +01:00
0bd2b3cb0c
[WIP] upgrade app store apps during console upgrade
2015-03-13 12:16:16 +01:00
40b2889785
shipped apps are now defined in core/shipped.json - the shipped tag in info.xml is ignored from now on - never trust an app 🙊
2015-03-13 11:18:39 +01:00
5855108e9b
drop any fallback code related to curl - refs https://github.com/owncloud/core/pull/14838#issuecomment-78586447
2015-03-12 21:43:41 +01:00
00f5025ff1
Add cURL as hard-dependency
...
It is required by other functionalities such as S2S anyways and ownCloud will fail hard at a lot of places without it.
2015-03-12 18:39:54 +01:00
80ef53eff0
verify the file name length not to exceed 255 characters + verify path during rename
2015-03-12 10:47:47 +01:00
fefcbb966b
Also use all keys for an empty array, just in case
2015-03-12 09:18:43 +01:00
dbd2bb66e9
Merge pull request #14357 from owncloud/fix/1373
...
Run `updateDataDirectory` after Update
2015-03-11 18:33:51 +01:00
f9fd1629da
Merge pull request #14705 from rullzer/avatarcontroller
...
Move AvatarController to AppFramework
2015-03-11 17:15:42 +01:00
82254ad5ef
Merge pull request #13893 from owncloud/create-cachedir-on-user
...
Only make sure the cache directory exists when we use it
2015-03-11 16:49:24 +01:00
1a0f9c375b
Avatar controller moved to AppFrameWork
...
* Original avatarcontroller migrated to the appframework
* Added DataDisplayResponse that show data inline in the browser (used
to retrun the image)
* Removed some unneeded code
* Added unit tests for the avatarcontroller
2015-03-11 16:37:42 +01:00
73dc02d42c
Merge pull request #14798 from owncloud/enable-oci-autotest-master
...
Setting oci as supported database
2015-03-11 16:14:54 +01:00
04eef93b25
Merge pull request #13648 from oparoz/sfnt-fonts-preview
...
Add support for font previews
2015-03-11 15:56:32 +01:00
96b223676d
Don't play with config values ...
2015-03-11 15:47:24 +01:00
169031d1c5
fix factory test
2015-03-11 15:07:59 +01:00
e1f2a6df94
Allow setting the watcher policy as mount option
2015-03-11 15:07:23 +01:00
7adda88786
Copy mount options to the storage
2015-03-11 15:06:48 +01:00
4f0f175f8b
Allow getting all mount options as array
2015-03-11 15:06:12 +01:00
e5c8fd37df
pass mountpoint to storage wrapper callback
2015-03-11 15:06:12 +01:00
dbade19362
Merge pull request #13839 from owncloud/issue/13678-improve-remote-domain-detection-in-sharedropdown
...
Better finding the remote URL from user input in share dropdown
2015-03-11 14:38:41 +01:00
ad97ceb787
Merge pull request #13513 from owncloud/repair-legacystoragenofatalfail
...
Do not abort when meeting unfixable legacy storages
2015-03-11 13:32:33 +01:00
8154ed4d2c
Merge pull request #14791 from owncloud/fix-14516
...
Adding a more meaningful message for sabre dav exception
2015-03-11 12:52:18 +01:00
0d0f9a52d2
Merge pull request #14788 from cmeh/patch-3
...
Correct "one invalid characters" to "one invalid character"
2015-03-11 12:26:49 +01:00
0f3e36fdfd
Adding a more meaningful message for sabre dav exception - fixes #14516
2015-03-11 11:53:31 +01:00
abb726c994
Merge pull request #14789 from owncloud/better-app-install-error-messages
...
display app update error messages
2015-03-11 11:28:28 +01:00
ffe06ac5c7
display app update error messages - fixes #14611
2015-03-11 09:59:56 +01:00
4a0c649c8a
Correct "one invalid characters" to "one invalid character"
...
Corrected "one invalid characters" to "one invalid character" in line 1575.
2015-03-11 09:59:42 +01:00
2af8fea2be
Throw a RuntimeException in the cache aswell
2015-03-11 09:33:50 +01:00
6c1a1234f8
Properly handle available databases at runtime and respect setup checks in command line as well
2015-03-11 09:27:12 +01:00
81fa9550a0
No need to restart the web server in cli mode
2015-03-11 09:27:12 +01:00
d1511cdbee
Fix doc blocks of insertIfNotExists() method
2015-03-11 09:05:30 +01:00
284bd6647c
Merge pull request #14759 from owncloud/clean-up-code
...
Clean-up code and use proper exception types
2015-03-10 14:18:21 +01:00
6dc59019af
Merge pull request #14346 from owncloud/storage-based-path-validation
...
adding storage specific filename verification
2015-03-10 11:02:47 +01:00
c8ed88f4d6
Merge pull request #14689 from owncloud/better-missing-resource-handling
...
Log errors and create 404 in network list when a css or js is missing
2015-03-09 23:33:25 +01:00
89be55a672
let insertIfNotExist() throw the native DBALException - no need to hide the real exception
2015-03-09 22:37:49 +01:00
2747a83a49
Get the id before using it
2015-03-09 22:37:49 +01:00
3115d66d60
Better save then sorry
2015-03-09 22:37:49 +01:00
940163e16b
insertIfNotExists() for storage insertion
2015-03-09 22:37:49 +01:00
c917ea183c
Only check unique keys for the comparison on filecache insert & update otherwise
2015-03-09 22:37:49 +01:00
8fa692388b
Allow specifying the compare-array for insertIfNotExists()
2015-03-09 22:37:49 +01:00
d34662122d
Merge pull request #14429 from owncloud/issue/14176-validate-timezone-before-using
...
Etc timezones don't exist for .5 and .75 offsets
2015-03-09 16:16:16 +01:00
01cd83a902
Merge pull request #14713 from owncloud/issue/14671-preview-delete-check-for-valid-fileid
...
Check whether the file id is valid, before using it to delete the previews
2015-03-09 11:56:46 +01:00
2ac6f3a4f5
Clean-up code and use proper exception types
2015-03-09 11:48:55 +01:00
a12e16e985
Check whether the file id is valid, before using it to delete the previews
2015-03-09 11:25:18 +01:00
3623f14e73
no translation service in common storage class
2015-03-09 10:38:38 +01:00
2367797c17
Respect http header 'Accept-Language' on ocs and remote.php calls
2015-03-09 10:38:38 +01:00
33b11682f9
translate error messages
2015-03-09 10:38:38 +01:00
2f18a09a20
Optimize loop
2015-03-09 10:38:38 +01:00
e28d314b53
deprecate isValidFileName()
2015-03-09 10:38:38 +01:00
49e1a81eba
fixing namespaces and PHPDoc
2015-03-09 10:38:37 +01:00
4bac595068
adding storage specific filename verification - refs #13640
2015-03-09 10:38:37 +01:00
d550143ba0
proper filename for "require version.php"
2015-03-09 08:03:28 +01:00
60c507cd4e
Merge pull request #14722 from owncloud/master-14711
...
Fix totally broken AppStore code...
2015-03-06 18:52:12 +01:00
1b08b7c726
use insertIfNotExist() in cache put
2015-03-06 15:32:58 +01:00
4e37831d85
Fix PHPDoc on the way ....
2015-03-06 14:54:57 +01:00
987b683895
Use an atomic implementation on sqlite for insertIfNotExist()
2015-03-06 14:54:54 +01:00
d5a8225c0e
Fix totally broken AppStore code...
...
As it turned out the AppStore code was completely broken when it came from apps delivered from the appstore, this meant:
1. You could not disable and then re-enable an application that was installed from the AppStore. It simply failed hard.
2. You could not disable apps from the categories but only from the "Activated" page
3. It did not show the activation state from any category page
This code is completely static and thus testing it is impossible. We really have to stop with "let's add yet another feature in already existing static code". Such stuff has to get refactored first.
That said, this code works from what I can say when clicking around in the AppStore page GUI. However, it may easily be that it does not work with updates or whatsever as I have no chance to test that since the AppStore code is not open-source and it is impossible to write unit-tests for that.
Fixes https://github.com/owncloud/core/issues/14711
2015-03-06 00:16:17 +01:00
78819da3bf
\OC\Memcache\Cache implements \OCP\ICache
2015-03-05 11:36:34 +00:00
0e4933e6d2
Refactor \OC\Memcache\Factory
...
Caches divided up into two groups: distributed and local. 'Low latency' is an
alias for local caches, while the standard `create()` call tries to get
distributed caches first, then local caches.
Memcache backend is set in `config.php`, with the keys `memcache.local` and
`memcache.distributed`. If not set, `memcache.distributed` defaults to the value
of `memcache.local`.
2015-03-05 11:36:34 +00:00
716ba49a82
Log errors and create 404 in network list when a css or js is missing
2015-03-04 17:56:33 +01:00
aa11b83158
Merge pull request #14682 from owncloud/issue/14681-noop-scanner-outdated
...
Update scanFile() and scanChildren() to the new signature of the parent ...
2015-03-04 10:07:42 +01:00
ac10441600
Merge pull request #14326 from owncloud/remove-unnessary-backslashes-from-translation
...
Remove unnecessary backslashes from translations
2015-03-04 09:58:42 +01:00
f1d74e8803
Merge pull request #14651 from owncloud/add-some-headers-to-htaccess-for-my-best-friend-jenkins
...
Let users configure security headers in their Webserver
2015-03-04 09:36:01 +01:00
09ac2df1f8
Update scanFile() and scanChildren() to the new signature of the parent class
2015-03-04 09:22:53 +01:00
e12c83e3dc
Merge pull request #14674 from owncloud/fix-l10n-getlanguagecode-2
...
Jenkins #14650
2015-03-03 18:33:08 +01:00
b669bf26d6
Fix the behaviour of getLanguageCode() to match the expectation of the name
2015-03-03 16:47:31 +01:00
ed4c05c7b5
Use findLanguage() instead of creating the object first
2015-03-03 16:47:31 +01:00
1761b162e6
Merge pull request #14660 from metaworx/replace-static-dbtableprefix-with-config-dbtableprefix
...
use `dbtableprefix` for temp table and index names
2015-03-03 16:43:47 +01:00
be27188649
Merge pull request #14574 from owncloud/fix-irequest-for-older-php-versions
...
Read from IRequest instead of reading twice
2015-03-03 14:22:56 +01:00
e30ca8198f
Merge pull request #14638 from owncloud/issue/14538-repairstep-drop-old-tables
...
Add a repair step to delete old tables
2015-03-03 13:37:54 +01:00
29ecbc8c6c
Merge pull request #14496 from owncloud/kill-substr-mssql-master
...
[Master] Remove hacky Substring support for MSSQL
2015-03-03 11:00:13 +01:00
276d678080
Etc timezones don't exist for .5 and .75 offsets
2015-03-03 09:08:47 +01:00
6be8ab65a5
replace 'oc_' with dbtableprefix form config for temporary table names and indexes
2015-03-03 01:54:15 +01:00
c3c993446e
Run `updateDataDirectory` after Update
...
Fixes https://github.com/owncloud/core/issues/13731
2015-03-02 19:39:17 +01:00
bbd5f28415
Let users configure security headers in their Webserver
...
Doing this in the PHP code is not the right approach for multiple reasons:
1. A bug in the PHP code prevents them from being added to the response.
2. They are only added when something is served via PHP and not in other cases (that makes for example the newest IE UXSS which is not yet patched by Microsoft exploitable on ownCloud)
3. Some headers such as the Strict-Transport-Security might require custom modifications by administrators. This was not possible before and lead to buggy situations.
This pull request moves those headers out of the PHP code and adds a security check to the admin settings performed via JS.
2015-03-02 19:07:46 +01:00
00568af74d
Allow running the async commands from unit tests
2015-03-02 15:25:31 +01:00
e61aa3723e
Merge pull request #14573 from owncloud/enc-migrate-disable-updater
...
Disable the cache updater when doing the encryption migration
2015-03-02 14:53:29 +01:00
195c577c77
Add a repair step to delete old tables
2015-03-02 12:02:14 +01:00
faddd1e256
Simplify code
2015-03-01 11:46:39 +01:00
4100610390
Disable some server checks when running on HHVM
...
Ref https://github.com/owncloud/core/issues/10837#issuecomment-76516839
2015-02-28 10:08:41 +01:00
f6182aa87e
Allow disabling the cache updater
2015-02-27 17:14:16 +01:00
b4dfd043d7
Merge pull request #14575 from owncloud/cache-rename-overwrite
...
Fix cache update when doing a rename that overwrites the target
2015-02-27 17:11:37 +01:00
fc027bceb7
Fix cache update when doing a rename that overwrites the target
2015-02-27 16:39:58 +01:00
970b14d297
Merge pull request #13616 from owncloud/streamresponse
...
AppFramework StreamResponse
2015-02-27 15:43:01 +01:00
95239ad21e
AppFramework StreamResponse
...
First stab at the StreamResponse, see #12988
The idea is to use an interface ICallbackResponse (I'm not 100% happy with the name yet, suggestions?) that allow the response to output things in its own way, for instance stream the file using readfile
Unittests are atm lacking, plan is to
check if a mock of ICallbackResponse will be used by calling its callback (also unhappy with this name) method
Usage is:
$response = new StreamResponse('path/to/file');
rename io to output, add additional methods and handle error and not modified cases when using StreamResponse
fix indention and uppercasing, also handle forbidden cases
fix indention
fix indention
no forbidden, figuring out if a file is really readable is too complicated to get to work across OSes and streams
remove useless import
remove useless import
fix intendation
2015-02-27 15:42:33 +01:00
c5a9bad919
Merge pull request #14567 from owncloud/node-check-fileinfo-interface
...
Add "throws" lines to calling methods and interface aswell
2015-02-27 15:15:09 +01:00
5c2fafa05f
Read from IRequest instead of reading twice
...
Potentially fixes https://github.com/owncloud/core/issues/14541 and https://github.com/owncloud/core/issues/14506
2015-02-27 14:22:35 +01:00
22bc37cb82
Properly forward repair errors and warnings
...
This makes repair errors and warnings visible for the user when
upgrading on the command line or in the web UI.
2015-02-27 12:44:04 +01:00
8abb80c642
Merge pull request #14565 from owncloud/more-https
...
Add more HTTPS endpoints
2015-02-27 03:31:08 -08:00
3a6a0501c4
Add "throws" lines to calling methods and interface aswell
2015-02-27 12:16:53 +01:00
e6abe96374
Do not abort when meeting unfixable legacy storages
2015-02-27 12:03:22 +01:00
7fe07e93fe
Merge pull request #14437 from owncloud/node-check-fileinfo
...
Check if we have a proper fileinfo
2015-02-27 02:56:13 -08:00
b048e7129a
Add more HTTPS endpoints
...
The doc server can now finally speak SSL...
2015-02-27 11:37:30 +01:00
1c6857d92c
Merge pull request #14529 from owncloud/intuitive-version-check
...
Make version check work on the lowest common version denominator
2015-02-27 02:16:23 -08:00
b58455241b
Add notice about Travis Checks
...
Maybe it helps in the future so we won't forget it again 🙈
2015-02-27 10:23:20 +01:00
f72f9e0159
Merge pull request #14530 from owncloud/revert-14403
...
Revert "Updating license headers"
2015-02-27 00:39:29 -08:00
Thomas Müller
Lukas Reschke
Bernhard Posselt
Robin McCorkell
Morris Jobke
Bernhard Posselt
Vincent Petry
Joas Schilling
Adam Williamson
Olivier Paroz
Georg Ehrke
Roeland Jago Douma
Robin Appelman
cmeh
Joas Schilling
martin-rueegg