a90b4bcc32
Do not switch to root folder if filelist is already shown
...
Navigating to the root folder is already handled by
OCA.Files.Navigation.setActiveItem in case the view doesn't change.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-22 14:03:23 +01:00
e39db808fb
Fix rendering of the sidebar in Files app
...
When a view is rendered it should not be concerned with where it is
going to be placed in the document; in general this should be a
responsibility of the object using the view.
Moreover, when the details view is rendered it should simply prepare a
skeleton that includes the root elements provided by the plugins; those
elements will be updated by the plugins as needed when a file or a tab
is selected.
Finally, the details view should not be explicitly rendered. The
rendering removes the previous elements, but that is needed only when
the details view is in a dirty state, that is, when new plugins were
added since the last time that it was rendered. However, that dirty
state is internally handled, and the view is automatically rendered
again if needed when a file info is set.
Due to all that the details view is no longer explicitly rendered when
updating it with a different file. Also, as each file list has its own
details view, and each details view has its own element, but there can
be only one details view/sidebar element in the document, when the file
list updates the details view it also replaces the current one in the
document with its own details view if needed (that is, if it is not the
current one already).
Besides that, when the element of a details view is replaced with the
element of a different details view the old one should be detached from
the document, but never removed. Otherwise the event handlers would not
work when that element is attached again later (when changing to a
different section in the Files app and then going back to the previous
one).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 05:58:25 +01:00
78056a3bef
Fix whitespace and file action cleanup
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-20 19:46:49 +01:00
fb8aa31dbf
Allow to hide download option for folders shared by link
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-20 19:46:35 +01:00
802e4a79d1
JSUnit tests are not compatible with let/const yet
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-19 15:22:10 +01:00
85a491a6fb
Translate name for "(copy)"
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-19 13:57:27 +01:00
313aee91ca
Per the last comment on having only (copy) for the first one
...
Signed-off-by: Ido Green <greenido@gmail.com>
2018-11-19 13:57:23 +01:00
48d74482c1
Use the new naming per the comments on #9931
...
More details here: https://github.com/nextcloud/server/issues/9931#issuecomment-402318120
Signed-off-by: Ido Green <greenido@gmail.com>
2018-11-19 13:57:17 +01:00
c794452689
fixing issue 9931 - copy a file to the same directory
...
Signed-off-by: Ido Green <greenido@gmail.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-19 13:56:40 +01:00
eb039608f9
Make number of file list entries depending on the width for grid view
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-18 10:44:53 +01:00
8bf7ec26e0
[tx-robot] updated from transifex
2018-11-18 01:12:58 +00:00
9a6d60e95f
Merge pull request #12474 from nextcloud/default-to-files-list
...
Rollback to default list view
2018-11-16 13:48:16 +01:00
def8af3e7e
[tx-robot] updated from transifex
2018-11-16 01:12:14 +00:00
1deda8fd65
Rollback to default list view
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-15 20:29:10 +01:00
790ee0c8a3
Merge pull request #12467 from nextcloud/bugfix/11901/show-thumbnail-on-rename
...
Show thumbnail on rename
2018-11-15 14:09:55 +01:00
c09560627f
Enhance jsunit tests
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-15 13:40:05 +01:00
61f7eecc0b
Show thumbnail on rename
...
* does not hide thumbnail when rename is shown
* fixes layout for grid and list view
* fixes #11901
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-15 12:14:15 +01:00
d70b010432
Merge pull request #12447 from nextcloud/bugfix/12446/fix-oracle-install-again
...
Shorten index name of calendar changes table
2018-11-15 10:47:51 +01:00
10c9b37461
[tx-robot] updated from transifex
2018-11-15 01:12:14 +00:00
c126c3f56a
Update PHPDoc to fix typos
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-14 21:21:41 +01:00
aa88254f64
Shorten index name of calendar changes table
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-14 10:14:23 +01:00
fef51895c2
[tx-robot] updated from transifex
2018-11-14 01:12:12 +00:00
5e84824839
[tx-robot] updated from transifex
2018-11-13 01:12:40 +00:00
48395baa7e
[tx-robot] updated from transifex
2018-11-12 01:12:49 +00:00
55f0c2ac3b
[tx-robot] updated from transifex
2018-11-08 01:12:18 +00:00
c48722c201
Fix file move tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-07 11:14:19 +01:00
c26d847d19
[tx-robot] updated from transifex
2018-11-07 01:12:29 +00:00
e03bc6e4c9
Merge pull request #12303 from nextcloud/grid-for-all-file-templates
...
Add grid toggle for every files view
2018-11-06 17:29:31 +01:00
cac2f7f4d6
Fix tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 16:05:34 +01:00
ccd89f366d
Merge pull request #11968 from nextcloud/feature/noid/drop-verbose-appscan
...
Replace $verbose with VERBOSITY_VERBOSE for scanFiles method
2018-11-06 14:41:39 +01:00
98edf3612c
Fix min trhumbnail size
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 11:45:19 +01:00
5682d302c7
Add grid toggle for every files view
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-06 11:42:18 +01:00
a88e7d30f3
Merge pull request #11831 from nextcloud/feature/noid/drop-verbose-scan
...
Replace $verbose with VERBOSITY_VERBOSE
2018-11-06 10:21:51 +01:00
54a30a4b81
[tx-robot] updated from transifex
2018-11-06 01:12:39 +00:00
f350f2e3ec
Merge pull request #12128 from tomasz-grobelny/fix_file_move
...
Fix file move operation for large number of files
2018-11-06 00:24:27 +01:00
cd31bea2b7
Merge pull request #12289 from nextcloud/ie11-grid-disable
...
Disable grid for ie
2018-11-05 22:48:24 +01:00
e0de0a122f
Disable grid for ie
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-05 17:27:09 +01:00
a793b1027c
Ask before cancelling an ongoing upload
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-05 10:11:50 +01:00
4be625b128
Merge pull request #12231 from nextcloud/bugfix/10934/setmodel_before_render
...
Set the filemodel before rending the detailsview
2018-11-05 08:07:49 +01:00
c28ea52155
[tx-robot] updated from transifex
2018-11-05 01:12:32 +00:00
1fa6e0be23
Merge remote-tracking branch 'upstream/master' into fix_file_move
...
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-04 09:39:19 +00:00
9d7f02ec47
[tx-robot] updated from transifex
2018-11-04 01:14:02 +00:00
41687ef00f
Fix move related tests
...
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-03 23:01:32 +00:00
b1fd72c1cf
Set the filemodel before rending the detailsview
...
fixes #10934
Else it triggers the rendering two times. Resulting is weird state in
for example the comments. Because the comments for OLD_FILEID are
retrieved but then the model is changed to NEW_FILEID. But the old
comments still get in and get parsed.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-02 22:45:25 +01:00
bfab6ccf1b
Merge pull request #12180 from nextcloud/sidebar-fixes
...
Sidebar fixes, mostly fixing design of tabs
2018-11-01 12:42:03 +01:00
0247a0d6db
Merge pull request #12162 from nextcloud/file-menu-align
...
Align file menu below '+' button, fix #5595
2018-11-01 12:01:05 +01:00
4e12132e43
Fix issues with clipboard button for local link in sidebar
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-01 04:11:20 +01:00
9d5982ba4b
[tx-robot] updated from transifex
2018-11-01 01:12:59 +00:00
838105877c
Merge pull request #11647 from nextcloud/make-possible-for-tab-views-to-add-css-classes-to-their-container
...
Make possible for tab views to add CSS classes to their container
2018-10-31 15:37:48 +01:00
1cc05af7a6
Align file menu below '+' button, fix #5595
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-31 11:20:02 +01:00
9c68db5ffb
slightly round off thumbnails in list view too
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-31 00:01:58 +01:00
68a27debd1
Fix file move operation for large number of files
...
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-10-30 15:37:21 +01:00
c0477afb5d
Properly hide files when searching
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-29 14:51:29 +01:00
18fef12721
[tx-robot] updated from transifex
2018-10-29 01:13:07 +00:00
13abee2836
[tx-robot] updated from transifex
2018-10-28 00:12:49 +00:00
0092e3adec
[tx-robot] updated from transifex
2018-10-27 00:12:35 +00:00
aff53d6e34
[tx-robot] updated from transifex
2018-10-26 00:12:48 +00:00
5d888984a0
Fix jsdocs build on server repo
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-24 15:41:08 +02:00
37782b1084
Merge pull request #11573 from nextcloud/gridview-table
...
Files grid view
2018-10-24 15:31:23 +02:00
b3a0d87117
Merge pull request #10888 from nextcloud/bug/noid/fix-missing-quickaccess-favorite-folder-on-add
...
Bug/noid/fix missing quickaccess favorite folder on add
2018-10-24 13:45:40 +02:00
41fbda00ed
Merge pull request #11928 from stweil/fix
...
Fix use of undeclared variable
2018-10-23 21:15:53 +02:00
ede6472e52
Fix FF performance and recals issues
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 18:07:15 +02:00
8013dab044
Allow focus on input with keyboard
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 17:00:47 +02:00
a9fb21f9fc
[tx-robot] updated from transifex
2018-10-23 14:54:28 +00:00
cf57df6e73
Restore table head
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:46:45 +02:00
b6981dcecb
Merge branch 'master' of https://github.com/nextcloud/server into gridview-table
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 16:44:20 +02:00
ae94c5a94c
Merge pull request #11943 from nextcloud/buttons-round
...
Round off buttons 'pill style' like on the website
2018-10-23 16:29:47 +02:00
9b092fd4bd
Merge pull request #11967 from nextcloud/fix-opening-a-section-again-in-the-files-app
...
Fix opening a section again in the Files app
2018-10-23 15:29:55 +02:00
b04ebd8553
Round off buttons 'pill style' like on the website
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-23 15:18:37 +02:00
26ca7a0e2f
Add filepicker toggle
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 10:38:00 +02:00
e0dde083d0
Public fixes, request & default to grid
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:43:02 +02:00
8652ada561
Tooltip on hover only
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:27:27 +02:00
efdb535a5d
Fix grey background over thumbnail
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:23:22 +02:00
b662977862
Fix table hidden on empty folder
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-23 08:18:14 +02:00
a887c6e77b
Fix use of undeclared variable
...
This fixes a warning from LGTM:
Variable 'data' is used before its declaration.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-22 21:07:52 +02:00
1ad42e8f81
Revert changes not related to $verbose
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-22 14:29:49 +02:00
1177ad7bb9
Remove quiet and verbose from Command/Scan
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-21 22:15:10 +02:00
816fbf9b9f
Replace $verbose with VERBOSITY_VERBOSE for scanFiles method
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-21 22:15:10 +02:00
2422dfe619
Replace $verbose with VERBOSITY_VERBOSE for scanFiles method
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2018-10-21 22:06:44 +02:00
0426ba6de5
Remove event handler no longer needed
...
The custom handler for "URL changed" events were added to reload the
file list whenever the sections for favorites and shares were opened;
this was used to fix the problem of not reloading the file lists when
opening them for a second time. However, besides that the handlers were
not really necessary, and as the root of the bug was fixed in the
previous commit those handlers are now removed.
The file list for tags uses the handler for a different purpose, though,
so that one was kept.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-21 20:21:59 +02:00
449349e901
Fix opening a section again in the Files app
...
When a section is open in the Files app a "show" event is triggered.
File list objects handle that event by reloading themselves, but only
if the file list was shown at least once. However, the file list objects
of plugins are created when the "show" event is triggered for the first
time for their section; as the file list objects register their handler
for the "show" event when they are created they never handle the first
triggered "show" event, as the handler is set while that event is being
already handled. Therefore, from the point of view of the handler, the
second time that a "show" event was triggered it was seen as if the file
list was shown for the first time, and thus it was not reloaded. Now the
"shown" property is explicitly set for those file lists that are created
while handling a "show" event, which causes them to be reloaded as
expected when opening their section again.
Note that it is not possible to just reload the file list whenever it is
shown; the file list is reloaded also when the directory changes, and
this can happen when the web page is initially loaded and the URL is
parsed. In that case, if file lists were reloaded when shown for the
first time then it could be reloaded twice, one with the default
parameters due to the "show" event and another one with the proper
parameters once the URL was parsed, and the files that appeard in the
list would depend on which response from the server was received the
last.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-10-21 20:21:19 +02:00
c5d3febf37
Add missing variable declarations
...
This fixes errors from LGTM like the following one:
Variable i is used like a local variable,
but is missing a declaration.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 20:17:55 +02:00
97717ae3a7
Merge pull request #11905 from nextcloud/design/noid/tab-icons
...
Add icon to file sidebar tabs
2018-10-19 16:53:56 +02:00
6a979a0ba0
Merge pull request #11823 from lex111/fix-illegible-text-color-in-size-and-modified-columns
...
Fix illegible text color in columns Size and Modified on dark theme
2018-10-19 15:31:51 +02:00
d35b6513cd
Merge pull request #11922 from stweil/semicolons
...
Add missing semicolons
2018-10-19 12:07:59 +02:00
2ad38200fb
Add missing semicolons
...
This fixes some recommendations from LGTM:
Avoid automated semicolon insertion (90% of all statements
in the enclosing function have an explicit semicolon).
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2018-10-19 11:24:24 +02:00
1b44bdfb58
Add .l10nignore files for compiled assets
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-10-19 10:29:36 +02:00
30cbd137e8
Fix illegible text color in columns Size and Modified on dark theme: rework after review
...
Signed-off-by: Alexey Pyltsyn <lex61rus@gmail.com>
2018-10-18 20:49:46 +03:00
45804b5bef
Add icon to file sidebar tabs
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-10-18 15:54:17 +02:00
0f299d1077
Revert "Remove negative z-index on thumbnail-wrapper, caused thumbnails to not show"
...
This reverts commit fb7fb1cebae5af129c4474a380e0f5e55f79569f.
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:11 +02:00
8614693e9a
Reduce bottom whitespace on share link page
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
25ae3ea296
More space for filename on public share page since there is no share icon
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
d979da3755
In "Deleted files", do not show "Restore" text next to icon as there is no space
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:10 +02:00
bdfece12b2
Fix tabbability to view-toggle, action on Enter to be fixed
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
35ef2b2737
Adjustments for public share page, actions menu, view toggle
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
c0648efe3a
Remove negative z-index on thumbnail-wrapper, caused thumbnails to not show
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
1d486673f6
If there is a comment, show it instead of the share icon
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:09 +02:00
64607f5491
If an avatar is present, show that instead of the icon
...
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-10-18 13:44:08 +02:00
b532c95162
Border radius
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
1f1dddcc5e
Fix spacing
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-10-18 13:44:08 +02:00
Julius Härtl
Daniel Calviño Sánchez
Morris Jobke
Ido Green
Nextcloud bot
John Molakvoæ (skjnldsv)
Joas Schilling
John Molakvoæ
Daniel Kesselberg
Roeland Jago Douma
Tomasz Grobelny
Roeland Jago Douma
Jan-Christoph Borchardt
Stefan Weil
Alexey Pyltsyn