Commit Graph

55088 Commits

Author SHA1 Message Date
Nextcloud bot 63ac3615c5
[tx-robot] updated from transifex 2020-09-03 02:16:37 +00:00
Brad Rubenstein 442af8c5d5 Minor cleanup: php-cs-fixer, tests, interface consistency
IMipPlugin.php Removed blank lines to make php-cs-fixer happy.
Minor cleanup:  bugs found by Psalm static checker
IEMailTemplate: The public interface to addBodyListItem also needs to include the new plainIndent parameter.
IMipPlugin: Fixes an undefined variable for events that do not have DTEND.  Also use explicit string conversion for parameters and properties in several places.

The new email template adds an additional blank line before "button" links in plain text, so the tests were fixed to include that additional blank line.

Signed-off-by: Brad Rubenstein <brad@wbr.tech>
2020-09-02 17:54:36 +02:00
Joas Schilling 87aa9b187e
Use the correct root to determinate the webroot for the resource
Since all the compiled routes are based on the server webroot,
we have to use this, independent from which app this belongs to.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-02 17:13:24 +02:00
John Molakvoæ 34aca46325
Merge pull request #22526 from nextcloud/feature/unified-search/emit-query
Emit unified search query
2020-09-02 09:27:58 +02:00
Raimund Schlüßler 7abfaadc54 Emit unified search query
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-09-02 06:04:10 +00:00
Nextcloud bot d1ea6e09bc
[tx-robot] updated from transifex 2020-09-02 02:17:10 +00:00
Roeland Jago Douma 6bda2c26c7
Merge pull request #22423 from nextcloud/bugfix/noid/direct-editing-encryption
Do not expose direct editing if no master key is available
2020-09-01 20:32:21 +02:00
Christoph Wurst 2b192e7061
Merge pull request #22535 from nextcloud/fix/zipstreamer_external_storage
Only disable zip64 if the size is known
2020-09-01 15:40:46 +02:00
Roeland Jago Douma ab6bd79c02
Only disable zip64 if the size is known
Else we might run into the issue that for an external storage where the
size is not known yet we do not use zip64. Which then of course fails on
large zip files.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-09-01 15:01:12 +02:00
blizzz f32c84a29f
Merge pull request #22533 from nextcloud/fix/noid/rm-matcher-magic
Flow: do not hide "matches" and "does not match" checkers
2020-09-01 11:55:57 +02:00
Julius Härtl e0ae37745a
Do not expose direct editing if no master key is available
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-01 11:40:27 +02:00
Daniel Kesselberg ac8051ee0c
Tests only: Forward calls to getUserValue and getAppValue
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-09-01 11:39:26 +02:00
Arthur Schiwon 2a00c47943
do not hide "matches" and "does not match" checkers
- they show up previously with / typed – end user needs to know about it
- inconsistent with some other fields, that show it directly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-01 10:29:46 +02:00
dependabot-preview[bot] 823f94bb01
Merge pull request #22491 from nextcloud/dependabot/npm_and_yarn/dompurify-2.0.14 2020-09-01 06:55:07 +00:00
Roeland Jago Douma d0a7f833cc
Merge pull request #22116 from nextcloud/bugfix/noid/transfer-ownership-share-root
Fix share transfer of single files and on the transfered node
2020-09-01 08:50:22 +02:00
Roeland Jago Douma e0d767d3e1
Merge pull request #16632 from nextcloud/bugfix/external-reshare
Set proper root path for single file shares originating from other storages
2020-09-01 08:48:31 +02:00
dependabot-preview[bot] ec986af726 Bump dompurify from 2.0.12 to 2.0.14
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.0.12 to 2.0.14.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.0.12...2.0.14)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-09-01 06:19:50 +00:00
Nextcloud bot 023d18bc40
[tx-robot] updated from transifex 2020-09-01 02:16:09 +00:00
Daniel Kesselberg 2513b64602
Change free space calculation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-31 23:11:10 +02:00
Roeland Jago Douma 8dd249937f
Merge pull request #22514 from nextcloud/fix/s3/only_delete_new_failed
Fix S3 error handling
2020-08-31 19:03:24 +02:00
Georg Ehrke 6b835e3c1d
Merge pull request #22424 from nextcloud/feature/noid/dnd_will_mute_notifications
User Status: Display hint that DND mutes all notifications
2020-08-31 17:45:24 +02:00
Robin Appelman 6b9b88f8b7
Merge pull request #22517 from nextcloud/external-mount-id-before-wrapper
set the mount id before calling storage wrapper
2020-08-31 15:19:51 +00:00
Georg Ehrke dbef68b397
User Status: Display hint that DND mutes all notifications
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-31 16:55:54 +02:00
dependabot-preview[bot] 1c22004bf4
Merge pull request #22494 from nextcloud/dependabot/npm_and_yarn/underscore-1.11.0 2020-08-31 14:44:33 +00:00
Robin Appelman 81c5aa9819
set the mount id before calling storage wrapper
this allows the storage wrapper to use the mount id for it's own logic

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-31 16:38:47 +02:00
dependabot-preview[bot] 9aacfa5cea Bump underscore from 1.10.2 to 1.11.0
Bumps [underscore](https://github.com/jashkenas/underscore) from 1.10.2 to 1.11.0.
- [Release notes](https://github.com/jashkenas/underscore/releases)
- [Commits](https://github.com/jashkenas/underscore/compare/1.10.2...1.11.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-31 14:03:41 +00:00
dependabot-preview[bot] 9d9a69332b
Merge pull request #22459 from nextcloud/dependabot/npm_and_yarn/nextcloud/dialogs-2.0.1 2020-08-31 13:41:58 +00:00
blizzz 849c13f202
Merge pull request #22472 from nextcloud/fix/contacts-interaction-blob-postgres
Fix writing BLOBs to postgres with recent contacts interaction
2020-08-31 15:07:22 +02:00
Julius Härtl ac2999a26a
Transfer shares of the transferred root node
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-31 14:23:34 +02:00
Roeland Jago Douma 789b33aba4
Only update the filecache entry once the file has been written to S3
If we already update before we have no way to revert if the upload
fails.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-31 12:28:04 +02:00
Roeland Jago Douma 6ffd7173f9
Don't lose filecache entry on s3 overwrite error
If the object store errors we should not always delete the filecache
entry. As this might lead to people losing access to their files.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-31 12:25:20 +02:00
dependabot-preview[bot] 2ebc14abb7 Bump @nextcloud/dialogs from 1.4.0 to 2.0.1
Bumps [@nextcloud/dialogs](https://github.com/nextcloud/nextcloud-dialogs) from 1.4.0 to 2.0.1.
- [Release notes](https://github.com/nextcloud/nextcloud-dialogs/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-dialogs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-dialogs/compare/v1.4.0...v2.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-31 09:21:36 +00:00
Roeland Jago Douma 7c8a8dc143
Merge pull request #22511 from nextcloud/fix/oca-search-monkey-patch
Declare OCA.Search  directly, not via a monkey patch
2020-08-31 11:04:49 +02:00
Christoph Wurst e2d209536f
Declare OCA.Search directly, not via a monkey patch
Apps could use OCA.Search very early on a page load without a problem
prior to Nextcloud 20 (current master). Since the unified search work
moved some code around, it now was added later, resulting in `TypeError:
OCA.Search is not a constructor` errors if the apps did not wrap their
calls in a `DOMLoaded` event handler.

To ensure existing code continues to work without modification, this
patch moves the declaration of the `OCA.Search` API to where we defined
`OCA`, instead of monkey-patching it later on.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-31 10:31:12 +02:00
Roeland Jago Douma 8c9f3a5f5e
Merge pull request #22502 from nextcloud/fix/12302/oauth2_table
Pimp Oauth2 table
2020-08-31 09:49:02 +02:00
Roeland Jago Douma 5659e69cd8
Pimp Oauth2 table
Fixes #12302

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-08-31 07:48:07 +02:00
Nextcloud bot 5fb1d8d3be
[tx-robot] updated from transifex 2020-08-31 02:16:10 +00:00
Roeland Jago Douma c43189beae
Merge pull request #22476 from nextcloud/setting-sections-unique
ignore duplicate setting sections
2020-08-30 21:15:50 +02:00
Roeland Jago Douma 5d4c4b54e6
Merge pull request #22481 from nextcloud/fix-clicks-on-actions-menu-of-non-opaque-file-rows-in-acceptance-tests
Fix clicks on actions menu of non opaque file rows in acceptance tests
2020-08-30 20:07:13 +02:00
Roeland Jago Douma 6a40e96853
Merge pull request #22490 from nextcloud/dependabot/npm_and_yarn/webpack-node-externals-2.5.2
Bump webpack-node-externals from 2.5.1 to 2.5.2
2020-08-30 20:06:10 +02:00
Nextcloud bot 41d95d9e5a
[tx-robot] updated from transifex 2020-08-30 02:16:07 +00:00
dependabot-preview[bot] e80fd79825
Bump webpack-node-externals from 2.5.1 to 2.5.2
Bumps [webpack-node-externals](https://github.com/liady/webpack-node-externals) from 2.5.1 to 2.5.2.
- [Release notes](https://github.com/liady/webpack-node-externals/releases)
- [Commits](https://github.com/liady/webpack-node-externals/compare/v2.5.1...v2.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-29 17:20:31 +00:00
Nextcloud bot 2bc4094deb
[tx-robot] updated from transifex 2020-08-29 02:17:47 +00:00
Daniel Calviño Sánchez 034b7bd4a9 Fix clicks on actions menu of non opaque file rows in acceptance tests
When a row is added to the file list the opacity of the file row is
animated from transparent to fully opaque. As the file actions menu is a
descendant of the row but overflows it when the row is not fully opaque
clicks on the menu entries "fall-through" and are received instead by
the rows behind.

The opacity animation is a CSS animation, and it is not possible to know
if a row is appearing or not except from its opacity (the row will have
the "appear" CSS class even after the animation ended). Therefore it
should be waited until the row of the file is fully opaque before using
the menu.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-08-29 03:32:14 +02:00
Robin Appelman eb4154cee0
ignore duplicate setting sections
this prevents some 'Section with the same ID already registered' errors in the log

also includes an improvement of the error message to make other cases easier to find

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-28 17:06:48 +02:00
Roeland Jago Douma 7b8364e001
Merge pull request #21288 from lmamane/master
Return correct loginname in credentials
2020-08-28 16:11:46 +02:00
Christoph Wurst 3bc54bfd06
Fix writing BLOBs to postgres with recent contacts interaction
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-28 14:30:33 +02:00
Robin Appelman af381a9a93
remove unneeded if
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-28 11:43:23 +02:00
Robin Appelman 2879472f81
trim slashes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-08-28 11:14:50 +02:00
Julius Härtl 7512dc2b34
Set proper root path for single file shares originating from other storages
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-28 10:50:15 +02:00