Joas Schilling
0833a6e332
Correctly create activities for public downloads
2015-02-17 17:26:03 +01:00
Lukas Reschke
3213b04aef
Check if the offset exists before accessing
...
This checks if the offset exists before accessing it and also adds unit tests to this function which would have catched this before 🙈
Fixes https://github.com/owncloud/core/issues/14277
2015-02-17 17:08:23 +01:00
Clark Tomlinson
ac13cf04ba
Merge pull request #14266 from owncloud/encodeUriComponentPerDefault
...
Encode parameters in `OC.generateUrl` by itself
2015-02-17 10:37:06 -05:00
Lukas Reschke
0ea6de2f8c
Encode Requesttoken for avatars
...
Fixes new avatar selection in master half, other half will work when https://github.com/owncloud/core/pull/14266 has get merged.
Shocking to see how much places in our code do it wrong 🔫
2015-02-17 15:25:38 +01:00
Robin Appelman
e672f8cc8f
Use appmanager in OC_App::enable/disable
2015-02-17 15:05:29 +01:00
Robin Appelman
5394a81c05
Dont fatal error test when encryption is enabled
2015-02-17 15:05:29 +01:00
Robin Appelman
04628cf368
better name for getAppsEnabledForUser
2015-02-17 15:05:29 +01:00
Robin Appelman
434835b326
also set user in UserSession when doing OC_User::setUserId
2015-02-17 15:05:29 +01:00
Robin Appelman
4d805b52cc
Test improvements
2015-02-17 15:05:29 +01:00
Robin Appelman
409453bc60
better user group caching
2015-02-17 15:05:29 +01:00
Robin Appelman
5c68c81d00
Update cache when enabling/disabling apps
2015-02-17 15:05:25 +01:00
Lukas Reschke
8e6a7350f9
Merge pull request #14289 from owncloud/remove-null-byte-check
...
Remove Null Byte Check
2015-02-17 14:47:27 +01:00
Lukas Reschke
27c1409be5
Encode parameters in `OC.generateUrl` by itself
...
This function is often used in a wrong and potential dangerous way... Thus we should escape the URL per default and offer developers to disable the automatic escaping via an option parameter if they really want that behaviour.
Might break some things, however, those things are then easy to fix and we really have a ton of bugs caused by this...
Fixes https://github.com/owncloud/core/issues/14228
2015-02-17 14:41:06 +01:00
Lukas Reschke
20d57c8bfe
Remove Null Byte Check
...
This is not relevant anymore since we require PHP 5.4
2015-02-17 14:19:20 +01:00
Lukas Reschke
b701bbd8c5
Use APCu only if available in version 4.0.6 and higher
...
APCu before 4.0.6 is unbelievable buggy and tend to segfault the PHP process (i.e. the whole webserver)
This potentially fixes https://github.com/owncloud/core/issues/14175
Requires a backport to stable8
2015-02-17 13:28:02 +01:00
Lukas Reschke
76c511de92
Merge pull request #14056 from owncloud/refactor/13976
...
Refactor OC_Request into TrustedDomainHelper and IRequest
2015-02-17 13:17:04 +01:00
Vincent Petry
e8f16db49d
Merge pull request #13866 from rullzer/avatar_share_dialog
...
Avatars in share dialog
2015-02-17 10:17:36 +01:00
Jenkins for ownCloud
30ca14021c
[tx-robot] updated from transifex
2015-02-17 01:56:23 -05:00
Christian Seiler
535757bc42
DAV authentication: also use Owncloud's internal user for short-circuit
...
It still works otherwise, but without this, the performance optimization
of #13416 is defeated in these situations.
2015-02-16 23:47:39 +01:00
Christian Seiler
1377ebc7e9
DAV authentication: use Owncloud's internal user instead of HTTP-supplied one
...
Fixes : #14048 , #14104 , calendar#712
2015-02-16 23:34:49 +01:00
Lukas Reschke
cebf9f6a5a
Incorporate review changes
2015-02-16 22:13:03 +01:00
Lukas Reschke
992164446c
Add blackmagic due to cyclic dependency 🙈
2015-02-16 22:13:01 +01:00
Lukas Reschke
9f91d64918
Make scrutinizer happy
2015-02-16 22:13:00 +01:00
Lukas Reschke
886bda5f81
Refactor OC_Request into TrustedDomainHelper and IRequest
...
This changeset removes the static class `OC_Request` and moves the functions either into `IRequest` which is accessible via `\OC::$server::->getRequest()` or into a separated `TrustedDomainHelper` class for some helper methods which should not be publicly exposed.
This changes only internal methods and nothing on the public API. Some public functions in `util.php` have been deprecated though in favour of the new non-static functions.
Unfortunately some part of this code uses things like `__DIR__` and thus is not completely unit-testable. Where tests where possible they ahve been added though.
Fixes https://github.com/owncloud/core/issues/13976 which was requested in https://github.com/owncloud/core/pull/13973#issuecomment-73492969
2015-02-16 22:13:00 +01:00
Victor Dubiniuk
bdfc9b57bd
Skip primary index if the table has one
2015-02-16 20:30:28 +01:00
Victor Dubiniuk
4e9764b122
Submodule update
2015-02-16 20:30:28 +01:00
Lukas Reschke
912a536c17
Encode requesttoken
...
One cannot make any assumptions about the requesttoken content. Thus we need to encode it.
2015-02-16 20:28:30 +01:00
Lukas Reschke
7f624188a7
Merge pull request #14261 from owncloud/fix-last-login-master
...
Return milliseconds instead of seconds for lastLogin - refs #14005
2015-02-16 20:22:47 +01:00
Thomas Müller
1a4b9b0c92
Merge pull request #14263 from owncloud/missing-visibility-activity-iextension
...
Add visibility to interface to make scrutinizer 1 step happier
2015-02-16 19:54:55 +01:00
Thomas Müller
29c8dfe1f8
Merge pull request #13879 from owncloud/add_debug_log_for_memcache_instantiation
...
add debug log for memcache instantiation
2015-02-16 19:51:40 +01:00
Thomas Müller
4910f3e202
fixing unit tests in UsersControllerTest
2015-02-16 19:45:40 +01:00
Jörn Friedrich Dreyer
87db136508
add debug log for memcache instantiation
2015-02-16 18:05:43 +01:00
Joas Schilling
f808acd317
Add visibility to interface to make scrutinizer 1 step happier
2015-02-16 17:46:43 +01:00
Thomas Müller
3c75a440a6
Return milliseconds instead of seconds for lastLogin - refs #14005
2015-02-16 17:41:44 +01:00
Morris Jobke
5a5d6bf4db
Merge pull request #14128 from owncloud/drop-unused-methods
...
Remove unused function and correct PHPDoc
2015-02-16 17:37:36 +01:00
Morris Jobke
fadf0a9443
Merge pull request #10673 from owncloud/smb-new
...
New SMB storage backend
2015-02-16 17:37:20 +01:00
Thomas Müller
9271059195
Merge pull request #13750 from owncloud/enhanced-code-checker
...
Implement php code checker to detect usage of not allowed private ...
2015-02-16 16:55:57 +01:00
Joas Schilling
8eb804b1f6
Merge pull request #13269 from owncloud/issue/13211-cache-array-implementation
...
Add an array implementation of cache and use it if we are not debugging
2015-02-16 15:35:20 +01:00
Robin Appelman
23ab25e93a
Use the app manager from oc_app
2015-02-16 15:16:13 +01:00
Robin Appelman
2b58e8489f
Add getInstalledApps and getAppsForUser to the app manager
2015-02-16 15:15:35 +01:00
Thomas Müller
9c47ab91f2
Merge pull request #14194 from owncloud/url-encode-logout-attribute
...
URLEncode logout attribute
2015-02-16 15:04:20 +01:00
Joas Schilling
8848b5f067
Add an array implementation of cache and use it if we are not debugging
2015-02-16 14:55:50 +01:00
Thomas Müller
bd994cb294
Update 3rdparty commit to master
2015-02-16 14:53:16 +01:00
Lukas Reschke
c6705ab574
Merge pull request #13890 from owncloud/add-no-referrer
...
Add `rel="noreferrer"` where possible and switch to HTTPS
2015-02-16 14:36:44 +01:00
Morris Jobke
f7bd543a85
Merge pull request #14243 from owncloud/console-execution-time-master
...
console commands shall not be limited with respect to execution time
2015-02-16 14:26:14 +01:00
Robin Appelman
6477e39be9
also make sure we have a leading slash for the test root
2015-02-16 14:01:08 +01:00
Thomas Müller
6cdc7a890a
Merge pull request #14076 from owncloud/autotest-external-ftp
...
[files_external] ftp tests
2015-02-16 13:56:40 +01:00
Robin Appelman
6467369cad
make sure the root has a trailing slash
2015-02-16 13:52:11 +01:00
Robin Appelman
35077ec34e
remove outdated test
2015-02-16 13:52:11 +01:00
Robin Appelman
e98983485f
handle deleting non existing files
2015-02-16 13:52:11 +01:00