Commit Graph

53192 Commits

Author SHA1 Message Date
Christoph Wurst 734c62bee0
Format code according to PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:56:50 +02:00
Christoph Wurst 28f8eb5dba
Add visibility to all constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
Christoph Wurst 1584c9ae9c
Add visibility to all methods and position of static keyword
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
Christoph Wurst a7c8d26d31
Add visibility to all properties and move static keyword
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:48:31 +02:00
Christoph Wurst 1762a409f9
Merge pull request #20422 from nextcloud/techdebt/format-control-structs-classes-methods
Format control structures, classes, methods and function
2020-04-10 16:38:23 +02:00
Roeland Jago Douma eba3726e1e
Merge pull request #19495 from nextcloud/preview-generate-batch
optimize batch generation of previews
2020-04-10 15:57:06 +02:00
John Molakvoæ (skjnldsv) e24818f6bb Bump core-js from 1.4.1 to 1.5.0
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-10 12:37:20 +00:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Christoph Wurst edf8ce32cf
Merge pull request #20403 from nextcloud/techdebt/utf8-encoding
Use utf8 encoding everywhere
2020-04-10 14:05:23 +02:00
Robin Appelman 8f9bac26f8
fix preview generation tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-10 13:39:45 +02:00
John Molakvoæ 71b073839f
Merge pull request #20402 from nextcloud/techdebt/elseif
Use elseif instead of else if
2020-04-10 13:28:15 +02:00
Roeland Jago Douma 75836f004d
Show setup check for recommended php modules
Fixes #20393

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-10 13:25:12 +02:00
dependabot-preview[bot] 7db582390f
Bump core-js from 3.6.4 to 3.6.5
Bumps [core-js](https://github.com/zloirock/core-js) from 3.6.4 to 3.6.5.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/v3.6.5/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.6.4...v3.6.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-10 11:55:37 +02:00
dependabot-preview[bot] 04e1fc8226
Bump @nextcloud/initial-state from 1.1.1 to 1.1.2
Bumps [@nextcloud/initial-state](https://github.com/nextcloud/nextcloud-initial-state) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/nextcloud/nextcloud-initial-state/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-initial-state/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-initial-state/compare/v1.1.1...v1.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-10 11:55:28 +02:00
dependabot-preview[bot] c7a6f0f602
Bump @nextcloud/l10n from 1.2.2 to 1.2.3
Bumps [@nextcloud/l10n](https://github.com/nextcloud/nextcloud-l10n) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/nextcloud/nextcloud-l10n/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-l10n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-l10n/compare/v1.2.2...v1.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-10 11:54:20 +02:00
dependabot-preview[bot] b532a02e3e
Bump sinon from 9.0.1 to 9.0.2
Bumps [sinon](https://github.com/sinonjs/sinon) from 9.0.1 to 9.0.2.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-10 09:54:11 +00:00
dependabot-preview[bot] e255820443
Bump @nextcloud/password-confirmation from 1.0.0 to 1.0.1
Bumps [@nextcloud/password-confirmation](https://github.com/nextcloud/nextcloud-password-confirmation) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/nextcloud/nextcloud-password-confirmation/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-password-confirmation/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-password-confirmation/compare/v1.0.0...v1.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-10 11:53:45 +02:00
dependabot-preview[bot] abbbaa2c94
Bump @nextcloud/event-bus from 1.1.3 to 1.1.4
Bumps [@nextcloud/event-bus](https://github.com/nextcloud/nextcloud-event-bus) from 1.1.3 to 1.1.4.
- [Release notes](https://github.com/nextcloud/nextcloud-event-bus/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-event-bus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-event-bus/compare/v1.1.3...v1.1.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-10 11:53:39 +02:00
dependabot-preview[bot] 08ea2fed34
Bump @babel/preset-env from 7.8.7 to 7.9.5
Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.8.7 to 7.9.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.8.7...v7.9.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-10 11:53:25 +02:00
dependabot-preview[bot] 98b4338094
Bump @nextcloud/auth from 1.2.2 to 1.2.3
Bumps [@nextcloud/auth](https://github.com/nextcloud/nextcloud-auth) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/nextcloud/nextcloud-auth/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-auth/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-auth/compare/v1.2.2...v1.2.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-10 11:53:18 +02:00
dependabot-preview[bot] e5302d2335
Bump p-limit from 2.2.2 to 2.3.0
Bumps [p-limit](https://github.com/sindresorhus/p-limit) from 2.2.2 to 2.3.0.
- [Release notes](https://github.com/sindresorhus/p-limit/releases)
- [Commits](https://github.com/sindresorhus/p-limit/compare/v2.2.2...v2.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-10 11:53:08 +02:00
Christoph Wurst a0e94e6670
Use utf8 encoding everywhere
PSR2 likes that and so do I

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:43:54 +02:00
Christoph Wurst 14c996d982
Use elseif instead of else if
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
Roeland Jago Douma d6e17fb017
Merge pull request #20256 from nextcloud/dependabot/composer/nikic/php-parser-4.3.0
Bump nikic/php-parser from 4.2.1 to 4.3.0
2020-04-10 09:11:32 +02:00
Roeland Jago Douma 94e602d7b9
Merge pull request #20281 from nextcloud/bugfix/noid/use-primary-element-color
Use the primary element color in case it primary color is too bright
2020-04-10 08:53:48 +02:00
Joas Schilling 0b53084ccb Use the primary element color in case it primary color is too bright
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-10 06:49:21 +00:00
Roeland Jago Douma b68680596d
Merge pull request #20313 from nextcloud/dependabot/npm_and_yarn/underscore-1.10.2
Bump underscore from 1.9.2 to 1.10.2
2020-04-10 08:35:43 +02:00
Roeland Jago Douma fb64fda4d8
Merge pull request #20385 from nextcloud/skeeable-http-harden
harden seekable http stream a bit against failures
2020-04-10 08:34:52 +02:00
Roeland Jago Douma 7799eef90e
Merge pull request #20390 from nextcloud/refactor/no-closing-tag
Do not use closing tags
2020-04-10 08:34:18 +02:00
Nextcloud bot 078b12a9b0
[tx-robot] updated from transifex 2020-04-10 02:18:23 +00:00
Christoph Wurst 008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
Azul 43f0d2a3b5 Allow opening files for editing in new tabs
In a file list files with a default action
have an href that will trigger the action.
This way ctrl-click and middle button click open the default action in a new tab.

In order to achieve this a new param `openfile` was introduced to the files app.
It will make the files app trigger the default action for the file in question.
This also allows linking to file content rather than just the details display.

Introduce fileList.getDefaultActionUrl()
to create a link with that param set.
It's overwritten in the trashbin fileList
so that anchors continue to have `#` as a href.

Fix the link generation for subfolders of public shares:
58a87d0 was the last commit that touched the linkTo function in public.js.
It included the params as arguments to the generateUrl function.
Turns out this completely ignores the dir parameter now.
The inclusion was reverted in other places
so revert it here as well.
Also change `dir` to `path` in the param as that is respected
when following the link.

Add Test for the new link url for files with default action.
Remove test for multiple selects with ctrl-click
as that is not what we are doing anymore.

Signed-off-by: Azul <azul@riseup.net>
2020-04-09 16:41:09 +02:00
Christoph Wurst 64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
Christoph Wurst 3a415e4139
Remove space between switch case and colon
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:17:53 +02:00
Christoph Wurst f4c09f299d
Make sure there is exactly one newline after imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:14:31 +02:00
Christoph Wurst bcd13296de
Make sure every file ends with an empty newline
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
Christoph Wurst a8a06a82d2
Remove trailing whitespaces from comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
Christoph Wurst 42625a46be
Remove spaces after method or function call
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:05:56 +02:00
Christoph Wurst 709584b853
Do not use closing tags
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:01:17 +02:00
Christoph Wurst c56a273b39
Merge pull request #20383 from nextcloud/techdebt/function-spacing
Unify function spacing to PSR2 recommendation
2020-04-09 15:53:09 +02:00
John Molakvoæ f0dd71ccd2
Merge pull request #20376 from nextcloud/fix/tags-ellipsis
Fix systemtags overflow
2020-04-09 15:18:16 +02:00
Robin Appelman 60de74ac40
harden seekable http stream a bit against failures
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-09 14:37:01 +02:00
Christoph Wurst 36b3bc8148
Use php keywords in lowercase
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
Christoph Wurst afbd9c4e6e
Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
John Molakvoæ 66b743385e
Merge pull request #20355 from nextcloud/fix/comments/clear-input/19585
Clear comment on successful post
2020-04-09 13:46:20 +02:00
Christoph Wurst 19e97e86c6
Merge pull request #20379 from nextcloud/techdebt/blank-lines
Use one blank line after the opening tag and namespace declaration
2020-04-09 13:44:39 +02:00
Robin Appelman 7d386872e5
optimize batch generation of previews
by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file

the main use case for this is the preview generator app (pr for that comming next)

in my local testing this saves about 25% of time when using the preview generator app

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-09 12:50:59 +02:00
Robin Appelman 5cd12cd7c3
allow generating multiple preview sizes for a single file at once
this saves having to do some of the overhead multiple times

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-09 12:50:55 +02:00
Christoph Wurst 2a529e453a
Use a blank line after the opening tag
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:50:14 +02:00