13e817e901
Throw exception on `getPath` if file does not exist
...
Currently the `getPath` methods returned `NULL` in case when a file with the specified ID does not exist. This however mandates that developers are checking for the `NULL` case and if they do not the door for bugs with all kind of impact is widely opened.
This is especially harmful if used in context with Views where the final result is limited based on the result of `getPath`, if `getPath` returns `NULL` PHP type juggles this to an empty string resulting in all possible kind of bugs.
While one could argue that this is a misusage of the API the fact is that it is very often misused and an exception will trigger an immediate stop of execution as well as log this behaviour and show a pretty error page.
I also adjusted some usages where I believe that we need to catch these errors, in most cases this is though simply an error that should hard-fail.
2015-10-25 17:58:21 +01:00
eb10e3abc2
[tx-robot] updated from transifex
2015-10-25 01:55:04 -04:00
ba010a5aa4
[tx-robot] updated from transifex
2015-10-24 01:55:42 -04:00
e8b12a3c2c
Merge pull request #19970 from owncloud/encryption-getuidonboolean
...
Fix "Call to a member function getUID() on boolean" in Crypt
2015-10-23 12:56:14 +02:00
a341e786dd
[tx-robot] updated from transifex
2015-10-23 01:55:06 -04:00
db25f41da8
handle NoUserException in sharing code
...
* setup LDAP users
* share from an LDAP user
* delete that LDAP user
* log in as share recipient
* before: unhandled NoUserException
* after: NoUserEception is logged and share is not shown anymore
2015-10-22 17:04:36 +02:00
e0a56317fa
Fix "Call to a member function getUID() on boolean" in Crypt
2015-10-22 11:46:37 +02:00
bbea8c3545
Merge pull request #19937 from owncloud/detailsview-donotopenonrename
...
Do not display details bar after rename
2015-10-22 10:42:15 +02:00
8ed0214818
Merge pull request #19931 from owncloud/fix-webui-upload-and-conflicts
...
Fix file upload, conflict dialog, also in public link
2015-10-22 10:41:48 +02:00
c50bbb8cde
[tx-robot] updated from transifex
2015-10-22 01:55:47 -04:00
9b64fa7b92
[provisioning api] losen test
...
Since we have no control of how backends sort their list of users and we
also don't want to sort yet another time the test now just checks if the
correct number of elements is returned and if they are from the list of
group members.
2015-10-21 20:05:14 +02:00
e36c85178f
Do not display details bar after rename
2015-10-21 13:43:39 +02:00
abd0ba1f25
Fix file upload, conflict dialog, also in public link
...
- Use "FileList" instead of "OCA.Files.App.fileList" that doesn't exist in public
link page.
- Fix public link upload by properly adding the form data using a new
utility function "addFormData". That one is needed because IE8 upload
and regular upload use a different format...
2015-10-21 12:18:06 +02:00
ee42e9d489
increase core version and add dav version number
2015-10-21 11:36:44 +02:00
74f41349b7
[tx-robot] updated from transifex
2015-10-21 01:56:16 -04:00
aeffd51145
Fix scrutinizer issues
...
* PHPDoc
* Proper array initialization
2015-10-20 21:47:37 +02:00
480a005b47
fix pagination on public file list
2015-10-20 16:11:10 +02:00
122f8d831b
Merge pull request #19863 from owncloud/external-storage-wording
...
fix wording on external storage checkbox, ref #19858
2015-10-20 15:21:26 +02:00
257ccfa698
Merge pull request #19877 from owncloud/dropbox-fixmetadatacachepaths
...
Fix Dropbox metadata cache with trimmed paths
2015-10-20 15:17:28 +02:00
60abc2738b
Merge pull request #18399 from owncloud/api-getusers-for-subadmins
...
enable api getUsers for subadmins
2015-10-20 14:28:31 +02:00
474f34eb6b
Merge pull request #19636 from owncloud/share_expire_backgroun
...
Add backgroundjob to expire link shares
2015-10-20 14:27:15 +02:00
899165113c
Merge pull request #19742 from owncloud/shareinfo_performance
...
Do not calculate non essential info
2015-10-20 14:25:36 +02:00
adfb33b791
Merge pull request #19838 from owncloud/remove-files-remote.php
...
Remove apps/files/appinfo/remote.php - this is no longer used
2015-10-20 11:31:35 +02:00
5752e3b3c0
Merge pull request #19666 from owncloud/fix_13002
...
Combine OCS API getUser method code into provisioning_api app
2015-10-20 11:10:39 +02:00
50cb8106dc
Merge pull request #19859 from owncloud/fix-long-groupnames
...
ellipsize long group names in select2 dropdown, fix #16977
2015-10-20 11:06:18 +02:00
e1c47d6823
use correct class name
2015-10-20 08:18:53 +02:00
ec296b0b7d
Add backgroundjob to expire link shares
...
Simple background job to expire the link shares.
* added unit tests
2015-10-20 08:18:53 +02:00
dfd44942c6
[tx-robot] updated from transifex
2015-10-20 01:55:03 -04:00
d795643ef9
Fix Dropbox metadata cache with trimmed paths
...
Makes sure that the paths are trimmed to avoid duplicate entries like
"/test" and "test". This should make this storage slightly faster by
reducing the cache misses.
2015-10-19 20:52:15 +02:00
2895c91291
Merge pull request #17641 from owncloud/fix_objectstore_rename
...
don't move files in cache twice, fixes renaming for objectstores
2015-10-19 17:18:57 +02:00
acc906c4d8
fix wording on external storage checkbox, ref #19858
2015-10-19 21:26:47 +13:00
008082ebad
[tx-robot] updated from transifex
2015-10-19 01:55:02 -04:00
3875ca2d19
ellipsize long group names in select2 dropdown, fix #16977
2015-10-19 16:11:53 +13:00
8d25528c49
[tx-robot] updated from transifex
2015-10-18 01:55:07 -04:00
0d3d75b3b3
Increase the 2nd digit of shipped apps
2015-10-17 08:47:11 +02:00
c378456137
[tx-robot] updated from transifex
2015-10-17 01:55:34 -04:00
d636bce8a4
fix encryption migration test
2015-10-16 21:41:51 +02:00
e4364426e2
Fix listing of trash files in test
2015-10-16 21:41:51 +02:00
2e8232e803
Fix trashbin handling of unknown/unlimited free space
2015-10-16 21:41:51 +02:00
d749b9a5ac
Fix rename shared versions test
2015-10-16 21:41:51 +02:00
22c5c19376
handle versions expire for home storages with unlimited quota
2015-10-16 21:41:51 +02:00
416da0dfe9
fix delete orphan shares test with object home storage
2015-10-16 21:41:51 +02:00
54cea05271
Fix preserving file ids when restoring a file with object storage
2015-10-16 21:41:51 +02:00
a87b34a059
dont assume home storage is local in trash test
2015-10-16 21:41:51 +02:00
8efd037eb8
Make shared folder size propagation test work with object home storage
2015-10-16 21:41:51 +02:00
e7f75484f8
Fix shared storage tests for non local home storage
2015-10-16 21:41:51 +02:00
0cdd46de60
fix sabre connector tests when using a non local home storage
2015-10-16 21:41:51 +02:00
6cd1126dd1
Merge pull request #19843 from owncloud/an-app-is-identified-by-having-a-info.xml-app.php-should-not-be-mandatory
...
an-app-is-identified-by-having-a-info.xml-app.php-should-not-be-manda…
2015-10-16 21:28:55 +02:00
9e6a4dce43
Merge pull request #19821 from owncloud/GreenArchon-fix-memberof-regression
...
Revert "adjust to nested group fix
2015-10-16 13:39:57 -04:00
8a036842aa
Fix failing unit test
2015-10-16 17:36:27 +02:00
Lukas Reschke
Jenkins for ownCloud
Thomas Müller
Morris Jobke
Joas Schilling
Roeland Jago Douma
Vincent Petry
Hendrik Leppelsack
Jörn Friedrich Dreyer
Jan-Christoph Borchardt
Robin Appelman
C. Montero Luque