Commit Graph

55969 Commits

Author SHA1 Message Date
Nextcloud bot 83429cb4c0
[tx-robot] updated from transifex 2020-10-17 02:18:48 +00:00
nhirokinet 3a05334f18 manifest to report correct favicon size
In the environment where php-imagick with SVG support is correctly installed, this endpoint returns 512x512 image.
d9015a8c94/apps/theming/lib/Controller/IconController.php (L146)

The problem is in the environment without php-imagick or without SVG support, this will fall back to original, whose default is 128x128; but I thought this is a separate problem. (For this, default image may be enlarged. Should I create another issue if this is important one?)

Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
2020-10-16 15:36:56 +00:00
Morris Jobke 09501e1710
Merge pull request #23508 from nextcloud/fix/23355/iuser-expected-null-given
fixes potential passing of null to getUserGroupIds
2020-10-16 14:57:54 +02:00
Morris Jobke 4bf891f605
Merge pull request #23478 from nextcloud/fix/21059/fix-deadlock-in-scsscacher
Clear cached app config while waiting for the SCSSCache lock to return
2020-10-16 14:56:43 +02:00
Julius Härtl 4512c73293
Only retry fetching app store data once every 5 minutes in case it fails
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-16 14:32:58 +02:00
Morris Jobke cce716f9f3
Clear cached app config while waiting for the SCSSCache to finish processing the file
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 13:28:00 +02:00
Morris Jobke 1c68a6d3f6
Merge pull request #23488 from nextcloud/fix/noid/no-lock-removal-scss-cacher
SCSSCacher - Lock should not be removed
2020-10-16 13:25:23 +02:00
Arthur Schiwon fd23614c08
fixes potential passing of null to getUserGroupIds
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-10-16 12:29:35 +02:00
Julius Härtl 439e21e087
Merge pull request #23348 from nohn/gh20679
Fix #20679 - be more alert about 2FA consequences
2020-10-16 11:57:43 +02:00
Morris Jobke 9273436534
SCSSCacher - Lock should not be removed
This is within the failed lock acquiring branch. So the lock is free by another process and should not be removed because the cached file (that was created by the process having the lock) appeared on the filesystem.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 10:02:18 +02:00
Morris Jobke 2456969b41
Merge pull request #23490 from nextcloud/debug/noid/log-statements-for-scss-locking
Provide log statements for SCSS cache
2020-10-16 09:48:09 +02:00
Morris Jobke c2c077b5ae
Merge pull request #23494 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2020-10-16 09:26:56 +02:00
Christoph Wurst caa739f96e
Merge pull request #23492 from nextcloud/tests/22305/unreliable-SharedMountTest
SharedMountTest.php:367 is unreliable
2020-10-16 08:39:06 +02:00
dependabot-preview[bot] 17a2f0869b
Merge pull request #23495 from nextcloud/dependabot/composer/vimeo/psalm-3.17.2 2020-10-16 05:54:18 +00:00
Simon Spannagel 9956d13b90 CalDavBackend: check if timerange is array before accessing
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-10-16 07:50:36 +02:00
lynn-stephenson a3bdb0c4cb
Implement unit tests for versions 1 and 2.
Signed-off-by: lynn-stephenson <lynn.stephenson@protonmail.com>
2020-10-15 21:23:24 -08:00
lynn-stephenson 648b60fa0e
Derive encryption key & MAC key from a single key.
Signed-off-by: lynn-stephenson <lynn.stephenson@protonmail.com>
2020-10-15 21:23:24 -08:00
dependabot-preview[bot] 8b89aa4e64
Bump vimeo/psalm from 3.17.1 to 3.17.2
Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 3.17.1 to 3.17.2.
- [Release notes](https://github.com/vimeo/psalm/releases)
- [Commits](https://github.com/vimeo/psalm/compare/3.17.1...3.17.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-10-16 05:13:31 +00:00
Nextcloud-PR-Bot 8005fd6f19 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-10-16 04:28:48 +00:00
Nextcloud bot b13d9bcca6
[tx-robot] updated from transifex 2020-10-16 02:18:11 +00:00
Morris Jobke 512d2edc35
SharedMountTest.php:367 is unreliable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 00:36:23 +02:00
Morris Jobke 95020a4787
Merge pull request #23479 from nextcloud/techdebt/noid/typed-migration-template
Make the migration template typed
2020-10-16 00:33:50 +02:00
Morris Jobke 000c4b49f9
Merge pull request #23481 from nextcloud/enhancement/psalm-typed-event-dispatcher
Add psalm types for the event dispatcher
2020-10-16 00:32:04 +02:00
Morris Jobke e5fe3426c3
Provide log statements for SCSS cache
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-16 00:09:11 +02:00
John Molakvoæ 4bcf2ac639
Merge pull request #15999 from gary-kim/bugfix/15954/set-favicon-ico 2020-10-15 17:09:29 +02:00
Christoph Wurst b47a2730c0
Type the authentication listeners
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-15 16:43:21 +02:00
Christoph Wurst e646d7d5a9
Add psalm types for the event dispatcher
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-15 16:23:26 +02:00
Joas Schilling 600381f82a
Make the migration template typed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-10-15 16:08:50 +02:00
Morris Jobke 87f8a09ac9
Merge pull request #23464 from nextcloud/enhancement/psalm-typed-migration-schema-closure
Add psalm types for the migration schema closure
2020-10-15 13:21:44 +02:00
Christoph Wurst 65fb50f9fb
Add psalm types for the migration schema closure
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-15 10:58:51 +02:00
John Molakvoæ 20e8b266b5
Merge pull request #23448 from nextcloud/fix/sidebar-standalone
Fix app sidebar mountpoint
2020-10-15 07:46:17 +02:00
Nextcloud bot ce57372471
[tx-robot] updated from transifex 2020-10-15 02:18:25 +00:00
Gary Kim dfa17e9174
Allow setting favicon with a .ico file
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-10-14 18:19:23 -04:00
Morris Jobke 02fa6a77c3
Merge pull request #23097 from nextcloud/bugfix/noid/trashbin-query-versions
Restrict query when searching for versions of trashbin files
2020-10-14 22:50:02 +02:00
John Molakvoæ (skjnldsv) 2ead7732a7 Fix app sidebar mountpoint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-14 16:17:53 +00:00
Morris Jobke 9979b6d4e0
Merge pull request #23377 from nextcloud/enhancement/psalm-annotate-icontainer
Annotate IContainer so Psalm knows what resove and query return
2020-10-14 17:04:37 +02:00
Morris Jobke 2b36842e13
Merge pull request #23436 from nextcloud/fix/23158/remove-posix_getpwuid
Remove posix_getpwuid and compare only userid
2020-10-14 16:48:50 +02:00
Julius Härtl 2616a784c9
Restrict query when searching for versions of trashbin files
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-10-14 16:38:30 +02:00
Christoph Wurst f464ef050b
Fix type errors detected by Psalm
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-14 15:40:12 +02:00
Christoph Wurst f9f20b63f4
Annotate IContainer so Psalm knows what resove and query return
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-14 12:29:26 +02:00
Morris Jobke a41b273bcd
Merge pull request #23434 from nextcloud/dependachristoph/composer/vimeo-psalm-3.17.1
Bump vimeo/psalm from 3.15 to 3.17.1
2020-10-14 12:28:01 +02:00
Christoph Wurst 2c40d2cf45
Bump vimeo/psalm from 3.15 to 3.17.1
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-14 11:47:54 +02:00
Nextcloud bot 42fcc74b67
[tx-robot] updated from transifex 2020-10-14 02:18:46 +00:00
dependabot-preview[bot] a560c30725
Merge pull request #23155 from nextcloud/dependabot/npm_and_yarn/dompurify-2.1.1 2020-10-13 23:49:41 +00:00
dependabot-preview[bot] 12baebce29 Bump dompurify from 2.0.15 to 2.1.1
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.0.15 to 2.1.1.
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](https://github.com/cure53/DOMPurify/compare/2.0.15...2.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-13 21:43:15 +00:00
Morris Jobke 78a044900f
Merge pull request #23401 from nextcloud/techdebt/psalm-no-global
Use own psalm instead of a global one
2020-10-13 23:34:17 +02:00
Morris Jobke 106c8d719c
Do not fail on changes to baseline.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-13 21:55:37 +02:00
Nextcloud bot 55b923e1fd
[tx-robot] updated from transifex 2020-10-13 19:33:40 +00:00
Morris Jobke 0c67de3109
Merge pull request #23286 from nextcloud/design/deleted-sorting
Sort deleted files by most recently deleted first
2020-10-13 19:42:13 +02:00
blizzz 060286c51a
Merge pull request #23021 from nextcloud/notify-saved-login-auth
allow using saved login credentials for notify
2020-10-13 19:39:31 +02:00