Christoph Wurst
039ecbdcf9
Merge pull request #25560 from nextcloud/enhancement/pure-psr-event
...
Make our event base class independent of Symfony and follow PSR
2021-02-10 16:13:06 +01:00
Roeland Jago Douma
25f9203a70
Fix remaining #25359
...
As a wise man once said:
"I like PRs that pass tests before merging"
C. Wurst, Feb 9th 2021
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 15:41:25 +01:00
Christoph Wurst
2f26ff40e9
Merge pull request #25359 from nextcloud/enhancement/typed-service-registration
...
Type the service registration
2021-02-10 15:31:42 +01:00
Roeland Jago Douma
8677870a09
Merge pull request #25435 from nextcloud/fix/favorite-icon
...
Fix favorite dark icon
2021-02-10 15:19:04 +01:00
Christoph Wurst
0a28440bf6
Make our event base class independent of Symfony and follow PSR
...
Symfony is migrating towards a pure PSR event dispatcher, hence their
event class is POPO that implements the PSR stoppable event interface.
Since we can do that ourself and this change doesn't come with any API
changes (breakage), it's easy for us to become independent of Symfony
but also stay PSR-compliant at the same step.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 15:15:29 +01:00
Roeland Jago Douma
f9a4871bd4
Merge pull request #25557 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
...
[Automated] Update psalm-baseline.xml
2021-02-10 15:15:04 +01:00
Roeland Jago Douma
cc18213c98
Have psalm analysis directly on github
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-10 14:57:36 +01:00
Lukas Reschke
d42f9e65a2
Merge pull request #25554 from nextcloud/fix/pslam/tainted_cookie
...
tain-escape the cookie input
2021-02-10 12:20:49 +01:00
Christoph Wurst
aabd73912e
Type the service registration
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 09:44:24 +01:00
Christoph Wurst
f76ec25e58
Deprecate the GenericEvent wrapper
...
This class is a convenience type to replace the old Symfony GenericEvent
with our own type, to ease the transition from Symfony events to our
(PSR) events. Hence we can deprecate the class as precaution to smoothen
the next transition step in the future.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-10 08:54:08 +01:00
Nextcloud-PR-Bot
130ce14892
Update psalm baseline
...
Signed-off-by: GitHub <noreply@github.com>
2021-02-10 04:31:13 +00:00
Nextcloud bot
decb70b9ac
[tx-robot] updated from transifex
2021-02-10 02:20:59 +00:00
Roeland Jago Douma
784a752c0f
tain-escape the cookie input
...
we only set the cookie if it is a proper <=32 char alphanum string.
Otherwise we just ignore the input.
Makes psalm also happier so that we can focus on other errors.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-09 22:35:18 +01:00
Christoph Wurst
e4ca0c9fa0
Merge pull request #25548 from k00ni/pr/add-tests-for-LoginFlowV2Credentials
...
Added tests for OC\Core\Data\LoginFlowV2Credentials
2021-02-09 21:37:37 +01:00
Lukas Reschke
1fb03b3b2f
Merge pull request #25545 from k00ni/fix/Dockerfile-wrong-package-name-php7.4-acpu
...
Corrected package name used in .devcontainer/Dockerfile (php7.4-acpu => php7.4-apcu)
2021-02-09 21:26:30 +01:00
Christoph Wurst
3c2ea99940
Merge pull request #25546 from nextcloud/techdept/deprecate-event-constants
...
Deprecate all remaining event constants
2021-02-09 20:19:04 +01:00
Christoph Wurst
f96f0f6cad
Merge pull request #25543 from nextcloud/deprecate/idb-events
...
Deprecate the internal IDBConnection event name constants
2021-02-09 18:50:55 +01:00
Christoph Wurst
4201fb25d3
Merge pull request #25549 from nextcloud/remove-reconnect-wrapper
...
remove ReconnectWrapper
2021-02-09 18:15:56 +01:00
Robin Appelman
111fa47f10
remove ReconnectWrapper
...
dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 16:40:09 +01:00
Konrad Abicht
a50c615d37
simplified tests
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:48:37 +01:00
Konrad Abicht
a28705064b
fixed coding style issue
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:40:19 +01:00
Konrad Abicht
b38a619212
added tests for OC\Core\Data\LoginFlowV2Credentials
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 15:25:37 +01:00
Roeland Jago Douma
f797a94393
Merge pull request #25531 from nextcloud/fix/dispatcher-argument-order
...
Fix the legacy dispatcher argument order
2021-02-09 14:39:12 +01:00
Christoph Wurst
4c6bc62f38
Merge pull request #25535 from nextcloud/query-exception-foreward
...
Improve exception when auto-wiring fails
2021-02-09 14:27:43 +01:00
Christoph Wurst
4fc0b2c639
Deprecate all remaining event constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 13:53:41 +01:00
Konrad Abicht
f987eaea10
corrected package name used in .devcontainer/Dockerfile (php7.4-acpu => php7.4-apcu)
...
Signed-off-by: Konrad Abicht <hi@inspirito.de>
2021-02-09 13:52:52 +01:00
Roeland Jago Douma
a36186980d
Merge pull request #25542 from nextcloud/fix-file-checker
...
Add .devcontainer to file-checker.php
2021-02-09 13:20:10 +01:00
Robin Appelman
ec875227ec
forward query exception when fallback construction fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 13:15:22 +01:00
Christoph Wurst
3d075c370a
Deprecate the internal IDBConnection event name constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 11:27:59 +01:00
Lukas Reschke
d4c718acad
Add .devcontainer to file-checker.php
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-02-09 11:22:29 +01:00
Christoph Wurst
abc61a9f63
Fix the legacy dispatcher argument order
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 10:47:14 +01:00
Nextcloud bot
9eea1e56dc
[tx-robot] updated from transifex
2021-02-09 02:20:45 +00:00
Roeland Jago Douma
983f7f3e49
Merge pull request #25493 from Worteks/fix-filessharing-debug
...
fix(log): remove debug log in _formatRemoteShare, suggested by @maxbes
2021-02-08 21:40:05 +01:00
Roeland Jago Douma
4854f91d94
Merge pull request #25423 from nextcloud/codespace
...
Add support for Codespaces
2021-02-08 21:27:02 +01:00
Robin Appelman
3401be216d
forward original query exception when querying by name fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-08 19:13:25 +01:00
Lukas Reschke
838c7005d3
Install more PHP modules by default
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-02-08 17:16:29 +00:00
Lukas Reschke
b68ff8df64
Hard-code SMTP configuration
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-02-08 17:08:42 +00:00
Lukas Reschke
7f983cc549
Add initial support for GitHub codespaces
...
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-02-08 16:55:01 +00:00
Nextcloud bot
26a20ed13f
[tx-robot] updated from transifex
2021-02-08 02:20:05 +00:00
dependabot-preview[bot]
4c0ad08084
Merge pull request #25517 from nextcloud/dependabot/npm_and_yarn/babel/preset-env-7.12.13
2021-02-07 12:05:36 +00:00
dependabot-preview[bot]
a21a8adb2b
Bump @babel/preset-env from 7.12.11 to 7.12.13
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.12.11 to 7.12.13.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.12.13/packages/babel-preset-env )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-07 11:36:26 +00:00
Samuel
69df6c41de
fix(ci): build additionalScripts
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-07 11:06:11 +01:00
dependabot-preview[bot]
9e1a3a1447
Merge pull request #25516 from nextcloud/dependabot/npm_and_yarn/css-vars-ponyfill-2.4.3
2021-02-07 09:38:42 +00:00
dependabot-preview[bot]
2d4e33da83
Bump css-vars-ponyfill from 2.4.2 to 2.4.3
...
Bumps [css-vars-ponyfill](https://github.com/jhildenbiddle/css-vars-ponyfill ) from 2.4.2 to 2.4.3.
- [Release notes](https://github.com/jhildenbiddle/css-vars-ponyfill/releases )
- [Changelog](https://github.com/jhildenbiddle/css-vars-ponyfill/blob/master/CHANGELOG.md )
- [Commits](https://github.com/jhildenbiddle/css-vars-ponyfill/compare/v2.4.2...v2.4.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-07 09:11:00 +00:00
Nextcloud bot
f19287ae57
[tx-robot] updated from transifex
2021-02-07 02:20:51 +00:00
Joas Schilling
98032425b4
Fix linter
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
Joas Schilling
86109f77e0
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
Joas Schilling
ef7ed47f14
Make Psalm happy
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
Joas Schilling
1344c61145
Improve mention matches
...
The previous regex didn't correctly match users with . ' or -
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:05 +01:00
Roeland Jago Douma
cd77b1f238
Merge pull request #25499 from nextcloud/test/symfony-adapter
...
Test the symfony adapter / fix missing return object
2021-02-06 13:01:23 +01:00