Commit Graph

22395 Commits

Author SHA1 Message Date
Roeland Jago Douma d12e379c96
Merge pull request #21128 from nextcloud/backport/21123/stable19
[stable19] simplify getGroups, fixing wrong chunking logic
2020-05-28 14:59:50 +02:00
Arthur Schiwon 1e5295138a simplify getGroups, fixing wrong chunking logic
pagination is taken care of properly in the search logic in Access class

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-27 17:38:45 +00:00
Christoph Wurst 14b618bcaf
Fix devices & sessions sanitization
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-05-27 15:57:18 +02:00
Arthur Schiwon 557a3754c1 use the loginname to verify the old password in user password changes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 19:20:42 +00:00
Arthur Schiwon d0559a4871 fixes infinitely repeating LDPA search results with PHP <= 7.2
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 09:56:10 +00:00
Morris Jobke 138eddc0f1
Merge pull request #21028 from nextcloud/backport/20629/stable19
[stable19] Don't load text file preview when text app is available (Fixes: #20615)
2020-05-20 13:54:17 +02:00
Julius Härtl dd15780edd Fix share update test
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-05-18 13:47:39 +00:00
Roeland Jago Douma aac0dd1f20 Have share permissions on link shares if it is enabled
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-18 13:47:38 +00:00
Jonas Meurer be37ca1776 Don't load text file preview when text app is available (Fixes: #20615)
When opening a shared text document, the files_sharing app uses
internal preview support in case no other app to open the text file is
available.

So far, it only checks for the old files_texteditor app, not for the new
new text app. This commit fixes this by checking for both.

Signed-off-by: Jonas Meurer <jonas@freesources.org>
2020-05-18 08:59:53 +00:00
Robin Appelman ffc3b48a40 update icewind/smb to 3.2.4
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-15 12:35:22 +00:00
John Molakvoæ 4bde23d239
Merge pull request #20878 from nextcloud/backport/20719/stable19 2020-05-11 14:55:16 +02:00
Georg Ehrke e048bf8550 Rename app-generated to z-app-generated, because macOS Contacts supports only one and will pick the first one alphabetically
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:56 +00:00
Georg Ehrke d1909526fc Implement ctag and etag in ContactsInteraction
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:55 +00:00
GretaD adbdecb1d6 Fix languages empty array
Signed-off-by: GretaD <gretadoci@gmail.com>
2020-05-08 09:25:59 +00:00
John Molakvoæ (skjnldsv) 90a65f83e0 Do not process the same FileInfo twice
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-08 05:39:53 +00:00
Robin Appelman 614acc9419
add locking to resolve concurent move to trashbin conflicts
uses a lock to prevent two requests from moving a file to the trashbin concurrently
(causing sql duplicate key errors)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-06 20:36:55 +02:00
Morris Jobke 06732cf2af
Merge pull request #20832 from nextcloud/fix/sharing-filter-user-shares-only-fix-group-display
Do not filter id matching userId on non-user-share shares
2020-05-06 17:46:21 +02:00
Nextcloud bot 3bf4e7d673
[tx-robot] updated from transifex 2020-05-06 02:16:28 +00:00
John Molakvoæ (skjnldsv) a26ca1e638
Do not filter id matching userId on non-user-share shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 21:36:46 +02:00
John Molakvoæ (skjnldsv) edecd0931e Fix filtering our owner & current user from shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-05 10:28:33 +00:00
Nextcloud bot 09d7854d0e
[tx-robot] updated from transifex 2020-05-05 02:16:14 +00:00
John Molakvoæ (skjnldsv) ff20da637e Fix federated link sharing permissions
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-04 11:48:11 +00:00
Morris Jobke 6aceb39714
Merge pull request #19124 from nextcloud/bug/13647/ignore-delete-groups
Exclude groups from sharing: Skip delete groups
2020-05-04 10:02:32 +02:00
Nextcloud bot 43fefee847
[tx-robot] updated from transifex 2020-05-04 02:16:18 +00:00
Nextcloud bot d2f165e448
[tx-robot] updated from transifex 2020-05-03 02:16:16 +00:00
Gary Kim 8dd23f9854
Fix expiry datepicker allowing all dates
vue2-datepicker expects a `disabled-date` function
rather than `not-before` and `not-after` dates.

This commit updates it so that we now provide
vue2-datepicker with a `disabled-date` function.

Signed-off-by: Gary Kim <gary@garykim.dev>
2020-05-02 18:58:41 +08:00
Nextcloud bot e77e0b0e2f
[tx-robot] updated from transifex 2020-05-02 02:16:32 +00:00
John Molakvoæ (skjnldsv) 31172a0cd9 Process shares only once, better debug and expiration date code
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-01 13:39:57 +00:00
Roeland Jago Douma b7b7b2872c
Fix owner on publicownerwrapper
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-01 10:50:26 +02:00
Roeland Jago Douma c724eb24d5
Merge pull request #20380 from nextcloud/design/notification-mails
Fix design and layout of notification mails
2020-05-01 08:53:39 +02:00
Roeland Jago Douma da9ad9ec78
Merge pull request #20291 from nextcloud/fix/user_menu_not_focused
Fix focus for user actionmenu
2020-05-01 08:42:06 +02:00
Nextcloud bot 9f448d864b
[tx-robot] updated from transifex 2020-05-01 02:16:47 +00:00
Jan-Christoph Borchardt e981669e89
Fix notification mail tests
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-05-01 03:00:42 +02:00
GretaD 9b1f98f6fd Fix the keyboard tab for actionmenu
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-30 19:03:56 +00:00
Roeland Jago Douma b2b8be83f8
Merge pull request #20538 from nextcloud/fix/20520/share-expire
Fix share expiration date not shown
2020-04-30 20:55:05 +02:00
Jan-Christoph Borchardt ae665e2175
Merge pull request #20744 from nextcloud/fix/public-design
Fix public layout header title & description
2020-04-30 19:02:32 +02:00
Gary Kim 02b5ded840
Fix share expiration date not shown
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-30 22:35:52 +08:00
Morris Jobke 0f9b88c5a9
Merge pull request #20718 from nextcloud/fix/public_share_owner_activity_mess
Add a wrapper to fall back to the share owner on public shares
2020-04-30 13:46:13 +02:00
John Molakvoæ (skjnldsv) 6e79fb60d8
Fix public layout header title & description
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-30 13:32:28 +02:00
Joas Schilling 5b5550dbba
Merge pull request #20677 from nextcloud/followup/17718/scaling-user-provisioning
Scaling user provisioning for subadmins with many groups
2020-04-30 12:49:57 +02:00
Roeland Jago Douma b8b53a2d9a
Merge pull request #19436 from nextcloud/bugfix/noid/dav-quota-calculation
Do not include mountpoints when calculating quota usage on WebDAV
2020-04-30 09:13:19 +02:00
Roeland Jago Douma a1f3293c06
Merge pull request #19039 from nextcloud/dav-activity-provide-links-to-calendar
Provide links to calendar in event creation/update activities
2020-04-30 09:10:56 +02:00
Roeland Jago Douma bc66bdc072
Add a wrapper to fall back to the share owner on public shares
Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-30 08:57:01 +02:00
Roeland Jago Douma 2df57b270c
Merge pull request #20720 from nextcloud/bugfix/noid/temporary-fix-contacts-search
Temporary fix contacts search
2020-04-30 08:52:50 +02:00
Nextcloud bot 523a8ba5c3
[tx-robot] updated from transifex 2020-04-30 02:17:11 +00:00
Roeland Jago Douma d466a7b808 Allow to navigate to others with access from the sidebar
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 17:53:35 +00:00
Joas Schilling f662d3663b
Temporary fix contacts search
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-29 14:48:41 +02:00
Christoph Wurst b219eadb8f
Merge pull request #20714 from nextcloud/fix/license-headers-19
Update license headers for 19
2020-04-29 14:24:27 +02:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
dependabot-preview[bot] 08296c04c0 Bump webpack from 4.42.1 to 4.43.0
Bumps [webpack](https://github.com/webpack/webpack) from 4.42.1 to 4.43.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](https://github.com/webpack/webpack/compare/v4.42.1...v4.43.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-29 09:23:51 +00:00
Nextcloud bot 297276baba
[tx-robot] updated from transifex 2020-04-29 02:16:55 +00:00
Morris Jobke 192cf12440
Merge pull request #20636 from nextcloud/tests/noid/tests-for-update-notifications-controller
Add tests for update notification controller for non-default updater …
2020-04-28 16:18:18 +02:00
Morris Jobke 773e9d0554
Add tests for update notification controller for non-default updater server URL
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-04-28 15:28:47 +02:00
blizzz 0c701cec56
Merge pull request #20676 from clementhk/ldap-group
Don't remove last user in ldap group when limit is -1
2020-04-28 12:58:02 +02:00
Roeland Jago Douma c69686a29d
Merge pull request #20673 from nextcloud/enh/tweaks-app-data-scan
Set exit code if something went wrong.
2020-04-28 12:04:25 +02:00
Nextcloud bot ef566a1f40
[tx-robot] updated from transifex 2020-04-28 02:16:22 +00:00
Morris Jobke 31ebc827f7
Merge pull request #20558 from nextcloud/dependabot/npm_and_yarn/vue-click-outside-1.1.0
Bump vue-click-outside from 1.0.7 to 1.1.0
2020-04-27 11:08:21 +02:00
Morris Jobke 1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare
Fix resharing of federated shares that were created out of links
2020-04-27 11:05:34 +02:00
Morris Jobke 3c5c4caa4d
Merge pull request #20632 from nextcloud/bugfix/20624
Only catch anonymous OPTIONS for Office
2020-04-27 10:38:32 +02:00
Nextcloud bot e56ffe5992
[tx-robot] updated from transifex 2020-04-27 02:16:13 +00:00
Clement Wong 9f5f505acf Don't remove last user in ldap group when limit is -1
Signed-off-by: Clement Wong <git@clement.hk>
2020-04-27 02:33:00 +02:00
Daniel Kesselberg 3294f53942
Set exit code if something went wrong.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-26 20:37:21 +02:00
Thomas Citharel deb2ea9cea
Provide links to calendar in event creation/update activities
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-26 11:11:50 +02:00
Nextcloud bot 0eeb660679
[tx-robot] updated from transifex 2020-04-26 02:16:12 +00:00
Mikael Hammarin 6ffde74928
Patch to optimize for large installations (>5000 users >20000 groups) where subadmins have access to many of groups (>250)
- UsersController:editUser() calls isUserAccessible() even if the user is admin

This fix reduces API calls to editUser (ex change locale/display name) from >2 minutes (!) to ~3 seconds per call in average.

Signed-off-by: Mikael Hammarin <mikael@try2.se>
2020-04-25 14:37:46 +02:00
Nextcloud bot 39f6f1ba34
[tx-robot] updated from transifex 2020-04-25 02:16:01 +00:00
Julius Härtl 902d12555e
Do not include mountpoints when calculating quota usage on WebDAV
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 18:15:43 +02:00
Daniel Kesselberg 16f29d81bf
Ignore delete groups
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-24 18:10:02 +02:00
dependabot-preview[bot] dc46743ef5 Bump vue-click-outside from 1.0.7 to 1.1.0
Bumps [vue-click-outside](https://github.com/vue-bulma/click-outside) from 1.0.7 to 1.1.0.
- [Release notes](https://github.com/vue-bulma/click-outside/releases)
- [Commits](https://github.com/vue-bulma/click-outside/commits/v1.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-24 14:58:19 +00:00
Roeland Jago Douma 768b012000
Merge pull request #20570 from nextcloud/fix/20235/use_uploadfile
Use a proper upload file so propfinds return 404
2020-04-24 16:31:38 +02:00
Roeland Jago Douma 4114bce1e5
Merge pull request #17623 from j3l11234/master
Add support for download share on old android browser
2020-04-24 16:01:45 +02:00
Julius Härtl d7161b4eee
Only catch anonymous OPTIONS for Office
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 14:46:07 +02:00
Roeland Jago Douma 8c07b6e07a
Merge pull request #20626 from nextcloud/enh/scan-appdata-folder-arg
Add folder argument to files:scan-app-data
2020-04-24 13:07:17 +02:00
blizzz 212138daa1
Merge pull request #19919 from nextcloud/enh/noid/ldpa_group_perf
LDAP Group Backend optimizations
2020-04-24 12:27:27 +02:00
Nextcloud bot 84a3536159
[tx-robot] updated from transifex 2020-04-24 02:27:55 +00:00
blizzz 038045d55e
Merge pull request #18816 from nextcloud/bugfix/noid/paginate-contacts-search
Use paginated search for contacts
2020-04-23 22:20:58 +02:00
Arthur Schiwon 4babdc082b
formatting
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-23 21:34:05 +02:00
Julius Härtl 6709833dc7
Use paginated search for contacts
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 19:08:16 +02:00
blizzz 24e58947d6
Merge pull request #20618 from nextcloud/bugfix/noid/fix-workflow-ui
Fix workflow UI
2020-04-23 17:16:33 +02:00
Joas Schilling 335b1f15f3
Fix workflow UI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-23 13:52:04 +02:00
Robin Appelman 7a4ea4a6b6
make php-cs happy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-23 13:35:30 +02:00
Nextcloud bot 79e3823d72
[tx-robot] updated from transifex 2020-04-23 02:16:54 +00:00
blizzz 4a8871f5f2
Merge pull request #19399 from nextcloud/smb-read-acl
Add option to check share ACL's when listing directories
2020-04-22 23:16:12 +02:00
Roeland Jago Douma 8c5bb22bc1
Merge pull request #20576 from nextcloud/fix/dav/oc-etag
Make sure that OC-ETag is set again
2020-04-22 22:21:22 +02:00
John Molakvoæ d0a57a33a9
Merge pull request #20595 from nextcloud/fix/ie11-fallback-upload
Fix IE11 upload fallback methods
2020-04-22 22:06:56 +02:00
Morris Jobke f0ad46dec8
Merge pull request #20575 from nextcloud/fix/sharing-suggestions
Fix Sharing recommendation user display
2020-04-22 14:56:01 +02:00
Roeland Jago Douma acdc68e1e2
Merge pull request #20591 from nextcloud/fix/settings
Fix settings routing
2020-04-22 14:45:25 +02:00
Robin Appelman 7f32fe6d50
add tooltip to option
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-22 14:25:33 +02:00
John Molakvoæ (skjnldsv) 754fd40e40
Fix IE11 upload fallback methods
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-04-22 13:40:23 +02:00
Morris Jobke 8ffa762486
Merge pull request #20536 from nextcloud/fix/noid/ldap-73api-read-wo-pagedresults
do not run paged results against ldap_read ops on PHP7.3+
2020-04-22 13:37:43 +02:00
Roeland Jago Douma e983ae3b06
Add folder argument to files:scan-app-data
If you need to rescan something but don't feel like rescanning your
whole preview stash.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-22 13:27:33 +02:00
Roeland Jago Douma c870b6ab2e
Fix new routing in settings etc
Also prefix resources
Unify the prefix handling
Handle urls with and without slash

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-22 13:09:25 +02:00
Nextcloud bot ac57bbcf99
[tx-robot] updated from transifex 2020-04-22 02:17:06 +00:00
Robin Appelman 23e2baeb95
Add option to check share ACL's when listing directories
If a file or folder in a directory doesn't have read permissions they
will not be shown

Note that enabling this option incurs a performance penalty additional
requests need to be made to get all the acl.

Additionally the acl resolving logic is fairly primitive at the moment
and might not work correctly in all setups (it should error to showing
the entry)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-21 16:26:12 +02:00
Roeland Jago Douma 8f650feede
Merge pull request #20114 from nextcloud/techdebt/noid/allow-some-apps-to-have-root-urls
Allow some apps to have root URLs in their own routing file
2020-04-21 16:00:34 +02:00
Arthur Schiwon 75c686d825
do not run paged results against ldap_read ops on PHP7.3+
- previously it was needed as the PHP LDAP handling of paged results was
strange
- but now the read operation would fail, e.g. with extra home dir attribute
set ("Home dir attribute can't be read from LDAP for uid: foobar"

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-21 15:47:49 +02:00
Julius Härtl 5646f7c761
Link shares have reshare permission if outgoing federated shares are enabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-21 14:35:29 +02:00
Julius Härtl 45c3ee7f36
Set proper share type when converting link shares to federated shares
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-21 14:35:28 +02:00
Daniel Kesselberg 0e925285b7
Add test that shares and tags are ignored for chunk files.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-21 14:00:52 +02:00
Roeland Jago Douma aa79f9ada2
Merge pull request #20577 from nextcloud/bugfix/noid/sabre4_aftermethod
Fix usages of afterMethod -> afterMethod:*
2020-04-21 13:26:13 +02:00