e30271be4f
Respect additional user settings not covered by the controller
...
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.
Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).
This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:10 +02:00
c130b88004
Add more unit tests for setting user settings
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:09 +02:00
f2e40238a6
Change default test data to values less similar to empty values
...
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:08 +02:00
5a497841be
Extract default test data to a helper getter
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:07 +02:00
eaedf5fcd9
Use constants from interface rather than class
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:07 +02:00
739504bd10
[tx-robot] updated from transifex
2021-04-23 02:26:44 +00:00
f43c25dfe3
[tx-robot] updated from transifex
2021-04-22 02:26:53 +00:00
5262bb97f7
Continue iterating over diretory contents and just hide file if denied by acl
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-21 07:24:13 +00:00
e73034b95b
[tx-robot] updated from transifex
2021-04-21 02:26:35 +00:00
3dac09a9d7
Make lookup search explicit
...
Speedsup sharee lookup quite a bit.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 08:39:32 +00:00
6259ba779e
Merge pull request #26638 from nextcloud/backport/26615/stable19
...
[stable19] Require read permissions for federated shares
2021-04-20 09:06:46 +02:00
16eed4a1ba
[tx-robot] updated from transifex
2021-04-20 02:26:29 +00:00
46823e8f68
Require read permissions for federated shares
...
Else they end up as weird shares that can't be properly utilized by
other parties anyway.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 19:56:14 +00:00
d9f06c1792
cast ints
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-19 14:49:05 +00:00
f8346f43f1
handle the cache where a cache entry with the correct path has already been recreated
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-19 14:49:04 +00:00
0e790dad31
also repair storage id
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-19 14:49:02 +00:00
de2ad46c3c
add command to repair broken filesystem trees
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-19 14:49:01 +00:00
95c65f756e
Do not allow adding file drop shares to your own cloud
...
There is no reason for this and you can't create such shares normally
anyway.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 13:03:04 +00:00
69d60cbcaa
[tx-robot] updated from transifex
2021-04-19 02:26:35 +00:00
6b7f09eacb
[tx-robot] updated from transifex
2021-04-18 02:24:37 +00:00
e5b67bfdb7
[tx-robot] updated from transifex
2021-04-17 02:24:35 +00:00
09a5cb1495
[tx-robot] updated from transifex
2021-04-16 02:26:22 +00:00
46686de607
[tx-robot] updated from transifex
2021-04-15 02:25:40 +00:00
f988edd5f7
[tx-robot] updated from transifex
2021-04-14 02:27:20 +00:00
cd76cc773d
[tx-robot] updated from transifex
2021-04-13 02:25:25 +00:00
5a2de59a8f
l10n: Add word user in FederatedShareProvider.php
...
Standardizing text strings with other Nextcloud applications.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-12 06:46:50 +00:00
3e8bf30005
[tx-robot] updated from transifex
2021-04-12 02:25:25 +00:00
0aed70e0db
[tx-robot] updated from transifex
2021-04-11 02:25:11 +00:00
08c65167f4
[tx-robot] updated from transifex
2021-04-10 02:31:40 +00:00
2843b84b43
[tx-robot] updated from transifex
2021-04-09 02:25:36 +00:00
26dea5d023
[tx-robot] updated from transifex
2021-04-08 02:24:31 +00:00
f29f06febd
[tx-robot] updated from transifex
2021-04-07 02:24:43 +00:00
6cbf84784a
[tx-robot] updated from transifex
2021-04-06 02:25:58 +00:00
c516405fe1
[tx-robot] updated from transifex
2021-04-05 02:25:12 +00:00
9b6cf09a8e
[tx-robot] updated from transifex
2021-04-04 02:25:14 +00:00
c9c3631428
[tx-robot] updated from transifex
2021-04-03 02:44:03 +00:00
d702c66a9d
[tx-robot] updated from transifex
2021-04-02 02:26:32 +00:00
f75e7e7b54
Show the actual error on share requests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:04:41 +02:00
bfe4a84ca7
[tx-robot] updated from transifex
2021-04-01 02:25:09 +00:00
e929afd4e8
[tx-robot] updated from transifex
2021-03-31 02:25:18 +00:00
acafb8838d
[tx-robot] updated from transifex
2021-03-30 02:24:48 +00:00
9bfbf3ff7c
[tx-robot] updated from transifex
2021-03-29 02:24:26 +00:00
2a7a9b80a0
[tx-robot] updated from transifex
2021-03-28 02:24:31 +00:00
4e96d9a63a
[tx-robot] updated from transifex
2021-03-27 02:24:55 +00:00
0e88470b75
Delete old birthday calendar object when moving contact to another address book
...
When an contact is moved to another address book, the contact is copied to
the second address book.
During copying, the birthday event is created - but it gets the same UID
as the contact's birthday event in the first address book.
To prevent the "Calendar object with uid already exists" error that followed,
we need to delete the old entry before the new one is created.
Resolves: https://github.com/nextcloud/server/issues/20492
Signed-off-by: Christian Weiske <cweiske@cweiske.de>
2021-03-26 07:22:56 +00:00
5c737b73af
Merge pull request #26296 from nextcloud/backport/26287/stable19
...
[stable19] Fix l10n
2021-03-26 08:09:07 +01:00
79a5ba1992
[tx-robot] updated from transifex
2021-03-26 02:26:01 +00:00
8771e7c98c
Fix l10n
...
Issue: #26286
2021-03-25 12:58:43 +00:00
7ae4b6b0aa
[tx-robot] updated from transifex
2021-03-25 02:26:05 +00:00
e14cb5a20b
l10n: Separate ellipsis
...
Unifying the text string with the others.
2021-03-24 13:26:46 +00:00
eeea77112e
[tx-robot] updated from transifex
2021-03-24 02:25:33 +00:00
bc5e51af7e
[tx-robot] updated from transifex
2021-03-23 02:24:33 +00:00
175d1d35ba
l10n: Add changes to text string for user
2021-03-22 10:30:57 +00:00
01f84ddd13
l10n: Add word user in ShareByMailProvider.php
...
Standardizing text strings with other Nextcloud applications.
2021-03-22 10:30:56 +00:00
6365e59aa9
[tx-robot] updated from transifex
2021-03-22 02:24:13 +00:00
def34fbfce
[tx-robot] updated from transifex
2021-03-21 02:23:36 +00:00
9b23da22c0
Merge pull request #26216 from nextcloud/backport/26145/stable19
...
[stable19] add (hidden) option to always show smb root as writable
2021-03-20 10:53:45 +01:00
a4d6201d7e
[tx-robot] updated from transifex
2021-03-20 02:24:08 +00:00
ec0ca19deb
add (hidden) option to always show smb root as writable
...
some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't.
This works around the problem by adding a hidden option to overwrite the permissions of the root of the share.
This can be enabled using
```bash
occ files_external:config <mount id> root_force_writable true
```
where you can find your mount id using
```bash
occ files_external:list
```
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-19 15:47:09 +00:00
8670ef707f
[tx-robot] updated from transifex
2021-03-19 02:25:21 +00:00
05cbdddb0d
Fix valid storages removed when cleaning remote storages
...
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.
The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.
Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-18 08:02:28 +00:00
0e30c82f30
[tx-robot] updated from transifex
2021-03-18 02:25:29 +00:00
10b024642f
Use correct exception type hint in catch statement
...
Found by psalm update 4.6.2 to 4.6.3 in #26111
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-17 08:49:42 +00:00
709788e08f
[tx-robot] updated from transifex
2021-03-17 02:24:47 +00:00
b9b2c6d2fa
fix search in nested jails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:27:00 +01:00
f9c9e27e46
Merge pull request #26129 from nextcloud/backport/26115/stable19
...
[stable19] Log exceptions when creating share
2021-03-16 11:09:15 +01:00
95b55423e8
[tx-robot] updated from transifex
2021-03-16 02:25:09 +00:00
e43c93881e
Log exceptions when creating share
...
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.
In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 15:06:34 +00:00
3ac0601e26
Merge pull request #26060 from nextcloud/backport/25911/stable19
...
[stable19] Only clear share password model when actually saved
2021-03-15 09:48:23 +01:00
901472a899
[tx-robot] updated from transifex
2021-03-15 02:24:26 +00:00
bbb616a604
[tx-robot] updated from transifex
2021-03-14 02:24:05 +00:00
2a955bf864
[tx-robot] updated from transifex
2021-03-13 02:23:21 +00:00
20c16e21c2
Only clear share password model when actually saved
...
Instead of always clearing the password in the share model, now only do
it when it was actually saved.
Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-12 12:23:36 +01:00
54affce466
[tx-robot] updated from transifex
2021-03-12 02:23:09 +00:00
586cbde4ba
Merge pull request #26041 from nextcloud/backport/25916/stable19
...
[stable19] Remove trash items from other trash backends when deleting all
2021-03-11 10:34:44 +01:00
c750417f19
[tx-robot] updated from transifex
2021-03-11 02:23:35 +00:00
0a7a401f95
Merge pull request #26028 from nextcloud/backport/25933/stable19
...
[stable19] Hide expiration date field for remote shares
2021-03-10 15:46:47 +01:00
6e394ac9d6
Hide expiration date field for remote shares
...
Remote shares currently do not support expiration date.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 08:45:54 +00:00
37b161b526
Remove trash items from other trash backends when deleting all
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-10 08:05:03 +00:00
efcc3dd99f
[tx-robot] updated from transifex
2021-03-10 02:23:25 +00:00
6db532444f
[tx-robot] updated from transifex
2021-03-09 02:24:20 +00:00
ad8a1bcc12
[tx-robot] updated from transifex
2021-03-08 02:23:37 +00:00
82244f1466
[tx-robot] updated from transifex
2021-03-07 02:22:31 +00:00
e73ea889ab
Merge pull request #25957 from nextcloud/backport/25932/stable19
...
[stable19] Skip empty obsolete owner when adding to own NC
2021-03-06 10:54:10 +01:00
3bf923ec55
[tx-robot] updated from transifex
2021-03-06 02:22:48 +00:00
f21e25182b
Skip empty obsolete owner when adding to own NC
...
The owner field is nowadays always empty when adding a federated share
using "Add to your Nextcloud", so don't check for it.
Fixes an issue where "Add to your Nextcloud" doesn't add anything.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-05 13:40:41 +00:00
bcb840ce04
Merge pull request #25845 from nextcloud/backport/25757/stable19
...
[stable19] fix detecting cyclic group memberships
2021-03-05 08:43:35 +01:00
8d9d540257
[tx-robot] updated from transifex
2021-03-05 02:22:23 +00:00
18ba1854db
[tx-robot] updated from transifex
2021-03-04 02:22:39 +00:00
7afb588059
fix detecting cyclic group memberships
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-03 10:53:24 +01:00
4a111afc8d
Merge pull request #25901 from nextcloud/backport/25860/stable19
...
[stable19] do not die after LDAP auth failed with expired acc
2021-03-03 08:35:21 +01:00
7d5f7cef93
[tx-robot] updated from transifex
2021-03-03 02:21:51 +00:00
4b3961c412
do not die after LDAP auth failed with expired acc
...
- some servers return error code 53
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-02 20:40:11 +00:00
3177ab8ba9
Merge pull request #25859 from nextcloud/backport/25856/stable19
...
[stable19] Card::getOwner should return the actual value
2021-03-02 09:20:34 +01:00
47bb51cfeb
[tx-robot] updated from transifex
2021-03-02 02:22:49 +00:00
6baad31815
Card::getOwner should return the actual value
...
I guess we never call this at runtime or it would already ahve done boom
very loudly.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 17:33:17 +00:00
a00eff8372
Merge pull request #25741 from nextcloud/backport/25602/stable19
...
[stable19] Avoid creating two share links when password is enforced
2021-03-01 12:49:12 +01:00
832374d4fe
Avoid creating two share links when password is enforced
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-01 10:00:57 +01:00
b9d417f812
[tx-robot] updated from transifex
2021-03-01 02:20:45 +00:00
be671e390e
[tx-robot] updated from transifex
2021-02-28 02:20:20 +00:00
Daniel Calviño Sánchez
Nextcloud bot
Julius Härtl
Roeland Jago Douma
Morris Jobke
Robin Appelman
Valdnet
Christian Weiske
John Molakvoæ
Roeland Jago Douma
Christoph Wurst
Vincent Petry
Arthur Schiwon
kesselb