68fa9a4f54
Merge pull request #25389 from nextcloud/backport/25302/stable19
...
[stable19] Use RFC-compliant URL encoding for cookies
2021-02-09 22:07:45 +01:00
09f16281a2
revert(comment)
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 15:23:18 +00:00
d494c6650c
revert(exception): keep throwing an exception for now
...
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 15:23:16 +00:00
038def2328
fix(translation): replace static error message
...
as suggested by @kesselb in nextcloud/server#25490
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 15:23:14 +00:00
c5d2ea84e6
Use RFC-compliant URL encoding for cookies
...
PHP 7.4.2 changed the way how cookies are decoded, applying RFC-compliant raw URL decoding. This leads to a conflict Nextcloud's own cookie encoding, breaking the remember-me function if the UID contains a space character.
Fixes #24438
Signed-off-by: Marco Ziech <marco@ziech.net>
2021-01-29 12:42:14 +00:00
6fa08f38b3
The objectid is a string
...
This allows the query to use the index. Else it has to resort on
scanning all the rows.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-29 07:17:41 +00:00
a4c7a62394
Merge pull request #25121 from nextcloud/backport/25036/stable19
...
[stable19] respect DB restrictions on number of arguments in statements and queries
2021-01-28 12:27:52 +01:00
1de3cfd049
Don't log keys on checkSignature
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 21:28:32 +00:00
b78ed6ea3f
CI satisfaction
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-15 00:53:48 +01:00
83b0b84c1f
DB: warn on parameter number constraints
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-15 00:53:37 +01:00
16850b940f
Make sure to do priority app upgrades first
...
Otherwise those apps might not be loaded when the others app migrations
are running. The previous loading of authentication apps in the upgrade
step never worked as it just returns in maintenance mode
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-11 13:49:12 +00:00
57e165c244
Merge pull request #24593 from nextcloud/backport/23912/stable19
...
[stable19] use in objectstore copy
2021-01-07 13:28:38 +01:00
3f8024932a
Merge pull request #24962 from nextcloud/backport/24683/stable19
...
[stable19] [Fix #24682 ]: ensure federation cloud id is retruned if FN property not found
2021-01-07 09:41:40 +01:00
d77b3345b2
Show unique displayname context in the sharing input
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-05 10:06:32 +01:00
db048845ef
[ Fix #24682 ]: ensure federation cloud id is retruned if FN property not found
...
Signed-off-by: Guillaume Virlet <github@virlet.org>
2021-01-05 08:27:31 +00:00
7d282a4e88
Avoid huge exception argument logging
...
In some cases it might happen that you have an argument that deep down
somewhere has an array with a lot of entries (think thousands). Now
before we would just happily print them all. Which would fill the log.
Now it will just print the first 5. And add a line that there are N
more.
If you are on debug level we will still print them all.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-29 10:46:54 +00:00
ae49423991
Actually set the TTL on redis set
...
Else well the keys remain for ever and ever.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-21 13:53:42 +00:00
dedff0facb
use in objectstore copy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-07 16:07:25 +00:00
ec270ce35e
Fix typo
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-04 15:56:38 +00:00
a5951d0d79
Remember me is not an app_password
...
While technically they are stored the same. This session variable is
used to indicate that a user is using an app password to authenticate.
Like from a client. Or when having it generated automatically.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-04 15:56:32 +00:00
ca917c59e1
Generate a new session id if the decrypting the session data fails
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-04 11:58:13 +00:00
bf9888870c
Fix vsprint parameter
...
%2\$; is not valid. On php7 this is just ignored but on php8 it gives an
error. %2\$s; works.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-12-03 08:20:06 +00:00
349f754833
Fix file size computation on 32bit platforms
...
Signed-off-by: aler9 <46489434+aler9@users.noreply.github.com>
2020-12-02 15:27:22 +00:00
21defabc41
Merge pull request #24327 from nextcloud/backport/24103/stable19
...
[stable19] Only check path for being accessible when the storage is a object home
2020-12-01 11:04:09 +01:00
6d6382a55d
Merge pull request #24354 from nextcloud/backport/24162/stable19
...
[stable19] set the display name of federated sharees from addressbook
2020-11-25 16:18:12 +01:00
29a452c693
send expected format of cloud id
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-25 14:32:30 +01:00
10a252c905
set the display name of federated sharees from addressbook
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-11-25 14:32:06 +01:00
aecf4eff27
Extra white space to follow other ifs
...
Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
2020-11-25 11:55:16 +00:00
43e401e3a2
Avoid substr() error when strpos returns false
...
"Exception: substr() expects parameter 3 to be int, bool given" can occur on Line 378 $mimePart = substr($icon, 0, strpos($icon, '-'));
This happens, when '-' is not found and strpos returns false instead of an int.
When this occurs, e.g., Activity hangs.
Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
2020-11-25 11:55:15 +00:00
49299ed1c1
Fix the config key on the sharing expire checkbox
...
We don't use `shareapi_internal_enforce_expire_date` anywhere.
`shareapi_enforce_internal_expire_date` is the one we want.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-11-24 14:56:53 +00:00
3d0fd501f6
Only check path for being accessible when the storage is a object home
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-24 09:15:27 +00:00
8f9facccf0
Simple typo in comments
2020-11-20 19:48:09 +00:00
47ee460f86
Merge pull request #24160 from nextcloud/backport/24069/stable19
...
[stable19] Fix default internal expiration date
2020-11-16 19:17:46 +01:00
8de8bd2326
Merge pull request #24076 from nextcloud/backport/23741/stable19
...
[stable19] Unlock when promoting to exclusive lock fails
2020-11-16 17:07:05 +01:00
dd70a20da0
Fix default internal expiration date
...
The default expiration date for internal shares was set from the default
link expiration date instead of the internal one.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-11-16 13:20:11 +00:00
eecac68459
Don't throw on SHOW VERSION query
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-16 09:02:52 +00:00
da7f445179
Unlock when promoting to exclusive lock fails
...
In certain cases changeLock to EXCLUSIVE fails
and throws LockedException. This leaves the
file locked as SHARED in file_put_contents,
which prevents retrying (because on second
call file_put_contents takes another SHARED
lock on the same file, and changeLock doesn't
allow more than a single SHARED lock to promote
to EXCLUSIVE).
To avoid this case, we catch the LockedException
and unlock before re-throwing.
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2020-11-12 19:07:35 +00:00
b9db1cede3
Only use index of mount point when it is there
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-12 14:44:43 +01:00
f70abf4939
add mount point to quota warning message
...
makes it more clear to the user what the quota applies to
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-11-12 14:39:12 +01:00
d5dfaf42a8
Fix iLike() falsely turning escaped % and _ into wildcards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-11 09:27:28 +00:00
91242c9f0a
Merge pull request #23634 from nextcloud/backport/23374/stable19
...
[stable19] Only retry fetching app store data once every 5 minutes in case it fails
2020-11-09 16:59:56 +01:00
5aef556016
Only retry fetching app store data once every 5 minutes in case it fails
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-11-09 11:50:00 +01:00
40a2cf96be
Make sure root storage is valid before checking its size
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-11-09 10:08:17 +00:00
ce718ebd7b
Improve query type detection
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-06 21:23:20 +00:00
f97048f0d0
Merge pull request #23931 from nextcloud/backport/23917/stable19
...
[stable19] Do not emit UserCreatedEvent twice
2020-11-06 21:58:15 +01:00
dff10238de
fix: also remove use statement of UserCreatedEvent
...
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
2020-11-06 09:58:02 +00:00
ed46c5c94a
fix: no more translation from postCreateUser hook to UserCreatedEvent anymore, as event is already emitted in user manager
...
Signed-off-by: Tobias Assmann <tobias.assmann@ecsec.de>
2020-11-06 09:58:00 +00:00
d24ca17168
Bearer must be in the start of the auth header
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-06 08:23:52 +00:00
9bd25d2a7f
Merge pull request #23777 from nextcloud/backport/23024/stable19
2020-11-05 18:06:12 +01:00
1b2b478ff5
No need to check if there is an avatar available, because it is generated on the fly nowadays
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-02 18:13:11 +00:00
Roeland Jago Douma
Samuel
Marco Ziech
Roeland Jago Douma
blizzz
Joas Schilling
Julius Härtl
Morris Jobke
Guillaume Virlet
Robin Appelman
aler9
lui87kw
bladewing
Christoph Wurst
Carlos Ferreira
Daniel Calviño Sánchez
Ashod Nakashian
John Molakvoæ (skjnldsv)
Tobias Assmann