Commit Graph

868 Commits

Author SHA1 Message Date
Nextcloud bot 7f5e9ff7fc
[tx-robot] updated from transifex 2021-05-31 02:35:47 +00:00
Nextcloud bot d63a757092
[tx-robot] updated from transifex 2021-05-30 02:25:27 +00:00
Nextcloud bot 5fd1b719d7
[tx-robot] updated from transifex 2021-05-26 02:28:51 +00:00
Nextcloud bot c87c3710f2
[tx-robot] updated from transifex 2021-05-25 02:27:40 +00:00
Nextcloud bot 8be87861a2
[tx-robot] updated from transifex 2021-05-24 02:26:51 +00:00
Nextcloud bot 694454ca0d
[tx-robot] updated from transifex 2021-05-23 02:26:09 +00:00
Nextcloud bot 7ffae790ef
[tx-robot] updated from transifex 2021-05-22 02:27:38 +00:00
Nextcloud bot 3a9c6eef44
[tx-robot] updated from transifex 2021-05-21 02:28:17 +00:00
Roeland Jago Douma 998bcd92c6 Harden apptoken check
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-18 13:10:51 +00:00
Nextcloud bot f80b1fe0cb
[tx-robot] updated from transifex 2021-05-16 02:27:10 +00:00
dependabot-preview[bot] 7dd0a2c147
Merge pull request #26909 from nextcloud/dependabot/npm_and_yarn/stable20/lodash-4.17.21 2021-05-11 09:21:11 +00:00
dependabot-preview[bot] d945d6a063 [Security] Bump lodash from 4.17.20 to 4.17.21
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. **This update includes a security fix.**
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.20...4.17.21)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-05-11 10:47:07 +02:00
Nextcloud bot 6fbdbfa971
[tx-robot] updated from transifex 2021-05-10 02:32:02 +00:00
Nextcloud bot 6a63c535a0
[tx-robot] updated from transifex 2021-05-09 02:25:37 +00:00
Nextcloud bot b436c3a8df
[tx-robot] updated from transifex 2021-05-08 02:25:13 +00:00
Nextcloud bot edae9eb9a4
[tx-robot] updated from transifex 2021-05-06 02:25:54 +00:00
Nextcloud bot 83ec0bd360
[tx-robot] updated from transifex 2021-05-04 02:26:38 +00:00
Nextcloud bot a27a241d25
[tx-robot] updated from transifex 2021-05-01 02:26:54 +00:00
Nextcloud bot 3b1ac61331
[tx-robot] updated from transifex 2021-04-30 02:28:11 +00:00
Roeland Jago Douma f902adf188
Merge pull request #25973 from nextcloud/backport/25417/stable20-fix-account-data-visibility-after-disabling-public-addressbook-upload
[stable20] Fix account data visibility after disabling public addressbook upload
2021-04-29 20:52:38 +02:00
Nextcloud bot eb93e0dd29
[tx-robot] updated from transifex 2021-04-29 02:26:50 +00:00
Nextcloud bot c5ac15925b
[tx-robot] updated from transifex 2021-04-28 02:26:07 +00:00
Nextcloud bot 07b94975d4
[tx-robot] updated from transifex 2021-04-26 02:24:59 +00:00
Nextcloud bot 09c8c985e1
[tx-robot] updated from transifex 2021-04-25 02:25:15 +00:00
Nextcloud bot 1c784b1bf2
[tx-robot] updated from transifex 2021-04-24 02:26:59 +00:00
Daniel Calviño Sánchez 546be0ea63 Handle corrupted scope values
Due to a bug (fixed some commits ago) in the UsersController of the
settings app the scope of the properties can be null (for example, if
lookup server upload was disabled and the user then changed the display
name in the profile information). In that case now the scope menu icon
shows an error to inform the user.

The scope value will not change when other properties are modified until
the user chooses an explicit value from the menu. Note that until a
scope is explicitly set the property will behave as if it is private.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:58 +02:00
Daniel Calviño Sánchez e929d16bbb Fix settings scope menu hidden when lookup server upload is disabled
When upload to the lookup server is disabled the scope menu was hidden
in the personal information settings. However, even if the lookup server
upload is disabled the personal information is still accesible from the
local server as well as trusted servers. Users should be able to still
set if their information is available to other users or if it is
private, so now the scope menu is always show (although the "Public"
option is hidden if the lookup server upload is disabled).

If the user set the information as public before the upload to the
lookup server was disabled the menu will also show the "Public" option
as active, although disabled. Setting the visibility to any of the other
options will hide the "Public" option from the menu (until the lookup
server upload is enabled again).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:58 +02:00
Daniel Calviño Sánchez 77aba3df3c Fix deleting properties of user settings when not given explicitly
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:57 +02:00
Daniel Calviño Sánchez 0ddd892736 Fix TypeError when "email" is not given in the controller request
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:57 +02:00
Daniel Calviño Sánchez 0dfd0ec77a Respect additional user settings not covered by the controller
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.

Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).

This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:56 +02:00
Daniel Calviño Sánchez bedb97fd57 Add more unit tests for setting user settings
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:55 +02:00
Daniel Calviño Sánchez 1c8295610b Change default test data to values less similar to empty values
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:52 +02:00
Daniel Calviño Sánchez 91e06bc08a Extract default test data to a helper getter
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:49 +02:00
Daniel Calviño Sánchez 32fd379b66 Use constants from interface rather than class
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:48 +02:00
Nextcloud bot a335ff969d
[tx-robot] updated from transifex 2021-04-23 02:26:35 +00:00
Morris Jobke 3c9b923eb1
Merge pull request #26684 from nextcloud/backport/26474/stable20
[stable20] Mention MariaDB in MySQL support warning
2021-04-22 09:47:45 +02:00
Nextcloud bot bef596de06
[tx-robot] updated from transifex 2021-04-22 02:26:44 +00:00
Claas Augner 3082777bfd Mention MariaDB in MySQL support warning 2021-04-21 14:45:41 +00:00
Nextcloud bot 80d93acff0
[tx-robot] updated from transifex 2021-04-21 02:26:25 +00:00
Nextcloud bot a4c55e4601
[tx-robot] updated from transifex 2021-04-20 02:26:21 +00:00
Nextcloud bot ed5f446ec1
[tx-robot] updated from transifex 2021-04-19 02:26:26 +00:00
Nextcloud bot 36a16bcf63
[tx-robot] updated from transifex 2021-04-17 02:24:25 +00:00
Nextcloud bot e57f65cdfe
[tx-robot] updated from transifex 2021-04-16 02:26:13 +00:00
Nextcloud bot 36d2bb05cf
[tx-robot] updated from transifex 2021-04-15 02:25:32 +00:00
Nextcloud bot d35011b3f7
[tx-robot] updated from transifex 2021-04-14 02:27:12 +00:00
Nextcloud bot bb6dc44afb
[tx-robot] updated from transifex 2021-04-13 02:25:18 +00:00
Nextcloud bot 0cdfea022d
[tx-robot] updated from transifex 2021-04-12 02:25:16 +00:00
Nextcloud bot e78e509618
[tx-robot] updated from transifex 2021-04-09 02:25:30 +00:00
Nextcloud bot e09760f2bc
[tx-robot] updated from transifex 2021-04-08 02:24:23 +00:00
Nextcloud bot f1fd067db1
[tx-robot] updated from transifex 2021-04-07 02:24:36 +00:00