Commit Graph

696 Commits

Author SHA1 Message Date
Azul 43f0d2a3b5 Allow opening files for editing in new tabs
In a file list files with a default action
have an href that will trigger the action.
This way ctrl-click and middle button click open the default action in a new tab.

In order to achieve this a new param `openfile` was introduced to the files app.
It will make the files app trigger the default action for the file in question.
This also allows linking to file content rather than just the details display.

Introduce fileList.getDefaultActionUrl()
to create a link with that param set.
It's overwritten in the trashbin fileList
so that anchors continue to have `#` as a href.

Fix the link generation for subfolders of public shares:
58a87d0 was the last commit that touched the linkTo function in public.js.
It included the params as arguments to the generateUrl function.
Turns out this completely ignores the dir parameter now.
The inclusion was reverted in other places
so revert it here as well.
Also change `dir` to `path` in the param as that is respected
when following the link.

Add Test for the new link url for files with default action.
Remove test for multiple selects with ctrl-click
as that is not what we are doing anymore.

Signed-off-by: Azul <azul@riseup.net>
2020-04-09 16:41:09 +02:00
Azul d2728cbdc1 refactor: fileActions.getCurrentDefaultFileAction()
fileActions.getCurrentDefaultFileAction() returns the default file action
for the currently selected file.

There were a number of places querying for the mime, type and permissions
of that file first to then query for the default action.

Signed-off-by: Azul <azul@riseup.net>
2020-04-08 18:19:58 +02:00
GretaD b201121e62 Fix default action for deleted shares
Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-03-09 20:16:38 +00:00
Christoph Wurst bb1d8b3189
Remove deprecated global variables
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-09 13:31:50 +01:00
Julius Härtl af4139ce64
Show proper file name when fetching details fails
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-02-12 14:14:14 +01:00
Joas Schilling 034fefa7b7
Removed nested call to beforeunload
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-06 20:35:00 +01:00
John Molakvoæ (skjnldsv) b476659ac8
Fix legacy tabs
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-01-29 16:44:53 +01:00
Julius Härtl bfaf28452b
Adjust filelist color handling to new dark theme value
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-24 10:31:18 +01:00
Julius Härtl 8a5632d3a1
Do not show sidebar on rename (fixes #18613)
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-15 11:00:07 +01:00
Julius Härtl f7b267a61b
Properly set current file info when switching the details view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-15 11:00:07 +01:00
John Molakvoæ (skjnldsv) 27dc4ef268 Fix Sidebar enabled check
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-12-19 07:51:49 +00:00
John Molakvoæ (skjnldsv) f3cdf7e4c1
Properly reload file list on share accept
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-12-04 11:29:04 +01:00
John Molakvoæ (skjnldsv) 16e0887ec6
Use function to open a sidebar file
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-11-13 14:34:44 +01:00
John Molakvoæ (skjnldsv) d88b93c919 Add LoadSidebar event
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-29 13:20:07 +01:00
John Molakvoæ (skjnldsv) fd90af50d9 Add OCA.Files.Sidebar
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-29 12:56:00 +01:00
Julius Härtl 975c1982a0
Allow registering header sections in the file lists
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-10-23 08:48:15 +02:00
Julius Härtl 5e4eda1ae0
Remove deprecated legacy file actions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-10-14 19:19:16 +02:00
Thomas Ebert e47a7f0a95 Allow options to be passed to `FileList.createFile`, so that `scrollTo` can be overridden.
Signed-off-by: Thomas Ebert <thomas.ebert@te-online.net>
2019-09-16 15:17:05 +02:00
Roeland Jago Douma 6093acd4f0
Merge pull request #16969 from nextcloud/bugfix/14350/thumbnail_should_open_thefile_not_sidebar
When you click on thumbnail of a file, it should open the file not the sidebar
2019-09-03 07:52:34 +02:00
Greta Doci ac2c1ddd4e Change filelist _onClickFile function so thumbnail to open the file instead of the sidebar
Signed-off-by: Greta Doci <gretadoci@gmail.com>
2019-09-02 15:11:52 +02:00
Jonathan Matthews 1ae45bdaa1
Fix grid view
Signed-off-by: Jonathan Matthews <jgit@pixelnet.work>
2019-08-19 15:18:05 -04:00
Morris Jobke 003e23520d
Trigger fallback code to get max contrast value and use integer there
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-07-25 09:45:09 +02:00
Morris Jobke 5e02d71588
Fix max contrast retrieval to limit minimum color for relative time
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2019-07-24 21:48:52 +02:00
Julius Härtl 51683fa9d1
Properly load permissions in showActions
When setViewerMode(false) is called, the permissions should be fetched from the available dirInfo

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-07-05 12:21:21 +02:00
Robin Appelman 258902b337
fix permissions for drag-n-drop uploads
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-07-01 11:58:13 +02:00
Julius Härtl bf56f2843c
Fix window scroll container
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-06-19 11:14:57 +02:00
Morris Jobke 64fb083dd9
Merge pull request #15767 from nextcloud/bugfix/0b-quota-create
Hide newFile menu if quota is set to 0B
2019-05-28 14:27:01 +02:00
Julius Härtl 1cf16fa7aa
Hide newFile menu if quota is set to 0B
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-05-28 10:27:01 +02:00
Julius Härtl d48787e661
Also allow dragging below the file list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-05-27 13:00:45 +02:00
Christoph Wurst 0f3e438f7c
Move OC.theme to the bundle and deprecate oc_defaults
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-14 11:14:29 +02:00
Morris Jobke aa47358812
Merge pull request #15302 from nextcloud/enhancement/files/table-head-sticky
Floating files header
2019-05-07 23:59:51 +02:00
John Molakvoæ (skjnldsv) faff807ba6
Floating files header
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-05-07 19:06:58 +02:00
John Molakvoæ (skjnldsv) 54afe0bca2
Do NOT assume all files are selected if the first checkbox is
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-04-30 16:53:50 +02:00
John Molakvoæ (skjnldsv) ec09f121af
Use max contrast variable to cap the generated colours
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-03-21 08:45:01 +01:00
John Molakvoæ 6a3f4e4957
Merge pull request #12652 from tomasz-grobelny/operation_progress_improvements3
Operation progress improvements
2019-02-14 14:24:20 +01:00
Christian Aigner ce37930910 HBOX-297 trim in webfrontend for new files to stay compatible with windows 2019-02-01 09:47:07 +00:00
fnuesse f13b3ab4ae Add drop zone for favorites quick access in navigation
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
2019-02-01 01:45:03 +01:00
Daniel Calviño Sánchez 75edcad549 Replace double quotes with single quotes
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 19:55:51 +01:00
Daniel Calviño Sánchez 96bc1397b1 Add missing trailing ";"
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 19:55:33 +01:00
Daniel Calviño Sánchez 72a424d4c8 Remove unneeded triggering of event
The "droppedOnTrash" event was being triggered when the file list was
initialized, but it should be triggered only when the user actually
drops a file on the trash bin.

Besides that, the event had no effect; only the file list handles it,
but as it was not triggered on any element it ended being triggered on
the document, and thus not handled. Moreover, even if it had been
triggered on the file list it would have been done before the handler
was set, so it would not have been handled anyway. And even if it had
been handled no data was provided, so the handler would have failed.

In conclusion, triggering the event there was not needed, and thus it
was removed.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 19:14:58 +01:00
Daniel Calviño Sánchez dd91c4e500 Remove duplicated variable declaration
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 17:59:50 +01:00
Daniel Calviño Sánchez 47937a5062 Remove leftover from a WIP
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-01-31 17:49:25 +01:00
John Molakvoæ 53fd4997cc
Merge pull request #12364 from tomasz-grobelny/file_range_select
Ability to select file ranges with mouse or touchscreen
2019-01-30 10:21:23 +01:00
Tomasz Grobelny 08919eb193 Merge branch 'master' into operation_progress_improvements3
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2019-01-29 21:26:44 +01:00
imsolost 5742ec79ab changed case on variable to match initial case
Signed-off-by: imsolost <imsolost@gmail.com>
2019-01-25 11:16:37 -08:00
imsolost 3e37620cc2 fixed replacement functions to catch all instances of parenthesis
Signed-off-by: imsolost <imsolost@gmail.com>
2019-01-25 11:16:37 -08:00
Tomasz Grobelny 907deab278 Add more accessible method of selecting file ranges
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2019-01-24 22:04:52 +01:00
Florian Schunk 332b4aee9d fix testing for undefined
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-16 22:54:16 +01:00
Florian Schunk ecb936495f also remember folder for multiselect actions
Signed-off-by: Florian Schunk <florian.schunk@rwth-aachen.de>
2019-01-16 22:54:16 +01:00
Tomasz Grobelny 04d326f95f Fix unit tests
Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>
2018-11-24 23:57:13 +01:00