Commit Graph

45931 Commits

Author SHA1 Message Date
Roeland Jago Douma 55c4d3f555
Merge pull request #12600 from nextcloud/backport/12592/stable14
[stable14] Fix Typo in Original English String and All Translations
2018-11-22 20:16:42 +01:00
Patrick Baber 49c8512f59 fix typo in original english string and all translations
Signed-off-by: Patrick Baber <patrick@p-squared.de>
2018-11-22 18:22:56 +00:00
Daniel Calviño Sánchez e3d90efdbb Fix rendering of the sidebar in Files app
When a view is rendered it should not be concerned with where it is
going to be placed in the document; in general this should be a
responsibility of the object using the view.

Moreover, when the details view is rendered it should simply prepare a
skeleton that includes the root elements provided by the plugins; those
elements will be updated by the plugins as needed when a file or a tab
is selected.

Finally, the details view should not be explicitly rendered. The
rendering removes the previous elements, but that is needed only when
the details view is in a dirty state, that is, when new plugins were
added since the last time that it was rendered. However, that dirty
state is internally handled, and the view is automatically rendered
again if needed when a file info is set.

Due to all that the details view is no longer explicitly rendered when
updating it with a different file. Also, as each file list has its own
details view, and each details view has its own element, but there can
be only one details view/sidebar element in the document, when the file
list updates the details view it also replaces the current one in the
document with its own details view if needed (that is, if it is not the
current one already).

Besides that, when the element of a details view is replaced with the
element of a different details view the old one should be detached from
the document, but never removed. Otherwise the event handlers would not
work when that element is attached again later (when changing to a
different section in the Files app and then going back to the previous
one).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 17:45:46 +01:00
Daniel Calviño Sánchez 2d58826d42 Add acceptance tests for showing again the input field for tags
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 17:43:58 +01:00
Daniel Calviño Sánchez f9efd31623 Add acceptance tests for opening and closing again the details view
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 17:43:58 +01:00
Daniel Calviño Sánchez 400d42a47a Add acceptance tests for marking a file as favorite in the details view
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 17:43:58 +01:00
Daniel Calviño Sánchez d0ea4ad8b8 Add acceptance tests for switching to the comments of another file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-11-22 17:43:58 +01:00
Julius Härtl a584406947 Load apps that have a dav type set before the dav server plugins
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-22 16:26:14 +00:00
Julius Härtl 07c5c686a0 Do not switch to root folder if filelist is already shown
Navigating to the root folder is already handled by
OCA.Files.Navigation.setActiveItem in case the view doesn't change.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-22 15:10:53 +00:00
Morris Jobke ff59905b12
Merge pull request #12540 from nextcloud/backport/12450/stable14
[stable14] Throw exception if decryption fails
2018-11-22 14:54:02 +01:00
Morris Jobke 47b9e5d08c
Merge pull request #12555 from nextcloud/backport/12552/stable14
[stable14] Respect the disabled setting for lost_password_link
2018-11-22 14:53:46 +01:00
Morris Jobke d25e8a774a
Merge pull request #12586 from nextcloud/version/noid/14.0.4
14.0.4
2018-11-22 14:14:28 +01:00
Morris Jobke 99646e1976
14.0.4
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-22 11:05:37 +01:00
Nextcloud bot 7d6aea2e54
[tx-robot] updated from transifex 2018-11-22 01:12:30 +00:00
Roeland Jago Douma 4044ac3b71
Merge pull request #12561 from nextcloud/backport/12544/stable14
[14] Handle permission in update of share better
2018-11-21 08:58:02 +01:00
Nextcloud bot 3593764e1b
[tx-robot] updated from transifex 2018-11-21 01:12:26 +00:00
Roeland Jago Douma e07db91900
Merge pull request #12545 from nextcloud/backport/12543/stable14
[stable14] Bearer tokens are app token
2018-11-20 20:06:39 +01:00
Roeland Jago Douma 395d697598
Handle permission in update of share better
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-20 19:36:17 +01:00
Roeland Jago Douma b776c3b89f Respect the disabled setting for lost_password_link
Fixes #11146
As documented when it is set to disabled the user can't request a lost
password.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-20 14:53:19 +00:00
Roeland Jago Douma adf1488e4e Bearer tokens are app token
Fixes #12498

This means that we set that it is a proper app token once it is
validated. This will allow the 2FA middleware to just run the same
check.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-20 10:50:21 +00:00
Morris Jobke b4a410e502
Merge pull request #12533 from nextcloud/version/noid/14.0.4rc2
14.0.4 RC 2
2018-11-20 10:17:01 +01:00
Morris Jobke 07d25f6582
14.0.4 RC 2
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-20 09:17:38 +01:00
Morris Jobke e03f159961
Merge pull request #12542 from nextcloud/stb14-settings-svg-icons-scss-fix
Remove unused svg api route
2018-11-20 09:16:26 +01:00
John Molakvoæ (skjnldsv) 761f6e6413
Remove unused sg api route
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-20 07:41:30 +01:00
Nextcloud bot 2820179e73
[tx-robot] updated from transifex 2018-11-20 01:12:49 +00:00
Roeland Jago Douma 40a3937877 Throw exception if decryption fails
For #11868

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-11-19 21:26:01 +00:00
Roeland Jago Douma b133ca311e
Merge pull request #12529 from nextcloud/backport/12401/php-warning
[stable14] Fix the warning appearing in the admin section when mail_smtpmode is not configured
2018-11-19 19:43:22 +01:00
Morris Jobke 511eade1d4
Use the proper default values
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-19 15:49:49 +01:00
Kyle Fazzari 5ba33b7574
Verify that isPhpMailerUsed uses config as expected
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
2018-11-19 15:49:49 +01:00
Marc Peña Segarra dba617ada3
Fix the warning appearing check setup when mail_smtpmode is not configured.
Closes #11107
2018-11-19 15:49:49 +01:00
Morris Jobke 079e59dd4b
Merge pull request #12502 from nextcloud/swift-object-not-found-14
[14] forward object not found error in swift as dav 404
2018-11-19 15:32:46 +01:00
Robin Appelman f43cfd9275
forward object not found error in swift as dav 404
Signed-off-by: Robin Appelman <robin@icewind.nl>
2018-11-19 11:36:33 +01:00
Nextcloud bot 3ba18cea8f
[tx-robot] updated from transifex 2018-11-19 01:12:15 +00:00
Roeland Jago Douma b2c9dce235
Merge pull request #12492 from nextcloud/stable14-12489
[stable14] Only use width and opacity for transition
2018-11-18 20:20:49 +01:00
Nextcloud bot 3671606051
[tx-robot] updated from transifex 2018-11-18 01:13:09 +00:00
Nextcloud bot 4fe3f9eead
[tx-robot] updated from transifex 2018-11-17 01:12:57 +00:00
Julius Härtl b5dd252a06
Only use width and opacity for transition
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2018-11-16 16:32:26 +01:00
Morris Jobke a79c7c7b05
Merge pull request #12482 from nextcloud/share-menu-click-fix
Fix wrong share popover opening on share link
2018-11-16 14:18:45 +01:00
John Molakvoæ (skjnldsv) 5f1f9952dc
Fix wrong share popover opening on share link
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-16 10:58:48 +01:00
Nextcloud bot cd196f31a0
[tx-robot] updated from transifex 2018-11-16 01:12:25 +00:00
Morris Jobke d1e50a10e3
Merge pull request #12436 from nextcloud/version/noid/14.0.4RC1
14.0.4 RC 1
2018-11-15 15:44:52 +01:00
Morris Jobke 5bd5dc2822
14.0.4 RC 1
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-15 13:49:19 +01:00
Morris Jobke 9070de4753
Update autoloader dump
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-15 13:49:19 +01:00
Morris Jobke 7781485fb7
Merge pull request #12459 from nextcloud/bugfix-stable14/dav_shares_hickup
[stable14] fixes dav share issue with owner
2018-11-15 13:41:31 +01:00
Georg Ehrke cc27fdad46
fix caldav tests
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-11-15 13:01:04 +01:00
Nextcloud bot 659e4746db
[tx-robot] updated from transifex 2018-11-15 01:12:24 +00:00
Georg Ehrke 94c2b66df3
fixes dav share issue with owner
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2018-11-14 21:51:40 +01:00
Morris Jobke c4155e2f18
Merge pull request #12441 from nextcloud/stable14-10888
[stable14] Fix missing quickaccess favorite folder on add
2018-11-14 21:18:33 +01:00
Morris Jobke 94a5ffe394
Update PHPDoc to fix typos
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-11-14 21:18:16 +01:00
Morris Jobke fc516b508e
Merge pull request #12432 from nextcloud/stb14-accessibility-cache-fixes
[stable14] Added cache override to ensure an always up-to-date accessibility css
2018-11-14 16:54:15 +01:00