Joas Schilling
6c81c65eea
Also prevent null byte character
2016-09-01 12:24:14 +02:00
Joas Schilling
7cd86cfe59
Filter out %0A from paths
2016-09-01 10:06:06 +02:00
Joas Schilling
ee1c1b39b2
Update live timestamps to give a more live feeling
2016-09-01 09:02:36 +02:00
Roeland Jago Douma
e1ea45f32b
Merge pull request #1147 from nextcloud/files-hidden-files-summary
...
Display number of hidden files in files summary (#25870 )
2016-08-29 20:36:07 +02:00
Vincent Petry
7fa66409ae
Display number of hidden files in files summary ( #25870 )
...
When dot files are hidden, the table summary and selection summary will
not show how many hidden files were included.
2016-08-29 14:47:41 +02:00
Vincent Petry
29b45c5c42
Make sure file list files config always exists
...
Initialize files config with defaults in case none was passed
2016-08-29 14:44:25 +02:00
Vincent Petry
f7deb2c2eb
Fix hidden files handling
...
Hidden files (dot files) are now always rendered in the DOM to make
sure that all file operations and selection still work as expected.
Their visibility is now toggled on CSS level.
2016-08-19 10:26:19 +02:00
Robin Appelman
6368506e57
only load sidebar previews when we know it's available
2016-07-27 12:59:43 +02:00
Robin Appelman
03c17ff614
dont load filelist previews if we know we dont have one
2016-07-27 12:59:43 +02:00
Robin Appelman
2139a031e7
block user sorting in recent files
2016-07-22 15:20:55 +02:00
Lukas Reschke
2a1a3957b6
Merge pull request #333 from nextcloud/sync-master
...
Sync master
2016-07-07 19:29:43 +02:00
Morris Jobke
ba16fd0d33
Merge branch 'master' into sync-master
2016-07-07 11:29:46 +02:00
Vincent Petry
cf6fe95cbf
Merge pull request #25325 from owncloud/filelist-prependslash
...
Filelist change dir auto-prepend slash
2016-07-06 12:44:03 +02:00
Vincent Petry
1f9d728538
Ignore invalid paths in the JS file list ( #25368 )
2016-07-06 11:55:02 +02:00
Robin Appelman
d623763aac
Add "goto" links for files in non-default file lists
2016-07-05 22:22:55 +02:00
Björn Schießle
5b4cea4b36
Merge pull request #275 from nextcloud/master-sync-upstream
...
[Master] Sync upstream
2016-07-01 18:31:51 +02:00
Lukas Reschke
76c73d5ec3
Match on 405
2016-07-01 15:19:21 +02:00
Lukas Reschke
4ac9eaab03
Match for /../
2016-07-01 15:01:48 +02:00
Lukas Reschke
5b65591d84
Do not allow directory traversal using "../"
...
We should not allow directory traversals using "../" here.
To test access the following URL once with and then without this patch:
http://localhost/server/index.php/apps/files/?dir=../../This+Should+Not+Be+Here
2016-07-01 13:36:05 +02:00
Lukas Reschke
179a355b2c
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-07-01 11:36:35 +02:00
Vincent Petry
4acb06923d
Filelist change dir auto-prepend slash
...
Prepend a slash to directories in case it was missing since many places
assume that it's there.
2016-07-01 11:10:37 +02:00
Vincent Petry
5cfbb9624f
Prevent infinite loop in search auto-nextpage
...
When loading the next page of search results, make sure that the loop
can end if there are no more elements in case the total doesn't match.
Also added a check to avoid recomputing the search results whenever the
setFilter() is called with the same value. This happens when navigating
away to another folder, the search field gets cleared automatically and
it calls FileList.setFilter('').
2016-06-30 11:10:48 +02:00
Lukas Reschke
6670d37658
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-06-27 18:23:00 +02:00
Vincent Petry
b4cf297758
Prerender file list pages to include search results
...
When filtering the file list, if a result is on an unrendered page,
make sure to call _nextPage() to prerender the pages in order to
display all matching results.
2016-06-24 13:55:14 +02:00
Vincent Chan
203a07e7f3
change folder icon when dragging over a directory
2016-06-15 01:03:59 +02:00
Vincent Chan
937d21ed29
properly fix folder upload to use delegatedEvent
2016-06-14 11:51:03 +02:00
Vincent Petry
76c0bc29fe
Merge pull request #20150 from pellaeon/pr-droppable-hover-visual-cue
...
Add visual cue when moving draggable item over droppable item,
2016-05-30 16:03:36 +02:00
Dmitry Popov
83aa28ed1d
My fix for #24272 , #23613 , File not found when single file in a folder ( #24800 )
...
* Fixed group share searching for members of
multiple group. Issue #11808 .
* Fixed group share searching, continued.
Avoid searching for empty group list in getItemSharedWithUser().
Broke tests in previous commit, #12030 .
* Simler check for group count.
* Fix for https://github.com/owncloud/core/issues/24783 , described there
* Now it's #24272 , 24783 was a duplicate. Previous change was also not very good. Now we don't create ZIP with a single file inside.
2016-05-24 14:09:05 +02:00
Pellaeon Lin
72ac5dd8a1
Make entire file tr droppable,
...
so that .canDrop will highlight the entire row when drag hover
2016-05-21 12:54:29 +08:00
Fabian
2a7d3dd831
dont update search onResize
...
this.updateSearch() sets the current file list instance and clears the box. This is unnecessary and makes the search box unsuable on some mobile devices where a keyboard fade-in causes a onResize trigger, which would then clear and blur the box.
2016-05-17 22:57:07 +02:00
Vincent Petry
88da2966b4
Merge pull request #22341 from owncloud/pellaeon-pr-breadcrumb-filelist-overlap-drop
...
Handle case when breadcrumb and filelist item overlap and both receive a drop
2016-05-13 17:12:36 +02:00
Vincent Petry
fdeafef6a0
Auto-add fileid in URL for currently displayed folder
2016-05-06 16:46:59 +02:00
Christoph Wurst
df2a9d1733
OCA.Files.App is not available on public page
2016-04-21 14:23:18 +02:00
Thomas Müller
1ab27ddd4a
Merge pull request #24081 from owncloud/migrate-deprecated-jquery-v1-functions
...
migrate deprecated jQuery 1.x functions
2016-04-20 20:38:38 +02:00
Christoph Wurst
6c5696d3a8
filter hidden files on the web interface
...
add checkbox to toggle show/hide hidden files
persist show hidden setting
fix settings menu layout
test ApiController::showHiddenFiles
don't show hidden files by default
Store config in Backbone model and inject it into FileList
Filter files only temporarily when rending the file list
Fix file rename validation
2016-04-19 16:08:56 +02:00
Christoph Wurst
05d203a989
replace $.parseJSON() by JSON.parse()
2016-04-19 15:06:42 +02:00
Christoph Wurst
37530f27f0
migrate jQuery.fn.unload()
2016-04-19 12:05:09 +02:00
Thomas Müller
63a385d2b8
Merge pull request #23933 from owncloud/remember-file-sorting
...
remember file sort order
2016-04-15 14:06:21 +02:00
Christoph Wurst
576f7244e6
fix default value, update js/php tests
2016-04-13 14:25:23 +02:00
Christoph Wurst
a4683bcfa9
persist file sorting changes
2016-04-13 11:28:42 +02:00
Christoph Wurst
3f492dd826
load file sorting mode from the db
2016-04-13 11:28:42 +02:00
Christoph Wurst
4d02233faa
restore selection after re-rendering file rows
2016-04-13 11:20:26 +02:00
Joas Schilling
bba28590b7
Remove xxx from ownCloud we dont want to see that 🙈
2016-04-07 12:18:44 +02:00
Jan-Christoph Borchardt
a8a98d42cb
improve emptycontent styles
2016-03-31 15:31:04 +02:00
Erik Pellikka
50655cbf7f
sidebar click modification
2016-03-24 11:57:40 +01:00
Pellaeon Lin
48430d4481
Handle case when breadcrumb and filelist item overlap
...
and both receive a drop.
Build breadcrumb over and out callback in filelist.js and
pass them as options to utilize local selectors of filelist
Re-enable td elements after drop to bread crumb
Fix# drop handler still being called after enable,
it seems that waiting for a short time before re-enabling solves the
problem
* Add explanations for setTimeout re-enable td.filename drop handler
2016-03-17 10:20:57 +01:00
Stefan Weil
692f312513
apps/files: Fix typos in comments (found and fixed by codespell)
...
This contribution is AGPL and MIT licensed.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-03-09 15:14:05 +01:00
Vincent Petry
dbdf2173ac
Return false on 401 in file list + trash file list
...
This gives a chance to the global ajax error handler to do its work if
the session expired.
2016-03-03 09:09:30 +01:00
Roeland Jago Douma
92cff0984d
Make file actions use icon CSS classes
...
This makes theming of file actions possible
2016-02-25 22:49:52 +01:00
Thomas Müller
7af7d18cfa
Merge pull request #16783 from owncloud/handle-redirects-global
...
Adding global error handler for ajax calls which run into redirection…
2016-02-17 14:49:04 +01:00
Vincent Petry
d565290d16
Close file detail sidebar when selecting/unselecting files
...
Interacting with the checkboxes, also "Select all" will automatically
close the sidebar now.
2016-02-15 14:58:44 +01:00
Vincent Petry
b8b77709c0
Add handler for global ajax errors
2016-02-15 12:48:47 +01:00
Vincent Petry
ae367c7e97
Fix elementToFile to also return path when defined
...
Fixes issue when opening the share dialog for a file inside the favorite
list, and the file is from a subfolder
2016-02-08 22:33:39 +01:00
Robin McCorkell
a49aff2db7
Only check selection for delete permissions, not parent folder
2016-01-15 16:52:51 +00:00
Erik Pellikka
ace66057f2
Fixed issue #21452
...
removed whitespace
removed whitespace
Changed it based on PVince81's suggestion
2016-01-13 14:47:00 +01:00
Roeland Jago Douma
86735c6b5a
Updating a file should not update the summary
2016-01-09 22:07:34 +01:00
Thomas Müller
7693c6d84a
Merge pull request #21254 from owncloud/files-uploadcanceliconfix
...
Correctly render uploadtext indicator only on folders
2015-12-28 10:21:38 +01:00
Vincent Petry
ca14277fca
Make a modifiable copy of the webdav properties in JS file list
...
Plugins can extend _getWebdavProperties to add custom properties.
These should not be added to the original properties list, so now the
FileList makes a copy of the array.
2015-12-22 11:17:24 +01:00
Vincent Petry
7ecb9696ba
Use showBusyState for upload into folder
...
This makes sure that the original icon will be restored properly in case
it's not the default folder icon
2015-12-18 18:09:54 +01:00
Vincent Petry
d27826bac0
Correctly render uploadtext indicator only on folders
2015-12-18 18:09:46 +01:00
Vincent Petry
4d9e12b8bc
Fix mount type root detection
...
Since Webdav doesn't contain that information, we need to rely on the
parent folder's mount type to find out whether a child item is a
shared/external root or not.
Fixed the mount type detection logic and added unit test.
Also added a fix that ignores detection if no parent folder exists (ex:
shared file list, favorites, etc)
2015-12-14 10:44:47 +01:00
Vincent Petry
d3383adb71
Fix issue when renaming creates a separate entry
2015-11-22 16:05:51 +01:00
Vincent Petry
dc8ce87a26
Query tags/favorite through Webdav in file list
2015-11-22 16:05:50 +01:00
Vincent Petry
fa2be0750c
Make files app use Webdav for most operations
2015-11-22 16:05:50 +01:00
Robin Appelman
3c01386a50
Merge pull request #20156 from owncloud/files-filter-triger-once
...
dont trigger the scroll event of every single item we filter in the file list
2015-10-30 12:52:04 +01:00
Robin Appelman
860e31a333
dont trigger the scroll event of every single item we filter in the file list
2015-10-29 16:30:56 +01:00
Vincent Petry
9c9158e6b7
Fix icon update to be more consistent
...
Makes the details bar show the same icon as in the list.
2015-10-29 12:59:51 +01:00
Vincent Petry
e36c85178f
Do not display details bar after rename
2015-10-21 13:43:39 +02:00
Vincent Petry
204b3ca189
Do not register sidebar panels when no sidebar
2015-10-15 16:30:50 +02:00
Thomas Müller
d8f0afaf9f
Merge pull request #19634 from owncloud/notif-showtemporary
...
showTemporary instead of show for notifications
2015-10-14 12:50:55 +02:00
Thomas Müller
b090ed7666
Merge pull request #19747 from owncloud/files-delete-hidenotif
...
Hide notification on delete
2015-10-14 12:49:22 +02:00
Vincent Petry
cdc1386885
Hide notification on delete
...
In case a permanent notification "storage full" was displayed, it will
be hidden after deleting a file.
Directly after that a getstoragestats.php call is made that will decide
whether to reshow the notification based on the new free space.
2015-10-13 17:24:52 +02:00
Vincent Petry
ecb10db039
Remove controls for file lists that don't need it
...
Remove controls from sharing overview and favorite file lists which
don't display paths.
2015-10-13 11:36:24 +02:00
Vincent Petry
5bf43ec60a
showTemporary instead of show for notifications
2015-10-08 10:52:39 +02:00
Vincent Petry
c17d60165a
Fix tooltip placement on rename error
2015-10-05 17:44:25 +02:00
Vincent Petry
f135128664
Fix filelist size issues, breadcrumb, multiselect
...
- calculate multiselect header width to exclude scrollbar
- call FileList._onResize() when sidebar is toggled ("appresized"), this
also updates the breadcrumb width
- moved global getScrollBarWidth() to OC.Util namespace
2015-10-02 18:03:48 +02:00
Thomas Müller
1d8c10cf63
Merge pull request #19468 from owncloud/fix-36-vs-32-previews
...
Change small thumbnails to 32 px
2015-09-30 15:47:34 +02:00
Thomas Müller
750f19340f
Merge pull request #19310 from owncloud/hide-sort-indicator
...
hide sort indicator when in multiselect mode, ref #19056
2015-09-30 11:07:45 +02:00
Morris Jobke
1051a3c6f5
Change small thumbnails to 32 px
...
* fixes #16913
* fixes issues in IE8 where the thumbnail is too big
2015-09-30 10:49:48 +02:00
Thomas Müller
733673b39d
Merge pull request #19365 from owncloud/files-detailsbar-interaction
...
Fix sidebar interaction
2015-09-29 14:44:28 +02:00
Vincent Petry
d52361b09b
Disable sorting when multiselect is enabled in file list
2015-09-29 13:24:33 +02:00
Vincent Petry
cc8efaa037
Show conflict dialog before upload when possible
...
When uploading files, first check if the files exist in the current file
list. For the ones that do, show a conflict dialog.
For the rest, upload directly.
If the upload operation detects a conflict on the server side, it will
also continue populating the conflict dialog.
From now on, server side conflict can only occur if someone concurrently
uploaded a file into the same folder but the current user hasn't
refreshed the list yet.
2015-09-28 17:50:11 +02:00
Vincent Petry
f9acf4627e
Fix sidebar interaction
...
- Clicking a file row or selecting it will open the sidebar.
- When sidebar is open, its contents update with the last selection.
- Dragging doesn't open the sidebar but does update its contents if it was
open already.
- Switching folders closes the sidebar.
- Close sidebar when highlighted file got deleted/removed from list
2015-09-28 15:23:37 +02:00
Vincent Petry
f35b6833ff
Fix order of actions in the files actions menu
2015-09-28 11:19:49 +02:00
Olivier Paroz
46475b8114
Switch from Math.floor() to Math.ceil() when sending the dimension to Preview
...
Fixes #18203
2015-09-27 12:46:25 +02:00
Hendrik Leppelsack
28d3c1cc0b
fix filelist checkboxes
2015-09-25 00:51:39 +02:00
Thomas Müller
4c62d71db7
Merge pull request #19277 from owncloud/files-plusbuttonfix
...
Only render the plus button when it makes sense
2015-09-23 11:31:52 +02:00
Thomas Müller
9fbd3fa6c1
Merge pull request #19270 from owncloud/files-sidebar-fixfortrashandco
...
Properly show sidebar for trash and sharing sections
2015-09-22 23:53:15 +02:00
Vincent Petry
a7d84287ad
Only render the plus button when it makes sense
2015-09-22 16:47:52 +02:00
Vincent Petry
fa725fba73
Properly show sidebar for trash and sharing sections
2015-09-22 15:28:48 +02:00
Vincent Petry
a35144e961
Properly translate file actions
2015-09-22 14:52:52 +02:00
Thomas Müller
4d77fac191
Merge pull request #19048 from owncloud/details-icon
...
add details icon for file actions dropdown
2015-09-16 13:56:30 +02:00
Jan-Christoph Borchardt
2356ba2494
fix accessibility of New button, use alt text instead of tooltip
2015-09-16 11:51:58 +02:00
Vincent Petry
e7e0cfe93d
Properly show sidebar when clicking on share button
2015-09-16 07:23:29 +02:00
Vincent Petry
e90065881d
Bring back the share icon and update its status
...
Display share icon in file list row.
Update share icon status when the sharing state changed.
2015-09-16 07:23:28 +02:00
Thomas Müller
d1f7087b6c
Merge pull request #18979 from owncloud/sidebare-preview-fixes
...
Sidebare preview fixes
2015-09-16 00:12:25 +02:00
Vincent Petry
7ab57f7f27
Add details icon for details menu item
2015-09-15 17:52:01 +02:00
Robin Appelman
19e1d35373
Fix path for fileinfomodel in subdirectories
2015-09-15 14:29:37 +02:00
Vincent Petry
d0cea82969
Fixed sidebar toggle entry
...
Properly highlight the row after selecting the item.
This also fixes the unit tests by changing the order of registration of
file actions.
2015-09-14 20:45:30 +02:00
Vincent Petry
8a6574e81a
Keep right sidebar open, add Details action
2015-09-14 20:45:30 +02:00