Commit Graph

22175 Commits

Author SHA1 Message Date
Roeland Jago Douma 21d8a2bfc1
Merge pull request #20446 from nextcloud/dependabot/npm_and_yarn/css-loader-3.5.2
Bump css-loader from 3.4.1 to 3.5.2
2020-04-13 14:11:00 +02:00
Roeland Jago Douma a307d82e1d
Merge pull request #20427 from nextcloud/bug/noid/fix-password-reset-activity
Fix password reset saying Admin changed my password when reset from login page
2020-04-13 13:15:49 +02:00
dependabot-preview[bot] 372d6bf23e Bump css-loader from 3.4.1 to 3.5.2
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.4.1 to 3.5.2.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v3.4.1...v3.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-13 11:13:09 +00:00
Nextcloud bot 6187cea304
[tx-robot] updated from transifex 2020-04-13 02:19:45 +00:00
Roeland Jago Douma 1cc793888f
Merge pull request #20421 from nextcloud/fix/20393/recommendend_webauthn_mods
Show setup check for recommended php modules
2020-04-12 15:56:10 +02:00
John Molakvoæ 8924214299
Merge pull request #20439 from nextcloud/Valdnet-patch-3
Changing the translation catalog for "Share"
2020-04-12 09:08:52 +02:00
Nextcloud bot d32ea71c30
[tx-robot] updated from transifex 2020-04-12 03:09:11 +00:00
Valdnet a50698b3c3 Changing the translation catalog for "Share"
Change "files" to "files_sharing".

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-12 02:20:14 +00:00
Julius Härtl c20321e7e0 Add tests for encoded group id
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-11 06:36:20 +00:00
Julius Härtl 5252836f44
Make sure the group id parameter gets properly encoded when used in URLs
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-11 08:28:15 +02:00
Julius Härtl e7249de145
Make the groupId url encoded
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-11 08:28:15 +02:00
John Molakvoæ e5ac5c7f34
Merge pull request #20185 from azul/open-new_tab
Modify do_action so default ctrl-click opens tab
2020-04-11 08:23:11 +02:00
John Molakvoæ b5a30d5cd6
Merge pull request #20426 from nextcloud/techdebt/psr2
It is done
2020-04-11 08:21:35 +02:00
John Molakvoæ 97de425a17
Merge pull request #20419 from nextcloud/dependabot/npm_and_yarn/various
Bump p-limit from 2.2.2 to 2.3.0, @nextcloud/auth from 1.2.2 to 1.2.3, @babel/preset-env from 7.8.7 to 7.9.5, @nextcloud/event-bus from 1.1.3 to 1.1.4, @nextcloud/password-confirmation from 1.0.0 to 1.0.1, @nextcloud/l10n from 1.2.2 to 1.2.3, @nextcloud/initial-state from 1.1.1 to 1.1.2, core-js from 3.6.4 to 3.6.5 …
2020-04-11 08:18:14 +02:00
Nextcloud bot de52e1cda7
[tx-robot] updated from transifex 2020-04-11 02:18:37 +00:00
Thomas Citharel 18e8af4bb8
Fix password reset saying Admin changed my password when reset from
login page

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-10 18:05:43 +02:00
Christoph Wurst 734c62bee0
Format code according to PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:56:50 +02:00
Christoph Wurst 28f8eb5dba
Add visibility to all constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
Christoph Wurst 1584c9ae9c
Add visibility to all methods and position of static keyword
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
Christoph Wurst a7c8d26d31
Add visibility to all properties and move static keyword
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:48:31 +02:00
John Molakvoæ (skjnldsv) e24818f6bb Bump core-js from 1.4.1 to 1.5.0
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-10 12:37:20 +00:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Roeland Jago Douma 75836f004d
Show setup check for recommended php modules
Fixes #20393

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-10 13:25:12 +02:00
Christoph Wurst 14c996d982
Use elseif instead of else if
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
Roeland Jago Douma 7799eef90e
Merge pull request #20390 from nextcloud/refactor/no-closing-tag
Do not use closing tags
2020-04-10 08:34:18 +02:00
Nextcloud bot 078b12a9b0
[tx-robot] updated from transifex 2020-04-10 02:18:23 +00:00
Christoph Wurst 008e6d7e84
Merge pull request #20391 from nextcloud/refactor/spaces-cleanup
Remove all extra whitespace PSR2 does not like
2020-04-09 20:39:37 +02:00
Azul 43f0d2a3b5 Allow opening files for editing in new tabs
In a file list files with a default action
have an href that will trigger the action.
This way ctrl-click and middle button click open the default action in a new tab.

In order to achieve this a new param `openfile` was introduced to the files app.
It will make the files app trigger the default action for the file in question.
This also allows linking to file content rather than just the details display.

Introduce fileList.getDefaultActionUrl()
to create a link with that param set.
It's overwritten in the trashbin fileList
so that anchors continue to have `#` as a href.

Fix the link generation for subfolders of public shares:
58a87d0 was the last commit that touched the linkTo function in public.js.
It included the params as arguments to the generateUrl function.
Turns out this completely ignores the dir parameter now.
The inclusion was reverted in other places
so revert it here as well.
Also change `dir` to `path` in the param as that is respected
when following the link.

Add Test for the new link url for files with default action.
Remove test for multiple selects with ctrl-click
as that is not what we are doing anymore.

Signed-off-by: Azul <azul@riseup.net>
2020-04-09 16:41:09 +02:00
Christoph Wurst 64510932b8
Merge pull request #20384 from nextcloud/techdebt/lowercase-keywords
Use php keywords in lowercase
2020-04-09 16:25:14 +02:00
Christoph Wurst 3a415e4139
Remove space between switch case and colon
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:17:53 +02:00
Christoph Wurst f4c09f299d
Make sure there is exactly one newline after imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:14:31 +02:00
Christoph Wurst bcd13296de
Make sure every file ends with an empty newline
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
Christoph Wurst a8a06a82d2
Remove trailing whitespaces from comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:09:23 +02:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
Christoph Wurst 42625a46be
Remove spaces after method or function call
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:05:56 +02:00
Christoph Wurst 709584b853
Do not use closing tags
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:01:17 +02:00
Christoph Wurst c56a273b39
Merge pull request #20383 from nextcloud/techdebt/function-spacing
Unify function spacing to PSR2 recommendation
2020-04-09 15:53:09 +02:00
Christoph Wurst 36b3bc8148
Use php keywords in lowercase
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 14:04:56 +02:00
Christoph Wurst afbd9c4e6e
Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
John Molakvoæ 66b743385e
Merge pull request #20355 from nextcloud/fix/comments/clear-input/19585
Clear comment on successful post
2020-04-09 13:46:20 +02:00
Christoph Wurst 2a529e453a
Use a blank line after the opening tag
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:50:14 +02:00
Christoph Wurst 41b5e5923a
Use exactly one empty line after the namespace declaration
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
Christoph Wurst 2fbad1ed72
Fix (array) indent style to always use one tab
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
John Molakvoæ 732a239cfd
Merge pull request #20363 from nextcloud/smb-3.2.3
update icewind/smb to 3.2.3
2020-04-09 08:16:43 +02:00
Nextcloud bot b537e9fbc7
[tx-robot] updated from transifex 2020-04-09 02:18:26 +00:00
Christoph Wurst 85e369cddb
Fix multiline comments
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +02:00
Azul d2728cbdc1 refactor: fileActions.getCurrentDefaultFileAction()
fileActions.getCurrentDefaultFileAction() returns the default file action
for the currently selected file.

There were a number of places querying for the mime, type and permissions
of that file first to then query for the default action.

Signed-off-by: Azul <azul@riseup.net>
2020-04-08 18:19:58 +02:00
Robin Appelman 2340f4f2d5
update icewind/smb to 3.2.3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-04-08 17:30:47 +02:00
Joas Schilling 3ea37d0d10
Show the displayname instead of the user id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-08 16:09:03 +02:00
Joas Schilling f8a5812f98
Try to use the display name of file transfers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-08 15:41:20 +02:00