e2453d78c0
Properly catch whether a share is `null`
...
Despite it's PHPDoc the function might return `null` which was not properly catched and thus in some situations the share was resolved to the sharing users root directory.
To test this perform the following steps:
* Share file in owncloud 7 (7.0.4.2)
* Delete the parent folder of the shared file
* The share stays is in the DB and the share via the sharelink is inaccessible. (which is good)
* Upgrade to owncloud 8 (8.0.2) (This step is crucial. The bug is not reproduceable without upgrading from 7 to 8. It seems like the old tokens are handled different than the newer ones)
* Optional Step: Logout, Reset Browser Session, etc.
* Access the share via the old share url: almost empty page, but there is a dowload button which adds a "/download" to the URL.
* Upon clicking, a download.zip is downloaded which contains EVERYTHING from the owncloud directory (of the user who shared the file)
* No exception is thrown and no error is logged.
This will add a check whether the share is a valid one and also adds unit tests to prevent further regressions in the future. Needs to be backported to ownCloud 8.
Adding a proper clean-up of the orphaned shares is out-of-scope and would probably require some kind of FK or so.
Fixes https://github.com/owncloud/core/issues/15097
2015-03-24 11:21:58 +01:00
946a7c3a83
Use 24h format instead of 12h format
...
Use correct time format in WebUI
2015-03-24 11:20:20 +01:00
ce5d2ab7db
Revert "Change to 24H format instead of 12H format"
...
This reverts commit 8279dde97a
2015-03-24 11:08:53 +01:00
9cb07f126d
[tx-robot] updated from transifex
2015-03-24 01:55:24 -04:00
8279dde97a
Change to 24H format instead of 12H format
...
Update how the time shows in WebUI.
My first PR to core, woha. :)
2015-03-23 22:05:44 +01:00
10eeb35167
Merge pull request #15121 from owncloud/email-sent-unbold
...
unbold share email sent notification
2015-03-23 18:57:20 +01:00
e8d12c1809
Merge pull request #15075 from owncloud/fix-15056-master
...
remove unneeded status element from json response on /categories
2015-03-23 18:30:40 +01:00
c2ccaf000a
add Tips & tricks section to admin settings
2015-03-23 18:19:13 +01:00
d4e5ef4f38
Removed simplified X-accel-redirect even further
2015-03-23 17:51:12 +01:00
8906158d3b
Merge pull request #15123 from owncloud/fix_14098
...
offset needs to be considered in computed limit
2015-03-23 17:50:24 +01:00
eb894e6625
Soft fail in CustomPropertiesBackend whenever storage not available
...
When a storage is not available, it will not fail the whole call any
more but still return a usable file list.
2015-03-23 17:41:32 +01:00
02c0fe8d43
Merge pull request #13941 from owncloud/fix-folder-upload-on-firefox
...
Show message if upload of folder isn't allowed
2015-03-23 17:18:46 +01:00
0adcb99110
Merge pull request #14862 from owncloud/introduce-shipped.json-master
...
shipped apps are now defined in core/shipped.json - the shipped tag in i...
2015-03-23 17:17:33 +01:00
fd8a134dd2
unbold share email sent notification
2015-03-23 16:53:20 +01:00
7520d0fb3d
offset needs to be considered in computed limit
2015-03-23 16:51:40 +01:00
c93e4c806a
Merge pull request #15114 from owncloud/sharing-labels
...
combine labels with inputs in sharing dialog, fix #14796
2015-03-23 16:46:53 +01:00
7f2b06dfa0
Merge pull request #15120 from owncloud/ldap-occ-fix-warnings
...
fix PHP warnings when using occ with some LDAP commands
2015-03-23 16:29:27 +01:00
fe5597b76e
Merge pull request #15118 from owncloud/user-mgmt-groups
...
fix long group names overlapping in the sidebar, fix #12649
2015-03-23 16:15:24 +01:00
c432b52c74
Changed the disputed while loop to a single if.
2015-03-23 16:12:03 +01:00
79f012d262
remove unneeded status element from json response on /categories - fixes 15056
2015-03-23 15:20:06 +01:00
468fc675a4
fix PHP warnings when using occ with some LDAP commands
2015-03-23 15:19:41 +01:00
33cd60ab9a
adding enterprise apps to shipped.json
2015-03-23 15:11:16 +01:00
1a26263123
Do not walk over the users directory, but over the list of tagged objects
...
Way quicker
2015-03-23 15:10:58 +01:00
23396a52cd
fix long group names overlapping in the sidebar, fix #12649
2015-03-23 14:57:07 +01:00
5130eca3e3
combine labels with inputs in sharing dialog, fix #14796
2015-03-23 14:40:56 +01:00
0e4ba618cf
Merge pull request #14383 from jknockaert/newbranch
...
make encryption stream wrapper seekable
2015-03-23 09:22:36 -04:00
98e770b68e
Merge pull request #15107 from owncloud/user-mgmt-header
...
fix first user mgmt header jumping around, fix #8873
2015-03-23 14:22:16 +01:00
f64ddad29d
Merge pull request #15108 from owncloud/issue/15049-iran-timezone
...
The iran timezone removed the DST handling which breaks the timezone lib
2015-03-23 14:21:47 +01:00
1686653fdd
The iran timezone removed the DST handling which breaks the timezone lib
2015-03-23 14:08:47 +01:00
5ec547a05f
Merge pull request #15103 from owncloud/link-personal
...
link back to top on Personal page
2015-03-23 14:03:57 +01:00
7079b1b434
fix first user mgmt header jumping around, fix #8873
2015-03-23 13:46:05 +01:00
f899d77ba5
fix capitalization in Personal settings
2015-03-23 13:42:33 +01:00
731c90a033
link back to top on Personal page, fix #14519
2015-03-23 13:41:40 +01:00
a9b4f0d842
[tx-robot] updated from transifex
2015-03-23 01:54:48 -04:00
21bc8e0c81
Merge pull request #15088 from oparoz/3d-support
...
Introducing 3D images support (media type)
2015-03-22 23:14:02 +01:00
a79d973005
[tx-robot] updated from transifex
2015-03-22 01:55:21 -04:00
bdde2156da
Added extra unit test
2015-03-21 09:47:07 +01:00
9ce8e1ddc7
OCS API should return fancy OC url
...
* Also use the URLGenerator
2015-03-21 09:47:06 +01:00
599ee5ce4e
fixing #15023 , getting comments out of HTML output
2015-03-21 07:10:46 +01:00
e36a33c89a
[tx-robot] updated from transifex
2015-03-21 01:56:09 -04:00
f3fe46685b
Introducing 3D images support (media type)
...
So that people with 3D images can at least see a 2D picture
Full 3D support is possible via an app
2015-03-20 22:11:42 +01:00
6c98925621
Merge pull request #14737 from owncloud/app-descriptions-collapsible
...
collapse app descriptions by default, make expandable, fix #13112
2015-03-20 17:51:51 +01:00
1f3fdf17ef
Support constructing an SMB_OC without saved session credentials
2015-03-20 16:24:30 +00:00
83e35412e6
Merge pull request #15069 from owncloud/enable-oci-testing-on-pr-master
...
Adding magic file to enable oci on pull request testing on ci.owncloud.o...
2015-03-20 17:01:04 +01:00
afa8872955
Merge pull request #14857 from owncloud/preview-provider-registration-in-manager
...
Preview provider registration in manager
2015-03-20 16:34:22 +01:00
4477053818
Adding magic file to enable oci on pull request testing on ci.owncloud.org
2015-03-20 15:00:51 +01:00
a45e45df1e
Merge pull request #14941 from AdamWill/pipeline-apps
...
fall back to absolute path for pipelined assets (#14940 )
2015-03-20 14:56:02 +01:00
e44ab2dcfe
Merge pull request #11884 from owncloud/ext-appframework
...
Cleanup ext storage CRUD code, introduce storage config id
2015-03-20 14:17:32 +01:00
0b1c4bfc3b
Merge pull request #15062 from owncloud/fix-15053-master
...
Handle session initialization errors and display error page
2015-03-20 14:07:15 +01:00
7ea5c47b3c
Merge pull request #15063 from owncloud/share-readonlyfile-permissions
...
Do not automatically add "update" permission to shared mounts
2015-03-20 14:06:55 +01:00
Lukas Reschke
Daniel Hansson
Vincent Petry
Jenkins for ownCloud
Morris Jobke
Thomas Müller
Jan-Christoph Borchardt
dratini0
blizzz
Joas Schilling
Clark Tomlinson
Roeland Jago Douma
Volker E
Olivier Paroz
Robin McCorkell