Commit Graph

18912 Commits

Author SHA1 Message Date
Christoph Wurst 4c6bc62f38
Merge pull request #25535 from nextcloud/query-exception-foreward
Improve exception when auto-wiring fails
2021-02-09 14:27:43 +01:00
Christoph Wurst 4fc0b2c639
Deprecate all remaining event constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 13:53:41 +01:00
Robin Appelman ec875227ec
forward query exception when fallback construction fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-09 13:15:22 +01:00
Christoph Wurst 3d075c370a
Deprecate the internal IDBConnection event name constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 11:27:59 +01:00
Christoph Wurst abc61a9f63
Fix the legacy dispatcher argument order
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 10:47:14 +01:00
Nextcloud bot 9eea1e56dc
[tx-robot] updated from transifex 2021-02-09 02:20:45 +00:00
Robin Appelman 3401be216d
forward original query exception when querying by name fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-08 19:13:25 +01:00
Nextcloud bot 26a20ed13f
[tx-robot] updated from transifex 2021-02-08 02:20:05 +00:00
Nextcloud bot f19287ae57
[tx-robot] updated from transifex 2021-02-07 02:20:51 +00:00
Joas Schilling 98032425b4 Fix linter
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
Joas Schilling ef7ed47f14 Make Psalm happy
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:06 +01:00
Joas Schilling 1344c61145 Improve mention matches
The previous regex didn't correctly match users with . ' or -

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-06 13:07:05 +01:00
Roeland Jago Douma cd77b1f238
Merge pull request #25499 from nextcloud/test/symfony-adapter
Test the symfony adapter / fix missing return object
2021-02-06 13:01:23 +01:00
Nextcloud bot 8bb6bb53ad
[tx-robot] updated from transifex 2021-02-06 02:20:50 +00:00
Roeland Jago Douma 6e461248e0
Merge pull request #25500 from Worteks/fix-sharemanager-genericshareexception
fix(translation): replace static error message
2021-02-05 16:17:34 +01:00
Samuel 3a077a3903 revert(comment)
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 13:27:37 +01:00
Samuel 5f8dfa8e4c revert(exception): keep throwing an exception for now
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:52:59 +01:00
Christoph Wurst f6ddda8dad
Test the symfony adapter
To prevent regression in the future.

And make sure we always return an object …

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-05 12:14:47 +01:00
Samuel 59e43b4828 fix(translation): replace static error message
as suggested by @kesselb in nextcloud/server#25490

Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:06:35 +01:00
Christoph Wurst 91e1707498
Log deprecation notice of GenericEventWrapper just once
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-05 08:45:58 +01:00
Nextcloud bot c935f6a776
[tx-robot] updated from transifex 2021-02-05 02:21:31 +00:00
Nextcloud bot df9ce19a6b
[tx-robot] updated from transifex 2021-02-04 02:20:03 +00:00
Roeland Jago Douma 137636b651
Merge pull request #24700 from Imajie/s3-creds
Resolves #24699, Support ES2 and ECS instance providers for S3 buckets
2021-02-02 21:48:22 +01:00
Roeland Jago Douma 5c6d245661
Merge pull request #25393 from nextcloud/fix/25165/repair-dav-shares
add repair job for unencoded group share uris
2021-02-02 21:43:42 +01:00
Julius Härtl 18e2e86b95
Avoid template creators being registered multiple times
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-02 19:36:31 +01:00
Christoph Wurst ad2033ef1d
Merge pull request #25444 from nextcloud/bug/25415/move-generic-errors-to-end
Check for generic errors at last.
2021-02-02 18:59:43 +01:00
Daniel Kesselberg fe378200fa
Check for generic errors at last.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-02-02 18:28:49 +01:00
Nextcloud bot e18c608cb4
[tx-robot] updated from transifex 2021-02-02 02:19:50 +00:00
Nextcloud bot 86678ba5df
[tx-robot] updated from transifex 2021-02-01 02:19:36 +00:00
Nextcloud bot d1bdd1ceba
[tx-robot] updated from transifex 2021-01-31 02:19:02 +00:00
Nextcloud bot fcbe4c5be5
[tx-robot] updated from transifex 2021-01-30 02:20:34 +00:00
Arthur Schiwon 3ecc6d0a8a
show suggestion to clean up possible invalid shares later
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 17:43:58 +01:00
Arthur Schiwon 558f062ca6
add repair job for unencoded calendars
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 17:29:10 +01:00
Christoph Wurst 8fcc0e8d8c
Merge pull request #25302 from mziech/patch-2
Use RFC-compliant URL encoding for cookies
2021-01-29 13:38:02 +01:00
Julius Härtl 222d8e6c1a
Use proper path for scanner
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-29 09:40:46 +01:00
Julius Härtl 0d384dedaa
Obtain the user language from the passed in user id
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-29 08:56:32 +01:00
Julius Härtl 39a4b1c401
Normalize compared path to avoid renaming to the same directory
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-29 08:43:17 +01:00
Roeland Jago Douma 7e727a1a31 The objectid is a string
This allows the query to use the index. Else it has to resort on
scanning all the rows.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-28 22:09:55 +01:00
Roeland Jago Douma e29f903dc4
Merge pull request #25360 from nextcloud/fix/update-autoloaders
Update all composer autoloader files
2021-01-28 20:38:22 +01:00
Christoph Wurst 299f37c5d9
Update all composer autoloader files
The format changed between 2.0.8 and 2.0.9.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-28 14:24:34 +01:00
Julius Härtl a71bb8a485
Make whole Template class final
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:21 +01:00
Julius Härtl 6c1b357973
Move TemplateProvider registration to boot context and make template type registration lazy
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:21 +01:00
Julius Härtl 0111381529
Only create template directory if it is present in the default skeleton
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
John Molakvoæ (skjnldsv) 4f90766ba3
Skip template picker if none available
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-28 12:00:20 +01:00
Julius Härtl 7e6d69d166
Add templatedirectory config value to let admins have their custom templates by default
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
Julius Härtl 66fa3fca83
Add ratio to template creators
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 12:00:20 +01:00
John Molakvoæ (skjnldsv) 78e114ed72
Add template picker
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-28 12:00:18 +01:00
Julius Härtl 4974404774
files: Create files from template API
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-28 11:59:46 +01:00
Roeland Jago Douma 3a9c7f99f6
Merge pull request #25335 from nextcloud/fix/app-fetcher-php-compat-comparison
Fix/app fetcher php compat comparison
2021-01-27 15:14:52 +01:00
Christoph Wurst e0f0e6e41a
Merge pull request #25268 from nextcloud/enh/previews/sgi-tga
Add SGI and TGA preview support
2021-01-27 14:54:27 +01:00
Nextcloud bot baba83e185
[tx-robot] updated from transifex 2021-01-27 02:20:46 +00:00
Christoph Wurst b4f71ccf4d
Fix app fetcher php comparison to allow wider ranges
When app app specifies php 7.4 as upper limit we have to allow the
installation on php>7.4.0. The previous version check didn't do that.
This adjusts the regexes to discard any irrelevant suffix after the
three version numbers so that we can use more fine granular checks than
php's version_compare can do out of the box, like for php 7.4 we only
compare the major and minor version numbers and ignore the patch level.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-26 16:35:43 +01:00
Christoph Wurst 652bf9d363
Revert "Fix comparison of PHP versions"
This reverts commit bedd9acf78.
2021-01-26 13:48:06 +01:00
Nextcloud bot b98860eeb3
[tx-robot] updated from transifex 2021-01-25 02:20:31 +00:00
Marco Ziech 4923c6be25
Use RFC-compliant URL encoding for cookies
PHP 7.4.2 changed the way how cookies are decoded, applying RFC-compliant raw URL decoding. This leads to a conflict Nextcloud's own cookie encoding, breaking the remember-me function if the UID contains a space character.

Fixes #24438

Signed-off-by: Marco Ziech <marco@ziech.net>
2021-01-24 14:18:28 +01:00
Morris Jobke 1d2707ad78
Merge pull request #25273 from nextcloud/enhancement/hide-two-factor-settings-if-no-providers
Do not show 2FA settings if the user has no providers available
2021-01-22 16:26:17 +01:00
Morris Jobke 47b10c3775
Merge pull request #25275 from nextcloud/fix/two-factor-token-type
Convert 2FA token type to string
2021-01-22 16:14:45 +01:00
Christoph Wurst ac591e2fc2
Fully deprecate the old initial state interface, not just the methods
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 14:53:26 +01:00
blizzz 939433363e
Merge pull request #25128 from nextcloud/ldapprovider-get-property
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
2021-01-22 14:31:19 +01:00
blizzz f15148f695
adjust since
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Co-authored-by: Morris Jobke <hey@morrisjobke.de>
2021-01-22 14:29:39 +01:00
Christoph Wurst 99d525eb36
Convert 2FA token type to string
The IConfig service is documented to handle its data as strings, hence
this changes the code a bit to ensure we store keys as string and
convert them back when reading.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 14:09:37 +01:00
Christoph Wurst 378f116a63
Do not show 2FA settings if the user has no providers available
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 13:55:22 +01:00
John Molakvoæ (skjnldsv) 0bc9e3ca15
Change license mail alias
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-22 13:06:35 +01:00
John Molakvoæ (skjnldsv) d47b84be67
Add SGI and TGA preview support
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-01-22 10:42:51 +01:00
Nextcloud bot 7989247574
[tx-robot] updated from transifex 2021-01-22 02:19:54 +00:00
Morris Jobke 10214fbee0
Merge pull request #25214 from nextcloud/dependabot/composer/phpseclib/phpseclib-2.0.30
Bump phpseclib/phpseclib from 2.0.25 to 2.0.30
2021-01-21 10:25:02 +01:00
Roeland Jago Douma d4d33e3095
Merge pull request #25238 from nextcloud/enh/noid/apps-defacto-in-root
Apps folder is defacto in root folder and not above
2021-01-21 09:08:54 +01:00
Roeland Jago Douma 15b0e4d922
Merge pull request #25240 from nextcloud/enh/noid/re-use-fetched-dependencies
Re-use fetched dependencies in lib/base.php
2021-01-21 08:54:05 +01:00
Julius Härtl 349b65eff3
Merge pull request #25236 from nextcloud/mkdir-explicit-chmod
explicitly set permissions on newly created folders
2021-01-21 07:56:10 +01:00
Nextcloud bot 054783e385
[tx-robot] updated from transifex 2021-01-21 02:20:36 +00:00
Morris Jobke d84e1f1951
Re-use fetched dependencies in lib/base.php
Reduces calls to DI container by reusing already fetched dependencies.

For status.php it went from 355 to 344.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 21:55:16 +01:00
Morris Jobke 5b0e69828f
Apps folder is defacto in root folder and not above
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 21:22:39 +01:00
Robin Appelman d182043e83
explicitly set permissions on newly created folders
this works around any `umask` that might be set and limiting the folder permissions

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-20 17:15:57 +01:00
Morris Jobke 4c81f5c4ad
Merge pull request #25212 from nextcloud/enh/preview-markdown
Enhance markdown file preview rendering
2021-01-20 15:02:41 +01:00
Morris Jobke 01f013661a
Fix typo in comment
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-20 15:02:32 +01:00
Morris Jobke 6129a85187
Merge pull request #25224 from nextcloud/bugfix/24600/fix-saving-user-credentials
Update handling of user credentials
2021-01-20 14:59:30 +01:00
Julius Härtl aed1fde6fd
Enhance markdown file preview rendering
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-20 11:07:55 +01:00
Roeland Jago Douma fcbbcacab4 Also load CA properly in integrity check
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-20 10:57:41 +01:00
Roeland Jago Douma d751fedffb phpsec lib can't parse multiple certs in one go
So we have to split it manually and do it ourselves

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-20 10:57:41 +01:00
Roeland Jago Douma 3d61adc908
Drop authtoken_version_index
The index was used when deleting old tokens. On top of that the index is
of course not that great since the version is either 1 or 2.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-20 09:34:41 +01:00
Joas Schilling 6c1e294edd
Compare and store the login name via the event
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-20 08:50:17 +01:00
Roeland Jago Douma 6d4afca7ac Add support for webp
Including handling in OC_Image
But also a preview provider

Of course only works if your php actually supports webp

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-19 20:17:10 +01:00
Robin Appelman fdc8635afb
extend ILDAPProvider to allow reading arbitrairy ldap attributes for users
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-19 16:33:58 +01:00
Roeland Jago Douma 0893bba369
Merge pull request #25153 from nextcloud/bugfix/noid/force-signature-verification-on-occ
Force signature verification of apps on occ
2021-01-19 09:35:52 +01:00
Nextcloud bot 91864aeb40
[tx-robot] updated from transifex 2021-01-19 02:20:43 +00:00
Joas Schilling 847aa08ebd
Don't log keys on checkSignature
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 16:09:06 +01:00
Joas Schilling 76c7356af9
Only use alphanumeric chars for mysql password
/ and + can cause problems with other tools that you might want to run on your Nextcloud database.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 12:03:52 +01:00
Joas Schilling 90c3013d40
Cleanup the constructor
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +01:00
Joas Schilling f319660f60
Force run the verification of the signature on occ
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-18 11:32:50 +01:00
Nextcloud bot 6d291c3c19
[tx-robot] updated from transifex 2021-01-18 02:19:28 +00:00
Nextcloud bot 1907cc197d
[tx-robot] updated from transifex 2021-01-17 02:19:53 +00:00
Joas Schilling eafd281800
Merge pull request #25138 from gouttegd/fix25137
Fix comparison of PHP versions
2021-01-15 15:18:25 +01:00
Morris Jobke bcb52d64f0
Merge pull request #25141 from nextcloud/bugfix/noid/add-a-hint-about-priority
Add a hint about the direction of priority
2021-01-15 09:46:37 +01:00
Joas Schilling b8acf2fe69
Add a hint about the direction of priority
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-15 08:34:24 +01:00
Damien Goutte-Gattat bedd9acf78 Fix comparison of PHP versions
Use the builtin function `version_compare` to check an app's
compatibility with the available PHP version, instead of reusing
the `OC\App\CompareVersion::isCompatible` method which is intended
to compare Nextcloud versions. PHP version strings do not always
necessarily follow the simple Major.Minor.Patch format used by
Nextcloud and therefore cannot be properly compared by that method.

Signed-off-by: Damien Goutte-Gattat <dgouttegattat@incenp.org>
2021-01-14 23:03:20 +00:00
Christoph Wurst b9287f9780
Merge pull request #25091 from nextcloud/enhancement/ocp-db-exception-abstraction
Add our own DB exception abstraction
2021-01-14 12:27:23 +01:00
blizzz f9ab7575e7
Merge pull request #25036 from nextcloud/fix/noid/limitied-allowed-items-db-in_2
respect DB restrictions on number of arguments in statements and queries
2021-01-14 11:36:42 +01:00
Nextcloud bot 6cf9c88596
[tx-robot] updated from transifex 2021-01-13 02:20:19 +00:00
Christoph Wurst 2c9cdc1cdb
Add our own DB exception abstraction
Right now our API exports the Doctrine/dbal exception. As we've seen
with the dbal 3 upgrade, the leakage of 3rdparty types is problematic as
a dependency update means lots of work in apps, due to the direct
dependency of what Nextcloud ships. This breaks this dependency so that
apps only need to depend on our public API. That API can then be vendor
(db lib) agnostic and we can work around future deprecations/removals in
dbal more easily.

Right now the type of exception thrown is transported as "reason". For
the more popular types of errors we can extend the new exception class
and allow apps to catch specific errors only. Right now they have to
catch-check-rethrow. This is not ideal, but better than the dependnecy
on dbal.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 16:38:23 +01:00
blizzz 3447ea4955
Merge pull request #25089 from nextcloud/enhancement/ocp-db-types
Add our own db column types via the public API
2021-01-12 15:24:15 +01:00