Morris Jobke
3d4c698f44
Improve OC_Image code to not guess the type of input, but actually request the specific methods to be called
...
Followup to #7836
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-18 13:40:55 +01:00
Morris Jobke
d0c46ab45e
Merge pull request #7923 from nextcloud/files_external_ocscontroller
...
[files_external] OCS endpoint to proper OCSController
2018-01-18 12:17:46 +01:00
Morris Jobke
d78a4daf7e
Merge pull request #7924 from nextcloud/dep_iappconfig
...
Remove deprecated function from IAppConfig
2018-01-18 12:03:55 +01:00
Morris Jobke
4836a5e536
Merge pull request #7930 from nextcloud/update-notification-strict
...
Make Update notficiations strict and fix all inspections
2018-01-18 12:00:35 +01:00
Roeland Jago Douma
05f75f803a
[files_external] OCS endpoint to proper OCSController
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-18 11:15:03 +01:00
Joas Schilling
19f7cc9e92
Make Update notficiations strict and fix all inspections
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-18 10:55:44 +01:00
Morris Jobke
9296116297
Merge pull request #7863 from nextcloud/update-notifications-plusplus
...
Update notifications ++
2018-01-18 10:51:14 +01:00
Nextcloud bot
b6eb50069b
[tx-robot] updated from transifex
2018-01-18 01:10:40 +00:00
Roeland Jago Douma
1e7b20f615
Remove IAppConfig::setValue
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 21:41:57 +01:00
Roeland Jago Douma
09f8a755ec
Remove IAppConfig::getValue
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 21:41:56 +01:00
Roeland Jago Douma
ee2617d88c
Simple IAppConfig deprecations
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 21:03:04 +01:00
Roeland Jago Douma
e628424ccf
Warn about the old OCP\API::register construct for OCS
...
* Add sleep
* Add log message
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-17 15:18:22 +01:00
Roeland Jago Douma
6e29b8731e
Merge pull request #7914 from nextcloud/fix-7254
...
format self-mentions, but don't offer them
2018-01-17 14:59:46 +01:00
Arthur Schiwon
39f34603f2
add types to php doc
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-17 13:58:42 +01:00
Arthur Schiwon
6fdd686111
do not offer the handle of the current user for auto completion
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-17 13:49:18 +01:00
Arthur Schiwon
3784fa2074
comments should compile mentions also if done by author
...
it is used by clients for formatting reasons, there is no reason not format
the author if her handle is included in the comment body.
It is unrelated to sending out notifications.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-01-17 13:48:43 +01:00
Morris Jobke
24c58d39f4
Merge pull request #7909 from nextcloud/fix-migration-type-hints
...
Fix the type hints of migrations and correctly inject the wrapped sch…
2018-01-17 13:47:58 +01:00
Roeland Jago Douma
f8756d96bc
Merge pull request #7847 from nextcloud/avatarmanager_strict
...
Fixes for avatarmanager
2018-01-17 13:46:18 +01:00
Roeland Jago Douma
73cc4ac1f6
Merge pull request #7912 from nextcloud/bugfix/noid/correctly-drop-owncloud-migrations-table
...
Correctly drop the ownCloud migrations table
2018-01-17 13:45:36 +01:00
Joas Schilling
0d37d24b4b
Correctly drop the ownCloud migrations table
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-17 12:17:41 +01:00
Morris Jobke
c121610d5a
Merge pull request #7813 from nextcloud/getHeader-should-only-return-string
...
Request->getHeader() should always return a string
2018-01-17 11:42:31 +01:00
Morris Jobke
9222dcd940
Merge pull request #7836 from nextcloud/image-type-hinting
...
Fix float/integer handling in image API
2018-01-17 11:40:35 +01:00
Joas Schilling
4a5282ba21
Fix the type hints of migrations and correctly inject the wrapped schema into migrations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-01-17 11:37:36 +01:00
Roeland Jago Douma
6e95bd7a51
Merge pull request #7899 from nextcloud/strict_discservice
...
Strict DiscoveryService
2018-01-17 10:01:56 +01:00
Morris Jobke
e4b3ee8d8f
Fix float/integer handling in image API
...
* IImage::crop/preciseResize now have type hinting for integers
* found while testing strict typing for PHP 7+
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-17 10:00:33 +01:00
Morris Jobke
4ef302c0be
Request->getHeader() should always return a string
...
PHPDoc (of the public API) says that this method returns string but it also returns null, which is not allowed in some method calls. This fixes that behaviour and returns an empty string and fixes all code paths that explicitly checked for null to be still compliant.
Found while enabling the strict_typing for lib/private for the PHP7+ migration.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-17 09:51:31 +01:00
Morris Jobke
22b3280ac2
Merge pull request #7897 from nextcloud/strict_lockingproviders
...
Made locking providers strict
2018-01-17 09:33:52 +01:00
Morris Jobke
cb0dbfa987
Merge pull request #7900 from nextcloud/strict_security
...
Make OCP\Security stricter
2018-01-17 09:29:32 +01:00
Roeland Jago Douma
d1420ef481
Merge pull request #7901 from nextcloud/strict_cache_factory
...
Made the cache factory strict
2018-01-17 06:51:04 +01:00
Morris Jobke
0b464e5274
Merge pull request #7884 from nextcloud/cleanup-oc_user
...
Cleanup OC_User and OCP\User
2018-01-17 05:33:07 +01:00
Nextcloud bot
ca2904a017
[tx-robot] updated from transifex
2018-01-17 01:10:58 +00:00
Roeland Jago Douma
569b8413d4
Add extra check so we don't error out on type
...
json_decode can return false if we have invalid data.
In that case just assume there was nothing cached
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 22:06:57 +01:00
Roeland Jago Douma
0e0db37658
Make OCP\Security stricter
...
* Add typehints
* Add return types
* Opcode opts from phpstorm
* Made strict
* Fixed tests: No need to test bogus values anymore strict typing fixes
this
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 22:01:19 +01:00
Roeland Jago Douma
c5fcfb0709
Made the cache factory strict
...
* Return types
* Typehints
* made strict
* fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 21:58:20 +01:00
Roeland Jago Douma
8edbfdb291
Made locking providers strict
...
* Added typehints
* Added return types
* Made strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 21:54:20 +01:00
Morris Jobke
117c1c90df
Merge pull request #7894 from nextcloud/strict_http_client
...
Make OCP\Http strict
2018-01-16 21:49:18 +01:00
Julius Härtl
e7605d9adc
Merge pull request #7892 from nextcloud/cloudid_strict
...
Make OCP\Federation strict
2018-01-16 21:10:53 +01:00
Roeland Jago Douma
34e112739d
Merge pull request #7895 from nextcloud/proper-codcov-config
...
Improve codecov config to recognize drone
2018-01-16 21:02:41 +01:00
Roeland Jago Douma
cdfffe7bda
Strict DiscoveryService
...
* Made strict
* Type hints
* Return types
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 20:01:38 +01:00
Roeland Jago Douma
2b70c708ab
Merge pull request #7882 from nextcloud/search-and
...
Support arbitrary number of arguments for d:or and d:and in search queries
2018-01-16 19:53:01 +01:00
Roeland Jago Douma
fde1ada916
Fix federatedshareprovidertest
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 19:25:08 +01:00
Roeland Jago Douma
50acde36b7
Make OCP\Federation strict
...
* Also internal classes
* Added scalar typehints
* Added return type
* Made strict
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 19:25:08 +01:00
Roeland Jago Douma
a345605ec1
Make OCP\Http strict
...
* Handle private files
* Add return types
* Add scalar typehints
* Made strict
* Fixed requiring proper guzzle message interface that is passed around
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 19:19:58 +01:00
Morris Jobke
0db466719f
Improve codecov config to recognize drone
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 18:56:05 +01:00
Morris Jobke
55532f19d9
Cleanup OC_User and OCP\User
...
* mainly removes deprecated methods and old static code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 18:39:11 +01:00
Morris Jobke
a159d7c28c
Merge pull request #7891 from nextcloud/fix-systemtags-list
...
Fix systemtags/list to be compliant
2018-01-16 18:38:06 +01:00
Morris Jobke
c2cc30741a
Fix systemtags/list to be compliant
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2018-01-16 15:55:01 +01:00
Roeland Jago Douma
8614eb91db
Fix avatarHome
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-16 15:37:47 +01:00
Joas Schilling
13a787e2f5
Merge pull request #7885 from nextcloud/ocp-user-app-code-check
...
Add OCP\User deprecations to app code checker
2018-01-16 14:17:07 +01:00
Morris Jobke
61b0d65353
Merge pull request #7848 from nextcloud/fix_7701
...
Show message when connection is throttled
2018-01-16 14:00:15 +01:00