Joas Schilling
cae849bcf9
Merge pull request #21869 from nextcloud/techdebt/noid/add-constants-for-magic-strings
...
Add constants for the magic strings of template rendering
2020-07-16 22:00:57 +02:00
Roeland Jago Douma
884f3d009a
Discourage webauthn user interaction
...
Else people might have the feeling this is also doing 2FA. And since it
is only prefered it can be ignored and hacked around.
Once we have proper 2FA with webauthn in one go this probably needs to
be revisted.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-16 21:10:07 +02:00
Roeland Jago Douma
dfcb49b9b7
Merge pull request #21873 from nextcloud/techdebt/deprecate-server-container-getters
...
Deprecate the server container getters
2020-07-16 20:27:36 +02:00
Roeland Jago Douma
3085cf7341
Merge pull request #21874 from nextcloud/feature/scoped-psr-logger
...
Add a scoped PSR logger for apps
2020-07-16 20:25:40 +02:00
Roeland Jago Douma
514dc45468
Merge pull request #21855 from p5n/master
...
fix typo in revokeShare()
2020-07-16 19:58:49 +02:00
Christoph Wurst
b3b856c9db
Migrate contacts interaction to the PSR-3 logger
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 19:38:20 +02:00
Christoph Wurst
8a433a7226
Deprecate ILogger
...
The logger service was always intended to follow the PSR-3 interface.
It's time to embrace this and switch over to the "official" API,
hence this custom interface can be slowly phased out.
With Nextcloud 20 the logger also got support for
* App id filled out automatically
* Exceptions handling (as replacement for logException)
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 19:19:23 +02:00
Christoph Wurst
c889021334
Add a scoped PSR logger for apps
...
Just like for ILogger we should have a version that has the app ID
pre-set for the context (unless overwritten) so that each log entry can
be traced back to the app that produced it.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 19:11:56 +02:00
Christoph Wurst
efd2835b23
Deprecate the server container getters
...
Service locators are an anti pattern. These getters just make it more
appealing to do the wrong thing. If you want to locate a service the bad
way, just use the `get` method on a container – it will do the same in
also one line of code.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 18:59:56 +02:00
Christoph Wurst
684a7200ac
Merge pull request #21863 from nextcloud/techdebt/files-trashbin-container-cleanup
...
Clean up container usage in files trashbin
2020-07-16 18:46:10 +02:00
Christoph Wurst
35e966c38d
Migrate LDAP to the PSR container
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 15:57:17 +02:00
Christoph Wurst
090a54adab
Migrate settigns to the PSR container
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 15:55:04 +02:00
Christoph Wurst
3b0478773a
Migrate files versions to the PSR container
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 15:53:40 +02:00
Christoph Wurst
b641f25606
Migrate files sharing to the PSR container
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 15:52:46 +02:00
Joas Schilling
49970639fa
Add constants for the magic strings of template rendering
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-16 15:47:28 +02:00
Christoph Wurst
5005510d82
Migrate DAV to the PSR container
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 15:44:03 +02:00
Christoph Wurst
33aeef2d10
Merge pull request #21809 from nextcloud/techdebt/di-container-cleanup
...
Use PSR container interface and deprecate our own abstraction
2020-07-16 15:43:26 +02:00
Joas Schilling
0dfcc132ca
Allow to register AlternativeLogin on RegistrationContext
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-16 14:20:24 +02:00
Christoph Wurst
4152216bd8
Use PSR container interface and deprecate our own abstraction
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 13:35:45 +02:00
Roeland Jago Douma
b12d3691c3
Merge pull request #21858 from nextcloud/dependabot/npm_and_yarn/build/lodash-4.17.19
...
Bump lodash from 4.17.14 to 4.17.19 in /build
2020-07-16 10:43:11 +02:00
Christoph Wurst
9e7426a101
Clean up container usage in files trashbin
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 10:29:38 +02:00
dependabot[bot]
94ae095051
Bump lodash from 4.17.14 to 4.17.19 in /build
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.14 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.14...4.17.19 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-07-16 07:23:29 +00:00
Nextcloud bot
89fe5415f8
[tx-robot] updated from transifex
2020-07-16 02:19:30 +00:00
Sergej Pupykin
1655ba9aeb
fix typo
2020-07-16 02:19:21 +03:00
Morris Jobke
8368d56f8e
Merge pull request #21853 from nextcloud/enh/noid/better-event-description
...
Better event description for BeforeTemplateRenderedEvent in files and files_sharing
2020-07-15 21:19:14 +02:00
Morris Jobke
c4b53538af
Better event description for BeforeTemplateRenderedEvent in files and files_sharing
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-15 20:15:51 +02:00
Morris Jobke
16d0ef9576
Merge pull request #21815 from nextcloud/enh/noid/sharing-additional-scripts-event
...
Add LoadAdditionalScriptsEvent for files_sharing
2020-07-15 20:02:58 +02:00
Morris Jobke
fc41810d2f
Merge pull request #21822 from nextcloud/enh/events/additionalscripts
...
Add real events to load additionalscripts
2020-07-15 19:50:01 +02:00
Morris Jobke
aed5eb55af
Merge pull request #21843 from nextcloud/debt/noid/less-verbose-translation-checker
...
Make translation-checker.php less verbose
2020-07-15 19:37:51 +02:00
Morris Jobke
cc258ad51a
Merge pull request #21844 from bladewing/bladewing-harden-against-mimetype-mismatch
...
Avoid substr() error when strpos returns false
2020-07-15 19:33:09 +02:00
Morris Jobke
638e9438a9
Merge pull request #21728 from nextcloud/bugfix/noid/s3-external-mtime-cache
...
Reuse cache for directory mtime/size if filesystem changes can be ignored
2020-07-15 18:26:48 +02:00
Morris Jobke
e27f8aa3e5
Merge pull request #21837 from nextcloud/enh/noid/also-show-cs-diff
...
Run cs:check a second time to show diff
2020-07-15 16:19:59 +02:00
Morris Jobke
f30ecbfadd
Merge pull request #21848 from nextcloud/techdebt/deprecate-internal-symfony-dispatcher-adapter
...
Deprecate the internal Symfony dispatcher adapter
2020-07-15 16:18:56 +02:00
Morris Jobke
19afeda366
Merge pull request #21849 from nextcloud/fix/noid/integration-tests
...
Fix integration test due to new dashboard app
2020-07-15 16:18:05 +02:00
Daniel Kesselberg
08cb4b8172
Run cs:check a second time to show diff
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-15 15:35:58 +02:00
Morris Jobke
8dd48f3dc8
Fix integration test due to new dashboard app
...
See #21346
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-15 14:07:59 +02:00
Roeland Jago Douma
7d7ba61625
Add real events to load additionalscripts
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-15 14:07:18 +02:00
Christoph Wurst
b9a911f0b3
Deprecate the internal Symfony dispatcher adapter
...
This type is not known on the public API, yet we should make sure that
any usage of this class is noticed and migrated as soon as possible.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-15 13:57:35 +02:00
Julius Härtl
217a69ebf9
Add BeforeTemplateRenderedEvent for files_sharing
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 13:55:26 +02:00
Roeland Jago Douma
da4f3559c5
Merge pull request #21720 from nextcloud/search-min-length-feedback
...
provide feedback about minimum length needed to trigger search
2020-07-15 12:31:03 +02:00
Daniel Kesselberg
5ffe9fc7db
Make translation-checker.php less verbose.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-15 11:29:12 +02:00
Robin Appelman
128910ebf1
provide feedback about minimum length needed to trigger search
...
instead of telling users that there are no results, tell them that search hasn't been triggered yet
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-07-15 11:19:51 +02:00
Roeland Jago Douma
f04f9321df
Merge pull request #21346 from nextcloud/enh/20930/dashboard
...
Dashboard API
2020-07-15 11:10:15 +02:00
Julius Härtl
6b2bb32f23
Bump bundles
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 10:54:34 +02:00
Roeland Jago Douma
24ec4a83ba
Merge pull request #21683 from nextcloud/dependabot/npm_and_yarn/babel/plugin-proposal-class-properties-7.10.4
...
Bump @babel/plugin-proposal-class-properties from 7.10.1 to 7.10.4
2020-07-15 10:34:44 +02:00
lui87kw
3fe3d1fca3
Extra white space to follow other ifs
...
Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
2020-07-15 10:18:47 +02:00
bladewing
7dafd5831f
Avoid substr() error when strpos returns false
...
"Exception: substr() expects parameter 3 to be int, bool given" can occur on Line 378 $mimePart = substr($icon, 0, strpos($icon, '-'));
This happens, when '-' is not found and strpos returns false instead of an int.
When this occurs, e.g., Activity hangs.
Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
2020-07-15 10:18:47 +02:00
Julius Härtl
0c35218e61
Include name in translatable greeting
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:28:12 +02:00
Julius Härtl
35bdb998ef
Dashboard strict typing
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:28:12 +02:00
Julius Härtl
e6fb1b9878
Load more than one panel
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-07-15 09:28:12 +02:00