e1096c964d
Fix getMock Security
2016-09-07 20:42:38 +02:00
dc60f4c441
Fix getMock Repair
2016-09-07 20:42:38 +02:00
1b5ed67857
Fix getMock Migration
2016-09-07 20:42:38 +02:00
b8b9fc2b1c
Fix getMock OCSClient
2016-09-07 20:42:38 +02:00
c95d5c77d7
Fix getMock LegacyHelperTest
2016-09-07 20:42:38 +02:00
f167e65d49
Fix getMock L10NTest
2016-09-07 20:42:38 +02:00
ba3a90d30c
Fix getMock checkertest
2016-09-07 20:42:37 +02:00
97f6410ac8
Fix getMock Http Client
2016-09-07 20:42:37 +02:00
aa670cab14
Fix getMock HTTPHelper
2016-09-07 20:42:37 +02:00
28c801b3d5
Fix getMock MetaDataTest
2016-09-07 20:42:37 +02:00
7656a8fa12
File getMock Files tests
2016-09-07 20:42:37 +02:00
a819fd3f1e
Fix getMock FileChunkingTest
2016-09-07 20:42:37 +02:00
4da1ee99d6
Fix getMock Encryption
2016-09-07 20:42:37 +02:00
9ea2153e9b
Fix getMock Command/Intergrity
2016-09-07 20:42:37 +02:00
4066f04c4b
Fix getMock MapperTestUtility
2016-09-07 20:42:37 +02:00
2d9574db34
fix tests
2016-09-07 17:27:41 +02:00
e8e950a4d2
more efficient querying of numeric storage ids
2016-09-07 17:22:40 +02:00
7c0951244a
Deprecate getEditionString()
2016-09-06 16:05:28 +02:00
b6bdf81d55
Merge pull request #1275 from nextcloud/OCS_forward_headers_cleanup
...
Internal OCS Controller cleanup
2016-09-06 14:46:05 +02:00
3c55fe6bab
Split OCS version handling
...
This cleans up a bit the OCSController/Middleware. Since the 2 versions
of OCS differ a bit. Moved a lot of stuff internal since it is of no
concern to the outside.
2016-09-06 11:57:39 +02:00
c609e291bd
Fix getMock share
2016-09-06 09:33:48 +02:00
1a05201543
Fix getMock Avatar
2016-09-06 09:33:48 +02:00
4d3b92e687
Fix getMock Authentication
2016-09-06 09:29:27 +02:00
777c3ee325
Add FileDisplayResponse
...
A lazy implementation of the DisplayResponse that only hits the
filesystem if the etag and mtime do not match.
2016-09-05 15:09:54 +02:00
06fa486706
Merge pull request #1158 from nextcloud/cache_avatars
...
Cache avatars
2016-09-05 15:08:43 +02:00
db6a3367ad
Merge pull request #1259 from nextcloud/language_order
...
ACCEPT_LANGUAGE goes before default_langauge
2016-09-05 12:37:44 +02:00
24d90a4bb1
Correctly remove the charset from finfo mimetype
2016-09-05 09:48:22 +02:00
581a83c2a1
Fix AppTest and intergration test
2016-09-05 09:42:58 +02:00
ddb659dd90
increase core version number to trigger db ugprade and fix app manager tests
2016-09-05 08:51:13 +02:00
8acb734854
add 2fa backup codes app
...
* add backup codes app unit tests
* add integration tests for the backup codes app
2016-09-05 08:51:13 +02:00
0228bc6e66
ACCEPT_LANGUAGE goes before default_langauge
...
See https://github.com/nextcloud/server/issues/970
Before we had
1. Users settings in personal settings
2. Admins default language settings
3. Accept-Language settings of the browser
However this is not in line with
https://www.w3.org/International/questions/qa-lang-priorities
So this changes the order to
1. Users settings in personal settings
3. Accept-Language settings of the browser
2. Admins default language settings
2016-09-04 13:19:40 +02:00
7ffed2deae
Merge pull request #1221 from nextcloud/proper_204_304_response
...
No body or content-length for 204 and 304 responses
2016-09-01 15:04:09 +02:00
a3c1d74829
Remove unneeded Windows logic
2016-09-01 10:47:57 +02:00
21a87d3c2e
No body or content-length for 204 and 304 responses
...
See: https://tools.ietf.org/html/rfc7230#section-3.3
2016-08-31 23:07:48 +02:00
f9cea0b582
Merge pull request #797 from nextcloud/only-match-for-auth-cookie
...
Match only for actual session cookie
2016-08-31 15:59:16 +02:00
e4311a2ebd
Merge pull request #608 from nextcloud/small-encryption-improvement
...
skip shared files, if files get decrypted only for a specific user we…
2016-08-31 12:30:37 +02:00
57f9117843
Merge pull request #1087 from nextcloud/get-delay-twice
...
dont get bruteforce delay twice
2016-08-30 18:43:01 +02:00
6a85882f61
Fix tests
2016-08-30 09:00:22 +02:00
4afe4bda26
Merge pull request #891 from nextcloud/us_25810
...
[OC] Fix unmerged shares repair targetdecision
2016-08-30 08:22:34 +02:00
d5518735c9
always return numeric storage id as int, also check type equality in test asserts
2016-08-29 14:20:51 +02:00
6c93fe08f5
dont get bruteforce delay twice
2016-08-29 13:36:49 +02:00
4d85ffc27c
Merge pull request #1054 from nextcloud/less-cache-hits
...
Reduce the number of cache operations for dav operations
2016-08-27 22:44:29 +02:00
89c78bbce4
Merge pull request #1031 from nextcloud/2fa-infinite-redirect-loop
...
prevent infinite redirect loops if the there is no 2fa provider to pass
2016-08-26 16:03:05 +02:00
ad4cab130e
Merge pull request #1069 from nextcloud/l10ntest_nodb
...
L10N tests do not require DB
2016-08-25 23:38:27 +02:00
c5bdb4d4e8
L10N tests do not require DB
...
* Makes CI a bit more efficient
* Cleanup getMock warning
2016-08-25 22:41:23 +02:00
04cffe6d81
CappedMemoryCacheTest does not require DB
...
Makes CI a bit more efficient
2016-08-25 22:32:39 +02:00
2693ae870e
cache user folders
2016-08-25 17:22:25 +02:00
6af2efb679
prevent infinite redirect loops if the there is no 2fa provider to pass
...
This fixes infinite loops that are caused whenever a user is about to solve a 2FA
challenge, but the provider app is disabled at the same time. Since the session
value usually indicates that the challenge needs to be solved before we grant access
we have to remove that value instead in this special case.
2016-08-24 10:49:23 +02:00
2f1b17d44a
Merge pull request #1007 from nextcloud/shared-storage-non-recursive
...
Fix shared storage recursive setup
2016-08-23 22:15:38 +02:00
a0c2342c20
prevent infinite recursion while getting storage from mount
2016-08-23 14:52:18 +02:00
3ed102497e
Merge pull request #995 from nextcloud/workflow-section
...
Workflow section + hidden empty sections
2016-08-23 11:20:43 +02:00
5cd3f4e4dc
add test
2016-08-22 16:56:00 +02:00
baa91809bd
adjust test
2016-08-22 08:29:49 +02:00
7972fa5527
enlist only registered sections that also have settings registered to
2016-08-22 08:29:49 +02:00
d50e7ee36c
Remove reading PATH_INFO from server variable
...
Having two code paths for this is unreliable and can lead to bugs. Also, in some cases Apache isn't setting the PATH_INFO variable when mod_rewrite is used.
Fixes https://github.com/nextcloud/server/issues/983
2016-08-19 14:48:13 +02:00
162b153f22
Fix loading of ThemingDefaults
2016-08-19 11:26:22 +02:00
fe80bb1aff
Merge pull request #867 from nextcloud/notification-primary-action-always-first
...
Make sure the primary action is always the first one
2016-08-17 19:31:14 +02:00
df9b509ed3
Improve regexp to detect duplicate folders when repairing unmerged shares
2016-08-17 15:31:47 +02:00
7a2d25fab4
Fix unmerged shares repair with mixed group and direct shares
...
Whenever a group share is created after a direct share, the stime order
needs to be properly considered in the repair routine, considering that
the direct user share is appended to the $subShares array and breaking
its order.
2016-08-17 15:31:36 +02:00
56b94b220d
Improve file_target finding logic when repairing unmerged shares
...
Pick the most recent subshare that has no parenthesis from duplication
which should match whichever name the user picked last. If all
subshares have duplicate parenthesis names, use the least recent group
share's target instead.
2016-08-17 15:31:35 +02:00
027069cbae
Merge pull request #846 from nextcloud/provisioning_api_ocs
...
Move Provisioning API to the AppFramework
2016-08-17 10:23:13 +02:00
4943441bde
adjust tests to latest changes
2016-08-16 18:59:45 +02:00
717e22267a
Merge branch 'master' into implement_712
2016-08-16 18:31:59 +02:00
c044aa34fa
Make the capabilities manager more error proof
...
If an app registers an invalid capabilty we should not crash hard.
Instead we should catch the exception. Log it (error) and carry on.
* Added tests
2016-08-15 20:37:19 +02:00
7ffb7b0d84
Use MockBuilder instead of createMock
...
CI uses an older PHPUnit
2016-08-15 16:43:22 +02:00
8a7a0f3287
Add unit tests
2016-08-15 16:25:34 +02:00
3ed05f8769
Make sure the primary action is always the first one
2016-08-15 11:13:54 +02:00
a0b22227fc
Add tests
2016-08-14 18:34:01 +02:00
1f370c97ed
OCSController requires DataResponse
...
The OCS Controller requires a DataResponse object to be returned.
This means that all error handling will have to be done via exceptions
thrown and handling in the middleware.
2016-08-10 12:40:26 +02:00
9fbdb0efe8
Merge pull request #529 from nextcloud/vendor-maintenance-downgrade
...
Allow downgrades of maintenance accross vendors
2016-08-10 00:25:53 +02:00
5214b62d55
Merge pull request #691 from nextcloud/ocs_allow_all_old_routes
...
Allow ocs/v2.php/cloud/... routes
2016-08-09 20:52:49 +02:00
b53ea18ea5
Match only for actual session cookie
...
OVH has implemented load balancing in a very questionable way where the reverse proxy actually internally adds some cookies which would trigger a security exception. To work around this, this change only checks for the session cookie.
2016-08-09 19:23:08 +02:00
b4ed4e152e
Merge pull request #746 from nextcloud/jail-root
...
getJailedPath expects $path to have a trailing /
2016-08-09 11:04:11 +02:00
0032a5c2d1
Hanlde Core and Settings app in AppFramework
...
'core' and 'settings' are just apps but we treat them slightly
different. Make sure that we construct the correct namespace so we can
actually do automatic AppFramework stuff.
2016-08-08 20:48:16 +02:00
63f6d2d558
Allow ocs/v2.php/cloud/... routes
...
One of the possibilities of the old OCS API is that you can define the
url yourself.
This PR makes this possible again by adding an optional root elemenet to
the route. Routes are thus:
.../ocs/v2.php/<root>/<url>
By default <root> = apps/<app>
This will allow for example the provisioning API etc to be in
../ovs/v2/php/cloud/users
2016-08-08 15:01:26 +02:00
f37fa6e45c
Move Share backends to PSR-4 instead of using class path ( #24941 )
2016-08-05 14:13:41 +02:00
f1cd68d713
Adding test case for getPathById including a jailed cache where root is just empty
2016-08-05 14:06:05 +02:00
0c6352e095
Fix RepairUnmergedShares to not skip valid repair cases
...
The repair step was a bit overeager to skip repairing so it missed the
case where a group share exists without subshares but with an
additional direct user share.
2016-08-03 10:16:28 +02:00
67fa6bf9bc
Add repair step for unmerged shares (WIP)
2016-08-03 10:16:28 +02:00
5c718b13b8
We should properly check for 'true' instaed of the bool
2016-08-01 08:52:50 +02:00
f7f5216aa3
Dark hackery to not always disable CSRF for OCS controllers
2016-07-29 15:49:27 +02:00
54ae8eede3
Merge pull request #556 from nextcloud/nextcloud-version-check
...
Allow apps to check for a given nextcloud version
2016-07-29 09:26:25 +02:00
351cab6bce
skip shared files, if files get decrypted only for a specific user we shouldn't touch files owned by a different user.
2016-07-27 15:39:24 +02:00
8bdd0adcee
Support subdir in the OCS v2 endpoint
...
We should check against the ending substring since people could
run their nextcloud in a subfolder.
* Added test
2016-07-27 15:28:35 +02:00
9c21067c19
fix enabled apps tests
2016-07-27 08:36:03 +02:00
6482be040b
fix unit tests
2016-07-26 16:43:58 +02:00
0fcc39cd8e
Translate the server version for nextcloud
2016-07-26 14:40:18 +02:00
2f42a3fc31
Add workflowengine
2016-07-26 11:16:34 +02:00
352e24e703
Merge pull request #292 from nextcloud/recent-files
...
Add "Recent" file listing
2016-07-25 15:25:02 +01:00
4ad0c383ad
Merge pull request #523 from Faldon/master
...
Renamed file logging
2016-07-25 11:41:24 +02:00
81e103074e
use limit instead of since when listing recent files
2016-07-22 15:20:55 +02:00
a4ba3eadd0
fix test
2016-07-22 15:20:55 +02:00
5c34346479
Allow downgrades of maintenance accross vendors
2016-07-22 14:51:43 +02:00
61a1d56d27
Renamed test classes for file logging tests.
2016-07-22 14:47:50 +02:00
e321ecd592
add recent files to node api
2016-07-22 14:39:32 +02:00
72b06d250d
Add tests
2016-07-22 12:53:47 +02:00
ba3f4f118e
Changed logtype to file instead of owncloud.
...
- Updated the config sample to point to log_type='file'
- Renamed the Class for logfile logging to File in namespace 'OC\Log\'.
Changed the occurrences of 'OC\Log\Owncloud' to 'OC\Log\File'.
- Renamed the Class for log:file command to File in namespace 'OC\Core\Command\Log\File'.
Changed registration of the command to use 'OC\Core\Command\Log\File'.
- Changed default Syslog tag to Nextcloud
- Retained backwards compatibility for configs with 'logtype' => 'owncloud'
- Adjusted tests for the new file log.
Closes #490 .
2016-07-22 11:44:19 +02:00
c385423d10
Merge pull request #479 from nextcloud/add-bruteforce-throttler
...
Implement brute force protection
2016-07-21 00:31:02 +02:00
c1589f163c
Mitigate race condition
2016-07-20 23:09:27 +02:00
ba4f12baa0
Implement brute force protection
...
Class Throttler implements the bruteforce protection for security actions in
Nextcloud.
It is working by logging invalid login attempts to the database and slowing
down all login attempts from the same subnet. The max delay is 30 seconds and
the starting delay are 200 milliseconds. (after the first failed login)
2016-07-20 22:08:56 +02:00
020a2a6958
Merge pull request #476 from nextcloud/port-same-site-cookies
...
[master] Port Same-Site Cookies to master
2016-07-20 21:35:02 +02:00
78cad699fe
Merge pull request #475 from nextcloud/ocs-middleware
...
Add OCS Middleware
2016-07-20 21:04:25 +02:00
e08278494d
Merge pull request #471 from nextcloud/storage-fopenspecialchars
...
Added storage tests for fopen with special chars
2016-07-20 20:56:59 +02:00
5f32b57332
Add unit tests
2016-07-20 20:03:49 +02:00
a299fa38a9
[master] Port Same-Site Cookies to master
...
Fixes https://github.com/nextcloud/server/issues/50
2016-07-20 18:37:57 +02:00
1264e9644f
Merge pull request #402 from nextcloud/smb-notifications
...
smb update notifications
2016-07-20 16:19:21 +02:00
631af42b3a
Added storage tests for fopen with special chars
...
This makes it possible to test special chars with unit tests.
There is already a test for directories but there was none for file
names.
2016-07-20 15:13:24 +02:00
0bda09236e
Add route tests
2016-07-18 11:09:49 +02:00
6f9236fb3b
Merge pull request #381 from nextcloud/postgres-setup
...
use pdo for postgres setup
2016-07-15 21:30:51 +02:00
a3fa0d00c3
Cleanup ManagerTest
...
* Fix deprecated getMock call
* No longer requires DB
2016-07-14 13:49:18 +02:00
c04e7b13c3
Merge pull request #392 from nextcloud/roottest_nodb
...
RootTest does not require DB
2016-07-13 16:54:19 +02:00
29eeeb2273
Save the files external mount id in the mount cache table
2016-07-13 16:34:08 +02:00
927be847b9
RootTest does not require DB
...
* Removed from DB group
* Also mock the manager
* Fixed deprecated getMock warnings
2016-07-13 14:35:34 +02:00
b288c6796a
fix test
2016-07-13 14:33:04 +02:00
f2d091a963
Fix failing tests after db split
2016-07-13 09:26:19 +02:00
8d739f308b
Some UtilTests require DB
...
In the current setup there is no DI so no way to mock them.
2016-07-11 21:05:39 +02:00
5b6f5f1a07
LegacyGroupTest need DB
...
Those old tests make it impossible in the current state to abstract
away.
2016-07-11 21:02:27 +02:00
4ebf001b2e
Improve ManagerTest
...
* No DB required
* Fixed phpunit 5.4 warnings
2016-07-11 21:02:27 +02:00
31018adab3
Improve GroupTest
...
* No longer require DB
2016-07-11 21:02:27 +02:00
e8169e0d71
Merge pull request #364 from nextcloud/ca-bundle-tests
...
add test for needsRebundling() check
2016-07-11 17:34:31 +02:00
7c64e1973f
add test for needsRebundling() check
2016-07-11 15:51:48 +02:00
3b4535c3be
Improve NodeTest
...
* Do not use DB
* Fix phpunit-5.4 warnigns
* Moved commong stuff to setup
2016-07-11 15:41:02 +02:00
0c1cf5f7eb
Merge pull request #347 from nextcloud/drop-windows-foo
...
Remove unneeded checks if it runs on a Windows machine
2016-07-11 13:16:03 +02:00
6ea77abb38
Fix some more tests
2016-07-11 10:59:27 +02:00
1ace70d2c2
Merge pull request #351 from nextcloud/improve_filetest_unittest
...
Improve FileTest
2016-07-11 10:40:13 +02:00
937c9519d6
Mock logger
2016-07-11 08:50:30 +02:00
2fa9e67294
Fix phpunit-5.4 wargning
...
* getMock is deprecated.
* \PDOStatement mocking fails hard on phpunit 4.8
2016-07-11 08:50:07 +02:00
58dd278b4e
Correction is no longer required in php7
2016-07-08 19:36:17 +02:00
c91aebc437
Fix phpunit Trait warning
2016-07-08 19:36:17 +02:00
3a60626b77
Improve FileTest
...
* No longer requires DB
* Fixed phpunit 5.4 warnings
* Moved common stuff to Setup phase
2016-07-08 19:35:51 +02:00
c2d88a08b7
Remove unneeded checks if it runs on a Windows machine
...
* the setup check is still there
2016-07-08 15:55:17 +02:00
66a134e69e
Disallow certain malformed domain names even if they match the trusted domain expression
...
Stricter checking for valid domain names
2016-07-06 23:51:04 +00:00
2b4ceae620
Trusted domain wildcard checking made shorter, supporting multiple *
...
Added test cases
2016-07-06 23:38:30 +00:00
90b7f74da7
Changed name of default logfile from owncloud.log to nextcloud.log.
2016-07-04 11:50:32 +02:00
179a355b2c
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-07-01 11:36:35 +02:00
3acdc1339d
Merge pull request #206 from nextcloud/ci-mysql
...
Add mysql job to CI
2016-06-30 09:06:19 +02:00
01829e8d7c
mysql only works with 3 byte UTF-8
2016-06-29 15:53:23 +02:00
b55ab6d22a
Various database migration fixes ( #25209 )
...
* String columns with a length higher then 4000 are converted into a CLOB columns automagically - we have to respect this when migrating
* Adding schema migration tests to prevent unnecessary and non-sense migration steps
Fix Oracle autoincrement and unsigned handling
* Fix sqlite integer type for autoincrement
* Use lower case table names - fixes pg
* Fix postgres with default -1 - this only affect pg 9.4 servers - 9.5 seems to work fine
2016-06-29 14:54:41 +02:00
1710de8afb
Login hooks ( #25260 )
...
* fix login hooks
* adjust user session tests
* fix login return value of successful token logins
* trigger preLogin hook earlier; extract method 'loginWithPassword'
* call postLogin hook earlier; add PHPDoc
2016-06-27 22:16:22 +02:00
6670d37658
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-06-27 18:23:00 +02:00
2a990a0db5
verify user password on change
2016-06-27 14:08:11 +02:00
d4989c8037
remove old hook, no longer needed
2016-06-27 14:05:27 +02:00
630e4b1b46
check password for link shares
2016-06-27 14:05:27 +02:00
199c8e304c
Merge pull request #25250 from owncloud/linkshare-includedeletewithuploadperms
...
Add explicit delete permission to link shares
2016-06-27 12:14:05 +02:00
7a9d60d87e
Merge remote-tracking branch 'upstream/master' into master-upstream-sync
2016-06-26 12:55:05 +02:00
89198e62e8
check login name when authenticating with client token
2016-06-24 13:57:09 +02:00
0ad065cb8d
Repair step to adjust link share delete permissions
2016-06-24 09:48:48 +02:00
955635c7aa
Add explicit delete permission to link shares
...
Link shares always allowed deletion, however internally the permissions
were stored as 7 which lacked delete permissions. This created an
inconsistency in the Webdav permissions.
This fix makes sure we include delete permissions in the share
permissions, which now become 15.
In case a client is still passing 7 for legacy reasons, it gets
converted automatically to 15.
2016-06-24 09:48:48 +02:00
3db5de95bd
Merge pull request #25172 from owncloud/token-login-validation
...
Token login validation
2016-06-22 13:58:56 +02:00
2b493e2f9d
Merge remote-tracking branch 'upstream/master' into master-sync-upstream
2016-06-21 11:18:22 +02:00
b805908dca
update session token password on user password change
2016-06-21 10:24:25 +02:00
62e6de5df3
fix unit tests
2016-06-20 13:52:51 +02:00
56199eba37
fix unit test warning/errors
2016-06-20 10:41:23 +02:00
fb36fd495b
fix DefaultTokenMapperTest
2016-06-20 09:25:15 +02:00
5c68084823
fix default token provider tests
2016-06-20 09:17:19 +02:00
8ef5431e7a
fix user session tests
2016-06-20 09:10:11 +02:00
c4149c59c2
use token last_activity instead of session value
2016-06-17 15:42:28 +02:00
82b50d126c
add PasswordLoginForbiddenException
2016-06-17 11:02:07 +02:00
3521f974db
assert app is loaded in unit tests
2016-06-16 11:08:43 +02:00
a40d64ff7f
load 2FA provider apps before querying classes
2016-06-16 10:12:16 +02:00
9c328de4ab
Merge pull request #24415 from owncloud/optimize_sharingdisabled_for_user
...
Optimize isSharingDisabledForUser
2016-06-16 09:27:48 +02:00
1251df3e17
Merge pull request #25075 from owncloud/fix_23265
...
Remove shares of the root folder
2016-06-16 09:27:06 +02:00
05967a6904
Merge pull request #25093 from owncloud/issue-12816-clean-tags-from-deleted-users
...
Clean up tags of deleted users
2016-06-15 12:20:29 +02:00
ea4c5e6e0a
Fix unit tests
2016-06-14 13:24:48 +02:00
123bf78ca8
Clean up tags of deleted users
2016-06-14 12:38:09 +02:00
ae02685e6f
Merge branch 'master' of https://github.com/owncloud/core into downstream-160614
2016-06-14 01:06:25 +02:00
465807490d
create session token only for clients that support cookies
2016-06-13 19:44:05 +02:00
64471b5d4a
Remove shares of the root folder
...
Fixes #23265
(A possibly costly) repair job to remove cyclic shares.
2016-06-13 15:07:41 +02:00
5daa9a5417
fail hard if 2fa provider can not be loaded ( #25061 )
2016-06-13 12:46:45 +02:00
42c66efea5
Merge branch 'master' of https://github.com/owncloud/core into downstream-160611
2016-06-11 15:34:43 +02:00
842cc2a788
Merge pull request #19 from nextcloud/files-drop
...
add "hide file list" option
2016-06-10 18:29:09 +02:00
52a0c939ab
Merge pull request #24863 from owncloud/propagator-batching
...
Propagator batching for the file scanner
2016-06-10 17:45:52 +02:00
60225284f3
Add not-null columns for oracle
2016-06-10 12:44:49 +02:00
1b66db72d9
Repair job to fix permissions for avatars
...
Fixes #22978
On some older installations the permissions for the userRoot and the
avatars are not correct. This breaks since we now use the Node API in
the avatar code.
This repair job makes sure that the permissions are set correctly.
* Unit tests added
2016-06-10 12:44:49 +02:00
a636e4ff28
Downstream 2016-06-09
...
Merge branch 'master' of https://github.com/owncloud/core into downstream-160609
2016-06-09 18:45:12 +02:00
51fd2602a7
Revert "Downstream 2016-06-08"
2016-06-09 17:41:57 +02:00
7d51fd0310
Add repair step to clean old calendar/contact shares
...
fixes #21889
2016-06-09 15:48:45 +02:00
bb54ab0db8
add hide file list option
2016-06-09 15:15:17 +02:00
bee918693a
dissalow symlinks in local storages that point outside the datadir
2016-06-09 14:00:01 +02:00
4f27c2c433
Allow to decrypt user '0' files only
2016-06-09 14:00:00 +02:00
0041d89dc2
Do not allow to store boolean configs, they behave unexpected on postgres
2016-06-09 13:59:58 +02:00
67c2c85b05
allow deleting "ghost files" trough the View and Node api
2016-06-09 13:59:58 +02:00
826e276a79
Merge pull request #24973 from owncloud/token-password-session-token
...
When creating a session token, make sure it's the login password and …
2016-06-09 11:58:04 +02:00
aca4ea12c1
Merge pull request #24826 from owncloud/cors-client-login
...
use client login method on CORS routes
2016-06-09 10:31:14 +02:00
e49307014c
Do not log token or challenge with exception stacktrace ( #25026 )
...
* Make the filtering better readable
* Add some more methods to the sensitive list
2016-06-08 16:32:58 +02:00
9997c431c3
use client login method on CORS routes
2016-06-08 15:18:53 +02:00
ec929f07f2
When creating a session token, make sure it's the login password and not a device token
2016-06-08 13:31:55 +02:00
8d0948977e
Merge pull request #24899 from owncloud/local-storage-symlinks
...
dissalow symlinks in local storages that point outside the datadir
2016-06-08 10:19:24 +02:00
ed92f4c427
Merge pull request #24983 from owncloud/issue-23776-do-not-allow-boolean-user-config
...
Do not allow to store boolean configs, they behave unexpected on postgres
2016-06-08 10:14:08 +02:00
b7935dcebd
Merge pull request #24998 from owncloud/issue-24994-allow-decrypting-user-0-only
...
Allow to decrypt user '0' files only
2016-06-08 10:12:28 +02:00
38451c85f1
skip failing tests
2016-06-07 17:54:40 +02:00
7b1b723e5b
dissalow symlinks in local storages that point outside the datadir
2016-06-07 14:01:53 +02:00
d4ba982131
Allow to decrypt user '0' files only
2016-06-07 09:13:11 +02:00
911fd3ead4
Do not allow to store boolean configs, they behave unexpected on postgres
2016-06-06 12:38:20 +02:00
63408fa6ef
allow deleting "ghost files" trough the View and Node api
2016-06-03 13:30:59 +02:00
11900baaf3
add tests for propagator batching
2016-06-02 15:09:15 +02:00
5b1eb416d8
Fix TestCase::invokePrivate to work with static classes
2016-06-01 14:28:59 +02:00
5ad8fa7675
Add keepUnicode value in the cache key of normalizedPathCache
2016-06-01 14:28:59 +02:00
c58d8159d7
Create session tokens for apache auth users
2016-05-31 17:07:49 +02:00
a441220f24
Merge pull request #24628 from owncloud/decryptall-checkifneedsprocessing
...
[decrypt_all] Check if file needs to decrypted or not for speed up large oc setups.
2016-05-31 10:12:03 +02:00
718f0757e4
Fix for #23066 ( #24689 )
2016-05-31 06:53:28 +02:00
b15babd061
fix unit tests
2016-05-30 14:49:27 +02:00
4b1e8a1184
One more PSR-4 fix ( #24852 )
2016-05-26 16:31:26 +02:00
4cfefda891
Move Test\Files\Storage\Wrapper\EncodingTest to PSR-4
2016-05-25 15:26:14 +02:00
28ce7dd262
do not allow client password logins if token auth is enforced or 2FA is enabled
2016-05-24 17:54:02 +02:00
d3fb5d618e
Merge pull request #24748 from owncloud/login-explicitly
...
Log in explicitly, save login name when generating browser/device tokens
2016-05-24 17:51:49 +02:00
e7110c7678
Merge pull request #24760 from owncloud/objectstore_multibucket
...
Objectstore multibucket
2016-05-24 15:15:59 +02:00
ad10485cec
when generating browser/device token, save the login name for later password checks
2016-05-24 11:49:15 +02:00
abe338f433
Store user bucket in preferences
2016-05-23 21:57:41 +02:00
4f6670d759
Merge pull request #24658 from owncloud/invalidate-disabled-user-session
...
invalidate user session if the user was disabled
2016-05-23 20:50:25 +02:00
87fa86a69a
Merge pull request #24559 from owncloud/2fa
...
two factor auth
2016-05-23 20:50:03 +02:00
e03e4921a0
Fix Name
2016-05-23 20:42:08 +02:00
7ef21b0b27
Add unit tests for ObjectHomeMountProvider
2016-05-23 20:42:08 +02:00
12b63258d5
Add mapper unit tests
2016-05-23 20:42:08 +02:00
eca57be336
Only recurse into incomplete folders during background scans
2016-05-23 14:40:35 +02:00
57525a02f8
Merge pull request #24703 from owncloud/personal-settings-auth-tokens
...
Personal settings auth tokens
2016-05-23 14:17:01 +02:00
bd87f67473
Merge pull request #24349 from owncloud/nfd-storagewrapper
...
Add wrapper for NFD encoding workaround
2016-05-23 13:45:33 +02:00
dfb4d426c2
Add two factor auth to core
2016-05-23 11:21:10 +02:00
c20cdc2213
invalidate user session if the user is disabled
2016-05-23 10:32:16 +02:00
5ba1add03c
Merge pull request #24603 from owncloud/federated_reshare
...
flat federated re-share
2016-05-23 09:52:13 +02:00
74277c25be
add button to invalidate browser sessions/device tokens
2016-05-23 09:11:12 +02:00
7a6966cdfe
Merge pull request #24732 from owncloud/autoloader_fix
...
Autoloader fix
2016-05-21 19:09:22 +02:00
8646802850
Merge pull request #24696 from owncloud/lock-jobs-while-executing
...
Lock jobs while executing them, to allow multiple executors to run in…
2016-05-21 19:08:15 +02:00
d0a2fa0506
Lock jobs while executing them, to allow multiple executors to run in parallel
2016-05-21 01:59:25 +02:00
7b25839bd5
use share initiator as fall back to access the file
...
in case of federated re-shares the owner can be a remote user.
Therefore we can't always use to owner to access the local file
2016-05-20 21:15:15 +02:00
88740f035d
Act on effective system tag canAssign permission
...
Whenever the server returns true for the can-assign Webdav property of
a system tag, it means the current user is allowed to assign,
regardless of the value of user-assignable.
This commit brings the proper logic to the web UI to make it possible
for users to assign when they have the permission.
2016-05-20 17:56:02 +02:00
b5eb3d9e5a
Add system tag assignability check with groups
...
Whenever a user is not an admin, a tag is visible but not
user-assignable, check whether the user is a member of the allowed
groups.
2016-05-20 17:56:02 +02:00
3cd65fe25d
Add systemtag_group table and get/set methods
...
Added systemtag to group mapping table.
Added methods in ISystemTagManager to get/set the group mappings.
2016-05-20 17:56:02 +02:00
09b3883d9c
Updated canUser* functions in SystemTagManager to accept objects
2016-05-20 17:56:02 +02:00
8343cfb64b
Add interface methods for permission check
...
Instead of checking for admin perm, use interface method
canUserAssignTag and canUserSeeTag to check for permissions.
Allows for more flexible implementation.
2016-05-20 17:56:02 +02:00
54b637e83c
Fix unit tests
2016-05-20 16:35:07 +02:00
94ad54ec9b
Move tests/ to PSR-4 ( #24731 )
...
* Move a-b to PSR-4
* Move c-d to PSR-4
* Move e+g to PSR-4
* Move h-l to PSR-4
* Move m-r to PSR-4
* Move s-u to PSR-4
* Move files/ to PSR-4
* Move remaining tests to PSR-4
* Remove Test\ from old autoloader
2016-05-20 15:38:20 +02:00
e8d082208d
Fixes for encoding wrapper
...
Improved label
Fixed rename/copy/moveFromStorage/copyFromStorage and added tests
Improved findPathToUse algo
2016-05-20 09:33:59 +02:00
63bbbf29f4
Add wrapper for NFD encoding workaround
2016-05-20 09:33:59 +02:00
b495895017
Merge pull request #24728 from owncloud/no-more-test_-files
...
Fix autoloader for Test* files
2016-05-20 09:29:01 +02:00
f8180391fd
Create a Fallback in the old autoloader for PSR-4 Test\TestCase
2016-05-19 15:45:34 +02:00
ffa4633822
No more Test_* files exist, remove autoloading
2016-05-19 15:38:16 +02:00
f42cdec4c4
Merge pull request #24725 from owncloud/ocs-provider-psr4
...
Move OCS Provider to PSR-4 namespace
2016-05-19 15:36:19 +02:00
3b3940df6b
Merge pull request #24660 from owncloud/no-token-login-for-disabled-users
...
don't allow token login for disabled users
2016-05-19 15:32:09 +02:00
61b3260ebd
Merge pull request #24716 from owncloud/fix-test-namespaces-2
...
Fix test namespaces [files-]
2016-05-19 15:31:43 +02:00
20f229eed9
Move OCS Provider to PSR-4 namespace
2016-05-19 11:10:32 +02:00
bae4118b4f
Fix renamed class
2016-05-19 10:33:12 +02:00
e36a27d21c
Merge pull request #24712 from owncloud/fix-test-namespaces
...
Fix test namespaces [a-e]
2016-05-19 10:30:07 +02:00
320b1c3abf
Fix more failures
2016-05-19 10:11:42 +02:00
f24179a327
Fix deprecated private method
2016-05-19 09:44:53 +02:00
e88a9b2fed
Fix missing backtick before OC
2016-05-19 09:41:45 +02:00
e823d50044
Fix "Class 'Test\Security\DateTime' not found"
2016-05-19 09:40:34 +02:00
9a4253ef7c
Fix lib/
2016-05-19 09:38:52 +02:00
55fc6536d3
FIx lib/ a-d
2016-05-19 09:27:21 +02:00
7f3f16d155
Fix namespace in user/
2016-05-19 09:19:03 +02:00
a107e7de7b
Fix namespace in share/
2016-05-19 09:15:10 +02:00
68481c10e6
Fix namespaces in security/
2016-05-19 09:02:58 +02:00
a9f24a74a2
Fix namespace in repair/
2016-05-19 08:59:37 +02:00
d19d6533dd
Fix public/ namespace in tests
2016-05-19 08:56:47 +02:00
859d2bc0ff
Fix namespace of memcache/ and ocs/
2016-05-19 08:53:06 +02:00
71603fe348
Fix namespace in log/ and mail/
2016-05-19 08:50:14 +02:00
0ab1120a33
Fix namespaces in tests/lib/integritycheck
2016-05-19 08:48:22 +02:00
51db410e67
Fix namespaces in tests/lib/http/
2016-05-19 08:46:58 +02:00
995d4b7ecd
Fix namespaces in tests/lib/groups/
2016-05-19 08:44:41 +02:00
b1458d590d
Fix namespaces and class names in tests/lib/files/
2016-05-19 08:41:01 +02:00
f824f3e5f3
don't allow token login for disabled users
2016-05-18 21:10:37 +02:00
f57407e73e
Fix file name in tests/lib/encryption
2016-05-18 18:57:46 +02:00
ba230888c6
Fix filenames and class names in tests/lib/comments
2016-05-18 18:57:46 +02:00
bbf758b1b0
Fix file name of command test
2016-05-18 18:57:46 +02:00
1b6cd583f7
Fix namespace of tests/cache/
2016-05-18 18:57:46 +02:00
c54d79947b
Fix missing namespaces in tests/lib/db/
2016-05-18 18:57:45 +02:00
5ce5eb195a
Fix namespace for archive tests
2016-05-18 18:57:45 +02:00
9eade36ae5
Fix namespaces in AppFramework tests
2016-05-18 18:57:45 +02:00
0626578739
add method to query all user auth tokens
2016-05-18 18:25:37 +02:00
98b465a8b9
a single token provider suffices
2016-05-18 09:20:48 +02:00
5c9103287f
Group fixup ( #24621 )
...
* Move used OC_Group_xx to \OC\Group
* Add (deprecated) legacy wrapper in legacy, OC_Group_xx
* Replace deprecated use of OC_Group_xx with \OC\Group\xx
2016-05-17 16:06:44 +02:00
e383a9506d
Merge pull request #24617 from owncloud/autoloader_no_private
...
our autoloader should not load classes in \OC
2016-05-13 17:30:10 +02:00
9ac763a640
Merge pull request #24594 from owncloud/authtoken-name-column-size
...
Use CLOB for auth token names to allow long user agent strings
2016-05-13 11:56:52 +02:00
d022b6fad4
Fix unit tests
2016-05-13 11:33:21 +02:00
eb79b83831
Move functions.php to legacy
...
This file should really be properly namespaced etc!
2016-05-13 08:54:07 +02:00
c28e462583
Use CLOB for auth token names to allow long user agent strings
2016-05-12 11:19:17 +02:00
69dafd727d
delete the token in case an exception is thrown when decrypting the password
2016-05-11 13:36:46 +02:00
af707fba41
use the query builder instead of raw sql statements
2016-05-11 13:36:46 +02:00
46bdf6ea2b
fix PHPDoc and other minor issues
2016-05-11 13:36:46 +02:00
f0f8bdd495
PHPDoc and other minor fixes
2016-05-11 13:36:46 +02:00
dff108e97b
fix mock builder for old phpunit versions
2016-05-11 13:36:46 +02:00
fbb5768587
add unit tests for all new classes
2016-05-11 13:36:46 +02:00
aa85edd224
increase token column width
...
add some range to time() assertions
2016-05-11 13:36:46 +02:00
8cc5f6036f
Fix existing tests
2016-05-11 13:36:46 +02:00
f6ee738ba8
Add \OC\User\Backend
...
Since some apps (ldap et al) still depend on OC_User_Backend this seemed
like the cleanest approach.
2016-05-10 19:53:36 +02:00
9e1d9871a8
Move OC_User_Database to \OC\User\Database
2016-05-10 19:53:36 +02:00
e8e72aa910
Merge pull request #24434 from owncloud/permalinks
...
Permalinks
2016-05-10 09:44:50 +02:00
8b428d84c0
Make update server URL configurable
...
Currently testing the updates is a big problem and not really super easy possible. Since we now have a new updater server we should also make this configurable so that people can properly test updates.
2016-05-09 11:25:58 +02:00
108bd26856
Fix unit tests broken after #24457
...
Timeout was increased but tests were not updated.
2016-05-09 08:54:30 +02:00
caefe23bb6
Send permalink in internal share notification emails
2016-05-06 16:46:59 +02:00
873849e843
Merge pull request #24432 from owncloud/issue-24270-never-save-app-language-into-request-lang
...
Do not save the language as request lang for apps when we didn't find…
2016-05-04 13:47:08 +02:00
9fbb8ce302
Do not save the language as request lang for apps when we didn't find any
2016-05-04 08:28:13 +02:00
4b2544925f
Merge pull request #23844 from owncloud/disable-user
...
Add occ commands to enable and disable a user + a disabled user can n…
2016-05-03 15:22:41 +02:00
fc82047e26
Move OC_Log_xx to \OC\Log namespace
2016-05-03 08:57:26 +02:00
adf7e7295e
Merge pull request #24375 from owncloud/archive_move
...
Move OC_Archive to \OC\Archive and PSR-4
2016-05-03 08:37:01 +02:00
c87bd0432a
Merge pull request #24380 from owncloud/move-activity-manager-to-namespace
...
Move activity manager to the namespace
2016-05-03 07:40:04 +02:00
0cb434686c
Move OC_Archive_XX to PSR-4
...
* Fix code
* Fix tests
2016-05-02 19:32:51 +02:00
05cf552f66
Merge pull request #24322 from owncloud/install-and-uninstall-repair-steps
...
Adding repair steps for install and uninstall
2016-05-02 17:50:29 +02:00
b84825f030
Merge pull request #24229 from owncloud/session-id-wrapper
...
add ISession::getId() wrapper for session_id
2016-05-02 16:49:38 +02:00
7bfc617b03
Move activity manager to the namespace
2016-05-02 11:57:24 +02:00
3397e27657
Remove the password from the validateUserPass() method as well
2016-05-02 10:44:09 +02:00
9c9fec36dd
Add occ commands to enable and disable a user + a disabled user can no longer login - fixes #23838
2016-05-02 09:31:22 +02:00
e049953d1a
OC_Installer -> \OC\Installer
2016-05-02 08:52:06 +02:00
e59ccc5fe9
Merge pull request #24299 from owncloud/availability-avoid-concurrency
...
Prevent concurrent storage availability checks
2016-04-29 17:43:31 +02:00
66ebc2ee6f
Merge pull request #24337 from owncloud/add-db-group-for-required-tests
...
Add the DB group for preview tests that require the database
2016-04-29 15:02:27 +02:00
6571da1519
Merge pull request #24305 from owncloud/update-show-repair-step-progress
...
[Update] show repair step progress ...
2016-04-29 13:47:15 +02:00
a85be14b62
Add the DB group for tests that require the database
2016-04-29 09:30:47 +02:00
4c1b55be92
allow app developers to specify the minimum int size
...
simplify comparison
remove additional null
fix off by 1 error
2016-04-28 22:55:15 +02:00
0e774e0fd8
Merge pull request #24274 from owncloud/async-repair-steps
...
Introduce background repair steps
2016-04-28 14:11:43 +02:00
bbd2a07525
Remove emitter from class Repair
2016-04-28 13:52:01 +02:00
77cec29b10
Prevent concurrent availability checks
2016-04-26 22:30:09 +01:00
ddbebe91f0
Merge pull request #24246 from owncloud/local-invalid
...
error out if a local storage isn't setup correctly
2016-04-26 20:57:56 +02:00
2f01c83a01
add tests
2016-04-26 16:08:52 +02:00
e93bf80b29
throw SessionNotAvailableException if session_id returns empty string
2016-04-26 14:51:21 +02:00
2ee7d2485c
Introduce background repair steps
2016-04-26 11:56:56 +02:00
23e7ad7a78
Merge pull request #24256 from owncloud/scanner-propagate
...
triger the propagator from the command line scanner
2016-04-26 10:05:39 +02:00
61054df36d
triger the propagator from the command line scanner
2016-04-25 17:23:48 +02:00
c7542c02db
Introduce OCP\Migration\IRepairStep and adopt all repair steps to this new interface - refs #24198
2016-04-25 15:01:13 +02:00
0d53e86421
add ISession::getId() wrapper for session_id
2016-04-25 10:36:24 +02:00
8c7c713e86
Merge pull request #24187 from owncloud/fs-initmountpoint-rethrowifusernotfoundagain
...
Mark $usersSetup only if user was found in initMountPoints
2016-04-22 17:25:40 +02:00
4eebccd81f
Fix inconsistent nameing of AppFramework
2016-04-22 16:00:00 +02:00
cc4efc4c03
Merge pull request #24085 from owncloud/feedback-on-app-migrations
...
App migration steps need to push feedback to the user ....
2016-04-22 14:39:11 +02:00
13c01e62cf
Mark $usersSetup only if user was found in initMountPoints
...
initMountPoints is marking a user as successfully initialized too
early. If the user was not found an NoUserException was thrown, the
second time initMountPoints is called would not rethrow the exception
and happily continue.
This fix makes sure that we consistently throw NoUserException when
initMountPoints is called repeatedly with invalid users.
2016-04-22 14:29:41 +02:00
43323b0062
Merge pull request #24183 from owncloud/change-background-job-sort-order
...
Change the sort order of background jobs to be DESC instead of ASC
2016-04-22 13:33:54 +02:00
085bcd7da2
Throw NoUserException when attempting to init mount point for null user
...
In some scenarios initMountPoints is called with an empty user, and
also there is no user in the session.
In such cases, it is unsafe to let the code move on with an empty user.
2016-04-22 11:46:33 +02:00
04cee6a7db
Change the sort order of background jobs to be DESC instead of ASC
...
In theory, if your instance ever creates more jobs then your system cron can
handle, the default background jobs get never executed anymore. Because
everytime when the joblist returns the next job it looks for the next ID,
however there is always a new next ID, so it will never wrap back to execute
the low IDs. But when we change the sort order to be DESC, we make sure that
these low IDs are always executed, before the system jumps back up to
execute the new IDs.
2016-04-22 10:49:55 +02:00
d0030aad6c
Remove deprecated HTTPHelper from InfoParser
2016-04-22 08:38:41 +02:00
06a4da43ec
[master] Ignore certificate file if it starts with file://
2016-04-21 19:02:31 +02:00
b50d3255fb
Merge pull request #22791 from owncloud/enc_master_key_improvements
...
Enc master key improvements
2016-04-21 11:48:26 +02:00
cd01c440a0
Merge pull request #23919 from owncloud/cyclyc-share-dep-example
...
SharedStorage to new sharing code + cleanup
2016-04-20 20:37:27 +02:00
cdcabbd0b3
Merge pull request #24098 from owncloud/fix_23782
...
When calling file_put_contents clear the checksum
2016-04-20 20:37:01 +02:00
aa33ab0c03
Merge pull request #24094 from owncloud/move_dummy_group_backend_to_test
...
Move the group dummy backend to test
2016-04-20 11:55:00 +02:00
0dbcbc4cae
When the scanner detects a file is changed clear checksum
...
Fixes #23782 and #23783
If the file scanner detects a changed file we clear the checksum while
we update the cache.
* Unit test added
2016-04-19 20:20:45 +02:00
5b2ef92eb2
Merge pull request #24004 from owncloud/dont-transfer-files-to-not-ready-user
...
Introduce isReadyForUser and verify in file transfer ownership
2016-04-19 15:56:47 +02:00
dd7e0d13e5
Move the group dummy backend to test
...
The dummy backend is only used for testing and should thus reside in
tests.
2016-04-19 15:13:31 +02:00
92abb5f23d
Fix tests
2016-04-19 14:04:00 +02:00
1773dcbef2
Merge pull request #23973 from owncloud/share_move_post_delete_from_group_hook
...
Move post_removeFromGroup to shareManager
2016-04-19 06:59:58 +02:00
1626850fc9
Remove deprecated HTTPHelper
2016-04-18 17:28:10 +02:00
5c3183cedd
Move version check code out of class Updater
2016-04-18 17:12:59 +02:00
331e4efacb
Move login form into controller
...
First step on getting the authorisation stuff cleaned up. This is only for the login form, all other stuff is still where it is.
2016-04-15 17:36:23 +02:00
50e20e531e
Introduce isReadyForUser and verify in file transfer ownership - fixes #23786
2016-04-15 15:07:40 +02:00
6144ced7a0
Move post_removeFromGroup to shareManager
...
The last sharing hook to be moved over.
* Added unit tests
* Removed old tests that relied on old behaviour
* Removed old hooks.php
2016-04-13 15:00:12 +02:00
ef93ec8bc2
Add test
2016-04-12 21:32:40 +02:00
fdee771aca
Add unit testing capabilities for templates ( #23708 )
...
Add unit testing capabilities for templates
2016-04-12 12:49:11 +02:00
495a964ca2
Migrate post_groupDelete hook to share manager ( #23841 )
...
The hook now calls the share manager that will call the responsible
shareProvider to do the proper cleanup.
* Unit tests added
Again nothing should change it is just to cleanup old code
2016-04-12 09:46:25 +02:00
8e16e7bf34
Merge pull request #23856 from owncloud/share_remove_addtogroup_hooks
...
Remove pre/post_addToGroup hooks for shares
2016-04-11 15:05:20 +02:00
2a0244df27
Fix mappertest
2016-04-08 15:23:09 +02:00
f9ade49c7e
Fix notification tests
2016-04-08 15:23:06 +02:00
e65e7a5ad7
Fix ShareManager tests
2016-04-08 15:22:57 +02:00
1d3d43b1e9
Merge pull request #23553 from owncloud/lock-ttl-execution-time
...
Make lock ttl configurable
2016-04-08 14:53:26 +02:00
bd3bde2f3b
Set proper permissions on link share
...
If we do not allow public upload we should limit the permissions on
links shares upon retrieval.
* Added unit test
* Allow fetching federated shares by token as well
2016-04-08 14:17:05 +02:00
3fae4c82d2
Remove pre/post_addToGroup hooks for shares
...
There is no need to perform the checks for unique targets on add to
group as we have to do this all when mounting the shares anyway.
2016-04-08 11:56:38 +02:00
0de15a86f0
Merge pull request #23773 from owncloud/share_move_delete_user_hook
...
Migrate post_userDelete hook to share manager
2016-04-07 13:01:10 +02:00
cdedda99e4
Make lock ttl configurable
2016-04-07 08:24:13 +02:00
02e226a6b3
tests: Fix typos (found by codespell)
...
Fix also a small grammar issue.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-04-06 15:08:27 +02:00
93b1768eb7
Merge pull request #23819 from owncloud/move-core-completely-to-psr4
...
Move OC/Core completely to PSR-4
2016-04-06 13:31:44 +02:00
5a0c936f99
Remove OC/Settings from old autoloader
2016-04-06 11:34:53 +02:00
c952adabb5
Remove OC/Core autoloading from old autoloader
2016-04-06 11:34:29 +02:00
4445ef82e0
Test locking with strange filename
2016-04-05 16:13:28 +02:00
e0cee43cf0
Migrate post_userDelete hook to share manager
...
This makes the post_userDelete hook call the sharemanager. This will
cleanup to and from this user.
* All shares owned by this user
* All shares with this user (user)
* All custom group shares
* All link share initiated by this user (to avoid invisible link shares)
Unit tests are added for the defaultshare provider as well as the
federated share provider
2016-04-04 14:15:38 +02:00
2bff34be56
Merge pull request #23707 from owncloud/make-sure-that-encrypted-version-is-set
...
Make sure that the encrypted version is set
2016-03-31 20:37:17 +02:00
fdb59079a2
Merge pull request #23675 from owncloud/fix_encryption_versions_on_external_storages
...
fix creation of versions of encrypted files on external storages
2016-03-31 20:36:03 +02:00
93ed965cbb
fix creation of versions of encrypted files on external storages
...
in order to create a 1:1 copy of a file if a version gets created
we need to store this information on copyBetweenStorage(). This
allows us to by-pass the encryption wrapper if we read the source file.
2016-03-31 19:24:47 +02:00
c427bf3b5d
Make sure that the encrypted version is set
...
The code path called when using external storage with WebDAV is using `\OC\Files\Storage\Wrapper\Encryption::getMetaData` which did not contain the actual encrypted version inside the cache entry version. This lead to the following:
1. User uploaded a file
2. File is created and `\OC\Files\Storage\Wrapper\Encryption::getMetaData` is called. It has an empty `encryptedVersion` but sets `encrypted` to either `true` or `false`.
3. The call when updating the file cache will use the old version.
2016-03-31 18:06:37 +02:00
8da48a4482
Add unit tests
...
Add some unit tests for setting the internal id and the provider id
2016-03-30 23:08:35 +02:00
2f4294e781
Add setId and setProviderID to the public interface
...
Fixes #23337
We only allow the id to be set once!
2016-03-30 22:55:03 +02:00
66ee9d56fc
Merge pull request #23628 from owncloud/avatar-remove
...
only remove avatars from the folder we store them in
2016-03-30 17:00:09 +02:00
9ce5e4b01f
Non moveable mount points should always be UPDATE+DELETE shareable
...
Fixes #23536
The new sharing code is much stricter in checking permissions. However
for non moveable mounts the permissions UPDATE+DELETE are not reported
on the mount point.
This is just a quick fix.
* Updated unit tests
2016-03-30 13:33:16 +02:00
c22697e09e
only remove avatars from the folder we store them in
2016-03-30 10:24:43 +02:00
b8812c8cba
Merge pull request #23154 from owncloud/avatar-save-failure
...
dont die when we cant save the resized avatar, log instead
2016-03-24 22:43:17 +01:00
ea07a428f4
Merge pull request #22506 from owncloud/node-get-from-cache
...
Query the cache when checking if a node exists
2016-03-23 13:08:17 +01:00
fc18d33ff8
Merge pull request #22895 from owncloud/cleanup_default_share_provider
...
Remove support for old shares in the default share provider
2016-03-23 11:02:28 +01:00
efd378814c
Merge pull request #23362 from owncloud/fix-l10n-for-themes
...
Read available l10n files also from theme folder
2016-03-23 09:22:21 +01:00
b26b8d17eb
Remove support for old shares in the default share provider
...
In 9.0 we converted the old shares to the new shares. So for 9.1 we can
savely remove the fallback code.
This code was required when there was no initiator set.
* Fixed unit tests
2016-03-23 07:58:17 +01:00
52826d0e24
Block group sharing in API and in share manager
...
* Fix tests
2016-03-22 17:13:34 +01:00
dcca20a48a
Save the query when we get tags for no objects
2016-03-22 11:13:11 +01:00
0b0b3253bb
properly use fileinfo objects
2016-03-21 14:20:33 +01:00
5e6c905a14
pass the fileinfo to the node if available
2016-03-21 13:53:33 +01:00
76455204c0
Inject server root - allows proper testing and separation of concerns
2016-03-18 13:59:44 +01:00
5e267589d4
only create and update user specific key if no master key is enabled
2016-03-18 11:06:14 +01:00
23c0f4ff5f
Read available l10n files also from theme folder
...
The old behaviour was that only languages could be used for an app
that are already present in the apps/$app/l10n folder. If there is
a themed l10n that is not present in the apps default l10n folder
the language could not be used and the texts are not translated.
With this change this is possible and also the l10n files are
loaded even if the default l10n doesn't contain the l10n file.
2016-03-17 16:15:37 +01:00
676041ba7e
Ensure that stored version is at least 1 for cross-storage copy
...
In case of a move operation from an unencrypted to an encrypted
storage the old encrypted version would stay with "0" while the
correct value would be "1". Thus we manually set the value to "1"
for those cases.
See also https://github.com/owncloud/core/issues/23078
2016-03-16 10:36:15 +01:00
f7140294f2
Merge pull request #23157 from owncloud/remove-share-prop-entries
...
remove old share propagation entries from appconfig
2016-03-15 16:04:17 +01:00
27760ae54e
Merge pull request #23164 from owncloud/db-connection-precondition-fix
...
Prevent certain DBs throwing exceptions on same-value updates
2016-03-15 16:03:55 +01:00
7b06dd485d
Merge pull request #23250 from owncloud/fix-support-for-php7-in-htaccess
...
Fix several .htaccess and .user.ini related problems
2016-03-15 16:03:18 +01:00
1b2f1cc272
Prevent certain DBs throwing exceptions on same-value updates
...
A PreconditionNotMetException must only be thrown if explicit
preconditions are specified for setValues(), not if the value is merely
the same as was already in the DB.
2016-03-15 13:02:19 +01:00
0aa83511a1
remove old share propagation entries from appconfig
2016-03-15 12:50:22 +01:00
1db82073a4
Generate a valid URL for link notification
...
fixes #23197
* Updated unit test
2016-03-15 11:10:24 +01:00
5278bfe0e4
Add support for custom values in integrity checker
2016-03-15 10:41:17 +01:00
2f67aa9bc4
Fix errors in memcached implementation
2016-03-14 12:39:34 +01:00
54e750ba78
dont die when we cant save the resized avatar, log instead
2016-03-11 13:44:35 +01:00
dc6789fd5b
Explicitly check for port
...
The setup uses `\OCP\IRequest::getInsecureServerHost` which in some cases can also include a port. This makes the trusted domain check fail thus.
I've decided to add this here that way because adjusting the setup would require parsing the host properly. This is not something that can be done very good in PHP. Check the following example for why `parse_url` is not our friend: https://3v4l.org/k501Z
2016-03-10 22:32:29 +01:00
7301b43eb6
Added tests
...
* Unit tests for OC_Filechunking to verify the isComplete function
* Intergration tests to show that shuffling chunks is all fine
2016-03-07 21:20:13 +01:00
72c8187cbb
Keep "encryptedVersion" when calling `\OC\Files\View::copy`
...
When calling `\OC\Files\View::copy` we should also keep the version to ensure that the file will always have the correct version attached and can be successfully decrypted.
To test this the following steps are necessary (from https://github.com/owncloud/core/issues/22781#issuecomment-191328982 ):
1. setup a new ownCloud 9.0 beta2
2. enable encryption
2. upload a docx (5.7MB large)
3. upload the same file again and overwrite the existing file
4. I can download the original file and the first version
5. I restore the first version
6. restored version can no longer be downloaded with the error described above
The manual cache operation in `\OCA\Files_Versions\Storage` is unfortunately necessary since `\OCA\Files_Versions\Storage::copyFileContents` is not using `\OCP\Files\Storage::moveFromStorage` in the case when an object storage is used. Due to the workaround added in 54cea05271
2016-03-03 14:15:36 +01:00
2a0cda74d4
Use IQueryBuilder::PARAM_* instead of \PDO::PARAM_*
2016-02-29 09:44:40 +01:00
6526c122af
Merge pull request #22683 from owncloud/fix_22682
...
Relax rootfolder check
2016-02-29 08:53:58 +01:00
b116e80c56
Relax rootfolder check
...
* Updated unit tests
* Added intergration test
2016-02-26 16:05:32 +01:00
bfcdf40a64
Expiration date can only be enforced if default is enabled
...
If the default expiration date is not enebaled it can not be enforced.
* Added unit tests
2016-02-26 11:38:06 +01:00
62d7885c3b
Merge pull request #22660 from owncloud/fix_22656
...
Do not allow sharing of the users root folder
2016-02-26 10:49:12 +01:00
0795cc373d
Merge pull request #22646 from owncloud/fix_22642
...
Set default expiration date if none given on share creation
2016-02-26 10:48:21 +01:00
cbde4bb92f
Merge pull request #22650 from owncloud/fix_hook
...
Fix verifyExpirationDate passwordSet argument
2016-02-26 09:32:41 +01:00
8213d5df4f
Do not allow sharing of the root folder
...
Sharing of the users root folder should not be allowed as it is very
weird UX. Also many of our clients have no proper way of displaying
this.
Added unit test
Also added intergration tests to make sure we won't allow it in the
future.
2016-02-25 20:40:30 +01:00
9412f69104
Fix verifyExpirationDate passwordSet argument
...
Password set should be false if the password is null.
Also updated the unit tests to tests this now.
2016-02-25 15:39:02 +01:00
efc966698f
Merge pull request #22579 from owncloud/fix_broken_unencrypted_size
...
Heal unencrypted file sizes at download time (second approach)
2016-02-25 14:34:48 +01:00
6d4f80d680
Set default expiration date if none given on share creation
...
When we create a share for the first time we should set the default
expiration date. If none is given.
Fixes #22642
2016-02-25 14:21:46 +01:00
2ec1c738d0
Merge pull request #22573 from owncloud/issue-22568-allow-string-object-ids
...
Make sure we can store strings as per the interface
2016-02-24 12:15:23 +01:00
834b51b83b
recalculate unencrypted size if we assume that the size stored in the db is not correct
2016-02-23 15:09:46 +01:00
fb8b34bdd0
Allow defining a limit and offset for getObjectIdsForTags
2016-02-23 09:04:15 +01:00
24c7f38a00
Make sure we can store strings as per the interface
2016-02-22 15:43:20 +01:00
f8677628d4
Merge pull request #22503 from owncloud/issue_22500
...
When (re-)sharing an incomming federated share set the corrent owner
2016-02-19 16:07:43 +01:00
b5281b61ed
Merge pull request #22410 from owncloud/fix_22119
...
Do not copy skeleton on avatar access
2016-02-19 16:06:40 +01:00
2dcf887cce
When (re-)sharing an incomming federated share set the corrent owner
...
Incomming federated shares are a special kind. We mount them as normal
webdav shares but we do supply owner info with the federated cloud id of
the share owner.
Since we do not yet have the new resharing behaviour on federated shares
we need to set the correct owner. Which will allow sharing and proper
mounting for other users.
fixes #22500
2016-02-19 12:43:03 +01:00
ec6e8c1ab6
fix unit test
2016-02-18 12:39:19 +01:00
c6fef52939
Merge pull request #22416 from owncloud/fix_22402
...
Return proper error string if sharing for this user is disabled
2016-02-16 13:37:22 +01:00
d5226c88ac
Merge pull request #22338 from owncloud/fix_22247
...
Allow more characters in filenames
2016-02-16 13:37:07 +01:00
ed6843e87b
Return proper error string if sharing for this user is disabled
...
Fixes #22402
2016-02-16 10:22:49 +01:00
47d28155a8
Do not copy skeleton on avatar access
...
Fixes #22119
Just try to get the folder of the user. If it is not there a
NotFoundException will be thrown. Which will be handled by the avatar
endpoint.
2016-02-16 09:18:38 +01:00
7048d428b1
Remove unneeded parameter from OC_App::getEnabledApps
2016-02-15 13:33:07 +01:00
248c571c56
Merge pull request #22331 from owncloud/dav-nonexisting-part
...
fix getNodeForPath for non existing part files
2016-02-13 18:24:00 +01:00
207c09c511
Merge pull request #22309 from owncloud/infinite-recursion-on-expired-link
...
Do not getShare in deleteShare, it's already there when deleting
2016-02-12 11:11:26 +01:00
e99c4d83dc
Merge pull request #22317 from owncloud/fix_invisible_linkshares
...
Do not allow invisible link shares
2016-02-12 11:10:58 +01:00
759b19775d
Fix unit tests
2016-02-12 07:49:36 +01:00
c3e4ced64a
fix getNodeForPath for non existing part files
2016-02-11 17:22:40 +01:00
4533cb9c59
Add parent for invisible link shares
2016-02-11 13:29:23 +01:00
8cfdc62eae
Update info checker requirements
2016-02-11 11:54:13 +01:00
2aa206e900
Fix unit tests
2016-02-11 11:21:12 +01:00
9bb97c714b
fixing unit tests
2016-02-09 23:43:26 +01:00
29f6f451a9
Merge pull request #22192 from owncloud/fix_19685
...
Only set the default expiration date on share creation
2016-02-09 23:38:00 +01:00
2982017682
Merge pull request #22228 from owncloud/comments-limit-message
...
Limit comment message to 1k chars
2016-02-09 16:35:23 +01:00
ee65cd0bd8
Only set the default expiration date on share creation
...
Fixes #19685
The default expiration date should only be set when we create a new
share. So if a share is created and the expiration date is unset. And
after that the password is updated the expiration date should remain
unset.
2016-02-09 11:05:14 +01:00
347ad3e223
Limit comment message to 1k chars
2016-02-09 03:14:30 +01:00
cd00751de5
Send events when enabling and disabling of apps
2016-02-09 02:51:12 +01:00
fad85ad19f
Fix unit tests
2016-02-08 11:30:48 +01:00
8486d61764
getSharesBy should also expire link shares
2016-02-06 13:31:54 +01:00
3028ec5440
Delete expired share when fetched by id
2016-02-06 13:31:54 +01:00
5ed56d9edb
Delete a link share if it is expired on access
...
If we access a link share we should check if it has expired already.
If so we should remove it and throw a ShareNotFound exception
2016-02-06 13:31:54 +01:00
5832178f59
Merge pull request #22139 from owncloud/comments-files-cleanup
...
cleanup jobs for comments and comment read marks
2016-02-06 13:26:00 +01:00
065141f6f4
Move casting to IExpressionBuilder
2016-02-05 21:26:30 +01:00
fb76d7de69
remove unused Storage->getLocalFolder
2016-02-05 16:48:08 +01:00
169874957a
Path should be relative
2016-02-04 19:19:10 +01:00
b57aac0a89
[Share 2.0] Add missing post_update_permissions hook
2016-02-04 19:18:25 +01:00
d8faeab421
Merge pull request #21766 from farukuzun/master
...
Add some mimetypes
2016-02-04 16:49:31 +01:00
1619968a03
Merge pull request #22111 from owncloud/use-intermediate-certificate
...
Use intermediate root authority + sign other release channels
2016-02-04 16:17:47 +01:00
0f22a8db1d
Also add type (file/folder) to IShare object
...
We need this for the hooks :(
2016-02-04 14:28:09 +01:00
2c0cb5a00e
Unit test for delete lazy shares
2016-02-04 13:30:42 +01:00
e0bc128eb5
Add unit tests
2016-02-04 13:05:05 +01:00
fc215d0980
Make the share object lazy
...
Share providers can now just pass in a fileId. And the node will only be
created once needed.
2016-02-04 12:51:23 +01:00
6ffd8f3e0d
Introduce some mimetypes for richdocuments
...
* application/vnd.lotus-wordpro
* application/vnd.visio
* application/vnd.wordperfect
* application/msonenote
2016-02-04 13:48:21 +02:00
b594aa18ee
Merge pull request #22110 from owncloud/comment-types-always-plural
...
types shall always be plural
2016-02-04 10:55:49 +01:00
5f300ac275
Allow specifing the signing path
2016-02-03 20:08:40 +01:00
Roeland Jago Douma
Morris Jobke
Robin Appelman
Joas Schilling
Lukas Reschke
Christoph Wurst
Jörn Friedrich Dreyer
Arthur Schiwon
Julius Haertl
Roeland Jago Douma
Vincent Petry
Thomas Müller
Bjoern Schiessle
William Bargent
Robin Appelman
Thomas Pulzer
Johannes Ernst
Lukas Reschke
Thomas Müller
Christoph Wurst
Christoph Wurst
Joas Schilling
Roeland Jago Douma
Joas Schilling
Torben Dannhauer
Björn Schießle
Bernhard Posselt
Robin McCorkell
Stefan Weil
Frank Karlitschek
v1r0x
Arthur Schiwon
Faruk Uzun