Commit Graph

1305 Commits

Author SHA1 Message Date
Roeland Jago Douma 23e3730a10
Merge pull request #25449 from nextcloud/backport/25393/stable19
[stable19] add repair job for unencoded group share uris
2021-02-17 21:05:16 +01:00
Roeland Jago Douma 8be6692521
Merge pull request #25593 from nextcloud/backport/25582/stable19
[stable19] Do not send imip email to invalid recipients
2021-02-17 10:38:13 +01:00
Christoph Wurst 59805dbe2c
Do not send imip email to invalid recipients
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-17 09:29:36 +01:00
Roeland Jago Douma fb2b19221f
Merge pull request #25385 from nextcloud/backport/25218/stable19
[stable19] do not remove valid group shares
2021-02-17 08:48:25 +01:00
Arthur Schiwon b570b22601 take into account that UNIQUE index might not work as expected
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-02-02 20:48:41 +00:00
Julius Härtl 6f6f45b77b Properly handle SMB ACL blocking scanning a directory
This makes sure that a possible ForbiddenException is properly passed
through the storage as a ForbiddenException and can be catched when
trying to fetch the quota info of a parent folder

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-02-01 11:13:52 +00:00
Arthur Schiwon ae8903e946 do not remove valid group shares
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-29 10:44:35 +00:00
Thomas Citharel a720bdb83d
[CalDAV] Validate notified emails
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-01-26 11:09:43 +01:00
Robin Appelman 69331b22c6 also use storage copy when dav copying directories
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-21 21:09:30 +00:00
Morris Jobke ac8a64a59c
Merge pull request #24591 from nextcloud/backport/24358/stable19
[stable19] use storage copy implementation when doing dav copy
2021-01-07 13:29:08 +01:00
Joas Schilling 6cab0e695c Don't throw a 500 when importing a broken ics reminder file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-05 12:02:03 +00:00
Arthur Schiwon edd9562079
fixes sharing to group ids /w chars that are being url encoded, carddav
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-18 12:00:44 +01:00
Arthur Schiwon fede4f4197
fix finding of groups with decodable chars in their id via DAV
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-18 12:00:37 +01:00
Arthur Schiwon 5379273b06
fixes sharing to group ids with characters that are being url encoded
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-12-18 12:00:22 +01:00
Robin Appelman 31944e84cb use storage copy implementation when doing dav copy
instead of using the sabredav fallback (which does a read+write stream copy)

this greatly speeds up dav copies

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-12-07 16:07:10 +00:00
Morris Jobke 0cc0d826a8
Merge pull request #24447 from nextcloud/backport/23652/stable19
[stable19] Fix public calendars shared to circles
2020-11-30 11:33:21 +01:00
Daniel Kesselberg 23263f9490 A valid user session is required for circles.
The circles app depends on a valid userId. A public shared calender might be viewed by guests without a user session. For such requests the principal is null.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-30 09:02:05 +00:00
Daniel Kesselberg 04364169ed Update phpdoc for circleToPrincipal
as the QueryException is already catched inside circleToPrincipal.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-11-30 09:02:02 +00:00
John Molakvoæ (skjnldsv) 0d43076f07 Make sure we add new line between vcf groups exports
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-11-30 08:14:01 +00:00
Sven Strickroth 75cdfd8dc2 Use correct year for generated birthdays events
'X-APPLE-OMIT-YEAR' is not always present, at least iOS 12.4 uses the hard coded date of 1604 (the start of the gregorian calendar) when the year is unknown.

cf. https://forums.bitfire.at/topic/2050/bday-without-year-for-vcard-3-0-if-server-drops-property-x-apple-omit-year and https://gitlab.com/CardBook/CardBook/-/issues/586

Signed-off-by: Sven Strickroth <email@cs-ware.de>
2020-11-20 20:39:34 +00:00
Richard Steinmetz a6e3bf6a59 Use png icons in caldav reminder emails
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2020-11-11 12:38:24 +00:00
Simon Spannagel afb88e7719 CalDavBackend: check if timerange is array before accessing
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-10-19 11:16:49 +00:00
Joas Schilling ee29d6ab11 Sync all users to the system addresssbook
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-29 07:18:56 +00:00
Joas Schilling 3fe6b5b5f8 Fix numeric folders throwing on markDirty
TypeError: strpos() expects parameter 1 to be string, int given

The problem is that in cacheNode() we strip of any slashes, so
a folder "0/" will be trimmed to "0" and be used as an array key.
Since PHP automatically casts numeric array keys to integers,
you afterwards get $nodePath as int(0). Since it's now a number,
the strpos() function does not accept it anymore. Simply casting
$nodePath to a string again in the foreach solves the issue

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-09-25 13:14:58 +00:00
Georg Ehrke ac87e46dff Mitigate encoding issue with user principal uri
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-09-14 06:20:32 +00:00
Julius Härtl f5dec3702b Properly catch exception from writing to stream when copying a file
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-10 13:18:11 +00:00
Julius Härtl f4dfb96d8d Do not keep the part file if the forbidden exception has retry set to false
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-03 11:06:41 +00:00
Georg Ehrke 7f8e43c7a7 Add ability to limit sharing to owner
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-08-20 12:51:09 +00:00
Julius Härtl 2b34f0e785 Return proper status when file didn't exist before
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 18:55:06 +00:00
Julius Härtl 242b19f18e Delete chunks if the move on an upload failed
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-13 18:55:05 +00:00
Joas Schilling 5728f23b57
Short php syntax
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-06 12:43:47 +02:00
Arthur Schiwon f13d5a3ec0
coding style fixes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-06 12:43:47 +02:00
Roeland Jago Douma a3238c3790 Do not log RequestedRangeNotSatisfiable exceptions in DAV
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-14 19:47:14 +00:00
Morris Jobke 42d899c4d5
Merge pull request #21710 from nextcloud/backport/21074/stable19
[stable19] Fix releasing a shared lock multiple times
2020-07-06 22:52:46 +02:00
Jaakko Salo 3f1b055828 In LockPlugin, only release a lock if it was acquired
When uploading new files, getNodeForPath() will not succeed
yet so the lock cannot be acquired.

In that case, don't try to unlock it either.

Signed-off-by: Jaakko Salo <jaakkos@gmail.com>
2020-07-06 12:11:47 +00:00
Georg Ehrke da522dc3d5 Changes the Birthday calendar color to slightly brighter one
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-07-06 11:25:17 +00:00
Joas Schilling a8ef2418f2 Fix pagination of contacts search
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-15 06:49:03 +00:00
Thomas Citharel 8cef51bbad Fix empty event UUID reminder notifications
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-06-05 07:04:43 +00:00
Georg Ehrke e048bf8550 Rename app-generated to z-app-generated, because macOS Contacts supports only one and will pick the first one alphabetically
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2020-05-08 10:05:56 +00:00
Roeland Jago Douma b7b7b2872c
Fix owner on publicownerwrapper
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-01 10:50:26 +02:00
Morris Jobke 0f9b88c5a9
Merge pull request #20718 from nextcloud/fix/public_share_owner_activity_mess
Add a wrapper to fall back to the share owner on public shares
2020-04-30 13:46:13 +02:00
Roeland Jago Douma b8b53a2d9a
Merge pull request #19436 from nextcloud/bugfix/noid/dav-quota-calculation
Do not include mountpoints when calculating quota usage on WebDAV
2020-04-30 09:13:19 +02:00
Roeland Jago Douma a1f3293c06
Merge pull request #19039 from nextcloud/dav-activity-provide-links-to-calendar
Provide links to calendar in event creation/update activities
2020-04-30 09:10:56 +02:00
Roeland Jago Douma bc66bdc072
Add a wrapper to fall back to the share owner on public shares
Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-30 08:57:01 +02:00
Joas Schilling f662d3663b
Temporary fix contacts search
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-29 14:48:41 +02:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
Morris Jobke 3c5c4caa4d
Merge pull request #20632 from nextcloud/bugfix/20624
Only catch anonymous OPTIONS for Office
2020-04-27 10:38:32 +02:00
Thomas Citharel deb2ea9cea
Provide links to calendar in event creation/update activities
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-26 11:11:50 +02:00
Julius Härtl 902d12555e
Do not include mountpoints when calculating quota usage on WebDAV
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-24 18:15:43 +02:00
Roeland Jago Douma 768b012000
Merge pull request #20570 from nextcloud/fix/20235/use_uploadfile
Use a proper upload file so propfinds return 404
2020-04-24 16:31:38 +02:00