fe3b3a9cec
Merge pull request #26147 from nextcloud/backport/26013/stable20
...
[stable20] Return the fileid from `copyFromCache` and use it instead of doing an extra query
2021-03-17 20:04:11 +01:00
147134fc31
Add getID function to the simplefile implementation
...
Sometimes it is useful to get the actual fileid
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-17 16:15:46 +00:00
3c1402c2d9
Merge pull request #25876 from nextcloud/psalm/stable20/update
...
[stable20] Update psalm baseline
2021-03-17 14:17:20 +01:00
fd53468d7b
Merge pull request #26163 from nextcloud/backport/26153/stable20
...
[stable20] Use correct exception type hint in catch statement
2021-03-17 13:50:13 +01:00
94c47eddea
Merge pull request #26168 from nextcloud/backport/26072/stable20
...
[stable20] remove explicit fclose from S3->writeStream
2021-03-17 13:46:48 +01:00
67e0b194b6
Update and fix baseline
...
Backported some bits of stable21 to make Psalm happy.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-17 12:04:08 +01:00
534a935433
remove explicit fclose from S3->writeStream
...
streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-17 09:36:11 +00:00
f80f7a33e8
Fix baseline further
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-17 10:31:09 +01:00
7bb7f4d936
Update psalm baseline
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-17 10:06:06 +01:00
9749514649
Use correct exception type hint in catch statement
...
Found by psalm update 4.6.2 to 4.6.3 in #26111
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-17 08:47:07 +00:00
fdabe1172b
[tx-robot] updated from transifex
2021-03-17 02:24:39 +00:00
279f0d72f3
dont allow creating users with __groupfolders as uid
...
Fixes https://github.com/nextcloud/groupfolders/issues/338
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 18:51:58 +00:00
436cd31bd2
verify that cache entry is valid
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:04 +00:00
9bb73574c3
also implement for FailedCache and NullCache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:03 +00:00
20ab946c3f
use returned file id for object store copy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:01 +00:00
aaa4c071ed
add ICopyFromCache trait to expose existing implementation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 16:18:01 +00:00
2e14150889
Merge pull request #26134 from nextcloud/backport/25136/stable20
...
[stable20] do cachejail search filtering in sql
2021-03-16 17:00:29 +01:00
bdd7f28fa6
only use share cacheentry when available
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:23 +01:00
f500e2396e
adjust tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:23 +01:00
7fd53b91c3
fix search in nested jails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:22 +01:00
a20eb9a229
fix cachjail searching for root
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:22 +01:00
5d08beb3d2
do cachejail search filtering in sql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-16 15:22:22 +01:00
a6357ebcba
Merge pull request #26130 from nextcloud/backport/26115/stable20
...
[stable20] Log exceptions when creating share
2021-03-16 11:09:44 +01:00
7332b6f75e
[tx-robot] updated from transifex
2021-03-16 02:25:00 +00:00
20ebdf4fe0
Log exceptions when creating share
...
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.
In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 15:06:43 +00:00
797645bc49
send share notification instead of erroring on duplicate share
...
when creating a share that already exists, instead of erroring, resend the notifications
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-15 14:13:05 +00:00
ff64514bea
Allow overwriting isAuthenticated
...
* Some implementations might check for different things
* IT will not change how the current ones work
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-15 13:59:10 +00:00
3e18eca7a0
Merge pull request #26059 from nextcloud/backport/25911/stable20
...
[stable20] Only clear share password model when actually saved
2021-03-15 09:48:19 +01:00
25f27569f5
[tx-robot] updated from transifex
2021-03-15 02:24:17 +00:00
049895f3e7
[tx-robot] updated from transifex
2021-03-14 02:23:58 +00:00
b6af167c65
[tx-robot] updated from transifex
2021-03-13 02:23:14 +00:00
5827a156af
apply object store copy optimization when 'cross storage' copy is within the same object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-12 16:16:32 +00:00
60756e8e3e
[tx-robot] updated from transifex
2021-03-12 02:23:01 +00:00
51ba0faeaf
Only clear share password model when actually saved
...
Instead of always clearing the password in the share model, now only do
it when it was actually saved.
Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-11 10:20:59 +00:00
b306b88a41
Merge pull request #26040 from nextcloud/backport/25916/stable20
...
[stable20] Remove trash items from other trash backends when deleting all
2021-03-11 10:34:32 +01:00
28378720f1
[tx-robot] updated from transifex
2021-03-11 02:23:28 +00:00
a1935d0f74
cache baseurl in url generator
...
Servers don't tend to change their url in the middle of a request
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-10 19:38:41 +00:00
ae6c5f2af4
Merge pull request #26027 from nextcloud/backport/25933/stable20
...
[stable20] Hide expiration date field for remote shares
2021-03-10 15:46:53 +01:00
aad21777d4
Hide expiration date field for remote shares
...
Remote shares currently do not support expiration date.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 09:08:28 +00:00
f240f895e7
Merge pull request #25878 from nextcloud/backport/25568/stable20
...
[stable20] disable trasbin during the moveFromStorage fallback
2021-03-10 09:34:02 +01:00
0c98c15555
Remove trash items from other trash backends when deleting all
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-10 08:02:38 +00:00
8dc2b22e35
[tx-robot] updated from transifex
2021-03-10 02:23:17 +00:00
0d021249f8
Merge pull request #25938 from nextcloud/backport/25927/stable20
...
[stable20] Sharebymail: set expiration on creation
2021-03-09 20:20:49 +01:00
791868fa25
Merge pull request #25994 from nextcloud/backport/25975/stable20
...
[stable20] Add missing waits and asserts in acceptance tests
2021-03-09 09:34:25 +01:00
df04689af7
[tx-robot] updated from transifex
2021-03-09 02:24:13 +00:00
5f3955446a
Merge pull request #26009 from nextcloud/dependabot/npm_and_yarn/stable20/elliptic-6.5.4
...
[Security] Bump elliptic from 6.5.3 to 6.5.4
2021-03-08 19:37:51 +01:00
7dffaabe8a
[Security] Bump elliptic from 6.5.3 to 6.5.4
...
Bumps [elliptic](https://github.com/indutny/elliptic ) from 6.5.3 to 6.5.4. **This update includes a security fix.**
- [Release notes](https://github.com/indutny/elliptic/releases )
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-08 16:52:54 +00:00
ace7b9dfe1
Find directly the label instead of falling back to it
...
The input element is always hidden, so the check always ended falling
back to the label. Moreover, the label is the element that the user
interacts with, so it must be the one used.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:37 +00:00
f92a216dcf
Assert also element visibility instead of just finding it
...
Although if the element could not be found an exception would be thrown
and the test aborted if an element is in the DOM but hidden it would be
found and the test would pass.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:37 +00:00
30c91a7303
Add explicit locator for "Enable all" bundle button
...
Instead of looking for the bundle button and then checking its value now
the expected value is included in the locator and the button is checked
similarly to other elements.
No "Disable all" locator was added as it was not currently needed
anywhere.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-03-08 07:59:36 +00:00
Morris Jobke
Roeland Jago Douma
Vincent Petry
Robin Appelman
Nextcloud bot
Christoph Wurst
Roeland Jago Douma
Julius Härtl
dependabot-preview[bot]
Daniel Calviño Sánchez