Commit Graph

5215 Commits

Author SHA1 Message Date
Nextcloud bot 3ab7d6cf3e
[tx-robot] updated from transifex 2021-04-17 02:24:04 +00:00
castillo92 12948aa217
Update ShareAPIController.php
Change to capital letters in an abbreviation.

Signed-off-by: castillo92 javiercizquierdo@gmail.com
2021-04-16 08:56:20 +02:00
Vincent Petry af61486aea
Separate settings for remote share expiration
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +02:00
Vincent Petry 2650da70ca
Unit tests for federated share expiration date
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:03 +02:00
Vincent Petry b0aaafe259
Fix expire date capability for federated shares
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:03 +02:00
Vincent Petry 8680bafc5c
Implement expiration date for federated shares
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +02:00
Nextcloud bot 8ef920fdf9
[tx-robot] updated from transifex 2021-04-15 02:25:10 +00:00
Roeland Jago Douma 644ce9e4f0
Merge pull request #26529 from J0WI/getSystemValue-type
Use correct getSystemValue type
2021-04-14 13:36:56 +02:00
John Molakvoæ 857a40b334
Merge pull request #26533 from nextcloud/fix/add-share-resolve-default
Fix undefined error on add-share
2021-04-14 08:32:26 +02:00
Nextcloud bot 7081c63d09
[tx-robot] updated from transifex 2021-04-14 02:26:51 +00:00
John Molakvoæ (skjnldsv) 4b9991a4f2 Fix undefined error on add-share
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-13 06:21:48 +00:00
J0WI 74a7c2eefc Use correct getSystemValue type
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-12 22:54:50 +02:00
Nextcloud bot d942a5b2be
[tx-robot] updated from transifex 2021-04-11 02:24:42 +00:00
Nextcloud bot bbee01117e
[tx-robot] updated from transifex 2021-04-10 02:31:13 +00:00
dependabot-preview[bot] e2645a5e70 Bump core-js from 3.9.1 to 3.10.1
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.9.1 to 3.10.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.10.1/packages/core-js)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-08 15:50:13 +02:00
Nextcloud bot bfd926938f
[tx-robot] updated from transifex 2021-04-04 02:24:48 +00:00
Nextcloud bot 4bea123c7a
[tx-robot] updated from transifex 2021-04-02 02:26:04 +00:00
John Molakvoæ (skjnldsv) 11437223e9
Compile node
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-31 12:34:13 +02:00
John Molakvoæ (skjnldsv) 3e624dc399
Bump js licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-31 12:17:18 +02:00
Nextcloud bot 855b5fc638
[tx-robot] updated from transifex 2021-03-31 02:24:50 +00:00
Julius Härtl 6bef9e71da
Merge pull request #26337 from nextcloud/dependabot/npm_and_yarn/url-search-params-polyfill-8.1.1
Bump url-search-params-polyfill from 8.1.0 to 8.1.1
2021-03-29 10:33:38 +02:00
dependabot-preview[bot] e2216d44fd Bump url-search-params-polyfill from 8.1.0 to 8.1.1
Bumps [url-search-params-polyfill](https://github.com/jerrybendy/url-search-params-polyfill) from 8.1.0 to 8.1.1.
- [Release notes](https://github.com/jerrybendy/url-search-params-polyfill/releases)
- [Commits](https://github.com/jerrybendy/url-search-params-polyfill/compare/v8.1.0...v8.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-29 07:41:21 +00:00
Joas Schilling 602de272c0
Merge pull request #26243 from nextcloud/enh/noid/avatar-privacy-new-scope
Avatar privacy and new scope
2021-03-29 09:01:12 +02:00
Nextcloud bot 4564121c56
[tx-robot] updated from transifex 2021-03-29 02:23:55 +00:00
Nextcloud bot aec9c8437a
[tx-robot] updated from transifex 2021-03-27 02:24:25 +00:00
Vincent Petry 278a73789e
Map old account scope properties to new names
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Nextcloud bot 630eddf41b
[tx-robot] updated from transifex 2021-03-26 02:25:32 +00:00
Nextcloud bot 9af8c0b380
[tx-robot] updated from transifex 2021-03-25 02:25:39 +00:00
Nextcloud bot bb8a71266e
[tx-robot] updated from transifex 2021-03-24 02:25:07 +00:00
Nextcloud bot a81408a8e1
[tx-robot] updated from transifex 2021-03-23 02:24:02 +00:00
Daniel Calviño Sánchez f99876997a
Remove duplicated query for email shares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +01:00
John Molakvoæ (skjnldsv) a100186e5e
Sharing link & mail parity
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:45 +01:00
John Molakvoæ (skjnldsv) 5e519fe17a
Clear the input after adding a new share
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:41:33 +01:00
John Molakvoæ (skjnldsv) c47e79fc67
Handle enforced password for mail shares in the WebUI
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:40:43 +01:00
John Molakvoæ (skjnldsv) c8e0809d43
Extract GeneratePassword function to its own file
This is needed to be able to use the function from other components.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:40:41 +01:00
John Molakvoæ (skjnldsv) 100d5d9a47
Add labels to mail shares
Now the email is shown on a second line if a label is set.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:34:09 +01:00
Nextcloud bot ae19cb168f
[tx-robot] updated from transifex 2021-03-22 02:23:45 +00:00
dependabot-preview[bot] 017537ab95 Bump clipboard from 2.0.6 to 2.0.8
Bumps [clipboard](https://github.com/zenorocha/clipboard.js) from 2.0.6 to 2.0.8.
- [Release notes](https://github.com/zenorocha/clipboard.js/releases)
- [Commits](https://github.com/zenorocha/clipboard.js/compare/v2.0.6...v2.0.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-20 12:46:13 +00:00
John Molakvoæ 6ade109b60
Merge pull request #26194 from nextcloud/techdebt/noid/remove-duplicate-sharing-unit-integration-tests-group-permission
Remove duplicate unit test in sharing that checks for group permission updates
2021-03-18 16:37:29 +01:00
Morris Jobke b34035f845
Merge pull request #26193 from nextcloud/techdebt/noid/remove-sharing-duplicate-unit-integration-tests
Permission tests for the sharing are fully covered in sharing v1 integration tests
2021-03-18 11:34:15 +01:00
Morris Jobke d650de13a4
Remove duplicate unit test in sharing that checks for group permission updates
* it was skipped before anyways
* it is covered for example in build/integration/sharing_features/sharing-v1-part3.feature#L517-L548 (see 54f8f75f6f/build/integration/sharing_features/sharing-v1-part3.feature (L517-L548))
* more permission updates are tested in the webdav section, where an OCS API is called and the WebDAV response is checked for the properly changed permission

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-18 10:31:56 +01:00
Morris Jobke e6bd23acf9
Permission tests for the sharing are fully covered in sharing v1 integration tests
See build/integration/sharing_features/sharing-v1*.features for the exact same tests. Especially part3 that covers most of the different permission setups over webdav.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-18 10:15:42 +01:00
Morris Jobke 6401d88283
Merge pull request #25331 from nextcloud/fix-valid-storages-removed-when-cleaning-remote-storages
Fix valid storages removed when cleaning remote storages
2021-03-18 08:57:09 +01:00
Nextcloud bot a186d08471
[tx-robot] updated from transifex 2021-03-18 02:25:02 +00:00
Morris Jobke f56e5bb0db
Merge pull request #25676 from nextcloud/drop/utl-is-ie
Drop \OCP\Util::isIe
2021-03-17 20:18:11 +01:00
John Molakvoæ f1fefd91df
Merge pull request #26160 from nextcloud/enh/eslint 2021-03-17 18:14:31 +01:00
John Molakvoæ (skjnldsv) 043b5a9de4
Fix TerserPlugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 13:03:39 +01:00
John Molakvoæ (skjnldsv) 5d9bb5e247
Lint fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 13:03:38 +01:00
Vincent Petry c6d2d8746c
Fix CS in CacheTest
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-16 11:43:53 +01:00
Vincent Petry e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter
do cachejail search filtering in sql
2021-03-15 17:45:30 +01:00
Vincent Petry 6997344931
Log exceptions when creating share
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.

In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 12:00:41 +01:00
Nextcloud bot f82edda9c1
[tx-robot] updated from transifex 2021-03-15 02:23:58 +00:00
John Molakvoæ (skjnldsv) 31ddfb0294
Fix SharingInput Multiselect
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-11 12:30:15 +01:00
John Molakvoæ (skjnldsv) 7f06a0cf8e
Compile js
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-11 12:14:48 +01:00
Vincent Petry 3462444def
Only clear share password model when actually saved
Instead of always clearing the password in the share model, now only do
it when it was actually saved.

Fixes an issue where saving another field would clear the password too
early and prevent it to be saved when the dropdown closed.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-11 09:07:30 +01:00
dependabot-preview[bot] 613a5760f1 Bump css-loader from 5.0.1 to 5.1.1
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 5.0.1 to 5.1.1.
- [Release notes](https://github.com/webpack-contrib/css-loader/releases)
- [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md)
- [Commits](https://github.com/webpack-contrib/css-loader/compare/v5.0.1...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-10 16:47:32 +01:00
Christoph Wurst 7f3051e5bf Drop \OCP\Util::isIe
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-09 20:29:42 +01:00
Vincent Petry 77401e8c1c
Hide expiration date field for remote shares
Remote shares currently do not support expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-09 10:40:14 +01:00
Roeland Jago Douma 988b9f49c5 Fix invalid check after constructing DateTime
We construct an object. Either that works on not.But the result can't be
false.

Found by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 16:32:34 +01:00
Nextcloud bot e8f087d7d1
[tx-robot] updated from transifex 2021-03-08 02:23:08 +00:00
dependabot-preview[bot] 6c8650d414 Bump core-js from 3.8.3 to 3.9.1
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.8.3 to 3.9.1.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.9.1/packages/core-js)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 11:34:26 +01:00
Robin Appelman b844293536 catch notfound and forbidden exception in smb::getmetadata
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-04 21:34:54 +01:00
Christoph Wurst cdc9a1efd9
Merge pull request #25912 from nextcloud/techdept/psalm/sharedstorage_some_types
Add some typing to SharedStorage
2021-03-04 12:31:17 +01:00
Roeland Jago Douma 7b9ca4f7c2 Add some typing to SharedStorage
Makes psalm a bit more happy.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 10:49:42 +01:00
Julius Härtl 69c2864aca
Add appconfig to always show the unique label of a sharee
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-04 09:25:45 +01:00
Nextcloud bot 365d31743f
[tx-robot] updated from transifex 2021-03-04 02:22:10 +00:00
Vincent Petry c541094be0 Clear multiselect after selection in share panel
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-03 11:38:00 +01:00
Roeland Jago Douma ce430c3613
Merge pull request #25892 from nextcloud/techdept/initialstate/part1
Move some settings over to the IInitialState
2021-03-03 11:08:42 +01:00
Roeland Jago Douma bc961baa40 Move some settings over to the IInitialState
The old one has been deprecated. Part one of many.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:11:56 +01:00
Roeland Jago Douma 5c952e83fc Pimp sharingcheckmiddleware
Reported by psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 20:36:04 +01:00
Roeland Jago Douma 19e2136963 Update autoloader files
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:36:21 +01:00
dependabot-preview[bot] b486e26b81 Bump @babel/core from 7.12.16 to 7.13.8
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.16 to 7.13.8.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.8/packages/babel-core)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-01 21:30:34 +00:00
Nextcloud bot 9a90bfba32
[tx-robot] updated from transifex 2021-03-01 02:20:19 +00:00
Nextcloud bot c8f7a808fd
[tx-robot] updated from transifex 2021-02-25 02:21:21 +00:00
Nextcloud bot b89fbaf52d
[tx-robot] updated from transifex 2021-02-24 02:22:06 +00:00
Nextcloud bot ff54a0481b
[tx-robot] updated from transifex 2021-02-23 02:39:25 +00:00
John Molakvoæ 1eca8d21ee
Merge pull request #25602 from nextcloud/bugfix/noid/only-create-share-once
Avoid creating two share links when password is enforced
2021-02-22 12:08:49 +01:00
Nextcloud bot ac2577a594
[tx-robot] updated from transifex 2021-02-20 02:37:22 +00:00
Julius Härtl 9073c09c62 Avoid creating two share links when password is enforced
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-19 11:16:38 +00:00
dependabot-preview[bot] eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
Nextcloud bot 5f194dad24
[tx-robot] updated from transifex 2021-02-18 02:21:54 +00:00
Nextcloud bot 57212a99f9
[tx-robot] updated from transifex 2021-02-17 02:21:05 +00:00
Roeland Jago Douma 2ea3cb7c93 Drop redundant indes
Those indexes are already covered by others. So those can just be used.
THose extra indexes just take up space.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-16 11:38:43 +01:00
Roeland Jago Douma 9929adde08
Merge pull request #25594 from wankdanker/files_sharing_owner_display_name
Use ownerDisplayName for SharingEntry Tooltip
2021-02-15 13:17:25 +01:00
Nextcloud bot 69f0d7d5d4
[tx-robot] updated from transifex 2021-02-13 02:20:27 +00:00
Dan VerWeire 1f47ae7c1b Use ownerDisplayName for SharingEntry Tooltip
Some NC installations may use a LDAP UUID for the username. If that
is the case, then the tooltip for who a file/folder was shared by may say something
like `Shared with Steve McQueen (smqueen@yada.com) by FKDJ39-38D794JG-4398GJODF9H3G-4534`.

This commit changes the value showed for the owner to the full display name.

Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-12 07:32:26 +00:00
Roeland Jago Douma 983f7f3e49
Merge pull request #25493 from Worteks/fix-filessharing-debug
fix(log): remove debug log in _formatRemoteShare, suggested by @maxbes
2021-02-08 21:40:05 +01:00
Nextcloud bot 26a20ed13f
[tx-robot] updated from transifex 2021-02-08 02:20:05 +00:00
dependabot-preview[bot] a21a8adb2b Bump @babel/preset-env from 7.12.11 to 7.12.13
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.11 to 7.12.13.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.12.13/packages/babel-preset-env)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-02-07 11:36:26 +00:00
Samuel 69df6c41de fix(ci): build additionalScripts
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-07 11:06:11 +01:00
Nextcloud bot f19287ae57
[tx-robot] updated from transifex 2021-02-07 02:20:51 +00:00
Vincent Petry 50004bc4a5
Sharing dropdown now opens below
Fixes an issue where the dropdown list was not visible on small screens
as it would appear above the field and be hidden behind the container
border.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-05 14:47:01 +01:00
Samuel 73338a061b fix(debug): remove debug log in _formatRemoteShare, suggested by @maxbes
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 10:45:44 +01:00
Joas Schilling 9de00f3d24
This is 22
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-02-03 08:38:41 +01:00
Nextcloud bot 8c41589b30
[tx-robot] updated from transifex 2021-02-03 02:19:44 +00:00
Nextcloud bot e18c608cb4
[tx-robot] updated from transifex 2021-02-02 02:19:50 +00:00
Nextcloud bot 86678ba5df
[tx-robot] updated from transifex 2021-02-01 02:19:36 +00:00
Nextcloud bot fcbe4c5be5
[tx-robot] updated from transifex 2021-01-30 02:20:34 +00:00
Nextcloud bot d31013f1b8
[tx-robot] updated from transifex 2021-01-29 02:21:15 +00:00
Daniel Calviño Sánchez 9ccabff6ba Fix valid storages removed when cleaning remote storages
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.

The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.

Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-01-28 21:42:31 +01:00