blizzz
0ab5b3e265
Merge pull request #26679 from nextcloud/bugfix/noid/fix-unauthorized-ocs-status-in-provisioning
...
Fix unauthorized OCS status in provisioning
2021-05-13 23:39:20 +02:00
blizzz
b8b2e796bf
Merge pull request #26959 from nextcloud/techdebt/noid/verifiyuserdata-iaccountmanager
...
VerifyUserData shall use IAccountManager, not private API
2021-05-12 23:35:39 +02:00
Arthur Schiwon
9977027321
VerifyUserData shall use IAccountManager, not private API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:57:20 +02:00
Arthur Schiwon
a49588bbe5
PersonalInfo settings to use public AccoutManager API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:55:34 +02:00
Roeland Jago Douma
50517a2622
Throttle MountPublicLinkController when share is not found
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-12 16:26:31 +02:00
Robin Appelman
8d7fae8fae
fmt
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:55 +02:00
Robin Appelman
0e6321957d
allow excluding groups from creating link shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:31 +02:00
Robin Appelman
b1dca57a1c
load share settings from the share manager in more places
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:28 +02:00
Roeland Jago Douma
749dd1374c
Fix CS check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-12 16:01:05 +02:00
blizzz
7e1c842d96
Merge pull request #26923 from nextcloud/techdebt/noid/provapi-no-private-accountmanager
...
provisioning API to use only public API of IAccountManager
2021-05-12 14:17:50 +02:00
Roeland Jago Douma
6c741724fb
Merge pull request #26941 from nextcloud/enh/register-multiselect-fileactions
...
Allow apps to register a file action for multiselect
2021-05-12 10:53:58 +02:00
Roeland Jago Douma
a2a96466fc
Merge pull request #26922 from nextcloud/techdebt/noid/dav-no-private-class
...
dav: Converter & SyncService shall not use private AccountManager
2021-05-12 10:22:49 +02:00
Roeland Jago Douma
024ed97e7e
Merge pull request #26945 from nextcloud/enh/shareinfo/throttle
...
Add bruteforce protection to the shareinfo endpoint
2021-05-12 10:07:28 +02:00
Julius Härtl
96515d7338
Allow apps to register a file action for multiselect
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-05-12 09:48:52 +02:00
Roeland Jago Douma
701294520a
Add bruteforce protection to the shareinfo endpoint
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-12 09:34:45 +02:00
Joas Schilling
b6c6527705
Fix unauthorized OCS status in provisioning
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 08:16:07 +02:00
Nextcloud bot
0df326ab20
[tx-robot] updated from transifex
2021-05-12 02:26:16 +00:00
Arthur Schiwon
8413ed9475
allow to set valid scopes only in AccountProperty
...
the auto-fallback to v2-local is removed as well to react on wrong input
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 01:31:15 +02:00
Arthur Schiwon
665ffbdf80
remove private AccountManager from SyncService
...
and fix test
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-11 23:38:31 +02:00
Nextcloud bot
b2ad201644
[tx-robot] updated from transifex
2021-05-11 02:26:02 +00:00
Valdnet
99e6849906
Change the values in test
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-10 09:22:39 +02:00
Valdnet
73a616101b
Change the values in the test
2021-05-10 09:19:50 +02:00
Nextcloud bot
488eea82dc
[tx-robot] updated from transifex
2021-05-10 02:31:42 +00:00
Nextcloud bot
df71883c9a
[tx-robot] updated from transifex
2021-05-09 02:25:15 +00:00
Nextcloud bot
461a975749
[tx-robot] updated from transifex
2021-05-08 02:24:54 +00:00
Arthur Schiwon
1e271e9f76
provAPI to use only public API of IAccountManager
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-08 01:20:17 +02:00
Arthur Schiwon
04edd067f4
dav: do not use private AccountManager
...
- also updates data structure in test
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-08 00:18:17 +02:00
Christoph Wurst
cebe951b8e
Remove the untyped calendar update event
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-07 17:09:37 +02:00
Christoph Wurst
884e34b12a
Remove the untyped calendar create event
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-07 16:58:33 +02:00
Christoph Wurst
f8c519f5f0
Merge pull request #26913 from nextcloud/chore/dav-calendar-object-untyped-events
...
Drop some more untyped events from the dav code
2021-05-07 16:47:44 +02:00
Christoph Wurst
f5462650f1
Clean up reminder actions and call methods directly
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-07 12:13:47 +02:00
Christoph Wurst
257613e6ef
Remove the \OCA\DAV\CalDAV\CalDavBackend::createCalendarObject event
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-07 12:13:45 +02:00
Christoph Wurst
f808267949
Remove the \OCA\DAV\CalDAV\CalDavBackend::updateCalendarObject event
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-07 12:10:58 +02:00
Christoph Wurst
08a4b24926
Drop the unused second parameter on \OCA\DAV\CalDAV\CalDavBackend::getShares
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-07 11:57:31 +02:00
Christoph Wurst
d512a5629e
Remove the \OCA\DAV\CalDAV\CalDavBackend::deleteCalendarObject event
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-07 10:53:45 +02:00
Nextcloud bot
df685b4b59
[tx-robot] updated from transifex
2021-05-07 02:26:47 +00:00
Valdnet
2349df4ca5
l10n: Replace the apostrophe with double quotation
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-06 14:55:35 +02:00
Valdnet
c5a4668c88
l10n: Replace the apostrophe with double quotation
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-06 14:45:33 +02:00
Nextcloud bot
42f0f27240
[tx-robot] updated from transifex
2021-05-06 02:25:32 +00:00
Morris Jobke
1089ad5d9e
Merge pull request #26877 from nextcloud/chore/query-builder-execute-statement
...
Rename IQueryBuilder::executeUpdate to IQueryBuilder::executeStatement
2021-05-05 14:19:02 +02:00
Christoph Wurst
99f2fa73d1
Fix usage of rename executeUpdate
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-05 10:35:25 +02:00
Valdnet
4df8fec0c3
Fix test
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-04 11:38:45 +02:00
Valdnet
48d12b6441
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-04 09:38:46 +02:00
Nextcloud bot
6d3aef1849
[tx-robot] updated from transifex
2021-05-04 02:26:15 +00:00
Morris Jobke
68c8fa8235
Merge pull request #26845 from nextcloud/fix/noid/import-card-fix-string-value
...
fix creating vcards with multiple string values
2021-05-03 15:49:43 +02:00
Nextcloud bot
ea05e1a6ae
[tx-robot] updated from transifex
2021-05-03 02:25:36 +00:00
Nextcloud bot
a5faa98e6e
[tx-robot] updated from transifex
2021-05-02 02:25:23 +00:00
Nextcloud bot
5cccbbdd45
[tx-robot] updated from transifex
2021-05-01 02:26:34 +00:00
Arthur Schiwon
a9f39aab29
fix creating vcards with multiple string values
...
Internally it is valid to provide multiple values for a property as
plain string. An exampe is given in the PhpDoc of
AddressBookImpl::search().
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-30 21:36:05 +02:00
Nextcloud bot
f3baab3159
[tx-robot] updated from transifex
2021-04-30 02:27:46 +00:00
Morris Jobke
22ba8fa78d
Merge pull request #26826 from nextcloud/refactor/dav-typed-calendar-deleted-events
...
Exclusively use the typed calendar deletion events for DAV
2021-04-29 16:14:10 +02:00
Christoph Wurst
63eb3694e4
Exclusively use the typed calendar deletion events for DAV
...
We had both in places, but the old one isn't used anywhere outside this
app, so it's time to migrate the code.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-29 15:31:19 +02:00
dependabot-preview[bot]
fdf54e9e43
Merge pull request #26736 from nextcloud/dependabot/npm_and_yarn/babel/core-7.13.16
2021-04-29 07:15:26 +00:00
Nextcloud bot
e0f700b1bd
[tx-robot] updated from transifex
2021-04-29 02:26:26 +00:00
Morris Jobke
b971f69e26
Merge pull request #26461 from nextcloud/bugfix/noid/only-return-editable-displayname-field-when-allowed-by-backend
...
Only return display name as editable when the user backend allows it
2021-04-28 20:27:40 +02:00
dependabot-preview[bot]
c9b6f42c1a
Bump @babel/core from 7.13.15 to 7.13.16
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.13.15 to 7.13.16.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.13.16/packages/babel-core )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-04-28 12:47:31 +00:00
Roeland Jago Douma
758a662b23
Do not try to contact lookup server if not needed
...
In some cases (for example you never send data to the lookup server)
there is no need for this job to even try.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-28 14:27:46 +02:00
rakekniven
48f05158e5
Merge pull request #26784 from nextcloud/Valdnet-patch-8
...
l10n: Change to a capital letter
2021-04-28 10:11:32 +02:00
Valdnet
c79aba9865
Change size of the letter in test
2021-04-28 08:57:53 +02:00
Nextcloud bot
be4f665d2d
[tx-robot] updated from transifex
2021-04-28 02:25:44 +00:00
kesselb
9658bc9dd0
Merge pull request #26785 from nextcloud/fix/noid/ldap-beyond-last-page
...
LDAP: do not bother to search after the last page
2021-04-27 19:38:18 +02:00
Joas Schilling
0e6e80aaec
Merge pull request #26781 from nextcloud/bugfix/noid/more-auto-add-cleanup
...
More cleaning after auto-add removal
2021-04-27 15:56:17 +02:00
Joas Schilling
03b467bd23
Also check implementsAction method
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 15:28:02 +02:00
Joas Schilling
f67a10e8d0
Only return display name as editable when the user backend allows it
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 15:01:30 +02:00
Joas Schilling
df47445c01
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +02:00
Arthur Schiwon
2a5473e146
do not try to search after the last page
...
- saves an LDAP requests in these cases
- prevents a Protocol Error logged on < 7.3 API (for backports)
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-27 12:52:26 +02:00
Valdnet
505863c55e
l10n: Change to a capital letter
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-27 12:38:28 +02:00
Julius Härtl
9de6efd14e
Merge pull request #26774 from nextcloud/techdebt/noid/ldap-remove-pre73-paged-results
2021-04-27 07:00:28 -01:00
Joas Schilling
1029abc8f6
More cleaning after auto-add removal
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 08:13:47 +02:00
Joas Schilling
3f0b7fd289
Merge pull request #26765 from nextcloud/td/no_more_add_auto_trusted
...
No longer add trusted servers on federated share creation
2021-04-27 08:06:59 +02:00
John Molakvoæ
b8cde2c8b6
Merge pull request #26775 from robottod/patch-1
...
Remove some deprecated calls from ShareByMailProvider.php
2021-04-27 07:59:27 +02:00
Nextcloud bot
2aad4bbed6
[tx-robot] updated from transifex
2021-04-27 02:25:33 +00:00
Arthur Schiwon
5e8f43a55e
removes PagedResults adapter for PHP < 7.3
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-26 22:57:42 +02:00
robottod
0451927994
Remove some deprecated calls from ShareByMailProvider.php
...
This moves the execute calls to the executeQuery and executeUpdate calls
Resulting in less calls to deprecated functions
Signed-off-by: rtod <robottod@protonmail.com>
2021-04-26 21:53:56 +02:00
Roeland Jago Douma
71e05b1fd3
No longer add trusted servers on federated share creation
...
It was disabled by default for ages. And often resulted in unwanted
behavior. If admins want trusted servers they just have to do it
manually.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-26 19:47:55 +02:00
Roeland Jago Douma
70f12e7332
Improve federated permission handling
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-26 16:10:44 +02:00
Joas Schilling
aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
...
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +02:00
Chih-Hsuan Yen
fea5b4a8b9
Correctly truncate multibyte strings to fit into the database
...
Closes : #26174
Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
2021-04-26 16:54:50 +08:00
Nextcloud bot
4ded8a08b7
[tx-robot] updated from transifex
2021-04-26 02:24:39 +00:00
Nextcloud bot
da17db0fdc
[tx-robot] updated from transifex
2021-04-25 02:24:52 +00:00
Nextcloud bot
39764b05b1
[tx-robot] updated from transifex
2021-04-24 02:26:38 +00:00
Daniel Calviño Sánchez
8fc8451004
Merge pull request #25417 from nextcloud/fix-account-data-visibility-after-disabling-public-addressbook-upload
...
Fix account data visibility after disabling public addressbook upload
2021-04-23 16:48:36 +02:00
Christoph Wurst
323f95693c
Close open cursors
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 14:35:02 +02:00
Christoph Wurst
72a4f21efe
Use the new executeQuery and executeUpdate methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 13:21:25 +02:00
Christoph Wurst
94bf14a8dc
Drop default fetch mode parameter
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 13:21:25 +02:00
Daniel Calviño Sánchez
da84ed7d4c
Fix active scope not visible in the menu if excluded
...
Depending on some settings (for example, if lookup server upload is
disabled) some items can be hidden in the scope menu. However, if the
user selected an scope in the past once the settings were changed the
scope was no longer visible in the menu. Now the active scope will be
always visible in the menu, although if it is an excluded scope it will
be disabled. Selecting any other scope will then hide the excluded and
no longer active one.
When upload to the lookup server is disabled the scope menu was hidden
for display name and email in the personal information settings; now the
menu will be always shown to enable the above described behaviour.
Note that the menu will be shown even if there is a single available
scope so the user can read its description.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:42 +02:00
Daniel Calviño Sánchez
67dd087ce4
Fix deleting properties of user settings when not given explicitly
...
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
ac0c18327e
Fix TypeError when "email" is not given in the controller request
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
a7431817b9
Respect additional user settings not covered by the controller
...
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.
Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).
This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
c5e3d2e5c2
Add more unit tests for setting user settings
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +02:00
Daniel Calviño Sánchez
190ffd75b7
Change default test data to values less similar to empty values
...
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
Daniel Calviño Sánchez
ef5d538448
Extract default test data to a helper getter
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
Daniel Calviño Sánchez
8cae515daa
Use constants from interface rather than class
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +02:00
Christoph Wurst
1722044992
Only set copy etag if the destination source can be found
...
The etag is only set for files, but it's also possible that in edge
cases the copy destination node can't be found. In that case we don't
need to set any etag.
Required for #26083
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-23 10:53:24 +02:00
Nextcloud bot
539c065e8e
[tx-robot] updated from transifex
2021-04-23 02:26:10 +00:00
blizzz
6d25c3c7fe
Merge pull request #26627 from nextcloud/smb-341
...
update icewind/smb to 3.4.1
2021-04-22 19:58:02 +02:00
Joas Schilling
d80cc76ee7
Validate the website field input to be a valid URL
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +02:00
Joas Schilling
da043e52c8
Merge pull request #26586 from nextcloud/bugfix/noid/handle-device-login-like-an-alternative-login
...
Handle device login like an alternative login
2021-04-22 15:27:58 +02:00
Nextcloud bot
634b6b8b57
[tx-robot] updated from transifex
2021-04-22 02:26:21 +00:00
Roeland Jago Douma
4e39d1ce93
Merge pull request #26609 from nextcloud/Valdnet-patch-6
...
l10n: Improve styling
2021-04-21 19:56:41 +02:00