Commit Graph

57257 Commits

Author SHA1 Message Date
Christoph Wurst f8efab7c85
Only use libxml_disable_entity_loader on php older than 8
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 16:33:46 +01:00
Joas Schilling 3cdfe7b0f4
Don't try a transaction for the migrator on MySQL
As per https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
CREATE TABLE statements automatically commit always. The only reason
this worked in the past was that PHPs PDO connection didn't check the
actual state on commit, but only checked their internal state.
But in PHP8 this was fixed:
https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L446-L450
So now commit() fails because the internal PDO connection implicitly
commited already.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-01-08 16:25:40 +01:00
Robin Appelman 79b142cd12
adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-08 16:14:44 +01:00
Roeland Jago Douma e354ee4dc6
Merge pull request #24951 from nextcloud/version/21/beta5
21 beta5
2021-01-08 15:24:10 +01:00
Robin Appelman 518e91b008
dont offer to edit external config settings if we can't edit them
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-01-08 15:06:42 +01:00
Christoph Wurst 81302f78e5
Merge pull request #24948 from nextcloud/dependabot/composer/doctrine/dbal-3.0.0
Bump doctrine/dbal from 2.12.0 to 3.0.0
2021-01-08 14:58:43 +01:00
Morris Jobke aeb32e1bc8
Merge pull request #22992 from nextcloud/password-urlencode
allow authenticating using urlencoded passwords
2021-01-08 14:34:01 +01:00
Morris Jobke 63dc2df68d
Update baseline.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 14:21:12 +01:00
Morris Jobke bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 13:38:32 +01:00
Morris Jobke 250f76a59c
Use specific docker image tags to allow drone to cache them and not run into docker pull rate limits
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 13:23:55 +01:00
Roeland Jago Douma 08cc9ad496
Merge pull request #25017 from nextcloud/fix-clearing-the-label-of-a-share
Fix clearing the label of a share
2021-01-08 12:39:12 +01:00
Julius Härtl f31edf1544
Make sure to do priority app upgrades first
Otherwise those apps might not be loaded when the others app migrations
are running. The previous loading of authentication apps in the upgrade
step never worked as it just returns in maintenance mode

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-08 12:27:54 +01:00
Christoph Wurst f0c6cfde3a
Rollback failed transactions in TestCase.php to not break followup tests
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +01:00
Morris Jobke dc00c8ac31
Remove "primary" option from schema builder argument $options as it is not used anymore and triggers an exception
See 138eb85234 (diff-300f55366adb50a32a40882ebdc95c163b141f64cba5f45f20bda04a907b3eb3L82)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 11:45:19 +01:00
Christoph Wurst 8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +01:00
Roeland Jago Douma 84e6e9f7cf
Merge pull request #25031 from nextcloud/revert-25020-fix/noid/limitied-allowed-items-db-in
Revert "(LDAP) respect DB limits of arguments in an IN statement"
2021-01-08 10:44:48 +01:00
Roeland Jago Douma dc89447f13
Revert "(LDAP) respect DB limits of arguments in an IN statement" 2021-01-08 10:44:32 +01:00
Daniel Calviño Sánchez fb19d4afe2 Fix clearing the label of a share
When the label is being edited its value is stored in "newLabel", and
the original label is shown only if "newLabel" is not set. However, as
it was checked against any falsy value instead of only undefined when
the label was cleared and thus it has an empty value the original label
was shown instead.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-01-08 09:27:28 +00:00
Morris Jobke d6d8fc4226
Merge pull request #25029 from nextcloud/rakekniven-patch-1
Change defaultapp in config.sample.php to dashboard to improve docs and align it to source code
2021-01-08 10:08:14 +01:00
rakekniven 543df30174
Change defaultapp to dashboard
Result of discussion at https://help.nextcloud.com/t/enable-dashboard-on-per-user-basis/94872

Code reference:
db86bea18c/lib/private/legacy/OC_Util.php (L1106)

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
2021-01-08 09:49:12 +01:00
Roeland Jago Douma d13f2d984f
Merge pull request #25015 from nextcloud/fix/no-double-intl-polyfill
Replace patchwork/utf8 with symfony-polyfill-*
2021-01-08 08:25:31 +01:00
Roeland Jago Douma 741e5e273b
Merge pull request #25020 from nextcloud/fix/noid/limitied-allowed-items-db-in
(LDAP) respect DB limits of arguments in an IN statement
2021-01-08 08:25:03 +01:00
Roeland Jago Douma 645e3e6d7e
Merge pull request #25021 from nextcloud/enhancement/occ-install-exception-trace
Print an exception trace for setup exceptions
2021-01-08 08:22:50 +01:00
Roeland Jago Douma 5bb75c4f23
Merge pull request #25025 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
2021-01-08 08:22:35 +01:00
Nextcloud-PR-Bot b3cdb2e23a Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2021-01-08 04:53:15 +00:00
Nextcloud bot 94188370e7
[tx-robot] updated from transifex 2021-01-08 02:22:30 +00:00
Morris Jobke 1e3c071aa5
Merge pull request #24892 from nextcloud/fix/use-symfony-dispatcher-correctly
Use the Symfony dispatcher correctly
2021-01-07 21:42:44 +01:00
Morris Jobke 275f15c1fb
Merge pull request #23261 from nextcloud/enh/external-storage-session-type
Expose session based authentication through mount point type
2021-01-07 21:29:13 +01:00
Christoph Wurst 287c26bda3
Replace patchwork/utf8 with symfony-polyfill-*
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-07 21:22:41 +01:00
Morris Jobke 171373a944
Merge pull request #24989 from nextcloud/scanner-ignore-non-readable
ignore files that have no read permissions during scanning
2021-01-07 21:10:53 +01:00
Morris Jobke d0ac76a77c
Add more previous exceptions to database setup code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-07 21:04:11 +01:00
Arthur Schiwon 6eca8d6ae1
respect DB limits of arguments in a IN list
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-01-07 20:16:40 +01:00
Roeland Jago Douma 4f52e83695
Merge pull request #24934 from nextcloud/max_file_uploads
Remove useless ini_set calls
2021-01-07 20:15:13 +01:00
Christoph Wurst f1921364d6
Print an exception trace for setup exceptions
Right now any setup error will just result in the exception message
being printed. In some cases this doesn't give any insights into what
went wrong. This adds some dedicated logic to print the exception trace
and any previous exceptions to the CLI.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-07 20:11:25 +01:00
Roeland Jago Douma 9b250833aa
Merge pull request #24969 from nextcloud/dependabot/npm_and_yarn/core-js-3.8.2
Bump core-js from 3.8.1 to 3.8.2
2021-01-07 20:09:03 +01:00
Roeland Jago Douma 373aafab9f
Merge pull request #25018 from nextcloud/fix-name-of-avatar-integration-tests-in-drone
Fix name of avatar integration tests in Drone
2021-01-07 20:06:54 +01:00
Roeland Jago Douma 5020c73d15
Merge pull request #24999 from nextcloud/bugfix/noid/email-footer-language
Set the user language when adding the footer
2021-01-07 19:44:36 +01:00
Daniel Calviño Sánchez dafd0f1441 Fix name of avatar integration tests in Drone
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-01-07 18:26:08 +01:00
Julius Härtl 068e3b2c1e
Set the user language when adding the footer
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-07 15:31:55 +01:00
Carlos Ferreira bc1b5d7892
Remove useless ini_set functions 2021-01-07 15:24:49 +01:00
Roeland Jago Douma 82947263b9
Merge pull request #25011 from nextcloud/fix/23197/catch_throwable
Catch throwable instead of exception
2021-01-07 15:22:36 +01:00
dependabot-preview[bot] dab181a021
Bump core-js from 3.8.1 to 3.8.2
Bumps [core-js](https://github.com/zloirock/core-js) from 3.8.1 to 3.8.2.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/compare/v3.8.1...v3.8.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-01-07 14:55:52 +01:00
Roeland Jago Douma 317118ef79
Catch throwable instead of exception
The error that gets thrown can also be a type error etc. So we should
properly catch the Throwable.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-07 14:32:26 +01:00
Morris Jobke 7001f03645
Merge pull request #25010 from nextcloud/revert-24955-external-storage-login-ldap
Revert "allow using any ldap property as login name when using login credentials"
2021-01-07 14:14:50 +01:00
blizzz 72f16a46e8
Revert "allow using any ldap property as login name when using login credentials" 2021-01-07 14:01:32 +01:00
Morris Jobke 38e534e7c1
Merge pull request #24955 from nextcloud/external-storage-login-ldap
allow using any ldap property as login name when using login credentials
2021-01-07 13:33:18 +01:00
Roeland Jago Douma f552f23e43
Merge pull request #25003 from nextcloud/psalm/noid/phpdoc-fix-return-type
Fix return types for Archive::getStream
2021-01-07 13:31:24 +01:00
Roeland Jago Douma 2495e1825a
Merge pull request #25001 from nextcloud/bugfix/23044/fix-column-name-check
Fix column name to check prior to deleting
2021-01-07 13:30:49 +01:00
Roeland Jago Douma 450211590f
Merge pull request #25000 from nextcloud/bugfix/noid/hide-client-welcome-mail
Hide client link in welcome mail if an empty customclient_desktop config is set
2021-01-07 13:30:11 +01:00
Morris Jobke 15e8f8b817
Merge pull request #25004 from nextcloud/fix/noid/php8-optional-parameter-before-mandatory
Fix warning in PHP 8 about optional parameter before mandatory one
2021-01-07 13:26:51 +01:00