Commit Graph

875 Commits

Author SHA1 Message Date
Morris Jobke 482b42c4a7
Merge pull request #22891 from nextcloud/techdebt/18680/improve-ProvisioningApiMiddleware-service-logic
Improve registerService logic for ProvisioningApiMiddleware for static code analysis
2020-10-05 21:50:50 +02:00
Christoph Wurst d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
dependabot-preview[bot] 8c2fe6df0a
Bump jsdoc from 3.6.5 to 3.6.6 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.5 to 3.6.6.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.6/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.5...3.6.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-26 01:16:20 +00:00
Nextcloud-PR-Bot f7e5ba6116 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-25 04:24:37 +00:00
Daniel Calviño Sánchez 7b9a40b407 Add integration tests to check that only the given path is transferred
Until recently (it was fixed in ac2999a26a) when a path was transferred
other shares with the target user were removed, so a test was added to
ensure that it does not happen again.

Besides that a test to ensure that other files with the target user are
not transferred was added too (it did not fail before, but seemed
convenient to have that covered too :-) ).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-18 18:35:06 +02:00
Daniel Calviño Sánchez c4c602ee80 Add integration tests for transferring files of a user with a risky name
The files:transfer-ownership performs a sanitization of users with
"risky" display names (including characters like "\" or "/").

In order to allow (escaped) double quotes in the display name the
regular expression used in the "user XXX with displayname YYY exists"
step had to be adjusted.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-18 18:34:30 +02:00
Daniel Calviño Sánchez 5e143845cb Add integration test for transferring the path of a single file
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-18 18:32:23 +02:00
Nextcloud-PR-Bot 281f0d6793 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-18 04:23:58 +00:00
J0WI 68ce17e59b Unify links to php.net
Update all links to https://www.php.net/

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-09-17 17:40:04 +02:00
Morris Jobke a65b431f51
Update baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 17:02:44 +02:00
Morris Jobke c6948c2517
Update baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 16:54:10 +02:00
Morris Jobke 04a3580d19
Remove phan config - was replaced by Psalm
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 14:46:29 +02:00
Morris Jobke 1c9a898875
Merge pull request #22761 from nextcloud/extend-integration-tests-for-files-transfer-ownership-command
Extend integration tests for "files:transfer-ownership" command
2020-09-14 17:50:53 +02:00
Morris Jobke 04c174ab89
Merge pull request #22665 from nextcloud/dependabot/composer/build/integration/behat/behat-approx-3.7.0
Update behat/behat requirement from ~3.6.1 to ~3.7.0 in /build/integration
2020-09-10 12:52:31 +02:00
Daniel Calviño Sánchez 58d57b35ea Add integration tests for transferring ownership of reshares
Currently only transferring ownership of a reshare with a group to a
user in the group is possible.

When transferring ownership of a reshare with another user or with a
group to a user not in the group restoring the share fails (but the
command succeeds, it only fails for the specific files that are
reshares).

When transferring ownership of a path that is a reshare the command
fails (as when a specific path is provided the path tries to move the
file, it does not take into account reshares).

The added integration tests reflect the above behaviours.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:34:33 +02:00
Daniel Calviño Sánchez 0ce8096839 Check share ownership after transferring file ownership
The integration tests did not verify that the shares were actually
transferred between the users (or that they were removed due to being
transferred to the sharee).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:24:16 +02:00
Daniel Calviño Sánchez d3d01d6355 Check whether file exists or not after transferring ownership
The integration tests did not verify that the files were actually
transferred between the users, only that the files were downloadable.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-09-10 04:18:53 +02:00
Roeland Jago Douma c104c192ae
Merge pull request #22663 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-1.0.7
Bump karma-viewport from 1.0.6 to 1.0.7 in /build
2020-09-09 21:24:28 +02:00
Roeland Jago Douma fe5f8c5010
Merge pull request #22600 from nextcloud/dependabot/npm_and_yarn/build/http-proxy-1.18.1
[Security] Bump http-proxy from 1.17.0 to 1.18.1 in /build
2020-09-09 20:55:08 +02:00
Nextcloud-PR-Bot 9c57fff01f Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-09 04:23:34 +00:00
dependabot[bot] 94b228dca1
Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.6.1...v3.7.0)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:56 +00:00
dependabot[bot] 20e6d04a69
Bump karma-viewport from 1.0.6 to 1.0.7 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.6...1.0.7)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 06:37:47 +00:00
Christoph Wurst 1f7f93a695
Update license headers for Nextcloud 20 (again)
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +02:00
John Molakvoæ 54438c9d26
Merge pull request #21945 from nextcloud/fix-contact-download-picture
Changed Content-Disposition header to download Contact Photo with correct extension
2020-09-07 08:40:23 +02:00
Nextcloud-PR-Bot 14baa52a1a Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-06 04:22:33 +00:00
Jacob Neplokh e8a4feb1c6
Change Content-Disposition Header
- Make ALLOWED_CONTENT_TYPES public in order to use
- Add $fileName variable which uses "$node->getName()" to get the proper file name and "$file->getMimeType()" along with the ALLOWED_CONTENT_TYPES array in PhotoCache.php to get the proper file extension
- Make "$fileName" the name of the file in the Content-Disposition header when downloading a Contact's photo
- Add filename to the CardDAV integration image export test header
- Change headers in ImageExportPluginTest to reflect changes

Signed-off-by: Jacob Neplokh <me@jacobneplokh.com>
2020-09-05 11:46:25 -07:00
dependabot-preview[bot] 3e9359f930
[Security] Bump http-proxy from 1.17.0 to 1.18.1 in /build
Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.17.0 to 1.18.1. **This update includes a security fix.**
- [Release notes](https://github.com/http-party/node-http-proxy/releases)
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md)
- [Commits](https://github.com/http-party/node-http-proxy/compare/1.17.0...1.18.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-09-04 18:10:40 +00:00
Nextcloud-PR-Bot 7511885c15 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-09-03 04:22:57 +00:00
Julius Härtl 9dc23867c6
Use proper branch name in phpdoc builds
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-27 08:47:16 +02:00
Roeland Jago Douma b5e9f7e846
Merge pull request #22432 from nextcloud/enh/phpdoc
Add php docs build script
2020-08-26 21:18:11 +02:00
Julius Härtl 8c33bfe86b
Add php docs build script
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-26 08:32:42 +02:00
Nextcloud-PR-Bot bc7abbdb85 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-08-26 04:21:23 +00:00
Christoph Wurst 2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Nextcloud-PR-Bot 067945ff10 Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
2020-08-21 04:21:23 +00:00
Morris Jobke d58e71f0e6
Fix psalm warnings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 21:12:15 +02:00
Morris Jobke bb8be58386
Fix psalm warnings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 18:30:48 +02:00
Morris Jobke 8381af626f
Accept psalm warning for now
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 16:46:00 +02:00
Morris Jobke 69bbbc32a1
Extend psalm baseline to ignore errors for now
One is a false positive - see https://github.com/vimeo/psalm/pull/4032

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 14:20:56 +02:00
Julien Veyssier 70d1d1997a
new weather status used in dashboard
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2020-08-20 00:21:08 +02:00
Morris Jobke d8bdb439a4
Merge pull request #22289 from nextcloud/techdebt/noid/fix-encryption-stream-invalid-scalar-arguments
Cast float to int to avoid invalid scalar argument warning
2020-08-19 22:08:15 +02:00
Morris Jobke c449d54204
Merge pull request #22304 from nextcloud/techdebt/noid/matching-param-names
Use matching parameter names form interfaces and implementations
2020-08-19 19:34:02 +02:00
Morris Jobke 4c6eb96471
Merge pull request #22280 from nextcloud/bugfix/noid/429-on-brute-force-maximum
Send "429 Too Many Requests" in case of brute force protection
2020-08-19 18:21:01 +02:00
Morris Jobke fedf9c69d9
Use matching parameter names form interfaces and implementations
Found by Psalm 3.14.1

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 18:16:35 +02:00
Morris Jobke 60be722ee8
Merge pull request #22288 from nextcloud/techdebt/noid/fix-oc_image-invalid-scalar-arguments
Cast float/char to int to avoid invalid scalar argument warning
2020-08-19 17:55:56 +02:00
Morris Jobke e93bf71369
Fix the return type of OC_Template->fetchPage() to be string only
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 16:48:06 +02:00
Morris Jobke 5ced155032
Merge pull request #22285 from nextcloud/techdebt/noid/move-to-typed-event-in-list.php
Use dispatchTyped instead of dispatch on the new event dispatcher
2020-08-18 21:29:48 +02:00
Morris Jobke a5853d7ecc
Use dispatchTyped instead of dispatch on the new event dispatcher
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 20:27:46 +02:00
Morris Jobke 560ccf5d83
Cast float to int to avoid invalid scalar argument warning
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:56:36 +02:00
Morris Jobke 27e7332a9c
Cast float/char to int to avoid invalid scalar argument warning
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:51:59 +02:00
Morris Jobke 4c4f4685dc
Update psalm baseline due to fixes in #22236
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 16:49:36 +02:00
Morris Jobke 42bb6cd7d7
Check only the baseline.xml and exclude the psalm.xml from the file check
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +02:00
Morris Jobke c6b251ca0c
Add patches for stubs
* https://github.com/JetBrains/phpstorm-stubs/pull/893
* https://github.com/JetBrains/phpstorm-stubs/pull/894
* https://github.com/JetBrains/phpstorm-stubs/pull/895
* https://github.com/JetBrains/phpstorm-stubs/pull/896

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +02:00
Morris Jobke b70792aa6a
Add stubs for gd, intl, IntlChar, ldap, redis_cluster and xsl
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 13:01:10 +02:00
Morris Jobke 4efca69f8d
Add psalm baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-18 12:59:17 +02:00
Daniel Kesselberg 8b3b5ae5be
Add stubs for phpseclib
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-18 08:58:19 +02:00
Daniel Kesselberg 7257793fc4
Hello psalm
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-18 08:58:19 +02:00
Morris Jobke 79fc7e78b7
Merge pull request #21138 from nextcloud/fix/noid/search-in-group-displayname-email
Search also the email and displayname in user mangement for groups
2020-08-05 16:09:00 +02:00
Morris Jobke 907d3542dc
Add integration tests for search in groups
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-05 14:14:06 +02:00
Joas Schilling 8d5f5e8f8c
Fix integration test fail
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-03 13:43:15 +02:00
dependabot-preview[bot] 8e1d334258
Bump jsdoc from 3.6.4 to 3.6.5 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.4 to 3.6.5.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.5/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.4...3.6.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-25 01:15:12 +00:00
dependabot[bot] 94ae095051
Bump lodash from 4.17.14 to 4.17.19 in /build
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.14...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>
2020-07-16 07:23:29 +00:00
Morris Jobke aed5eb55af
Merge pull request #21843 from nextcloud/debt/noid/less-verbose-translation-checker
Make translation-checker.php less verbose
2020-07-15 19:37:51 +02:00
Morris Jobke 8dd48f3dc8
Fix integration test due to new dashboard app
See #21346

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-15 14:07:59 +02:00
Daniel Kesselberg 5ffe9fc7db
Make translation-checker.php less verbose.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-15 11:29:12 +02:00
Daniel Calviño Sánchez e0fbf4d033
Add more integration tests for resharing permissions
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-07-09 11:14:44 +02:00
Morris Jobke 3333c885c0
Merge pull request #21264 from stweil/master
build: Fix some typos (most of them found by codespell)
2020-07-05 22:52:28 +02:00
Joas Schilling dc175d4ecc
Fix typo in variable name and make check more accurate
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-01 10:48:38 +02:00
Joas Schilling e2100856ad
Add another test for exact matching of a user in group restriction
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-17 12:06:50 +02:00
Christoph Wurst cdcd61d4c8
Use empty for the OCP @since checker
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-09 08:49:24 +02:00
Stefan Weil 72f853424b build: Fix two typos in function names
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2020-06-06 15:57:08 +02:00
Stefan Weil e8af52001e build: Fix some typos (most of them found by codespell)
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2020-06-06 13:03:00 +02:00
Daniel Calviño Sánchez b192c04dc2 Add integration tests for video verification
Enabling the "send password by Talk" property of shares require that
Talk is installed and enabled, so the Drone step that runs them has to
first clone the Talk repository.

When the integration tests are run on a local development instance,
however, it is not guaranteed that Talk is installed. Due to this the
"@Talk" tag was added, which ensures that any feature or scenario marked
with it will first check if Talk is installed and, if not, skip the
scenario (instead of failing).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:30 +02:00
Daniel Calviño Sánchez a2f80d4f4c Add integration tests for creating and updating a mail share
In most cases, when a mail share is created or updated an e-mail is sent
to the sharee, which is done by connecting to the SMTP server set in the
configuration. If the server can not be contacted then the creation or
update of the mail share fails.

To make possible to test mail shares without using a real SMTP server a
fake one has been added. The original script, which is MIT licensed, was
based on inetd, so it was slightly modified to run on its own.

In order to use it from the integration tests the "Given dummy mail
server is listening" step has to be called in the scenarios in which the
mail server is needed.

For now that is the only available step; things like checking the sent
mails, while possible (as the script can log the mails to certain file),
have not been added yet.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:50:29 +02:00
Daniel Calviño Sánchez 7817f8578b Generalize integration test steps to download last share
Note that the "last link share can be downloaded" step was kept as it
tests the "url" property specific of link shares.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
Daniel Calviño Sánchez 6e49d3bb94 Remove unused variables
The step names were adjusted accordingly.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 02:46:12 +02:00
Roeland Jago Douma bd0a1b6e7d
Merge pull request #20586 from nextcloud/techdebt/noid/make-image-optimization.sh-better-readable
Improve build/image-optimization.sh
2020-05-21 09:48:55 +02:00
Roeland Jago Douma 108faf25c0
Update public link share permission code
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-15 08:18:03 +02:00
dependabot-preview[bot] c84a82bc0c
Bump node-sass from 4.14.0 to 4.14.1 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.14.0 to 4.14.1.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.14.0...v4.14.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 01:16:27 +00:00
Roeland Jago Douma d9e5925201
Merge pull request #20655 from nextcloud/dependabot/npm_and_yarn/build/node-sass-4.14.0
Bump node-sass from 4.13.0 to 4.14.0 in /build
2020-04-29 16:15:04 +02:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
dependabot-preview[bot] b836bcf040
Bump node-sass from 4.13.0 to 4.14.0 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.13.0 to 4.14.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.13.0...v4.14.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-29 08:27:58 +00:00
Morris Jobke 1738e17e20
Merge pull request #19793 from nextcloud/bugfix/noid/link-to-federated-reshare
Fix resharing of federated shares that were created out of links
2020-04-27 11:05:34 +02:00
Julius Härtl 7a9469f282
Adjust integration tests to new permissions
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-04-23 16:22:48 +02:00
Roeland Jago Douma 3fc66a65f8
Revert "Update guzzlehttp/guzzle requirement from 6.5.2 to 6.5.3 in /build/integration" 2020-04-22 16:40:11 +02:00
Joas Schilling e9f0a388d9
Allow to specify a directory and skip node_modules and tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:50:26 +02:00
Joas Schilling e49b6c576d
Don't error when the directory is broken
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:33:11 +02:00
Joas Schilling f354a4f17f
FIx glob usage to avoid problems with directories that contain spaces
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:32:11 +02:00
Joas Schilling 4651ff5a50
Make the script better readable
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-21 13:30:53 +02:00
Roeland Jago Douma 792c520774
Revert "Bump karma-coverage from 2.0.1 to 2.0.2 in /build" 2020-04-19 11:21:48 +02:00
dependabot-preview[bot] a95d6463b4
Bump karma-coverage from 2.0.1 to 2.0.2 in /build
Bumps [karma-coverage](https://github.com/karma-runner/karma-coverage) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/karma-runner/karma-coverage/releases)
- [Changelog](https://github.com/karma-runner/karma-coverage/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma-coverage/compare/v2.0.1...v2.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-19 01:13:43 +00:00
dependabot-preview[bot] e650c6366f
Update guzzlehttp/guzzle requirement in /build/integration
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/6.5.3/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/6.5.2...6.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-19 01:13:23 +00:00
blizzz 8bc381f104
Merge pull request #20037 from nextcloud/fix/19127/deprecated-ldap_control_paged_result_1
do not use deprecated API for LDAP paged results
2020-04-15 15:02:51 +02:00
Joas Schilling 4e846dda4d
Allow local remotes in integration tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-04-15 08:24:18 +02:00
Arthur Schiwon 84619a5b9c
use serverControls directly with LDAP calls, fixes 19127
- adapters for PHP API version to Support PHP < 7.3
- switch to pass only one base per search
- cookie logic is moved from Access to API adapters

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-04-14 12:58:28 +02:00
Daniel Kesselberg 0ccaec9841
Fix jsunit tests
JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-04-14 11:55:12 +02:00
Daniel Calviño Sánchez 7440868acd Fix app not listed in provisioning integration test
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-04-13 15:07:59 +02:00
dependabot-preview[bot] e1f8666f84
Bump jsdoc from 3.6.3 to 3.6.4 in /build
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.3 to 3.6.4.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.4/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.3...3.6.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-12 01:13:41 +00:00
Christoph Wurst 1584c9ae9c
Add visibility to all methods and position of static keyword
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:51:06 +02:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Christoph Wurst 14c996d982
Use elseif instead of else if
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
Christoph Wurst bcd13296de
Make sure every file ends with an empty newline
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:11:50 +02:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
Christoph Wurst afbd9c4e6e
Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
Joas Schilling bbba7bc45a
Merge pull request #20321 from nextcloud/enh/noid/check-translation-for-triple-dot
Check for triple dots in translations in CI
2020-04-08 20:10:05 +02:00
Gary Kim 283b8a5e74
Check for triple dots in translations in CI
Signed-off-by: Gary Kim <gary@garykim.dev>
2020-04-07 12:06:40 +08:00
dependabot-preview[bot] d7eac53ee1
Bump handlebars from 4.7.3 to 4.7.6 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.3 to 4.7.6.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.7.3...v4.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-04-05 10:57:12 +00:00
Roeland Jago Douma dbdd30d4d4
Merge pull request #20216 from nextcloud/dependabot/npm_and_yarn/build/karma-viewport-1.0.6
Bump karma-viewport from 1.0.5 to 1.0.6 in /build
2020-04-03 08:51:27 +02:00
Roeland Jago Douma 32577f2f57
Merge pull request #20209 from nextcloud/techdebt/php-cs-config
Add a shared php coding style fixer config
2020-04-01 13:25:16 +02:00
Christoph Wurst 1a9330cd69
Update the license headers for Nextcloud 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
Christoph Wurst 3eac89d448
Add shared php-cs config
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 13:45:10 +02:00
dependabot-preview[bot] aaaabd1678
Bump karma-viewport from 1.0.5 to 1.0.6 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.5 to 1.0.6.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.5...1.0.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-29 01:13:34 +00:00
Christoph Wurst 463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
Remove unused imports
2020-03-27 17:14:08 +01:00
Christoph Wurst b80ebc9674
Use the short array syntax, everywhere
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
Christoph Wurst 74936c49ea
Remove unused imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +01:00
Christoph Wurst 23eb0462e5
Use lowercase true, false and null constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 21:53:04 +01:00
Roeland Jago Douma 97949109ef
Merge pull request #19368 from nextcloud/dependabot/npm_and_yarn/build/handlebars-4.7.3
Bump handlebars from 4.5.3 to 4.7.3 in /build
2020-03-24 21:47:36 +01:00
Daniel Calviño Sánchez ec63327472 Force compatible EventDispatcher version in integration tests
Nextcloud requires EventDispatcher from Symfony 4.4. Behat required
Symfony 4.x until Behat 3.5, but since Behat 3.6 it supports Symfony 5.x
too. However, as the EventDispatcher version was not restricted in the
"composer.json" file Composer installed the latest compatible version
with all the dependencies, which happened to be Symfony 5.x. To prevent
that now the EventDispatcher is explicitly limited to Symfony 4.4 only.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-03-12 10:45:23 +01:00
dependabot-preview[bot] d3d6d8de3a
Bump handlebars from 4.5.3 to 4.7.3 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.5.3 to 4.7.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.3...v4.7.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-03-10 19:14:40 +00:00
dependabot-preview[bot] cb2877abd3
Update behat/behat requirement in /build/integration
Updates the requirements on [behat/behat](https://github.com/Behat/Behat) to permit the latest version.
- [Release notes](https://github.com/Behat/Behat/releases)
- [Changelog](https://github.com/Behat/Behat/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Behat/Behat/compare/v3.5.0...v3.6.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-12 19:28:54 +00:00
dependabot-preview[bot] 1829ee816d
Update guzzlehttp/guzzle requirement in /build/integration
Updates the requirements on [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) to permit the latest version.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md)
- [Commits](https://github.com/guzzle/guzzle/compare/6.3.3...6.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-09 02:14:17 +00:00
Joas Schilling e5e612a292
Merge pull request #18518 from nextcloud/security-polixy
Set up a security policy
2020-02-06 21:24:52 +01:00
dependabot-preview[bot] bf5174afe0
Bump karma-viewport from 1.0.4 to 1.0.5 in /build
Bumps [karma-viewport](https://github.com/squidfunk/karma-viewport) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/squidfunk/karma-viewport/releases)
- [Changelog](https://github.com/squidfunk/karma-viewport/blob/master/CHANGELOG)
- [Commits](https://github.com/squidfunk/karma-viewport/compare/1.0.4...1.0.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-02 02:13:24 +00:00
Ruben Barkow be506f7b29
Set up a security policy
Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>
2020-01-21 16:25:52 +01:00
Roeland Jago Douma fc77f530d7
Don't show link shares hash in inherited share list
This adds no value at all. Just showing the text "(Shared link)" now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-15 09:21:53 +01:00
Christoph Wurst 6127c288e8 Fix license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-13 14:23:49 +01:00
John Molakvoæ (skjnldsv) edf8893479
Fix tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-12-10 23:44:17 +01:00
Christoph Wurst 5bf3d1bb38
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
Christoph Wurst a166796378
Update license script apps
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:38 +01:00
Maxence Lange ccf7d87c11
integration tests
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
add tests on non-owner pov

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
duplicate

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
small fixes

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
removed tags

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2019-12-03 08:10:27 +01:00
Roeland Jago Douma 407c2c13ab
Merge pull request #18159 from nextcloud/tests/comments-integration
Do not call count on null
2019-12-02 08:53:02 +01:00
Julius Härtl 330cb7047e
Do not call count on null
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-11-29 09:59:35 +01:00
Roeland Jago Douma 3cda67c8b1
Fix integration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-28 10:22:05 +01:00
dependabot-preview[bot] 8a15447d63
Bump handlebars from 4.5.2 to 4.5.3 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.5.2 to 4.5.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.2...v4.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-24 02:12:31 +00:00
Daniel Calviño Sánchez 54f8f75f6f Accept incoming shares in integration tests
Now all incoming shares need to be explicitly accepted before being able
to use the shared file or get information about a reshare (although
getting the information of the incoming share is possible before
accepting it).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-11-20 15:47:11 +01:00
Daniel Calviño Sánchez 9004e90f5d Replace direct calls to share API with specific share steps
This makes possible to use steps that reference the last share, which
will be needed to accept pending shares.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-11-20 13:11:49 +01:00
Daniel Calviño Sánchez 847bd0f05b Remove extra spaces at the end of lines
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-11-20 13:10:35 +01:00
dependabot-preview[bot] 43b58ca30f
Bump handlebars from 4.5.1 to 4.5.2 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.5.1 to 4.5.2.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.5.1...v4.5.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-17 02:13:10 +00:00
dependabot-preview[bot] f166744f17
Bump handlebars from 4.4.5 to 4.5.1 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.5 to 4.5.1.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.5...v4.5.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-11-10 02:12:31 +00:00
Gary Kim f3009bc76e
Add .editorconfig to expected files
Signed-off-by: Gary Kim <gary@garykim.dev>
2019-11-08 08:28:39 +08:00
John Molakvoæ (skjnldsv) eebcf89091
Cleanup sharing leftovers
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-11-05 19:03:44 +01:00
John Molakvoæ (skjnldsv) 515171a653 Transpile also dependencies in node_modules
Some of the dependencies in node_modules, such as "p-queue", are not ES5
compatible, so they need to be transpiled to work in older browsers like
Internet Explorer 11.

Besides not excluding the dependencies for babel-loader in
"webpack.common.js" the global Babel configuration must be defined in
"babel.config.js", as in Babel 7.X, when ".babelrc.js" is used, all the
dependencies in "node_modules" are ignored (even if whitelisted in the
configuration file itself).

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-29 12:56:00 +01:00
John Molakvoæ (skjnldsv) ea6f423e2c Extend data returned when searching remote shares
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-29 12:55:59 +01:00
Roeland Jago Douma 11faf739c2
Merge pull request #17698 from nextcloud/dependabot/npm_and_yarn/build/node-sass-4.13.0
Bump node-sass from 4.12.0 to 4.13.0 in /build
2019-10-27 22:34:49 +01:00
dependabot-preview[bot] 64ce503bce
Bump handlebars from 4.4.3 to 4.4.5 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.3 to 4.4.5.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.3...v4.4.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-27 10:18:39 +00:00
dependabot-preview[bot] baeb369a67
Bump node-sass from 4.12.0 to 4.13.0 in /build
Bumps [node-sass](https://github.com/sass/node-sass) from 4.12.0 to 4.13.0.
- [Release notes](https://github.com/sass/node-sass/releases)
- [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sass/node-sass/compare/v4.12.0...v4.13.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-27 07:47:52 +00:00
Daniel Calviño Sánchez d0b205d0dd
Add more integration tests for getting shares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-10-26 14:22:17 +02:00
Daniel Calviño Sánchez eaa98ed343 Add integration tests for getting shares including subfiles
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-10-25 18:37:36 +02:00
Daniel Calviño Sánchez bb9814d052 Replace fully qualified name with alias
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2019-10-25 10:48:38 +02:00
John Molakvoæ (skjnldsv) a1480c95eb
Merge all babelrc into one file
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-17 00:06:09 +02:00
dependabot-preview[bot] 929295ac31
Bump handlebars from 4.4.2 to 4.4.3 in /build
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.2 to 4.4.3.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.2...v4.4.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-13 01:13:38 +00:00