Commit Graph

54822 Commits

Author SHA1 Message Date
Nextcloud bot ce3ef23d26
[tx-robot] updated from transifex 2021-04-30 02:28:21 +00:00
Roeland Jago Douma 49969fc9b4 19.0.11 RC1
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-29 20:56:33 +02:00
Roeland Jago Douma 1092ba8328
Merge pull request #25974 from nextcloud/backport/25417/stable19-fix-account-data-visibility-after-disabling-public-addressbook-upload
[stable19] Fix account data visibility after disabling public addressbook upload
2021-04-29 20:50:24 +02:00
Lukas Reschke 845a67c02b Limit size of properties to 2048 characters
It is unreasonable to expect that one of these fields would be longer
than 2048 characters. Whilst some have definitely lower limits (such as
for phone numbers or domain names), a upper bound as sanity check makes
sense.

Backport of https://github.com/nextcloud/server/pull/26433

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-29 20:50:14 +02:00
Roeland Jago Douma 1c2e547e9a
Merge pull request #26629 from nextcloud/backport/25189/stable19
[stable19] add command to repair broken filesystem trees
2021-04-29 20:48:47 +02:00
Morris Jobke a3fb7914c5
Merge pull request #26825 from nextcloud/backport/26811/stable19
[stable19] Do not try to contact lookup server if not needed
2021-04-29 15:50:14 +02:00
Roeland Jago Douma ecab69d513
Merge pull request #26787 from nextcloud/backport/26718/stable19
[stable19] Fix ratelimit template
2021-04-29 10:10:54 +02:00
Roeland Jago Douma c022e923ff Do not try to contact lookup server if not needed
In some cases (for example you never send data to the lookup server)
there is no need for this job to even try.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-29 09:21:08 +02:00
Joas Schilling 43d6921772
429 template is NC20+ and fix getDelay for CLI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-29 08:44:53 +02:00
Roeland Jago Douma 4369d1cf1d
Merge pull request #26780 from nextcloud/backport/26765/stable19
[stable19] No longer add trusted servers on federated share creation
2021-04-29 08:19:44 +02:00
Nextcloud bot 88c1dd8d6e
[tx-robot] updated from transifex 2021-04-29 02:26:59 +00:00
Morris Jobke 3aabf5eca8
Merge pull request #26807 from nextcloud/backport/26647/stable19
[stable19] Fail when creating new files with an empty path
2021-04-28 20:26:55 +02:00
Julius Härtl 7c8d5fd3a2
Merge pull request #26810 from nextcloud/backport/25659/stable19
[stable19] catch notfound and forbidden exception in smb::getmetadata
2021-04-28 15:55:11 -01:00
Robin Appelman bbaf4ced3a catch notfound and forbidden exception in smb::getmetadata
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-28 11:53:12 +00:00
Roeland Jago Douma 6819208ad8 Bump composer
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-28 13:28:28 +02:00
Julius Härtl 5bbf281371 Fail when creating new files with an empty path
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-28 10:05:41 +00:00
Julius Härtl 435ce0d971
Merge pull request #26799 from nextcloud/backport/26785/stable19
[stable19] LDAP: do not bother to search after the last page
2021-04-28 08:46:35 -01:00
Joas Schilling f585fbc391
Fix Nextcloud19 compatibility
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-28 09:59:53 +02:00
Nextcloud bot 5eaa0973b7
[tx-robot] updated from transifex 2021-04-28 02:26:17 +00:00
Arthur Schiwon 6a3b483273 do not try to search after the last page
- saves an LDAP requests in these cases
- prevents a Protocol Error logged on < 7.3 API (for backports)

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-27 17:43:44 +00:00
Lukas Reschke 23d0c71877 Run cs:fix
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-27 16:21:00 +02:00
Roeland Jago Douma 771dfc8170 No longer add trusted servers on federated share creation
It was disabled by default for ages. And often resulted in unwanted
behavior. If admins want trusted servers they just have to do it
manually.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-27 15:54:16 +02:00
Joas Schilling aa178f9e25 Do not allow to overwrite some variables
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:39:52 +00:00
Joas Schilling 167a4c7a0a Fix ratelimit template
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:39:50 +00:00
Nextcloud bot d18aa63560
[tx-robot] updated from transifex 2021-04-27 02:26:05 +00:00
Roeland Jago Douma 9f8d16b6f1
Merge pull request #26772 from nextcloud/backport/26763/stable19
[stable19] Improve federated permission handling
2021-04-26 21:26:58 +02:00
Julius Härtl d5a2eafedc
Merge pull request #26769 from nextcloud/backport/26762/stable19 2021-04-26 16:16:22 -01:00
Roeland Jago Douma 3f6be3d791 Improve federated permission handling
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-26 15:29:04 +00:00
Joas Schilling 59ab20972d Log deprecation only as debug
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 15:17:12 +00:00
Joas Schilling e3e4bfb163 Respect the error level when logging
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 15:17:11 +00:00
Nextcloud bot 7028094ece
[tx-robot] updated from transifex 2021-04-26 02:25:07 +00:00
Nextcloud bot 44e37f211a
[tx-robot] updated from transifex 2021-04-25 02:25:23 +00:00
Nextcloud bot 354176e123
[tx-robot] updated from transifex 2021-04-24 02:27:06 +00:00
Daniel Calviño Sánchez 184a7cadab Handle corrupted scope values
Due to a bug (fixed some commits ago) in the UsersController of the
settings app the scope of the properties can be null (for example, if
lookup server upload was disabled and the user then changed the display
name in the profile information). In that case now the scope menu icon
shows an error to inform the user.

The scope value will not change when other properties are modified until
the user chooses an explicit value from the menu. Note that until a
scope is explicitly set the property will behave as if it is private.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:14 +02:00
Daniel Calviño Sánchez 828865a508 Fix settings scope menu hidden when lookup server upload is disabled
When upload to the lookup server is disabled the scope menu was hidden
in the personal information settings. However, even if the lookup server
upload is disabled the personal information is still accesible from the
local server as well as trusted servers. Users should be able to still
set if their information is available to other users or if it is
private, so now the scope menu is always show (although the "Public"
option is hidden if the lookup server upload is disabled).

If the user set the information as public before the upload to the
lookup server was disabled the menu will also show the "Public" option
as active, although disabled. Setting the visibility to any of the other
options will hide the "Public" option from the menu (until the lookup
server upload is enabled again).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:13 +02:00
Daniel Calviño Sánchez 60b8ede80a Add integration tests for searching users in contacts menu
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:13 +02:00
Daniel Calviño Sánchez bc9b213b7b Make possible to set body in requesttoken requests in integration tests
"sendingAToWithRequesttoken" needs to be used to test some non OCS
endpoints which require the request token to be sent in the request. Now
it is possible to specify the body (or, rather, additional contents
beside the cookies and the request token) for those requests, as it will
be needed for example to update the user profile.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:12 +02:00
Daniel Calviño Sánchez d2f1225b34 Fix deleting properties of user settings when not given explicitly
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:11 +02:00
Daniel Calviño Sánchez 3304d33e3b Fix TypeError when "email" is not given in the controller request
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:11 +02:00
Daniel Calviño Sánchez e30271be4f Respect additional user settings not covered by the controller
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.

Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).

This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:10 +02:00
Daniel Calviño Sánchez c130b88004 Add more unit tests for setting user settings
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:09 +02:00
Daniel Calviño Sánchez f2e40238a6 Change default test data to values less similar to empty values
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:08 +02:00
Daniel Calviño Sánchez 5a497841be Extract default test data to a helper getter
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:07 +02:00
Daniel Calviño Sánchez eaedf5fcd9 Use constants from interface rather than class
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 16:53:07 +02:00
Nextcloud bot 739504bd10
[tx-robot] updated from transifex 2021-04-23 02:26:44 +00:00
Nextcloud bot f43c25dfe3
[tx-robot] updated from transifex 2021-04-22 02:26:53 +00:00
Morris Jobke d11ded9ef9
Merge pull request #26676 from nextcloud/backport/26658/stable19
[stable19] Do not stop directory listing when ACL is blocking access
2021-04-21 14:20:39 +02:00
Julius Härtl 5262bb97f7 Continue iterating over diretory contents and just hide file if denied by acl
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-21 07:24:13 +00:00
Nextcloud bot e73034b95b
[tx-robot] updated from transifex 2021-04-21 02:26:35 +00:00
Roeland Jago Douma 418dab9b98
Merge pull request #26646 from nextcloud/backport/26625/stable19
[stable19] Fix empty password check for mail shares
2021-04-20 20:47:52 +02:00